D6466: Android: scan for qml files in the source dir, not in the install dir.

2017-07-02 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. This will be problematic as soon as your application depends on any libraries. So far we've worked with the assumption that you'd install the applications into a prefix then ran

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 4 - Still Unstable!

2017-07-02 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/4/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 02 Jul 2017 23:06:44 + Build duration: 1 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 3 - Still Unstable!

2017-07-02 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/3/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 02 Jul 2017 23:06:44 + Build duration: 57 sec and counting JUnit Tests

D6473: Crash when replacing new lines with spaces

2017-07-02 Thread John Salatas
jsalatas edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: ltoscano, kwrite-devel, #frameworks

D6473: Crash when replacing new lines with spaces

2017-07-02 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D6473#121145, @jsalatas wrote: > In https://phabricator.kde.org/D6473#121136, @ltoscano wrote: > > > If the review is accepted and you want to close the bug, replace > > > > Fixes bug 381080 > >

D6473: Crash when replacing new lines with spaces

2017-07-02 Thread John Salatas
jsalatas added a comment. In https://phabricator.kde.org/D6473#121136, @ltoscano wrote: > If the review is accepted and you want to close the bug, replace > > Fixes bug 381080 > https://bugs.kde.org/show_bug.cgi?id=381080 > > with simply > > BUG: 381080 Thanks!

D6473: Crash when replacing new lines with spaces

2017-07-02 Thread Luigi Toscano
ltoscano added a comment. If the review is accepted and you want to close the bug, replace Fixes bug 381080 https://bugs.kde.org/show_bug.cgi?id=381080 with simply BUG: 381080 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas,

D6473: Crash when replacing new lines with spaces

2017-07-02 Thread John Salatas
jsalatas created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Fixes bug 381080 https://bugs.kde.org/show_bug.cgi?id=381080 TEST PLAN The problem was that it looked for multiline

Re: Kirigami in Frameworks

2017-07-02 Thread Marco Martin
On Sunday 02 July 2017, David Faure wrote: > > I'd like to finalize the tagging today. > With kirigami still having issues with translations, CI, and naming, I'd > like to skip it for now and release it next month, unless there are strong > reasons to do otherwise. I'm fine with this as well --

Re: Kirigami in Frameworks

2017-07-02 Thread Marco Martin
On Saturday 01 July 2017, David Faure wrote: > On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: > > Hi, > > I have moved it, should be good to go. > > one sidenote (hoping is not a problem) for historical reasons, the > > tarballs were called kirigami2-version instead of just kirigami

Re: cmake 3.9 breaks compiling kconfig (and dbus adaptors/interfaces)

2017-07-02 Thread David Faure
On vendredi 30 juin 2017 15:28:50 CEST Sebastian Holtermann wrote: > Hi David. > > >> I think the trouble comes from mixing AUTOMOC with qt5_generate_moc. The > >> moc file is generated twice > >> > >> 1. By AUTOMOC: > >> /d/kde/build/5/frameworks/kconfig/autotests/kconfig_compiler/test_signal_

Re: Kirigami in Frameworks

2017-07-02 Thread Sebastian Kügler
On zaterdag 1 juli 2017 11:27:21 CEST Albert Astals Cid wrote: > https://websvn.kde.org/trunk/l10n-kf5/templates/messages/frameworks/libkirig > ami2plugin_qt.pot?revision=1492189=markup > > Disagrees with you Ow, okay. I see, I only grepped for i18n, not for qsTr(), sorry for the noise! > On

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 3 - Unstable!

2017-07-02 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/3/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Sun, 02 Jul 2017 10:11:52 + Build duration: 57 sec and counting JUnit Tests Name:

Re: Kirigami in Frameworks

2017-07-02 Thread Rik Mills
On 01/07/17 12:48, David Faure wrote: > On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: >> Hi, >> I have moved it, should be good to go. >> one sidenote (hoping is not a problem) for historical reasons, the >> tarballs were called kirigami2-version instead of just kirigami (or >>

Re: Kirigami in Frameworks

2017-07-02 Thread Luigi Toscano
Il 02 luglio 2017 10:07:49 CEST, Rik Mills ha scritto: >On 01/07/17 12:48, David Faure wrote: >> On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: >>> Hi, >>> I have moved it, should be good to go. >>> one sidenote (hoping is not a problem) for historical reasons,

Re: Kirigami in Frameworks

2017-07-02 Thread Luigi Toscano
Il 02 luglio 2017 09:55:48 CEST, David Faure ha scritto: >On samedi 1 juillet 2017 13:48:28 CEST David Faure wrote: >> On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: >> > Hi, >> > I have moved it, should be good to go. >> > one sidenote (hoping is not a problem) for

D6466: Android: scan for qml files in the source dir, not in the install dir.

2017-07-02 Thread David Faure
dfaure created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY When the QML files are all bundled into a .qrc file, they don't get copied to the install dir, which would lead to qmlimportscanner not picking up the dependencies (e.g. QtQuick

Re: Kirigami in Frameworks

2017-07-02 Thread David Faure
On samedi 1 juillet 2017 13:48:28 CEST David Faure wrote: > On vendredi 30 juin 2017 15:16:17 CEST Marco Martin wrote: > > Hi, > > I have moved it, should be good to go. > > one sidenote (hoping is not a problem) for historical reasons, the > > tarballs were called kirigami2-version instead of

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 2 - Still Unstable!

2017-07-02 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/2/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 02 Jul 2017 07:36:39 + Build duration: 29 sec and counting JUnit Tests