This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8de13c67421: Don't list KF5::WindowSystem in public
libraries (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6495?
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> ilic wrote in kcatalog.cpp:124
> Also the lock should be removed, now that only read access is used.
I think I still need it.
QHash::value() isn't marked as being atomic so we still need to
asturmlechner added a comment.
Thanks, works for me!
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6495
To: davidedmundson, #plasma
Cc: asturmlechner, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts
asturmlechner abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma
Cc: davidedmundson, #frameworks
davidedmundson added a comment.
You're right that there's a bug, but I think this solution has backwards.
We don't use WindowSystem in public API, and it's PlasmaQuick/CmakeLists.txt
that's wrong by putting it in public not the other way round.
See https://phabricator.kde.org/D6495
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We don't use it in public API
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
ht
asturmlechner added a reviewer: Plasma.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma
Cc: #frameworks
asturmlechner created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Otherwise, reverse-dependencies are bugged
with finding KF5WindowSystem themselves.
TEST PLAN
Builds fine, plasma-sdk does not nee
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Otherwise if requestMoreData is called, we query the wrong request which
can be quite big if it happens before it's initialized
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
http
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/15/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 03 Jul 2017 16:23:56 +
Build duration:
1 min 54 sec and counting
JUnit Tests
Hi,
How/where is the rendering of "KPage" titles determined, like for instance the
"Widget Style and Behaviour" label in the `kcmshell5 style` dialog? This
appears to be a KF5-specific widget that's somehow under control of the widget
style. I think I figured out the how/where once but can't s
This revision was automatically updated to reflect the committed changes.
Closed by commit R279:94ab2f237e6b: Add missing export to QueueSignals
(authored by davidedmundson).
REPOSITORY
R279 ThreadWeaver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6452?vs=16058&id=16139
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/28/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Mon, 03 Jul 2017 16:08:28 +
Build duration:
3 min 45 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/23/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 03 Jul 2017 16:08:28 +
Build duration:
3 min 9 sec and counting
JUnit Tests
apol updated this revision to Diff 16136.
apol added a comment.
- Restore the old behavior of KI18N_INSTALL_TS_FILES
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6331?vs=15720&id=16136
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6331
A
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:dce2a89774c6: emit runningActivityListChanged on activity
creation (authored by mart).
REPOSITORY
R6 KActivities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6484?vs=16130&id=16134
REVISI
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Good work.
REPOSITORY
R6 KActivities
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6484
To: mart, #plasma, ivan, davidedmundson
Cc: davidedmundson, plas
mart added a reviewer: ivan.
REPOSITORY
R6 KActivities
REVISION DETAIL
https://phabricator.kde.org/D6484
To: mart, #plasma, ivan
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
if an activity gets created and started immediately,
runningActivityListChanged wasn't emitted, a symptom
was the activi
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/17/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 03 Jul 2017 13:57:07 +
Build duration:
1 min 50 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:06410e779b4f: Fix tab bar layout key handling in RTL
(authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6480?vs=16120&i
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
origin-master (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6480
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, Zre
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Current code will, when mirrored, treat all keys like they're the left
key.
BUG: 379894
TEST PLAN
Ran pl
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/6/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 03 Jul 2017 09:04:02 +
Build duration:
4 min 18 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/5/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 03 Jul 2017 09:04:02 +
Build duration:
32 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/5/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Mon, 03 Jul 2017 08:35:57 +
Build duration:
4 min 52 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/4/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 03 Jul 2017 08:35:57 +
Build duration:
56 sec and counting
JUnit Tests
Name
27 matches
Mail list logo
