anthonyfieroni added inline comments.
INLINE COMMENTS
> dialogshadows.cpp:270
> {
> m_shadowPixmaps << q->pixmap(element);
> }
Validate element (hasElement and > 0) or add default pixmap.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6518
davidedmundson added a comment.
What if a theme only has shadow-top, but not right etc.
(or a more likely scenario, they exist, but the metadata has them be 0px big)
What would happen if you have a theme with shadow then switch to one without?
REPOSITORY
R242 Plasma Framework
bkchr created this revision.
bkchr added a project: KSecrets Service.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The old implementation used CMAKE_INSTALL_PREFIX for determining the
installation directory. The
mart created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
some themes don't have a valid shadow, which would lead
to a crash in kwayland, don't even try to render a shadow
if
ltoscano accepted this revision.
ltoscano added a comment.
The issue initially reported is fixed. I tried with //fr// and other 3
languages which should be representative enough (//de//, //uk//,
//sr@ijekavian//; the latter was complaining before the last revision of the
review).
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> ltoscano wrote in KF5I18NMacros.cmake:178
> Before this line, in the original version before the changes, there was this
> line:
>
> string(REPLACE "@" "_" pmapc_target ${pmapc_target})
>
> Could it be
apol updated this revision to Diff 16202.
apol added a comment.
- Restore the old behavior of KI18N_INSTALL_TS_FILES
- Address luigi's comment
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6331?vs=16136=16202
BRANCH
master
REVISION DETAIL
leinir added a comment.
In https://phabricator.kde.org/D6512#121834, @apol wrote:
> +1 looks sensible to me.
Sweet :)
> What's the OCS state in this regard? When will 1.7 be a thing?
OCS 1.7 will be a thing hopefully in the not too distant future...
Incidentally, i need
leinir created this revision.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is to add support for the new tags support in Attica found in
https://phabricator.kde.org/D6512,
apol added a comment.
+1 looks sensible to me.
What's the OCS state in this regard? When will 1.7 be a thing?
REPOSITORY
R235 Attica
REVISION DETAIL
https://phabricator.kde.org/D6512
To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki,
leinir added a dependent revision: D6513: Add support for Attica tags support.
REPOSITORY
R235 Attica
REVISION DETAIL
https://phabricator.kde.org/D6512
To: leinir, #knewstuff, apol, whiting, #kde_store
Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt,
siyuandong,
leinir created this revision.
leinir added a project: KDE Store.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch is to add support for the proposed addition of tags to the OCS
standard version 1.7, as seen
On Wednesday July 05 2017 10:58:59 Hugo Pereira Da Costa wrote:
>No
>the default is false (no frame):
>
>breeze.kcfg:
>
>
>
>false
>
>
Curious, I've always seen Breeze display the frame, and never activated the
option as far as I can remember. I did notice yesterday that breezerc doesn't
davidedmundson added a comment.
Edit: I was wrong.
We do need your first change but not the second change to cmakelists.txt
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6493
To: asturmlechner, #plasma
Cc: davidedmundson, #frameworks
On Wednesday July 05 2017 09:55:27 Hugo Pereira Da Costa wrote:
(CC'ing the plasma-devel ML and thus keeping Hugo's full reply as context.)
>On 07/04/2017 11:13 PM, René J.V. Bertin wrote:
>> On Tuesday July 04 2017 20:16:55 Sebastian Kügler wrote:
>>
>> @Kevin: should we continue to CC you?
>>
15 matches
Mail list logo