D6518: guard against themes without a valid shadow

2017-07-05 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > dialogshadows.cpp:270 > { > m_shadowPixmaps << q->pixmap(element); > } Validate element (hasElement and > 0) or add default pixmap. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6518

D6518: guard against themes without a valid shadow

2017-07-05 Thread David Edmundson
davidedmundson added a comment. What if a theme only has shadow-top, but not right etc. (or a more likely scenario, they exist, but the metadata has them be 0px big) What would happen if you have a theme with shadow then switch to one without? REPOSITORY R242 Plasma Framework

D6519: Use CMAKE_INSTALL_BINDIR for dbus service generation

2017-07-05 Thread Bastian Köcher
bkchr created this revision. bkchr added a project: KSecrets Service. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The old implementation used CMAKE_INSTALL_PREFIX for determining the installation directory. The

D6518: guard against themes without a valid shadow

2017-07-05 Thread Marco Martin
mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY some themes don't have a valid shadow, which would lead to a crash in kwayland, don't even try to render a shadow if

D6331: Make sure that the tsfiles target is generated

2017-07-05 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. The issue initially reported is fixed. I tried with //fr// and other 3 languages which should be representative enough (//de//, //uk//, //sr@ijekavian//; the latter was complaining before the last revision of the review).

D6331: Make sure that the tsfiles target is generated

2017-07-05 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > ltoscano wrote in KF5I18NMacros.cmake:178 > Before this line, in the original version before the changes, there was this > line: > > string(REPLACE "@" "_" pmapc_target ${pmapc_target}) > > Could it be

D6331: Make sure that the tsfiles target is generated

2017-07-05 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 16202. apol added a comment. - Restore the old behavior of KI18N_INSTALL_TS_FILES - Address luigi's comment REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6331?vs=16136=16202 BRANCH master REVISION DETAIL

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D6512#121834, @apol wrote: > +1 looks sensible to me. Sweet :) > What's the OCS state in this regard? When will 1.7 be a thing? OCS 1.7 will be a thing hopefully in the not too distant future... Incidentally, i need

D6513: Add support for Attica tags support

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is to add support for the new tags support in Attica found in https://phabricator.kde.org/D6512,

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Aleix Pol Gonzalez
apol added a comment. +1 looks sensible to me. What's the OCS state in this regard? When will 1.7 be a thing? REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki,

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir added a dependent revision: D6513: Add support for Attica tags support. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt, siyuandong,

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KDE Store. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch is to add support for the proposed addition of tags to the OCS standard version 1.7, as seen

Re: KTitleWidget and the native Mac style

2017-07-05 Thread René J . V . Bertin
On Wednesday July 05 2017 10:58:59 Hugo Pereira Da Costa wrote: >No >the default is false (no frame): > >breeze.kcfg: > > > >false > > Curious, I've always seen Breeze display the frame, and never activated the option as far as I can remember. I did notice yesterday that breezerc doesn't

D6493: Add KF5WindowSystem to link interface

2017-07-05 Thread David Edmundson
davidedmundson added a comment. Edit: I was wrong. We do need your first change but not the second change to cmakelists.txt REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6493 To: asturmlechner, #plasma Cc: davidedmundson, #frameworks

Re: KTitleWidget and the native Mac style

2017-07-05 Thread René J . V . Bertin
On Wednesday July 05 2017 09:55:27 Hugo Pereira Da Costa wrote: (CC'ing the plasma-devel ML and thus keeping Hugo's full reply as context.) >On 07/04/2017 11:13 PM, René J.V. Bertin wrote: >> On Tuesday July 04 2017 20:16:55 Sebastian Kügler wrote: >> >> @Kevin: should we continue to CC you? >>