D1231: Add Remote Access interface to KWayland

Kanedias added a comment. I'll get rid of the fakeinput-related changes and test it with KRfb tomorrow. @davidedmundson , can you test this with multiple outputs? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc:

D1231: Add Remote Access interface to KWayland

Kanedias updated this revision to Diff 16318. Kanedias added a comment. Added wl_output reference for buffers as requested by @davidedmundson and @graesslin REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=15553=16318 REVISION DETAIL

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

mdawson added a comment. +1 LGTM. Before submitting, can you poke the usability people about this change please? If they are also happy, then it's got a ship it from me. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6553 To: dfaure, mdawson Cc: ltoscano, apol,

D6558: do not stderr that NoDisplay is set

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KF5PackageMacros turns stderr output into cmake level warnings. setting nodisplay is perfectly reasonable and doesn't warrant a warning.

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

apol added a comment. In https://phabricator.kde.org/D6553#122749, @ltoscano wrote: > Just to be sure, does it touch all applications which uses tabs (like Okular)? Yes, unless Okular is not using the standard action. REPOSITORY R237 KConfig REVISION DETAIL

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

ltoscano added a comment. Just to be sure, does it touch all applications which uses tabs (like Okular)? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6553 To: dfaure, mdawson Cc: ltoscano, apol, #frameworks

D6532: When requesting from the cache, report all entries at bulk

apol closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6532 To: apol, #frameworks, whiting, leinir

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

apol added a comment. +1, this has annoyed me in the past. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6553 To: dfaure, mdawson Cc: apol, #frameworks

D6554: [Plasma Dialog] Fix flag condition

davidedmundson added a comment. Your description doesn't match the code > This didn't work when other flags,, such as WindowStaysOnTopHint were present. & Flag is the same as TestFlag() From what I can tell, you've changed: if (!tooltipFlag && !notification) into if(!

D6554: [Plasma Dialog] Fix flag condition

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6554 To: broulik, #plasma, mart Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6554: [Plasma Dialog] Fix flag condition

broulik edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6554 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6554: [Plasma Dialog] Fix flag condition

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The code wants to check whether we're not a tooltip. This didn't work. TEST PLAN My Alternatives popup now slides in

D6553: Standard shortcuts: use Ctrl+PageUp/PageDown for prev/next tab.

dfaure created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is what other webbrowsers like Firefox and Chrome do, and is certainly much more international than Ctrl+Comma/Ctrl+Dot which is very qwerty centric. TEST PLAN Switching tabs in

D6466: Android: scan for qml files in the source dir, not in the install dir.

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D6466#122419, @dfaure wrote: > In https://phabricator.kde.org/D6466#121152, @apol wrote: > > > This will be problematic as soon as your application

D6543: [KPageListViewDelegate] Pass widget to drawPrimitive

This revision was automatically updated to reflect the committed changes. Closed by commit R236:abe58c287c32: [KPageListViewDelegate] Pass widget to drawPrimitive in drawFocus (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/29/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Fri, 07 Jul 2017 11:46:35 + Build duration: 4 min 1 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 24 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/24/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 07 Jul 2017 11:46:35 + Build duration: 2 min 18 sec and counting JUnit

D6537: Fix display of formatDuration with rounding.

This revision was automatically updated to reflect the committed changes. Closed by commit R244:13675d6ab695: Fix display of formatDuration with rounding. (authored by davidedmundson). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6537?vs=16271=16300

D6537: Fix display of formatDuration with rounding.

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6537 To: davidedmundson, dfaure Cc: #frameworks

D6527: [Containment Interface] Keep containment in RequiresAttentionStatus while context menu is open

This revision was automatically updated to reflect the committed changes. Closed by commit R242:f3dcff28b8fb: [Containment Interface] Keep containment in RequiresAttentionStatus while… (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D6547: Fix build with Qt 5.9.1 and clang

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D6547 To: elvisangelaccio, #frameworks, kfunk

D6547: Fix build with Qt 5.9.1 and clang

elvisangelaccio edited the summary of this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D6547 To: elvisangelaccio, #frameworks

D6547: Fix build with Qt 5.9.1 and clang

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Qt 5.9.1 expands Q_REQUIRED_RESULT to the attribute (see commit d254d8c19 in qtbase). This breaks the build with clang compilers because

D6543: [KPageListViewDelegate] Pass widget to drawPrimitive

fvogt accepted this revision. fvogt added a comment. This revision is now accepted and ready to land. Tested, works fine here. I don't see any other cases of drawPrimitive being invoked without passing a widget. REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D6543: [KPageListViewDelegate] Pass widget to drawPrimitive

broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Ensure the style knows what widget its painting focus for. Also take the widget's style (as is done in the delegate paint method)

D6532: When requesting from the cache, report all entries at bulk

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Hmm... i was thinking this //could// cause issues, i don't see anywhere assumptions are made about page size on the consumption side (damn we're lucky this whole split thing's so new ;) ).

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16285. kfunk added a comment. Fix logic. Sorry, must have been asleep here... :\ REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16284=16285 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16284. kfunk added a comment. Simplify code, address concerns REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16265=16284 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES

D6541: Emit signals from icon border when no mark was clicked

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - currently it is not possible to get a signal from the icon border menu when no mark is clicked, which prevents the creation

D6535: Use mutually exclusive group in Default Mark Type

croick added inline comments. INLINE COMMENTS > kateviewhelpers.cpp:2257 > dMA = selectDefaultMark.addAction(i18n("Mark Type %1", bit + > 1)); > +selectDefaultMarkActionGroup->addAction(dMA); > } this could be done once, after the if-else-block REPOSITORY

D6540: Use QActionGroup in icon border default marker menu

croick abandoned this revision. croick added a comment. Duplicate of D6535 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6540 To: croick, #ktexteditor Cc: kwrite-devel, #frameworks

D6540: Use QActionGroup in icon border default marker menu

croick created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY - the current checkboxes imply that it is possible to select more than one default marker, QActionGroup groups them to one