davidedmundson accepted this revision.
davidedmundson added a comment.
There's a bunch more q->flags & Qt::Tooltip, if we're going to change one, we
should change them all.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6554
To: broulik, #plasma,
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsQt5.7/22/
Project:
Frameworks kwindowsystem kf5-qt5 WindowsQt5.7
Date of build:
Sat, 08 Jul 2017 23:21:58 +
Build duration:
29 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kactivities-stats%20kf5-qt5%20XenialQt5.7/10/
Project:
Frameworks kactivities-stats kf5-qt5 XenialQt5.7
Date of build:
Sat, 08 Jul 2017 23:21:48 +
Build duration:
1 min 42 sec and counting
graesslin added a comment.
In https://phabricator.kde.org/D6569#123081, @davidedmundson wrote:
> I don't think this is necessary.
>
> The only times we want need to delete the connection ourselves is when
client code is creating it via ConnectionThread::fromApplication. If they
creat
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/31/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Sat, 08 Jul 2017 19:01:27 +
Build duration:
3 min 35 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/26/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 19:01:27 +
Build duration:
1 min 41 sec and counting
JUnit Tes
Kanedias added a comment.
Btw, should I bump patches to KWin/KRfb to match this version?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D1231
To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-
Kanedias added a comment.
@davidedmundson , @graesslin , I cleaned up fake-input handling, fixed
autotests.
Tested this manually with patched KWin and KRfb version - all works fine
(only one screen though).
I'm able to retrieve wl_output from native interface as David suggested.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:97ce7535124a: Fix build with Qt 5.9.1 and clang (authored
by elvisangelaccio).
REPOSITORY
R249 KI18n
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6547?vs=16293&id=16360
REVISION DETAIL
Kanedias updated this revision to Diff 16359.
Kanedias added a comment.
some -> const modifiers and typos
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1231?vs=16318&id=16359
REVISION DETAIL
https://phabricator.kde.org/D1231
AFFECTED FILES
autotests
davidedmundson added a comment.
I don't think this is necessary.
The only times we want need to delete the connection ourselves is when client
code is creating it via ConnectionThread::fromApplication. If they create it
themselves, we don't want to, and there's no need to track it.
graesslin added a dependent revision: D6571: Delete all Wayland connections by
plugins prior to own Wayland connection.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6569
To: graesslin, #frameworks, #plasma, #kwin
Cc: dfaure, plasma-devel, ZrenBot, progwolff, lesliez
dfaure added a comment.
Isn't a mutex needed to protect this data structure that is apparently
modified by different threads?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D6569
To: graesslin, #frameworks, #plasma, #kwin
Cc: dfaure, plasma-devel, ZrenBot, progwolf
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.7/14/
Project:
Frameworks threadweaver kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 12:22:08 +
Build duration:
20 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/25/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 12:21:33 +
Build duration:
16 min and counting
graesslin created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This is change needed by KWin. KWin has the problem that it destroys its
internal Wayland connection (KWin as client
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/25/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Sat, 08 Jul 2017 12:21:32 +
Build duration:
5 min 40 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.7/16/
Project:
Frameworks krunner kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 12:11:18 +
Build duration:
2 min 13 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.7/16/
Project:
Frameworks kpty kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 12:10:12 +
Build duration:
1 min 26 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/18/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 12:08:02 +
Build duration:
1 min 47 sec and counting
JUnit Tests
dfaure added a comment.
Damn, you're right, the third alternate isn't editable.
Making the shortcuts dialog more complex for this corner case doesn't sound
like a good solution either...
I'm considering going back to the previous approach, users of Ctrl comma/dot
will have to either
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/30/
Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
Date of build:
Sat, 08 Jul 2017 11:51:27 +
Build duration:
3 min 41 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/25/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Sat, 08 Jul 2017 11:51:27 +
Build duration:
2 min 3 sec and counting
JUnit Test
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/14/
Project:
Frameworks baloo kf5-qt5 XenialQt5.7
Date of build:
Sat, 08 Jul 2017 11:43:02 +
Build duration:
5 min 43 sec and counting
JUnit Tests
Name:
cfeck added a comment.
I am not sure if the shortcut editor allows editing the third shortcut. If
the user had assigned these to other actions, she needs a way to resolve the
conflicts.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D6553
To: dfaure, mdawson
Cc: cf
dfaure updated this revision to Diff 16335.
dfaure added a comment.
Preserve existing shortcuts
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6553?vs=16307&id=16335
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6553
AFFECTED FILES
src
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6558
To: sitter, mart, sebas, apol, dfaure
Cc: #frameworks
dfaure added a comment.
QKeySequence supports more, just not this data table.
I can look into extending that of course, if we want to be conservative about
this.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D6553
To: dfaure, mdawson
Cc: aacid, ltoscano, apol,
aacid added a comment.
-1 don't see why we should change established shortcuts people have learnt to
use.
Don't we have support for infinite shortcuts? Why not just add those that you
find important?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D6553
To: dfa
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:bcf2bcf39b44: Android: scan for qml files in the source
dir, not in the install dir. (authored by dfaure).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
30 matches
Mail list logo
