D6473: Crash when replacing new lines with spaces

jsalatas added a comment. In https://phabricator.kde.org/D6473#124300, @dhaumann wrote: > So the question is: Why is the cursor not updated? If we can answer this, we may be able to either find that this patch is correct, or that the root of the real issue lies somewhere else...

D6473: Crash when replacing new lines with spaces

dhaumann added a comment. ...thining a bit more about this: What I dislike is the fact that we don't seem to understand why it crashes in the first place, right? The problem is that the cursor of the view is not updated, so it is behind the document end in an invalid line. And moving the

D6473: Crash when replacing new lines with spaces

dhaumann added a comment. I'm not an expert in the search code - in general your fix looks sane (had a look into the KateRegExp class). A unit test indeed would be helpful, since it will allow us to not break the search code again. REPOSITORY R39 KTextEditor REVISION DETAIL

D6473: Crash when replacing new lines with spaces

jsalatas added a comment. In https://phabricator.kde.org/D6473#124287, @kfunk wrote: > Could you add a test in e.g. autotests/src/searchbar_test.cpp? Sure! will do it later... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas,

D6473: Crash when replacing new lines with spaces

kfunk added a comment. Could you add a test in e.g. autotests/src/searchbar_test.cpp? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: kfunk, ltoscano, kwrite-devel, #frameworks

D5034: Add support for x-gvfs style options in fstab

bruns added inline comments. INLINE COMMENTS > fstabstorageaccess.cpp:48 > > +const QStringList = FstabHandling::options(device->device()); > +// GVFS by default doesn't show devices outside of /media, $HOME (and > some other locations) Another useless use of const QList&,

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. In https://phabricator.kde.org/D6604#124228, @ochurlaud wrote: > At the time I thought about merging it but we would have to re-document everything in doxygen , which would be completely different from what upstream cmake does. > > The ECM page is already

D6473: Crash when replacing new lines with spaces

jsalatas added a comment. ping? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: ltoscano, kwrite-devel, #frameworks

D4377: Fix Python dependency in test scripts for KFileMetaData (bug 375472)

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. I tested on Debian with python2 (the version for /usr/bin/python ) . It works. Please ship your patch. Thanks for your work and sorry for the delay from my side. REPOSITORY R286

D6604: add a metainfo.yaml to make ECM a proper framework

ochurlaud added a comment. At the time I thought about merging it but we would have to read document everything in doxygen , which would be completely different from what upstream cmake does. The ECM page is already linked from the left menu. Does it make sense to have it in

D6631: Fix compilation with strict libc (such as musl)

mpyne created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Many of the functions we use implicitly are not part of the C standard library so we have to specific that we're pulling from POSIX, X/Open,

D6604: add a metainfo.yaml to make ECM a proper framework

dfaure added a comment. Please add a README.md too, with the same syntax as in the other frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6604 To: sitter, ochurlaud, dfaure, skelly Cc: #frameworks, #build_system

D5209: Load translations from KPackage files if bundled

ltoscano added a comment. In https://phabricator.kde.org/D5209#124129, @davidedmundson wrote: > contents/locale/fr/org.kde.blahblah.po > > which is the same as KDE4. I guess you mean contents/locale/fr/org.kde.blahblah.**mo** ? REPOSITORY R242 Plasma Framework (Library)

D5209: Load translations from KPackage files if bundled

davidedmundson added a comment. contents/locale/fr/org.kde.blahblah.po which is the same as KDE4. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: Zren, plasma-devel, #frameworks, ZrenBot, progwolff,

D5209: Load translations from KPackage files if bundled

Zren added a comment. Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then? Does this mean: 1. `digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po` 2.

D5208: Allow loading i18n catalogs from arbitrary locations

This revision was automatically updated to reflect the committed changes. Closed by commit R249:4c95ac8bb47f: Allow loading i18n catalogs from arbitrary locations (authored by davidedmundson). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5208?vs=12962=16509

D5209: Load translations from KPackage files if bundled

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3a0f61b5591d: Load translations from KPackage files if bundled (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Re: kaboutlicense api extension ::spdxId()?

On dinsdag 11 juli 2017 13:41:17 CEST Harald Sitter wrote: > I was wondering if anyone had an opinion on extending kaboutlicense > with a ::spdxId() instance method returning the license's spdx id [1]. > > Use case at hand is kpackagetool, which maps X-KDE-PluginInfo-License > of (e.g.) plasma

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added a comment. In https://phabricator.kde.org/D6624#124077, @cfeck wrote: > Reading your description on the referenced QTBUG, does it help to use a compare with previous m_columns in KCharSelectItemModel ::setColumnCount() before doing the emit dance? It probably does.

kaboutlicense api extension ::spdxId()?

Hola I was wondering if anyone had an opinion on extending kaboutlicense with a ::spdxId() instance method returning the license's spdx id [1]. Use case at hand is kpackagetool, which maps X-KDE-PluginInfo-License of (e.g.) plasma applets to appstream metadata. Appstream however uses the

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/14/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 11 Jul 2017 11:31:05 + Build duration: 50 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/13/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 11 Jul 2017 11:31:05 + Build duration: 52 sec and counting JUnit Tests

D6624: do not crash qaccessible by causing a resize in a resize event

cfeck added a comment. Reading your description on the referenced QTBUG, does it help to use a compare with previous m_columns in KCharSelectItemModel ::setColumnCount() before doing the emit dance? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6624 To:

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kcharselect.cpp:251 > QSignalBlocker blockResize(this) ? Block inhibits signal emission/slot calling. That is not what we want. We want the signals to run, just not on the same call chain as the resize event. REPOSITORY

D6624: do not crash qaccessible by causing a resize in a resize event

anthonyfieroni added inline comments. INLINE COMMENTS > kcharselect.cpp:251 > +connect(timer, ::timeout, [&,timer]() { > +d->_k_resizeCells(); > +timer->deleteLater(); QSignalBlocker blockResize(this) ? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D6606: Support SVG too

This revision was automatically updated to reflect the committed changes. Closed by commit R313:ed5c039f2d19: Support SVG too (authored by wbauer). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6606?vs=16448=16505#toc REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE

D6624: do not crash qaccessible by causing a resize in a resize event

sitter added a comment. FWIW, this is a bit of workaround. Not having kcharselect crash for just about every search is well worth it though. Also, I am not sure I particularly like the qtimer code. It does beat having to pass `const char *` method names to `invokeMethod` and turning the

D6624: do not crash qaccessible by causing a resize in a resize event

sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When enabling accessibility qaccessible will automatically add a11y support constructs to core qt types such as qtableview. Unfortunately

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/12/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 11 Jul 2017 10:31:01 + Build duration: 26 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/13/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 11 Jul 2017 10:31:01 + Build duration: 58 sec and counting JUnit Tests

D6608: [PlasmaComponents Menu] Don't crash on null action

This revision was automatically updated to reflect the committed changes. Closed by commit R242:21f954d94dc5: [PlasmaComponents Menu] Don't crash on null action (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/12/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Tue, 11 Jul 2017 10:20:06 + Build duration: 1 min 9 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/11/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Tue, 11 Jul 2017 10:20:06 + Build duration: 33 sec and counting JUnit Tests

D6604: add a metainfo.yaml to make ECM a proper framework

sitter added a comment. Good point on trying it locally. So, as one could expect this adds ECM as a product F3808791: Screenshot_20170711_120142.png Unfortunately given we have no actual documentation (outside the cmake documentation)

D6608: [PlasmaComponents Menu] Don't crash on null action

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6608 To: broulik, #plasma, davidedmundson Cc: anthonyfieroni, davidedmundson, plasma-devel, #frameworks, ZrenBot,

D6608: [PlasmaComponents Menu] Don't crash on null action

broulik updated this revision to Diff 16491. broulik added a comment. When assigning an action, match the item's visibility and enabled REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6608?vs=16452=16491 REVISION DETAIL