D6597: Add magic define to enable setgroups(2)

2017-07-22 Thread Michael Pyne
mpyne added a comment. With the help of the KDE sysadmins, I've tested this to build on FreeBSD. BSD-specific defines remain available on FreeBSD unless you start to use `_POSIX_C_SOURCE`, `_ANSI_SOURCE`, or `_XOPEN_SOURCE`. So `_BSD_SOURCE` and `_DEFAULT_SOURCE` appear to be safe for Free

D6596: Fix dev_t declaration for Solid UDisks2 backend

2017-07-22 Thread Michael Pyne
mpyne added a comment. If there are objections to this please let me know in next few days. A similar Differential request to this has already been opened and abandoned. I also have similar fixes/changes in https://phabricator.kde.org/D6597 and https://phabricator.kde.org/D6598 for whic

D6840: Add KF6 TODO for missing argument namespace in slot signature

2017-07-22 Thread Kevin Funk
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM Other KF6-related notes in KF5 look the same. REPOSITORY R39 KTextEditor BRANCH addkf6todo REVISION DETAIL https://phabricator.kde.org/D6840 To: kossebau, #kate, kfunk Cc: k

D6841: Use "document-close" as icon for KStandardAction::close

2017-07-22 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY As KStandardAction::close is about closing a file/document, both by API dox ("Close the current document") as well as set tooltip text (

D6840: Add KF6 TODO for missing argument namespace in slot signature

2017-07-22 Thread Friedrich W . H . Kossebau
kossebau added a comment. Unsure how you like your fixme-on-next-abi-change notes done, and noone on irc, so dumping here for now :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6840 To: kossebau, #kate Cc: kwrite-devel, #frameworks

D6840: Add KF6 TODO for missing argument namespace in slot signature

2017-07-22 Thread Friedrich W . H . Kossebau
kossebau created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REPOSITORY R39 KTextEditor BRANCH addkf6todo REVISION DETAIL https://phabricator.kde.org/D6840 AFFECTED FILES src/view/kateview.h To:

D6836: Stash without asking the user with a Copy/Cancel popup.

2017-07-22 Thread David Faure
This revision was automatically updated to reflect the committed changes. Closed by commit R241:7afee3f17674: Stash without asking the user with a Copy/Cancel popup. (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6836?vs=17029&id=17031#toc REPOSITORY R241 KIO CHA

D6836: Stash without asking the user with a Copy/Cancel popup.

2017-07-22 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6836 To: dfaure, #dolphin, elvisangelaccio Cc: #frameworks

D6836: Stash without asking the user with a Copy/Cancel popup.

2017-07-22 Thread David Faure
dfaure created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Just like when dropping files onto the trash, when dropping files onto kio_stash we can just do it without asking for the type of action w

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. @thiago Used FdSender in the function senndFileDescriptor in https://phabricator.kde.org/D6197 [filehelper.cpp] and FdReceiver in https://phabricator.kde.org/D6830 [file_unix.cpp] REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinm

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr Cc: #frameworks

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6833: Add support for PrivilegeExecution in KIO jobs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. chinmoyr added reviewers: dfaure, Frameworks. chinmoyr added a dependency: D6832: Integrate new file ioslave in KIO job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added reviewers: dfaure, Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr Cc: #frameworks

D6831: Make use of kauth helper in methods of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. chinmoyr added reviewers: dfaure, Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6831 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. chinmoyr added reviewers: dfaure, Frameworks. chinmoyr added a subscriber: elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6830 To: chinmoyr, dfaure, #frameworks Cc: elvisangelaccio, #frameworks

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. chinmoyr added reviewers: dfaure, Frameworks. chinmoyr added a dependency: D6197: Add kauth helper to file ioslave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr, dfaure, #frameworks Cc: #frameworks

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6829: Add ability to use the new kauth helper in file ioslave. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr edited the summary of this revision. chinmoyr added a dependency: D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6197: Add kauth helper to file ioslave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks Cc: davidedmundson, elvisangelaccio, shortstheory

D6831: Make use of kauth helper in methods of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6831 To: chinmoyr Cc: #frameworks

D6834: [KNewFileMenu] Enable creating new files in read-only folders

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6834 To: chinmoyr Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr Cc: #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6830 To: chinmoyr Cc: #frameworks

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr Cc: #frameworks

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr Cc: #frameworks

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr Cc: #frameworks

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks Cc: davidedmundson, elvisangelaccio, shortstheory

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks Cc: davidedmundson, elvisangelaccio, shortstheory

D6831: Make use of kauth helper in methods of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6831 To: chinmoyr Cc: #frameworks

D6834: [KNewFileMenu] Enable creating new files in read-only folders

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6834 To: chinmoyr Cc: #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6830 To: chinmoyr Cc: #frameworks

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr Cc: #frameworks

D6831: Make use of kauth helper in methods of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6831 To: chinmoyr Cc: #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6830 To: chinmoyr Cc: #frameworks

D6834: [KNewFileMenu] Enable creating new files in read-only folders

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6834 To: chinmoyr Cc: #frameworks

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6833 To: chinmoyr Cc: #frameworks

D6834: [KNewFileMenu] Enable creating new files in read-only folders

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds PrivilegeExecution flag to the jobs used by KnewFileMenu. This would allow the user to create new files in a read only dire

D6833: Add support for PrivilegeExecution in KIO jobs

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds support for PrivilegeExecution job flag in chmodjob, copyjob, deletejob, mkpathjob, transferjob and storedtransferjob. Dolp

D6832: Integrate new file ioslave in KIO job

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY 1. Adds a new job flag, PrivilegeExecution, to be used from applications side. 2. Adds code for confirmation dialog to be shown when the s

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6831: Make use of kauth helper in methods of file ioslave. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6831: Make use of kauth helper in methods of file ioslave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr Cc: #frameworks

D6831: Make use of kauth helper in methods of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Adds calls to `execWithRootPrivileges()` to following methods chmod(), get(), mkdir(), put(), setModificationTime(), deleteRecursive(),

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6830: Make use of kauth helper in copy method of file ioslave. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr Cc: #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds calls to `execWithElevatedPrivilege()` in copy method. `FileProtocol::copy()` is an important and somewhat complex method.

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a dependent revision: D6830: Make use of kauth helper in copy method of file ioslave. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks Cc: davidedmundson, elvisangelaccio, shortstheory

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks Cc: davidedmundson, elvisangelaccio, shortstheory

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr removed a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6829 To: chinmoyr Cc: #frameworks

D6829: Add ability to use the new kauth helper in file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch adds a method `execWithElevatedPrivilege()` which can be used by other methods of `FileProtocol` class when there occurs an erro

D6381: Add KAuth support to rename file operation.

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6381 To: chinmoyr Cc: elvisangelaccio, #frameworks

D6383: Add KAuth support to KIO's symlink operation

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6383 To: chinmoyr, elvisangelaccio Cc: #frameworks

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REVISION DETAIL https://phabricator.kde.org/D6197 To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D6197: Add kauth helper to file ioslave

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 17013. chinmoyr retitled this revision from "Add basic KAuth support to file ioslave" to "Add kauth helper to file ioslave". chinmoyr edited the summary of this revision. chinmoyr removed subscribers: davidedmundson, dfaure, eliasp, aacid. chinmoyr added a co

Minutes GSoC meeting

2017-07-22 Thread Elvis Angelaccio
Present: me, chinmoy, pepo. Minutes in the attachment. Cheers, Elvis2017-07-22 10:00:25 eangMeeting! 2017-07-22 10:00:41 chinmoy[m] i here 2017-07-22 10:00:57 eangwe can start 2017-07-22 10:01:50 chinmoy[m] this week 2017-07-22 10:02:56 chinmoy[m] I wor

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr added a task: T6561: Polkit support in KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6709 To: chinmoyr, thiago, #frameworks Cc: davidedmundson, elvisangelaccio, shortstheory

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-07-22 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 17012. chinmoyr marked 5 inline comments as done. chinmoyr added a comment. std::string -> QString binded -> bound setNonBlock() - > SOCK_NONBLOCK REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6709?vs=16732&id=17012

Disable automatic connection switch

2017-07-22 Thread Federico Buti
Hi list. I've been tasked from my boss to write a little wrapper for NetworkManagerQt to provide specific operations suited from the devices of my company. Currently the devices have wifi, umts modem and ethernet interfaces. The latter should not be used to communicate with our server thus I've a

D6808: Mark MPa and PSI as common units

2017-07-22 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R292:11a8590d0e83: Mark MPa and PSI as common units (authored by ngraham, committed by aacid). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6808?vs=16966&id=16

D6820: Add QValidator to KTimeCombobox

2017-07-22 Thread Christoph Feck
cfeck added a comment. Several code style issues. Please run it through uncrustify-kf5.cfg (see kde-dev-scripts.git) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D6820 To: bednar Cc: cfeck, #frameworks