BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/79/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 14 Aug 2017 02:57:05 +
Build duration:
18 min and counting
CONSOLE OUTPUT
[...truncat
jpoelen added a reviewer: Framework: Syntax Hightlighting.
jpoelen edited projects, added Framework: Syntax Hightlighting; removed
Frameworks.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7297
To: jpoelen, #framework_syntax_hightlighting
Cc: #frameworks,
jpoelen abandoned this revision.
jpoelen added a comment.
This commit is already merged.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D6288
To: jpoelen
Cc: #frameworks
jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R216 Syntax Highlighting
BRANCH
pony
REVISION DETAIL
https://phabricator.kde.org/D7297
AFFECTED FILES
autotests/folding/highlight.pony.fol
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> filehelper.cpp:39
> +}
> +errno = -1;
> +}
this basically abuses a global variable for something that could just be a
return value from this function
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good otherwise.
(Maybe extend the unittest for dropjob to test the polkit case too?)
INLINE COMMENTS
> dropjob.cpp:107
> +if (m_flags & KIO::PrivilegeExecution)
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fileundomanager.cpp:111
> +private:
> +class UndoJobPrivate : public JobPrivate
> +{
Is this subclass needed? You could just move the code of its cons
dfaure added a comment.
Thanks for the investigation. Actually the deprecated method wasn't supposed
to change behaviour. This was actually a consequence of the rework of the
patch, which initially didn't have this problem :-)
Proper fix is up for review: https://phabricator.kde.org/D729
dfaure created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
https://phabricator.kde.org/R278:32526718eae99ccb594360627586eebdf793372b
made this deprecated method call the new method which
can also set KeypadModifier, but for compatibility reasons symXToK
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bcdbe62660a9: Remove busy loop check in
TransferJobPrivate::slotDataReqFromDevice (authored by aacid).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7045?vs=18097&id=1
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
OK, thanks for the test.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7045
To: aacid, dfaure
Cc: dfaure, apol, #frameworks
dhaumann added a comment.
Ah, maybe I was too quick: this depends on deprecating Help, I am not yet
convinced about this.
However, the rest looks good.
REPOSITORY
R265 KConfigWidgets
BRANCH
improve-apidox
REVISION DETAIL
https://phabricator.kde.org/D7287
To: elvisangelaccio, #frame
dhaumann added a comment.
Not sure, but is that reason enough to deprecate API? This doesn't sound
convincing yet...
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks
Cc: dhaumann
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks mostly good to me, and definitely better.
INLINE COMMENTS
> kstandardaction.h:172
> +Next, ///< Scroll down one page.
> +Goto, ///< Go to somewhere in general.
> +Goto
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Please commit - thanks! :)
As I understand, the indent coloring with '>' is gone. There certainly will
be some users who want that, but if requested, we can add it again (I remember
vkrause updated this revision to Diff 18106.
vkrause added a comment.
- improve content boundary regexp
- don't attempt to highlight unknown header content, those can contain
arbitrarily bizarrely encoded stuff (see e.g. X-Face)
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDA
vkrause updated this revision to Diff 18105.
vkrause added a comment.
Add body context, fix some allowed characters for content boundaries and
email addresses.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7289?vs=18088&id=18105
BRANCH
mast
vkrause marked an inline comment as done.
vkrause added inline comments.
INLINE COMMENTS
> dhaumann wrote in email.xml:51
> Not sure, but is underscore '_' also allowed?
Not here, but below indeed.
> dhaumann wrote in email.xml:52
> Search for lineEmptyContext here:
> https://docs.kde.org/trun
dhaumann added a comment.
Looks already good, but maybe we can do better with the lineEmptyContext?
Also, we have things like fallthroughContext, if no rule matches at all in a
context.
I suggest one more review iteration.
INLINE COMMENTS
> email.xml:51
> + String="head
apol added a comment.
Do we have numbers on what's the improvement to use this? It will be an
incentive to see it applied on all frameworks.
REPOSITORY
R236 KWidgetsAddons
BRANCH
dontleaksymbolsofpimplclasses
REVISION DETAIL
https://phabricator.kde.org/D7279
To: kossebau, cfeck, dfau
apol added a comment.
Ugh my bad ^^', I don't know what happened.
> The reason why I'm discussing this is that I think one of the advantages of
Flatpak
is that it makes it much easier to set up the build environment. Documented
dependencies and tooling that integrates it. We need to
elvisangelaccio updated this revision to Diff 18098.
elvisangelaccio added a comment.
- Fixup PasteText doc.
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7287?vs=18092&id=18098
BRANCH
improve-apidox
REVISION DETAIL
https://phabricator.kde.org
aacid added a comment.
In https://phabricator.kde.org/D7045#134216, @dfaure wrote:
> Yes that would be a good idea. AFAICS it's still one good reason to loop
around, i.e. it's a possible regression from this patch.
Seems TransferJobPrivate::slotIODeviceClosed takes care of reading
aacid updated this revision to Diff 18097.
aacid added a comment.
Added new test
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7045?vs=17514&id=18097
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7045
AFFECTED FILES
autotests/jobtest.cpp
elvisangelaccio abandoned this revision.
elvisangelaccio added a comment.
I was wrong, this action is needed for KPasteTextAction.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7294
To: elvisangelaccio, #frameworks
elvisangelaccio added dependent revisions: D7294: Deprecate
KStandardAction::PasteText, D7293: Deprecate KStandardAction::SaveOptions,
D7292: Deprecate KStandardAction::Help.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7287
To: elvisangelaccio, #frameworks
elvisangelaccio added a dependency: D7287: Improve KStandardAction apidox..
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7292
To: elvisangelaccio, #frameworks
elvisangelaccio added a dependency: D7287: Improve KStandardAction apidox..
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7294
To: elvisangelaccio, #frameworks
elvisangelaccio added a dependency: D7287: Improve KStandardAction apidox..
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7293
To: elvisangelaccio, #frameworks
elvisangelaccio edited the summary of this revision.
REPOSITORY
R265 KConfigWidgets
REVISION DETAIL
https://phabricator.kde.org/D7294
To: elvisangelaccio, #frameworks
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
We already have KStandardAction::Paste which is widely used,
while according to lxr, there is only one usage of PasteText and 3 of
pasteText(). There is no reason to have two standarda
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
According to lxr, no one is using it. So just mark it as deprecated for
removal.
REPOSITORY
R265 KConfigWidgets
BRANCH
deprecate-saveoptions
REVISION DETAIL
https://phabricator.
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
According to lxr, no one is using it (applications use HelpContents
to show the handbooks). So just mark it as deprecated for removal.
REPOSITORY
R265 KConfigWidgets
BRANCH
depreca
mpyne added a comment.
In https://phabricator.kde.org/D7281#135053, @kossebau wrote:
> @mpyne: Beware, I have such patches prepared for all of KF :)
OK, I'll hold off on this one pending your KF5-wide patchset ;)
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator
elvisangelaccio updated this revision to Diff 18092.
elvisangelaccio added a comment.
- Fix HelpContents
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7287?vs=18090&id=18092
BRANCH
improve-apidox
REVISION DETAIL
https://phabricator.kde.org/D72
elvisangelaccio updated this revision to Diff 18090.
elvisangelaccio added a comment.
- Forgot to document one value.
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7287?vs=18086&id=18090
BRANCH
improve-apidox
REVISION DETAIL
https://phabricato
vkrause created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
- no more hardcoded colors, which makes the source view in KMail a lot more
pleasant to look at
- reduced the regexp usage in favor of key
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Add documentation to the StandardAction enum values. While at it, clean
up a bunch of sentences in the related methods.
REPOSITORY
R265 KConfigWidgets
BRANCH
improve-apidox
REVISI
rjvbb created this revision.
rjvbb added a project: Frameworks.
REVISION SUMMARY
As mentioned in https://phabricator.kde.org/D7237, the kioslave helper is
also a candidate for being converted to a "nongui" agent.
It thus makes sense to put the helper functions into a shared library, all
the
aaronpuchert updated this revision to Diff 18081.
aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.
Changed license to MIT.
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7280?vs=18067&id=18081
BRANCH
metamath
REVI
aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.
I don't have a commit account, so I'd need you to commit the changes.
INLINE COMMENTS
> dhaumann wrote in metamath.xml:7
> Can you change the license to MIT?
No problem. I was just looking what others were using, an
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/19/
Project:
Frameworks bluez-qt kf5-qt5 XenialQt5.7
Date of build:
Sun, 13 Aug 2017 11:25:32 +
Build duration:
1 min 59 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/20/
Project:
Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 13 Aug 2017 11:25:32 +
Build duration:
1 min 20 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:088a0c67ccdc: make kiod5 an "agent" on Mac (authored by
rjvbb).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7237?vs=18037&id=18080#toc
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
htt
anthonyfieroni added a comment.
But what is point to have a DataOfferInterface without valid source?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7078
To: graesslin, #kwin, #plasma, #frameworks
Cc: anthonyfieroni, davidedmundson, plasma-devel, leezu, ZrenBot, pro
graesslin added a comment.
To me the question is rather: can we ensure that other users of KKeyServer
didn't get broken by the change. What KWin did could be considered a bug or an
application misuse. KWin used the Qt key and compared it directly to
Qt::Key_Enter. That one doesn't work anymo
graesslin added a comment.
@dfaure please note that I already worked around the regression in KWin
master.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D6233
To: dfaure, graesslin
Cc: bcooksley, graesslin, #frameworks
graesslin added a comment.
In https://phabricator.kde.org/D7078#135036, @davidedmundson wrote:
> > So from KWayland Server side we have a selection
>
> from KWayland server side we have a Seat:selection, we don't check if that
has a DDI::selection
>
>
>
> If a client had
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/54/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 13 Aug 2017 07:47:18 +
Build duration:
7 min 10 sec and counting
JUnit Tes
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:9ef966973313: Fix build with QT_NO_ACCESSIBILITY (authored
by vkrause).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7275?vs=18056&id=18074
REVISION DETAIL
h
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/53/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 13 Aug 2017 07:25:38 +
Build duration:
10 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:878797830dbd: Switch from QtScript to QtQml (authored by
carewolf).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6914?vs=18072&id=18073#toc
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UP
dhaumann added a comment.
Looks already pretty good. But please change the license to MIT. We agreed to
using MIT license for new syntax-highlighting files. Could you update the
review request again?
Also can you commit yourself (i.e. Do you have a commit account? ) or shall I
commit fo
carewolf updated this revision to Diff 18072.
carewolf added a comment.
Minor cleanups
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6914?vs=17281&id=18072
REVISION DETAIL
https://phabricator.kde.org/D6914
AFFECTED FILES
CMakeLists.txt
autotests/CMakeLists.txt
autotests/s
dhaumann added a comment.
As you wish, but we'd also be fine with this commit now, and additional
commits for fine tuning. The main point is to get this in as early as possible
to have a longer testing period.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde
kossebau added a comment.
Okay, if just forgotten then I have patches for all of KF5, would just go
ahead and add Q_DECL_HIDDEN whereever it seems useful.
Would do so upcoming Monday.
REPOSITORY
R236 KWidgetsAddons
BRANCH
dontleaksymbolsofpimplclasses
REVISION DETAIL
https://phabri
carewolf added a comment.
Actually I wanted to clean a few minor things first. I will update it.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D6914
To: carewolf, cullmann, dhaumann, #frameworks
Cc: dfaure, cullmann, #frameworks
kossebau added a comment.
@mpyne: Beware, I have such patches prepared for all of KF :)
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D7281
To: mpyne, #frameworks
Cc: kossebau
58 matches
Mail list logo
