D7316: Avoid sending data offers from an invalid source.

davidedmundson updated this revision to Diff 18213. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. Split into two lines REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7316?vs=18162=18213

D7316: Avoid sending data offers from an invalid source.

davidedmundson marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7316 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7293: Deprecate KStandardAction::SaveOptions

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Indeed I have never seen "Save Settings" anywhere, and git log says it was added in 2000, with a bunch of other standard actions, looks like "just in case" to me. REPOSITORY R265

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7328 To: asturmlechner, #frameworks, dfaure

Re: Running applications and unittests without "make install"

On mardi 15 août 2017 18:36:39 CEST Elvis Angelaccio wrote: > On martedì 15 agosto 2017 17:17:16 CEST, David Faure wrote: > > Hi everyone, > > > > The documentation for how to do that is now up at > > > > https://blogs.kde.org/2017/08/15/running-applications-and-unittests-withou > >

D6829: Add ability to use the new kauth helper in file ioslave

dfaure added inline comments. INLINE COMMENTS > global.h:265 > /** > + * Specifies privilege file operation status. > + */ @since 5.38 > global.h:267 > + */ > +enum PrivilegeFileOpStatus { > +OperationNotAllowed, I suggest naming it PrivilegedOperationStatus (Better avoid

D6197: Add kauth helper to file ioslave

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filehelper.cpp:46 > +// Set it to 0. > +errno = 0; > + Well, this proves exactly my earlier point: we should only test errno *when* a libc function

D6829: Add ability to use the new kauth helper in file ioslave

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > global.h:270 > +OperationAllowed, > +OperationCancelled > +}; Canceled and cancelled as both correct English (maybe one is UK and one is US, I don't

D7337: Port rest of scripting API to QJSValue-based solution

carewolf accepted this revision. carewolf added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7337 To: dhaumann, carewolf, cullmann Cc: kwrite-devel, #frameworks

D7337: Port rest of scripting API to QJSValue-based solution

dhaumann created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This completes the scripting API for QJSValue-based Cursor and Range functions. The changes are rather simple, sometimes code

D6830: Make use of kauth helper in copy method of file ioslave

chinmoyr updated this revision to Diff 18208. chinmoyr added a comment. - Added method to check if filesystem supports chmod, chown and utime. - Added check for EUSERCANCELLED error. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6830?vs=18015=18208 BRANCH master REVISION

D6829: Add ability to use the new kauth helper in file ioslave

chinmoyr updated this revision to Diff 18206. chinmoyr added a comment. - Fix spelling CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6829?vs=18205=18206 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6829 AFFECTED FILES src/core/global.h

D6829: Add ability to use the new kauth helper in file ioslave

chinmoyr updated this revision to Diff 18205. chinmoyr added a comment. - Fix spelling CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6829?vs=18204=18205 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6829 AFFECTED FILES src/core/global.h

D6829: Add ability to use the new kauth helper in file ioslave

chinmoyr updated this revision to Diff 18204. chinmoyr added a comment. - Added enum to denote file operation state - Added new error code CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6829?vs=18014=18204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6829

Re: github repos

El dimarts, 15 d’agost de 2017, a les 17:14:27 CEST, David Faure va escriure: > Hi Albert, > > I just added myself as watcher to the frameworks I maintain: > > karchive > kcrash > kdbusaddons > kded > kinit > kio > kparts > kservice > kxmlgui > > Can you remove the auto-reply on merge requests

D7316: Avoid sending data offers from an invalid source.

graesslin added inline comments. INLINE COMMENTS > datadevice_interface.cpp:206 > +if (!otherSelection) { > +return sendClearSelection(); > +} please use a dedicated line for the return here. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7316 To:

D6197: Add kauth helper to file ioslave

chinmoyr added inline comments. INLINE COMMENTS > dfaure wrote in filehelper.cpp:44 > should be unnecessary now, with the above suggested change In my system errno is set to 11. It seems like the case where function call succeeds but errno is set. But then it happens right after control

D6197: Add kauth helper to file ioslave

chinmoyr updated this revision to Diff 18201. chinmoyr added a comment. - fixed minor issues CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6197?vs=18012=18201 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6197 AFFECTED FILES src/ioslaves/file/CMakeLists.txt

Re: Running applications and unittests without "make install"

On martedì 15 agosto 2017 17:17:16 CEST, David Faure wrote: Hi everyone, The documentation for how to do that is now up at https://blogs.kde.org/2017/08/15/running-applications-and-unittests-without-make-install I have ported/fixed all frameworks, except for kirigami, and there are still

D7230: Save up a bunch of stat() calls on application start

asturmlechner accepted this revision. asturmlechner added a comment. Briefly runtime tested it as well with and without translations, no issues. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7230 To: apol, #frameworks, dfaure, asturmlechner Cc:

D7297: Add Pony highlighting

jpoelen updated this revision to Diff 18196. jpoelen added a comment. Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7297: Add Pony highlighting

jpoelen updated this revision to Diff 18194. jpoelen added a comment. Restricted Application added a project: Frameworks. - Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony REPOSITORY R216 Syntax Highlighting

Running applications and unittests without "make install"

Hi everyone, The documentation for how to do that is now up at https://blogs.kde.org/2017/08/15/running-applications-and-unittests-without-make-install I have ported/fixed all frameworks, except for kirigami, and there are still pending merge requests for kpackage. I'm wondering if we could

D7330: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner created this revision. Restricted Application added a project: Frameworks. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D7330 AFFECTED FILES CMakeLists.txt src/file/extractor/CMakeLists.txt To: asturmlechner, #frameworks

github repos

Hi Albert, I just added myself as watcher to the frameworks I maintain: karchive kcrash kdbusaddons kded kinit kio kparts kservice kxmlgui Can you remove the auto-reply on merge requests for these repositories? Thanks. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE

D6234: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys

This revision was automatically updated to reflect the committed changes. Closed by commit R268:2c20ddff034e: KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad… (authored by dfaure). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE

D7239: Drop unused dependency

heikobecker added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D7239 To: heikobecker, #plasma, #frameworks Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7328: Don't enter test subdirectories if BUILD_TESTING=OFF

asturmlechner created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The proposed change to ECMAddTest was reverted because it led to failures with subsequent calls depending on then nonexisting test targets. Instead, just make the test subdirectories

D7230: Save up a bunch of stat() calls on application start

asturmlechner added a comment. Sounds fine. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7230 To: apol, #frameworks, dfaure, asturmlechner Cc: ltoscano, aacid, dfaure, elvisangelaccio, broulik

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH davidedmundson/xdgv6 REVISION DETAIL https://phabricator.kde.org/D7304 To: davidedmundson, #plasma, dfaure Cc: plasma-devel, #frameworks, leezu, ZrenBot, progwolff, lesliezhai,

D7249: Return high-resolution line edit clear icon

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kstyle.cpp:419 > just QIcon::fromTheme(directionalThemeName, "edit-clear") You mean `QIcon::fromTheme(directionalThemeName, QIcon::fromTheme("edit-clear"));`? REPOSITORY R252 Framework Integration REVISION DETAIL

D7326: [File KIO slave] Fix applying special file attributes

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9ac7832b859b: [File KIO slave] Fix applying special file attributes (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7326?vs=18184=18187 REVISION

D7326: [File KIO slave] Fix applying special file attributes

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7326 To: broulik, kde-frameworks-devel, dfaure Cc: #frameworks

D7230: Save up a bunch of stat() calls on application start

dfaure added a comment. A minor "breakage" though, just a menu item that brings a selection of 0 or 1 language, i.e. showing the user that no translation is available. Arguably that's actually better user interface than a missing menu item (A: "click on that menu item!" -- B: "where? you're

D7230: Save up a bunch of stat() calls on application start

asturmlechner added a comment. Thanks for adding me, at least Gentoo indeed supports stripping translations even after they were moved into the packages - so that would break. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D7230 To: apol,

D7326: [File KIO slave] Fix applying special file attributes

broulik created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY QFile does not support special attributes like sticky. This would cause us to always discard them. BUG: 365795 TEST PLAN Comes with

D7318: KFileItemDelegate: Always reserve space for icons

fvogt added a comment. The underlying issue is that KIconLoader's implementation of isNull (in virtual_hook) is not really meaningful. In cases where a name for a nonexistent icon is passed, pixmap will draw the "unknown" icon, but isNull still returns true. So the question is whether

D7249: Return high-resolution line edit clear icon

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kstyle.cpp:419 > + > +QIcon icon = QIcon::fromTheme(directionalThemeName); > + just QIcon::fromTheme(directionalThemeName, "edit-clear")

D7318: KFileItemDelegate: Always reserve space for icons

cfeck added a comment. BUG: 372207 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7318 To: fvogt, #frameworks Cc: cfeck, #frameworks

D7318: KFileItemDelegate: Always reserve space for icons

fvogt added a comment. It would be possible to avoid drawing null QIcons as well, but that would result in broken alignment. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7318 To: fvogt, #frameworks Cc: #frameworks

D7318: KFileItemDelegate: Always reserve space for icons

fvogt created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Even null icons are drawn so also reserve space for them to avoid overlapping. TEST PLAN http://imgur.com/a/fG2T0 REPOSITORY R241 KIO BRANCH iconfix-master REVISION DETAIL

D7249: Return high-resolution line edit clear icon

hpereiradacosta added a comment. +1 from me. Sounds sensible. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D7249 To: broulik, kde-frameworks-devel, hpereiradacosta Cc: hpereiradacosta, #frameworks

Re: Tests leaving behind large temporary files

On Mon, Aug 14, 2017 at 11:40 PM, Bhushan Shah wrote: > Hello Ben, Hi Bhushan, > > On Mon, Aug 14, 2017 at 10:59:49PM +1200, Ben Cooksley wrote: >> Could someone please investigate, determine which test(s) are >> responsible and fix those tests to cleanup after themselves? >>

D7281: KCoreAddons: Enforce hidden symbol visibility in nested private classes

bcooksley added a comment. I'm not sure why that happened - it automatically associated correctly so it should have closed. It does appear that one of the reviews (https://phabricator.kde.org/tag/frameworks/) hasn't approved it yet so that may be the reason why. (Phabricator upstream