cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I am happy beside one thing I missed: I think the file should be called
intelhex.xml, given its for the intel hex format only (the name is already
fine, did miss that the
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
I think this is more correct, just writing the unix libname was no good idea.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7443
To: sars, cullmann,
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt
version and kernel support it" to "Populate UDS_CREATION_TIME on Linux if Qt
and kernel versions support it".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7423
To: ngraham, dfaure, broulik,
ngraham added a comment.
Great, thanks guys. Thanks for bearing with me here. I'll see if I can test
with the unreleased qtbase.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7423
To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano, #frameworks
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt
version and Linux kernel support it (no effect if they don't) BUG: 286689" to
"Populate UDS_CREATION_TIME on Linux if Qt version and kernel support it".
ngraham edited the summary of this revision.
ngraham edited the
dhaumann added a comment.
@cullmann Since you seem to know this, please take care of this change
request :-)
REVISION DETAIL
https://phabricator.kde.org/D7367
To: martonmiklos, #framework_syntax_hightlighting
Cc: dhaumann, cullmann, #frameworks, vkrause
dhaumann added a comment.
@cullmann Is this the right fix, or could this also be fixed in
FindEditorConfig.cmake?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7443
To: sars, cullmann, #kate
Cc: dhaumann, kwrite-devel, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2baf9eb98c4e: Add syntax highlighting for Metamath
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7280?vs=18373=18466
REVISION
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me. Will integrate this soon.
By the way, you may want to apply for a KDE contributor account to commit
your changes yourself, especially since you are providing
dfaure added a comment.
Ah, OK, I see.
Well, still, you could test the patch by compiling qtbase dev (or by applying
whichever Qt patch is necessary).
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7423
To: ngraham, dfaure, broulik, elvisangelaccio
Cc: ltoscano,
ltoscano added a comment.
The title of the revision becomes the first line; all the rest (summary,
test, reviewers) become the rest of the content, a blank separator line is
added automatically. Please add the BUG: line in the summary, not in the title.
Also, as the title becomes the first
ngraham added a comment.
Noted! Thanks, Luigi. I'd like to add BUG: 286689 to the commit message on a
separate line. Does the title of this revision become the commit message? If
so, how do I add another line? The text field doesn't seem to support
multi-line strings.
REPOSITORY
R241 KIO
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if Qt
version and Linux kernel support it (no effect if they don't)" to "Populate
UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect
if they don't) BUG: 286689".
REPOSITORY
R241 KIO
ngraham retitled this revision from "Populate UDS_CREATION_TIME on Linux if QT
version and Linux kernel support it (no effect if they don't)" to "Populate
UDS_CREATION_TIME on Linux if Qt version and Linux kernel support it (no effect
if they don't)".
REPOSITORY
R241 KIO
REVISION DETAIL
ltoscano added a comment.
I can't comment on the content of the patch, but about the commit message, in
order to close a bug, use the syntax:
BUG: nn
while in order to add the commit as comment of a bug without closing it, use
CCBUG: nn
Both keyword should be in a
ngraham added a comment.
This patch doesn't actually directly use statx(); it goes through QFile,
which is used to populate the statbuf object. QT has gained support for using
statx() in Linux where available in current git master
dfaure added a comment.
The commit log is inconsistent with the actual patch. It says "lack of a Qt
version that supports this", but the patch doesn't use QFile at all, it uses
statx. Either way, the patch can be tested, no?
REPOSITORY
R241 KIO
REVISION DETAIL
sars created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
On Windows the library was found during config, but not during compilation
without the variable EditorConfig_LIBRARIES.
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/78/
Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 20 Aug 2017 19:15:23 +
Build duration:
2 min 58 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20XenialQt5.7/80/
Project:
Frameworks syntax-highlighting kf5-qt5 XenialQt5.7
Date of build:
Sun, 20 Aug 2017 19:15:23 +
Build duration:
3 min 11 sec and counting
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This breaks all subsequent SSL connections using QSslSocket or QNAM.
Thiago said about this on #kde-devel: "in the old days, it used to be
because Qt shipped with a very old database, we
rkflx added a comment.
Probably related to
https://phabricator.kde.org/R32:3e530e780b596e9505b66e1ae7b1044d335adb07 (I
guess Phabricator only adds "mentions" for shortlinks like Dxxx, but not full
URLs?).
REVISION DETAIL
https://phabricator.kde.org/D7010
To: brauch, cfeck, rkflx
Cc:
Present: me, chinmoy, shortstheory
Minutes in the attachment.
Cheers,
Elvis2017-08-20 09:01:22 eangMeeting!
2017-08-20 09:01:27 chinmoy[m] yes
2017-08-20 09:02:11 eanglet's start then
2017-08-20 09:03:44 chinmoy[m] Didn't do much this week due to college
:(
23 matches
Mail list logo
