graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in surface_interface.cpp:813
> UniqueConnection with lambda ?
Yeah, I don't think unique will work here. But looking at the code it also
doesn't matter if the lambda is executed multiple times.
REPOSITORY
R127 KWayland
anthonyfieroni added inline comments.
INLINE COMMENTS
> surface_interface.cpp:813
> +setOutputs(outputs);
> +}}, Qt::UniqueConnection);
> }
UniqueConnection with lambda ?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7531
To:
davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
createObjectFromSource can return a null on error. This needs guarding.
REPOSITORY
R242 Plasma Framework
davidedmundson created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
As per existing TODO.
A new signal is added on Global to emit so we can process the result
dfaure updated this revision to Diff 18724.
dfaure added a comment.
- Fix leak introduced by first version of the commit, we need to make a copy
of the idle list before clearing it.
- When deleting the slave because it emits a signal, we still need to use
deleteLater(), I guess...
dfaure created this revision.
REVISION SUMMARY
It's a struct with int+QByteArray so it's bigger than a pointer.
Minor effect on the overall numbers, it was only showing up
in the "allocations of a small size" list in heaptrack, so this is
more about not wasting space more than anything
dfaure created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Slave wasn't really deleted (too late for deleteLater when
the KIO Scheduler global object is being deleted).
But actually deleting led to SlaveKeeper using dangling pointers,
so clear it
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Now that I think about it, leftRef() would be even better...
REPOSITORY
R303 KInit
BRANCH
kdbus-appId
REVISION DETAIL
https://phabricator.kde.org/D7479
To: elvisangelaccio, dfaure,
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7513
To: broulik, kde-frameworks-devel, dfaure, elvisangelaccio
Cc: #frameworks
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7512
To: broulik, kde-frameworks-devel, dfaure, elvisangelaccio
Cc: #frameworks
aacid closed this revision.
REPOSITORY
R317 Kross
REVISION DETAIL
https://phabricator.kde.org/D7523
To: aacid, ltoscano, ilic, aspotashev
Cc: #frameworks
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Almost perfect ;-)
INLINE COMMENTS
> kurlcompletion.cpp:626
> {
> -qCDebug(KIO_WIDGETS) << text << "d->cwd=" << d->cwd;
> +qWarning() << text << "d->cwd=" << d->cwd;
>
mwolff added a comment.
Note that the test passes, but I noticed that the KURLCOMPLETION_LOCAL_KIO
branch is not covered by unit tests. Setting it even shows that the test is
then broken (even without this patch).
Also, creating a new thread for every completion request is not a good
mwolff created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This feature already exists in QFileDialog, but is so far missing
from KCompletion. This in turn makes KUrlRequester's mimetype filter
ilic accepted this revision.
ilic added a comment.
This revision is now accepted and ready to land.
I'd say the patch is fine as it is. If this code is invoked through an
intermediate library, that library's definition of TRANSLATION_DOMAIN will have
no effect, instead kross'
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file_unix.cpp:165
> +int dest_fd = fdRecv.fileDescriptor();
> +if (!dest_file.open(dest_fd, QIODevice::Truncate |
> QIODevice::WriteOnly,
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0f440836c548: KSqueezedTextLabel: Add isSqueezed() for
convenience (authored by rkflx).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7162?vs=17970=18713
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:d8254bc5ee6b: KSqueezedTextLabel: Small improvements to
API docs (authored by rkflx).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7161?vs=17969=18712
dfaure accepted this revision.
This revision is now accepted and ready to land.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
dfaure added inline comments.
INLINE COMMENTS
> klauncher.cpp:326
> {
> #ifdef KLAUNCHER_VERBOSE_OUTPUT
> qCDebug(KLAUNCHER) << pid << "exitStatus=" << exitStatus;
This seems to be mixed with an unrelated change, now.
REPOSITORY
R303 KInit
REVISION DETAIL
dfaure added a comment.
Hint: `arc diff HEAD~`
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7479
To: elvisangelaccio, dfaure, apol
Cc: #frameworks
ltoscano added a comment.
I was wondering: can it happen if this code is set in a library, where the
translation domain is set through TRANSLATION_DOMAIN, would it work?
If I understand the code correctly, i18n is set with the domain is
TRANSLATION_DOMAIN is set. Maybe if the
aacid added reviewers: ltoscano, ilic, aspotashev.
REPOSITORY
R317 Kross
REVISION DETAIL
https://phabricator.kde.org/D7523
To: aacid, ltoscano, ilic, aspotashev
Cc: #frameworks
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R317 Kross
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7523
AFFECTED FILES
src/core/action.cpp
chinmoyr updated this revision to Diff 18702.
chinmoyr added a comment.
- Return an enum (PrivilegeOperationStatus) instead of bool for confirmation
status.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=18018=18702
BRANCH
master
REVISION DETAIL
elvisangelaccio marked 2 inline comments as done.
REPOSITORY
R303 KInit
REVISION DETAIL
https://phabricator.kde.org/D7479
To: elvisangelaccio, dfaure, apol
Cc: #frameworks
elvisangelaccio updated this revision to Diff 18700.
elvisangelaccio added a comment.
- Fixed David's issues.
REPOSITORY
R303 KInit
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7479?vs=18600=18700
BRANCH
kdbus-appId
REVISION DETAIL
https://phabricator.kde.org/D7479
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Oh I see, sorry for the bug in operator bool() in my suggested code. It reads
strange that operator bool() returns true on failure, but yeah it's the
most common use case for this
chinmoyr updated this revision to Diff 18697.
chinmoyr added a comment.
- use the new execWithElevatedPrivilege method
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6831?vs=18016=18697
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6831
AFFECTED FILES
chinmoyr updated this revision to Diff 18695.
chinmoyr added a comment.
- use the new execWithElevatedPrivilege method
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6830?vs=18208=18695
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6830
AFFECTED FILES
chinmoyr updated this revision to Diff 18693.
chinmoyr added a comment.
- Changed back to the old version of PrivilegeOperationReturnValue with
slight modification. See my previous comment.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6829?vs=18508=18693
BRANCH
second
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
Kill 'em all
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7516
To: broulik, #plasma, mart
Cc: mart, plasma-devel, #frameworks, ZrenBot,
This revision was automatically updated to reflect the committed changes.
Closed by commit R303:db633494ef71: Drop KLAUNCHER_VERBOSE_OUTPUT ifdefs
(authored by elvisangelaccio).
REPOSITORY
R303 KInit
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7480?vs=18586=18690
REVISION DETAIL
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It should be different from the DeleteFile icon, otherwise it's not
possible to distinguish them.
TEST PLAN
Open context menu of Dolphin (master) and press Shift.
REPOSITORY
R265
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
It's not being set to anything anymore and people typically don't have 256
color displays these days.
TEST PLAN
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
BUG: 304589
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7513
AFFECTED FILES
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This makes it consistent with the breadcrumbs that also request a new tab
when middle-clicked
CCBUG: 304589
REPOSITORY
R241 KIO
Am 23.08.2017 um 14:15 schrieb Harald Sitter:
> On Tue, Aug 22, 2017 at 10:47 PM, Ralf Habacker
> wrote:
>> Hi,
>>
>> I'm using the following patch to cross build kdoctools for windows
>>
>>
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
I don't get the comment on why it is `/dev/null` instead of `QString()` but
using `SimpleConfig` at least saves 0.3ms
pablooliveira updated this revision to Diff 18664.
pablooliveira added a comment.
- Updated test code with license (MIT licensed); removed some utility
functions that were not written by me.
- Changed highlighter category to "Other"
CHANGES SINCE LAST UPDATE
Hi all,
The following is Sysadmin's suggested plan for the retirement of
Reviewboard now that Phabricator is fully up and running for hosting
of code reviews.
Phase 1: Commences September 2: All repositories are closed for
accepting new reviews on Reviewboard. A notice is added to the top of
the
broulik created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Total folder size in bytes is locale-formatted (ie. with thousand separator)
in slotDirSizeFinished but this was missing during calculation
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/59/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 24 Aug 2017 08:27:54 +
Build duration:
1 min 25 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/92/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 24 Aug 2017 08:26:44 +
Build duration:
1 min 54 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/55/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 24 Aug 2017 08:27:54 +
Build duration:
29 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/8/
Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 24 Aug 2017 08:26:44 +
Build duration:
1 min 27 sec and counting
CONSOLE OUTPUT
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1d480054428d: [KACLEditWidget] Allow double clicking to
edit entry (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7368?vs=18292=18654#toc
REPOSITORY
R241 KIO
CHANGES
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Just two questions:
- The section is "Scripts", is that really a script, or would another
category like "Scientific" or "Other" be more suitable?
- Is the
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/7/
Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 24 Aug 2017 06:22:36 +
Build duration:
50 sec and counting
CONSOLE OUTPUT
bshah added a comment.
In https://phabricator.kde.org/D7462#139193, @sitter wrote:
> You committed `(... && getuid() != reply)` rather than `||`. We'll want a
fork in either scenario, so this should be `||` as suggested by David.
Yeah realized that after commiting it, fixed in
sitter added a comment.
You committed `(... && getuid() != reply)` rather than `||`. We'll want a
fork in either scenario, so this should be `||` as suggested by David.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7462
To: bshah, #frameworks, sitter, dfaure
51 matches
Mail list logo