Am 29.08.2017 um 15:03 schrieb Harald Sitter:
> On Sun, Aug 27, 2017 at 8:37 PM, Luigi Toscano
> wrote:
>> Even without the if branch it would be still complicated.
> Ah! I think I get the complexity now. At build time we need to run our
> tools already and so the
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R263 KXmlGui
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7620
To: elvisangelaccio, #frameworks, davidedmundson, graesslin
nibags updated this revision to Diff 18983.
nibags added a comment.
- Updated AppArmor syntax highlighting file:
1. Updating https://phabricator.kde.org/D7461: Add syntax highlighting for
AppArmor Profiles. #
Updated AppArmor syntax highlighting file.
Hi! Sorry for the delay,
On 25/08/2017 5:41 AM, "Albert Astals Cid" wrote:
El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va
escriure:
> Hi all,
>
> The following is Sysadmin's suggested plan for the retirement of
> Reviewboard now that Phabricator is fully up and running for hosting
>
On Mon, Aug 28, 2017 at 8:20 PM, René J.V. Bertin wrote:
> On Friday August 25 2017 07:33:43 Ben Cooksley wrote:
>
> Hi,
Hi Rene,
>
>>> Note that due to how Reviewboard stores diffs and reproduces them for
>>> use, some reviews may have decayed and may no longer be
On Friday August 25 2017 07:33:43 Ben Cooksley wrote:
Hi,
>> Note that due to how Reviewboard stores diffs and reproduces them for
>> use, some reviews may have decayed and may no longer be readable. This
>> is due to short-hashes which are used by Git/Reviewboard in diffs now
>> having
El dijous, 24 d’agost de 2017, a les 21:07:49 CEST, Ben Cooksley va escriure:
> Hi all,
>
> The following is Sysadmin's suggested plan for the retirement of
> Reviewboard now that Phabricator is fully up and running for hosting
> of code reviews.
>
> Phase 1: Commences September 2: All
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
This fixes the transient parent of KHelpMenu, which is required
to properly position the popup on Wayland.
TEST PLAN
open Help menu from dolphin Control button.
REPOSITORY
R263
ltoscano added a reviewer: davidedmundson.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7620
To: elvisangelaccio, #frameworks, davidedmundson
elvisangelaccio edited the summary of this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D7620
To: elvisangelaccio, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R236:c0b452358397: simplify setContents by letting Qt do more
of the work (authored by sitter).
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129381/
---
(Updated Aug. 30, 2017, 4:08 p.m.)
Status
--
This change has been
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a96330292646: [Icon Item] Don't needlessly unset
imagePath (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7602
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7601
To: broulik, #plasma, mart
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
cfeck accepted this revision.
cfeck added a comment.
Could you please commit this to land in 5.38?
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6767
To: sitter, cfeck, davidedmundson
Cc: davidedmundson, #frameworks
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7584
To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
broulik added inline comments.
INLINE COMMENTS
> davidedmundson wrote in iconitem.cpp:199
> are you saying we'll always hit this one?
If we use plasma theme and have valid icon (line 176 does set image path and
181 checks for validity if plasmatheme).
If we dont have a plasma theme or
davidedmundson added inline comments.
INLINE COMMENTS
> iconitem.cpp:199
> if (!iconPath.isEmpty()) {
> m_svgIcon->setImagePath(iconPath);
> m_svgIconName = sourceString;
are you saying we'll always hit this one?
REPOSITORY
R242
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D7614
To: broulik, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
QPixmap::alphaChannel() is deprecated.
TEST PLAN
Corners of popups still nicely rounded (tested with Oxygen which has
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dc7e367ecfe0: Treat input RGB buffers as premultiplied
(authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7460?vs=18530=18950
REVISION
dfaure added a comment.
Patch for more docu: https://phabricator.kde.org/D7612
BTW CMAKE_LIBRARY_OUTPUT_DIRECTORY is not undocumented, it's part of the
cmake documentation:
Where to put all the :ref:`LIBRARY `
target files when built.
This variable is used to
dfaure created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Build System.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7612
AFFECTED FILES
24 matches
Mail list logo