ngraham added reviewers: VDG, jensreuterberg.
REPOSITORY
R266 Breeze Icons
REVISION DETAIL
https://phabricator.kde.org/D7810
To: mandian, #breeze, #vdg, jensreuterberg
Cc: #frameworks
mgallien added a comment.
I forgot to say that I do not mind modifying the patch. I am just hoping to
make steady progress on it since I am having crash very often with my music
player.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien,
mgallien added a reviewer: dfaure.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni
mgallien added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in extractor.cpp:34
> d *should* never be nullptr
If the Extractor is built using the move constructor, the other instance will
have a null d pointer. As far as I know, this is standard practice.
REPOSITORY
R286
anthonyfieroni added a subscriber: dfaure.
anthonyfieroni added a comment.
Add @dfaure to accept it.
INLINE COMMENTS
> extractor.cpp:34
> {
> -delete d->m_plugin;
> +if (d) {
> +if (d->m_pluginLoader.isLoaded()) {
d *should* never be nullptr
REPOSITORY
R286 KFileMetaData
mgallien added a comment.
Should I push the fix in its current version ?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien, #frameworks
Cc: anthonyfieroni
mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.
it would probably be a good idea to rewrite
`KConfigGroupPrivate::serializeList` to not take a `QVariantList`, but rather
to use a streaming API. I.e. instead of:
void
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/115/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 19 Sep 2017 14:42:53 +
Build duration:
31 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/111/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 19 Sep 2017 14:42:53 +
Build duration:
10 min and counting
JUnit
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D7879
To: broulik, kde-frameworks-devel, dfaure, davidedmundson
Cc: #frameworks
broulik created this revision.
broulik added reviewers: kde-frameworks-devel, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Using initializer_lists for QList we reserve the right amount of memory in
advance
This revision was automatically updated to reflect the committed changes.
davidedmundson marked an inline comment as done.
Closed by commit R127:eaac3948f149: Dont crash if a client (legally) uses
a deleted global (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/114/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 19 Sep 2017 12:51:36 +
Build duration:
17 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/43/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 19 Sep 2017 12:50:41 +
Build duration:
6 min 42 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/110/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 19 Sep 2017 12:51:36 +
Build duration:
5 min 22 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:ee2b12be0456: Add extra visual indicator for
Checkbox/Radio keyboard focus (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/109/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 19 Sep 2017 11:59:43 +
Build duration:
15 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/113/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 19 Sep 2017 11:59:43 +
Build duration:
9 min 51 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:31361267d419: KFileItemDelegate: Always reserve space for
icons (authored by fvogt).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7318?vs=18165=19665
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/106/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Tue, 19 Sep 2017 11:42:17 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R313 KHtml
BRANCH
debug-no-endl
REVISION DETAIL
https://phabricator.kde.org/D7875
To: ltoscano, apol
Cc: #frameworks
21 matches
Mail list logo