ngraham added a comment.
I'll just leave this here: ;-) https://bugs.kde.org/show_bug.cgi?id=290747
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7929
To: fvogt, #frameworks
Cc: ngraham, elvisangelaccio, lbeltrame, #frameworks
fvogt added a comment.
In https://phabricator.kde.org/D7929#147742, @elvisangelaccio wrote:
> I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not
possible to contribute the changes upstream?
It's not that easy - QColumnView is practically abandoned upstream (wit
elvisangelaccio added a comment.
I'm not sure if it's a good idea to fork QColumnView in KIO. Is it not
possible to contribute the changes upstream?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7929
To: fvogt, #frameworks
Cc: elvisangelaccio, lbeltrame, #frameworks
lbeltrame added a comment.
A screenshot before/after (or just after, since it is an addition) would be
helpful in this case, since it is a visual change.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D7929
To: fvogt, #frameworks
Cc: lbeltrame, #frameworks
elvisangelaccio accepted this revision as: elvisangelaccio.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D7855
To: nicolasfella, #frameworks, elvisangelaccio
Cc: #frameworks
fvogt created this revision.
fvogt added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It uses an imported and improved version of QColumnView for display.
KFileItemDelegate got amended with an arrow if used inside KColumnView,
to replace the ba
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
fix_crash_pendingfilequeue
REVISION DETAIL
https://phabricator.kde.org/D7926
To: chehrlic, broulik
Cc: #frameworks
chehrlic created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
With
https://phabricator.kde.org/R293:a75db7aedfcd356b027774e0dc156c334d4cb869 I
introduced a crash when removing a watched
directory. T
chinmoyr updated this revision to Diff 19758.
chinmoyr added a comment.
Added license header
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=19757&id=19758
BRANCH
sharefd
REVISION DETAIL
https://phabricator.kde.org/D6709
AFFECTED FILES
src/ioslaves/file/CMakeLists.txt
vkrause accepted this revision.
vkrause added a comment.
This revision is now accepted and ready to land.
good idea :)
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7915
To: dhaumann, #framework_syntax_highlighting, cullmann, vkrause
Cc: vkrause, #frame
chinmoyr updated this revision to Diff 19757.
chinmoyr marked an inline comment as done.
chinmoyr added a comment.
- separated FdReceiver and FdSender
- KMSgHdr -> FDMessageHeader and KSockaddrUn -> SocketAddress and moved them
to private header
- removed `stopListening()` method. Qt can h
nicolasfella added a comment.
This is a workaround for issues which will be more visible when
https://phabricator.kde.org/D7700 gets merged
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D7855
To: nicolasfella, #frameworks
Cc: #frameworks
dhaumann added a comment.
Maybe worth to note: This patch only detects usage of non-existing contexts.
However, this patch does NOT catch unused contexts (which might be
interesting as well).
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7915
To: dha
dhaumann created this revision.
dhaumann added reviewers: Framework: Syntax Highlighting, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch extends the highlighting indexer by collecting a list of all
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/46/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 21 Sep 2017 13:11:57 +
Build duration:
10 min and counting
JUnit Tests
Nam
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:2b3f9509ac12: Only send OutputConfig sendApplied /
sendFailed to the right resource (authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D78
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/83/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Thu, 21 Sep 2017 13:04:33 +
Build duration:
4 min 33 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/79/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 21 Sep 2017 13:04:33 +
Build duration:
1 min 5 sec and counting
JUnit Tests
sebas added a comment.
FWIW, I tested it, it fixes kwin crashing when adding a setApplied() call on
the OutputConfiguration, and it also means the applied signal arrives.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7898
To: davidedmundson, #pla
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/116/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 21 Sep 2017 12:34:05 +
Build duration:
10 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/112/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Thu, 21 Sep 2017 12:34:05 +
Build duration:
5 min 37 sec and counting
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Yes, the initial idea was to send applied() to all connected resources. That
is not s_allResources, so your patch is correct. The resources that are
actually bound are not currently tracked.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/45/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 21 Sep 2017 11:52:51 +
Build duration:
6 min 42 sec and counting
JUnit Tests
faguilar edited the test plan for this revision.
faguilar added a reviewer: Framework: Syntax Highlighting.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7909
To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting
Cc: #frameworks, faguilar, cullman
faguilar updated this revision to Diff 19732.
faguilar added a comment.
Add Crystal input for autotests
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7909?vs=19730&id=19732
REVISION DETAIL
https://phabricator.kde.org/D7909
AFFECTED FILES
faguilar added a comment.
I'm user of Manjaro KDE and I love coding using Kate. Currently I'm focused
in Crystal learning using Ruby syntax, however Ruby syntax doesn't support all
Crystal features.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D7909
T
faguilar created this revision.
faguilar added reviewers: dhaumann, vkrause.
faguilar added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This add syntax support the Crystal P
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:fb15e56857ca: [KConfigGroup] reserve() more and add some
C++11 (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7879?vs=19671&id=19727#toc
REPOSITORY
R237 KConfig
CHANG
mwolff accepted this revision.
mwolff added a comment.
ah ok, and since we don't have a proper byte array view yet, there's nothing
you can do (which is sad here!)
the other comments from me where suggestions for further improvements, they
don't need to hold up this patch
REPOSITORY
R
29 matches
Mail list logo
