KDE CI: Frameworks kconfig kf5-qt5 WindowsMSVCQt5.9 - Build # 8 - Still unstable!

2017-09-23 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20WindowsMSVCQt5.9/8/ Project: Frameworks kconfig kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 24 Sep 2017 04:50:49 + Build duration: 1 hr 24 min and counting JUnit Tests

D7954: Fix repaint loop in KToolBar

2017-09-23 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, let's get the quick fix in, but I still think my alternative patch (removing all this code and applying http://www.davidfaure.fr/2017/0001-KAcceleratorManager-set-icon-text-on-actions-t

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 117 - Still Unstable!

2017-09-23 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/117/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 23 Sep 2017 17:28:35 + Build duration: 20 min and counting JUni

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 113 - Still Unstable!

2017-09-23 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/113/ Project: Frameworks plasma-framework kf5-qt5 XenialQt5.7 Date of build: Sat, 23 Sep 2017 17:28:35 + Build duration: 14 min and counting JUnit

D7954: Fix repaint loop in KToolBar

2017-09-23 Thread Jean-Baptiste Mardelle
mardelle created this revision. mardelle added reviewers: Frameworks, ilic, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Patch is based on https://git.reviewboard.kde.org/r/128421/ This issue - endless repaint loop when a QToolButton is embedded in a KToolBar -

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 30 - Unstable!

2017-09-23 Thread no-reply
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/30/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 23 Sep 2017 13:59:11 + Build duration: 3 min 45 sec and counting JUnit Tests Name:

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7948 To: ngraham, #frameworks, nicolasfella, dfaure, kossebau, vhanda Cc: #frameworks

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 19829. ngraham added a comment. Grouping the startsWith() and contains() entries REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7948?vs=19827&id=19829 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7948

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham added a comment. Ah, excellent idea. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D7948 To: ngraham, #frameworks, nicolasfella, dfaure, kossebau, vhanda Cc: #frameworks

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yes (although I would then swap document to be after text/, to have all the "groups" together, and then the "substring searches"). In any case feel free to push. REPOSITORY R293 Baloo

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-23 Thread Nathaniel Graham
ngraham abandoned this revision. ngraham added a comment. Fair enough. Your points are stronger than mine, now that I think about it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7944 To: ngraham, #kde_applications, #frameworks, broulik, dfaure Cc: elvisangelaccio, #f

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread Nathaniel Graham
ngraham updated this revision to Diff 19827. ngraham added a comment. Use startsWith() instead of contains() for greater speed and correctness, and do this for text MIME types as well REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7948?vs=19816&id=19827 BRA

D7951: ContextChecker: support '!' context switchting and fallthroughContext

2017-09-23 Thread Dominik Haumann
dhaumann created this revision. dhaumann added reviewers: cullmann, vkrause. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Extend the highlighting index checker to support contexts of the form "#pop!otherContext". Ad

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 29 - Fixed!

2017-09-23 Thread no-reply
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/29/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 23 Sep 2017 12:28:47 + Build duration: 12 min and counting JUnit Tests Name: (root)

D7926: Remove pf.path() from container before the reference got screwed up by it.remove()

2017-09-23 Thread Christian Ehrlicher
chehrlic closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7926 To: chehrlic, broulik Cc: #frameworks

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-23 Thread Mark Gaiser
markg added a comment. In https://phabricator.kde.org/D7446#148135, @ngraham wrote: > It seems odd to have all of these special KIO URLs that we don't actually want to use because they're rough and underdeveloped. They're rough and underdeveloped because they're hidden by default, so nob

D7915: Highlighting indexer: check existence of referenced context names

2017-09-23 Thread Dominik Haumann
dhaumann closed this revision. dhaumann added a comment. Closed with https://commits.kde.org/syntax-highlighting/c62be1a9cbf501c7fd6ed1f6ad02ebd461ccb8c6 REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7915 To: dhaumann, #framework_syntax_highlighting, c

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

2017-09-23 Thread gregormi
gregormi added a comment. In https://phabricator.kde.org/D7446#148135, @ngraham wrote: > That said, the advantage to adding this as a Places item is that it shows up in file open/save dialogs for free, which is where it's most useful. This would support the use case presented here

D7944: Pre-select navigation bar URL when clicking on it to enter edit mode

2017-09-23 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D7944#148134, @ngraham wrote: > You're right that this improves one workflow and impairs another, but the way I see it, the patch simply brings consistency with the behavior you get if you hit ctrl-L/Replace Location.

D7948: Only match real MIME types, not e.g. "raw CD image"

2017-09-23 Thread David Faure
dfaure added a comment. Yes, but then startsWith() would be even more correct (and slightly faster) than contains(). And application/vnd.oasis.opendocument.text isn't plain text, so contains("text") should also be changed to startsWith("text/"). REPOSITORY R293 Baloo REVISION DETAIL