D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-10-02 Thread Matthieu Gallien
This revision was automatically updated to reflect the committed changes. Closed by commit R286:b53a72743601: fix crash when more than one instances of ExtractorCollection are destructed (authored by mgallien). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D7369: Wayland foreign protocol

2017-10-02 Thread Marco Martin
mart updated this revision to Diff 20257. mart added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. - move to xdg-foreign-unstable-v2 - get rid of setTransientFor REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 32 - Still Unstable!

2017-10-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/32/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Mon, 02 Oct 2017 14:46:29 + Build duration: 8 min 26 sec and counting JUnit

D8105: Find test helper

2017-10-02 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R278:e47c2285860c: Find test helper (authored by davidedmundson). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8105?vs=20235=20253 REVISION DETAIL

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 31 - Fixed!

2017-10-02 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/31/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 02 Oct 2017 14:46:29 + Build duration: 1 min 49 sec and counting JUnit

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8111?vs=20248=20251

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. Kirigami 1.0 isn't supported anyway, so it's indeed needed. Maybe it would be nice to have some tests on this code to make sure everything keeps working. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8111

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8111 To: leinir, #knewstuff, mart Cc: bshah, #frameworks, ZrenBot

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Bhushan Shah
bshah added a comment. +1, looks good to me. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8111 To: leinir, #knewstuff Cc: bshah, #frameworks, ZrenBot

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a reviewer: KNewStuff. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This reduces the amount of things which require the by now quite out

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7 - Build # 30 - Still Unstable!

2017-10-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.7/30/ Project: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 02 Oct 2017 13:16:14 + Build duration: 15 min and counting JUnit Tests

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!

2017-10-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/28/ Project: Frameworks kiconthemes kf5-qt5 XenialQt5.7 Date of build: Mon, 02 Oct 2017 13:16:14 + Build duration: 1 min 32 sec and counting JUnit

D8105: Find test helper

2017-10-02 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8105 To: davidedmundson, bshah Cc: #frameworks

D8107: Find test helper

2017-10-02 Thread Bhushan Shah
bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH master REVISION DETAIL https://phabricator.kde.org/D8107 To: davidedmundson, bshah Cc: #frameworks

D8107: Find test helper

2017-10-02 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since some ECM change, all binaries end up in $builddir/bin This doesn't keep relative paths, so we need to adjust a test to find

D5069: KWindowSystem: initial implementation of a platform plugin for OS X

2017-10-02 Thread René J . V . Bertin
rjvbb set the repository for this revision to R278 KWindowSystem. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D5069 To: rjvbb, #frameworks Cc: kde-mac, #frameworks

D5069: KWindowSystem: initial implementation of a platform plugin for OS X

2017-10-02 Thread René J . V . Bertin
rjvbb updated this revision to Diff 20237. rjvbb added a comment. Refactored patch (includes the Q_DECL_HIDDEN mods added elsewhere recently). If there are no further objections other than about the EXPERIMENTAL stuff I'll push this somewhere this week (without the experimental bits).

D8105: Find test helper

2017-10-02 Thread David Edmundson
davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Since some ECM change, all binaries end up in $builddir/bin This doesn't keep relative paths, so we need to adjust a test to find

D8060: allow to set a custom palette instead of colorSets

2017-10-02 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R302:0fd3ee28cedd: allow to set a custom palette instead of colorSets (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8060?vs=20107=20234#toc REPOSITORY R302 KIconThemes

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-10-02 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 20232. chinmoyr added a comment. Changed isValid() -> isListening() in FdReceiver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6709?vs=19758=20232 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6709 AFFECTED FILES

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 27 - Still Unstable!

2017-10-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/27/ Project: Frameworks kiconthemes kf5-qt5 XenialQt5.7 Date of build: Mon, 02 Oct 2017 10:45:30 + Build duration: 1 min 53 sec and counting JUnit

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7 - Build # 29 - Still Unstable!

2017-10-02 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.7/29/ Project: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 02 Oct 2017 10:45:30 + Build duration: 1 min 9 sec and counting JUnit

D8060: allow to set a custom palette instead of colorSets

2017-10-02 Thread Marco Martin
mart marked 2 inline comments as done. REPOSITORY R302 KIconThemes BRANCH custompalette REVISION DETAIL https://phabricator.kde.org/D8060 To: mart, dfaure, #frameworks, rikmills, davidedmundson Cc: davidedmundson, broulik, cfeck, #frameworks

D8060: allow to set a custom palette instead of colorSets

2017-10-02 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. 1 bug needs fixing. INLINE COMMENTS > kiconloader.cpp:142 > > -uintToHex(pal.text().color().rgba(), buffer.data()); > +uintToHex(pal.windowText().color().rgba(),

D8058: don't redefine output dirs on android

2017-10-02 Thread Marco Martin
mart added a comment. In https://phabricator.kde.org/D8058#150551, @apol wrote: > Before disabling it altogether on Android, I'd prefer to look into why it's not working. Give me a week, please? sure :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D8060: allow to set a custom palette instead of colorSets

2017-10-02 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > broulik wrote in kiconloader.cpp:869 > You don't seem to be following `qApp->palette()` anymore if no custom one is > set? it uses an empty QPalette(), which accordning to the docs, it should fall back to the application's palette REPOSITORY

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-02 Thread Simone Gaiarin
simgunz added a comment. > I see what you mean. How about implementing "down-arrow-changes-focus" only when not using dropdown completion? Seems ok. I'll implement it this way soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure,