This revision was automatically updated to reflect the committed changes.
Closed by commit R286:b53a72743601: fix crash when more than one instances of
ExtractorCollection are destructed (authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
mart updated this revision to Diff 20257.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- move to xdg-foreign-unstable-v2
- get rid of setTransientFor
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/32/
Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
Date of build:
Mon, 02 Oct 2017 14:46:29 +
Build duration:
8 min 26 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:e47c2285860c: Find test helper (authored by
davidedmundson).
REPOSITORY
R278 KWindowSystem
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8105?vs=20235=20253
REVISION DETAIL
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/31/
Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 02 Oct 2017 14:46:29 +
Build duration:
1 min 49 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for
KNewStuffQuick (authored by leinir).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8111?vs=20248=20251
apol accepted this revision.
apol added a comment.
Kirigami 1.0 isn't supported anyway, so it's indeed needed.
Maybe it would be nice to have some tests on this code to make sure
everything keeps working.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D8111
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D8111
To: leinir, #knewstuff, mart
Cc: bshah, #frameworks, ZrenBot
bshah added a comment.
+1, looks good to me.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D8111
To: leinir, #knewstuff
Cc: bshah, #frameworks, ZrenBot
leinir created this revision.
leinir added a reviewer: KNewStuff.
leinir added a project: KNewStuff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This reduces the amount of things which require the by now quite out
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.7/30/
Project:
Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 02 Oct 2017 13:16:14 +
Build duration:
15 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/28/
Project:
Frameworks kiconthemes kf5-qt5 XenialQt5.7
Date of build:
Mon, 02 Oct 2017 13:16:14 +
Build duration:
1 min 32 sec and counting
JUnit
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8105
To: davidedmundson, bshah
Cc: #frameworks
bshah accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8107
To: davidedmundson, bshah
Cc: #frameworks
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Since some ECM change, all binaries end up in $builddir/bin
This doesn't keep relative paths, so we need to adjust a test to find
rjvbb set the repository for this revision to R278 KWindowSystem.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D5069
To: rjvbb, #frameworks
Cc: kde-mac, #frameworks
rjvbb updated this revision to Diff 20237.
rjvbb added a comment.
Refactored patch (includes the Q_DECL_HIDDEN mods added elsewhere recently).
If there are no further objections other than about the EXPERIMENTAL stuff
I'll push this somewhere this week (without the experimental bits).
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Since some ECM change, all binaries end up in $builddir/bin
This doesn't keep relative paths, so we need to adjust a test to find
This revision was automatically updated to reflect the committed changes.
Closed by commit R302:0fd3ee28cedd: allow to set a custom palette instead of
colorSets (authored by mart).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8060?vs=20107=20234#toc
REPOSITORY
R302 KIconThemes
chinmoyr updated this revision to Diff 20232.
chinmoyr added a comment.
Changed isValid() -> isListening() in FdReceiver
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6709?vs=19758=20232
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6709
AFFECTED FILES
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/27/
Project:
Frameworks kiconthemes kf5-qt5 XenialQt5.7
Date of build:
Mon, 02 Oct 2017 10:45:30 +
Build duration:
1 min 53 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.7/29/
Project:
Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 02 Oct 2017 10:45:30 +
Build duration:
1 min 9 sec and counting
JUnit
mart marked 2 inline comments as done.
REPOSITORY
R302 KIconThemes
BRANCH
custompalette
REVISION DETAIL
https://phabricator.kde.org/D8060
To: mart, dfaure, #frameworks, rikmills, davidedmundson
Cc: davidedmundson, broulik, cfeck, #frameworks
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
1 bug needs fixing.
INLINE COMMENTS
> kiconloader.cpp:142
>
> -uintToHex(pal.text().color().rgba(), buffer.data());
> +uintToHex(pal.windowText().color().rgba(),
mart added a comment.
In https://phabricator.kde.org/D8058#150551, @apol wrote:
> Before disabling it altogether on Android, I'd prefer to look into why it's
not working. Give me a week, please?
sure :)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> broulik wrote in kiconloader.cpp:869
> You don't seem to be following `qApp->palette()` anymore if no custom one is
> set?
it uses an empty QPalette(), which accordning to the docs, it should fall back
to the application's palette
REPOSITORY
simgunz added a comment.
> I see what you mean. How about implementing "down-arrow-changes-focus" only
when not using dropdown completion?
Seems ok. I'll implement it this way soon.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8056
To: simgunz, dfaure,
27 matches
Mail list logo