dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Yes, sorry, I thought I already accepted. Please commit.
REPOSITORY
R39 KTextEditor
BRANCH
defaultmarker
REVISION DETAIL
https://phabricator.kde.org/D7167
To: croick,
martinkostolny added a comment.
I've tested meta+shift+arrow, alt+shift+arrow, meta+shift+PrtSc and they are
working for me, thanks! So far I didn't notice any regressions. I'll keep this
version around and will report problem if I see one.
Unfortunately I'm unable to properly review the
davidedmundson added a comment.
If it does go into wayland-protocols I imagine it would get renamed?
And even if it did get upstreamed and adopted, Steam (for example) would want
to set the palette.
INLINE COMMENTS
> graesslin wrote in server_decoration_interface.h:147
> Nothing better
ngraham planned changes to this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8021
To: ngraham, #frameworks, elvisangelaccio, broulik, dfaure
Cc: rkflx, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/80/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 06 Oct 2017 21:10:31 +
Build duration:
29 min and counting
JUnit Tests
croick added a comment.
Should I commit?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7167
To: croick, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:06ab983c7a3d: Minor spell check interface fixes (authored
by croick).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8154?vs=20381=20407
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/108/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 06 Oct 2017 18:57:35 +
Build duration:
2 min 0 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/114/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 06 Oct 2017 18:57:35 +
Build duration:
1 min 29 sec and counting
JUnit Tests
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Lgtm.
REPOSITORY
R39 KTextEditor
BRANCH
spellfixes
REVISION DETAIL
https://phabricator.kde.org/D8154
To: croick, #ktexteditor, dhaumann
Cc: dhaumann, #frameworks, cullmann,
graesslin added inline comments.
INLINE COMMENTS
> broulik wrote in server_decoration_interface.h:147
> I think we support both (doing a KService lookup if no complete path given),
> imho "name" would also be consistent with what KConfig uses
Nothing better than looking into the source:
broulik added inline comments.
INLINE COMMENTS
> graesslin wrote in server_decoration_interface.h:147
> is it a paletteName or palettePath? IIRC we set complete paths?
I think we support both (doing a KService lookup if no complete path given),
imho "name" would also be consistent with what
graesslin added a comment.
I'm fine with the change, but when I thought about it, I was wondering
whether it would be better to have a dedicated interface. There is at least one
other Wayland compositor out there which implements the protocol and I got
several requests about upstreaming it.
ltoscano added a comment.
Last chance before 5.39 :)
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D6665
To: dvratil, #frameworks, dfaure
Cc: aacid, arojas, fvogt, ltoscano, rdieter, #frameworks
davidedmundson added a comment.
In https://phabricator.kde.org/D8159#152648, @broulik wrote:
> > This is getting deprecated
>
> yay...
>
> global menu also uses it
That's next.
Will make a new protocol for that, it doesn't fit here.
REPOSITORY
R127 KWayland
REVISION
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20XenialQt5.7/12/
Project:
Frameworks qqc2-desktop-style kf5-qt5 XenialQt5.7
Date of build:
Fri, 06 Oct 2017 12:06:05 +
Build duration:
47 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.9/12/
Project:
Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 06 Oct 2017 12:06:05 +
Build duration:
29 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.7/12/
Project:
Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 06 Oct 2017 12:06:05 +
Build duration:
19 sec and counting
broulik added a comment.
> This is getting deprecated
yay...
global menu also uses it
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8159
To: davidedmundson, #plasma
Cc: broulik, plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/113/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Fri, 06 Oct 2017 11:59:45 +
Build duration:
1 min 4 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/107/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 06 Oct 2017 11:59:45 +
Build duration:
57 sec and counting
JUnit Tests
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This is currently handled by the QtExtended surface which is
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/29/
Project:
Frameworks kiconthemes kf5-qt5 XenialQt5.7
Date of build:
Fri, 06 Oct 2017 10:57:33 +
Build duration:
2 min 4 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.7/31/
Project:
Frameworks kiconthemes kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 06 Oct 2017 10:57:33 +
Build duration:
1 min 22 sec and counting
JUnit
mart added a comment.
In https://phabricator.kde.org/D8060#152619, @mardelle wrote:
> KIconLoader::global()->setCustomPalette(plt);
>
> To make icon color theming work in existing apps that allow color theme
switch.
> Regression can be easily tested with KDevelop or Kdenlive
mardelle added a comment.
Just to let you know, these last 2 commits to KIconThemes break the icon
coloring in existing apps like Kdenlive and KDevelop.
Previously, in a KXmlGuiWindow, doing:
QPalette plt = KColorScheme::createApplicationPalette(config);
setPalette(plt);
croick added a comment.
In https://phabricator.kde.org/D8154#152602, @dhaumann wrote:
> Looks already quite good. Btw, are there any bug reports in the Kate or
frameworks-ktexteditor product on bugs.kde.org that you fix here?
I didn't find one. I just discovered these yesterday
27 matches
Mail list logo
