dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Now is the right time ;)
REPOSITORY
R239 KDELibs4Support
REVISION DETAIL
https://phabricator.kde.org/D6665
To: dvratil, #frameworks, dfaure
Cc: aacid, arojas, fvogt, ltoscano, rdieter,
On samedi 9 septembre 2017 14:15:53 CEST no-re...@kde.org wrote:
> URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20
> FreeBSDQt5.7/54/ Project: Frameworks extra-cmake-modules kf5-qt5
> FreeBSDQt5.7
> Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 tes
dfaure added a comment.
Looks like the CI issue is gone?
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/
looks green to me (well, blue, the jenkins people got daltonism issues lately).
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kd
rkflx added a comment.
In https://phabricator.kde.org/D7164#156062, @dfaure wrote:
> Looks like the CI issue is gone?
Thanks for caring, David. Maybe I could have made this more clear, but work
regarding the CI failure is tracked in https://phabricator.kde.org/T6982, were
I solve
On Monday, 16 October 2017 07:10:29 CEST Luca Beltrame wrote:
> Il giorno Sun, 08 Oct 2017 19:45:00 +0200
>
> Kevin Funk ha scritto:
> > Heya,
> >
> > The KDevelop team is currently discussing a patch which adds
> >
> > git-describe like information to the version string in KAboutData:
> > ht
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:dea8a1ed5f2f: [FrameSvg] Optimize updateSizes (authored
by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8135?vs=20332&id=20851
REVIS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/125/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Mon, 16 Oct 2017 09:39:12 +
Build duration:
8 min 0 sec and counting
J
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/129/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 16 Oct 2017 09:39:12 +
Build duration:
18 min and counting
JUni
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20AndroidQt5.9/2/
Project:
Frameworks kcodecs kf5-qt5 AndroidQt5.9
Date of build:
Mon, 16 Oct 2017 11:27:17 +
Build duration:
1 min 9 sec and counting
CONSOLE OUTPUT
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/23/
Project:
Frameworks kemoticons kf5-qt5 XenialQt5.7
Date of build:
Mon, 16 Oct 2017 11:30:22 +
Build duration:
2 min 23 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.7/30/
Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 16 Oct 2017 11:28:02 +
Build duration:
5 min 16 sec and counting
JUnit T
davidk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This is useful if the extractor runs sandboxed, and read-write file access is
denied.
TagLib would retry it readonly, but this saves one sy
As promised, here is an interim update on the investigation into the
use of cppyy-based bindings for KF5 (and more...) instead of SIP-based
bindings.
The first thing is that the underlying technology of cppyy,
cling/ROOT, has been under development at CERN for quite a while. It
directly reads regu
mgallien added a reviewer: Frameworks.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks
Cc: ngraham, #frameworks
mgallien added a comment.
Thanks, I tested it and it works.
I am not sure about the qWarning.
I would prefer another opinion on that.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks
Cc: mgallien, ngraham, #frameworks
renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Added baloo dependency for filewidgets project
Added new sections for places model: 'Recently Saved' and 'Search for'
Based on dolphin
renatoo planned changes to this revision.
renatoo added a comment.
Remove baloon dependency using KConfig API to query if it is enable, and
hard-code search url with a fixed string.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo
Cc: #frameworks
gregormi added a comment.
Thanks for committing, Nate.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: mak, ngraham, ltoscano, #frameworks
brauch created this revision.
brauch added reviewers: KTextEditor, cullmann, dhaumann.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
If triggerCharacters was not set, toString() would return "undefined",
making
ngraham added a comment.
My pleasure. It's always nice to get bugs fixed. :)
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: mak, ngraham, ltoscano, #frameworks
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: mgallien.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Use a shorter sentence (since space is limited) with Title Capitalization
(since we are
anthonyfieroni added inline comments.
INLINE COMMENTS
> kateindentscript.cpp:47
>
> m_triggerCharactersSet = true;
>
But if triggerCharacters are undefined this variable should be false, no?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8333
To: brauch,
brauch marked an inline comment as done.
brauch added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kateindentscript.cpp:47
> But if triggerCharacters are undefined this variable should be false, no?
No, that's still fine, this variable just caches reading the value from the
script
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8334
To: elvisangelaccio, mgallien
Cc: #frameworks
elvisangelaccio created this revision.
elvisangelaccio added reviewers: kossebau, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
As discussed in https://phabricator.kde.org/D3977, document when
unregisterJob()
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:16751d8e232d: Fix display name of Generator property
(authored by elvisangelaccio).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8334?vs=20865&id=20871
REV
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
That makes a lot of sense. Please commit. Does that fix the indentation
problems reported about Python?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8333
renatoo edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo
Cc: ngraham, #frameworks
renatoo updated this revision to Diff 20873.
renatoo added a comment.
Removed baloo dependency
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20859&id=20873
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
autotests/kfileplacesmode
apol added inline comments.
INLINE COMMENTS
> kjobtrackerinterface.h:73
> * Unregister a job from this tracker.
> + * You need to manually call this method only if you re-implemented
> + * registerJob() without connecting KJob::finished to this slot.
Then it should be protected?
R
brauch marked 2 inline comments as done.
brauch added a comment.
Yes, at least the ones I'm aware of. Thanks for the review, I'll push it in a
moment.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D8333
To: brauch, #ktexteditor, cullmann, dhaumann
Cc: anthonyfie
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:aeebeadb5f59: fix some indenters from indenting on random
characters (authored by brauch).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8333?vs=20861&id=20874
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/84/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 16 Oct 2017 19:35:40 +
Build duration:
8 min 15 sec and counting
JUnit Tes
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Thanks for the fix!
Just one thing: could we in addition have an addition indentation test that
uses the trigger chars? Its amazing we seem to have none for this as otherwise
this pro
ngraham added reviewers: Frameworks, Dolphin, KDE Applications.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications
Cc: ngraham, #frameworks
renatoo updated this revision to Diff 20879.
renatoo added a comment.
Does not load baloo urls if file index is disabled
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=20873&id=20879
REVISION DETAIL
https://phabricator.kde.org/D8332
AFFECTED FILES
cfeck added a comment.
This probably also fixes bug 384682. Can someone confirm?
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: cfeck, mak, ngraham, ltoscano, #frameworks
ngraham added a comment.
I can confirm that this fixes https://bugs.kde.org/show_bug.cgi?id=384682.
Updating that accordingly.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/126/
Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
Date of build:
Tue, 17 Oct 2017 03:06:41 +
Build duration:
11 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/130/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 17 Oct 2017 03:06:41 +
Build duration:
14 min and counting
JUni
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/24/
Project:
Frameworks kemoticons kf5-qt5 XenialQt5.7
Date of build:
Tue, 17 Oct 2017 05:53:41 +
Build duration:
4 min 45 sec and counting
JUnit Tests
41 matches
Mail list logo