D8098: Strip down and re-write the tags KIO slave.

smithjd marked 14 inline comments as done. smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:64 > - merge with previous line > > - can path() really contain '?' ? I thought that wasn't possible (? delimits > the query). Yes, the url is non-hierarchical scheme, so

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21851. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. - Create a full url instead of only a path. - Check if the destination file already has the

D8643: Fix display of remote:/ in the qfiledialog

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D8643 To: apol, #frameworks, davidedmundson

D5805: include directory should contains all directory from pkg-config

xuetianweng abandoned this revision. xuetianweng added a comment. Just noticed that FindPkgConfig has import_module now.. Personally I just port my code to use that. Anyone who more familiar with test cmake script may take over this. REPOSITORY R240 Extra CMake Modules REVISION

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi, On Friday 2017-11-03 12:52, Philipp A. wrote: Am I missing something? Namespaces should be Python modules, not classes. If we can do represent them this way, the problem is solveable: https://packaging.python.org/guides/packaging-namespace-packages/ there are two different things that

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi Shaheed, Shaheed Haque schrieb am Fr., 3. Nov. 2017 um 14:16 Uhr: > Philipp, > > - my overall understanding of this technique is that it may end up > being fragile, especially given the difference between P2 and P3. > Python 2? I’m sure we shouldn’t include into our

D8643: Fix display of remote:/ in the qfiledialog

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY remote: is designed to redirect every entry so it has an entry that initially is defined as "remote:/network" then it changes to "network:/" through setUrl

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi Philipp, On 3 November 2017 at 14:09, Philipp A. wrote: > Hi Shaheed, > > Shaheed Haque schrieb am Fr., 3. Nov. 2017 um 14:16 > Uhr: >> >> Philipp, >> >> - my overall understanding of this technique is that it may end up >> being fragile, especially

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 141 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/141/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 03 Nov 2017 15:58:02 + Build duration: 1 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 135 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/135/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 03 Nov 2017 15:58:02 + Build duration: 43 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 140 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/140/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 03 Nov 2017 15:52:42 + Build duration: 5 min 8 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 134 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/134/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 03 Nov 2017 15:52:42 + Build duration: 55 sec and counting JUnit Tests

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren added a comment. Good idea. This will future proof us in case we ever want `?linkName=tiledmenu-v18-kde5.9.plasmoid` or something as well. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren updated this revision to Diff 21841. Zren edited the summary of this revision. Zren edited the test plan for this revision. REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8636?vs=21823=21841 REVISION DETAIL

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 139 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/139/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 03 Nov 2017 15:02:52 + Build duration: 1 min 34 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 133 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/133/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 03 Nov 2017 15:02:52 + Build duration: 1 min 33 sec and counting JUnit Tests

D8619: Refactor and remove duplicate code in kfileplacesview

cfeck set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8619 To: mlaurent, #frameworks, ervin Cc: ngraham

D8640: [KDirModel] Emit change for HasJobRole when jobs change

broulik added a reviewer: mwolff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8640 To: broulik, #frameworks, dfaure, hein, mwolff

D8640: [KDirModel] Emit change for HasJobRole when jobs change

broulik created this revision. broulik added reviewers: Frameworks, dfaure, hein. Restricted Application added a project: Frameworks. TEST PLAN I now have QML update live when a copy job comes and goes REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8640 AFFECTED FILES

Re: Python bindings using cppyy (was: An update on Python bindings)

Philipp, On 3 November 2017 at 12:52, Philipp A. wrote: > Hi Shaheed, > > Thank you so much for all your work! > >> a framework-by-framework integration of the binding generation logic (as >> previously pioneered by Steve) probably cannot work in general because there >> are

Re: Python bindings using cppyy (was: An update on Python bindings)

Hi Shaheed, Thank you so much for all your work! a framework-by-framework integration of the binding generation logic (as > previously pioneered by Steve) probably cannot work in general because > there are cases where multiple frameworks contribute to to the same C++ > namespace […] > > The

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

ngraham edited the summary of this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 91 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/91/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 03 Nov 2017 12:35:45 + Build duration: 23 min and counting JUnit Tests

D8332: Added baloo urls into places model

ngraham added a comment. @ervin and @dvratil, any remaining concerns? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent Cc: ervin, usta, mlaurent, dvratil, ngraham,

D8450: User can now hide an entire places group from KFilePlacesView

ngraham added a dependent revision: D8619: Refactor and remove duplicate code in kfileplacesview. REVISION DETAIL https://phabricator.kde.org/D8450 To: mlaurent, ngraham, renatoo, franckarrecot, ervin Cc: #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

ngraham added a dependent revision: D8450: User can now hide an entire places group from KFilePlacesView. REVISION DETAIL https://phabricator.kde.org/D8367 To: mlaurent, renatoo, ngraham, franckarrecot, ervin Cc: ngraham, mlaurent, #frameworks

D8619: Refactor and remove duplicate code in kfileplacesview

ngraham edited the summary of this revision. ngraham added a dependency: D8450: User can now hide an entire places group from KFilePlacesView. REVISION DETAIL https://phabricator.kde.org/D8619 To: mlaurent, #frameworks, ervin Cc: ngraham

D8450: User can now hide an entire places group from KFilePlacesView

ngraham edited the summary of this revision. ngraham added a dependency: D8367: Hidding place groups implementation in KFilePlacesModel. REVISION DETAIL https://phabricator.kde.org/D8450 To: mlaurent, ngraham, renatoo, franckarrecot, ervin Cc: #frameworks

D8544: KTextEditor : avoiding QML crashes

This revision was automatically updated to reflect the committed changes. Closed by commit R39:e427f6d4bdf9: Avoid (certain) crashes while executing QML scripts (authored by rjvbb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8544?vs=21793=21833#toc REPOSITORY R39 KTextEditor

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

apol added a comment. Hi, Thanks for your patch! It's something I pondered doing at some point but then got busy with other stuff. I was thinking that instead of adding yet another part, maybe we could have it as a URI query, this way we don't break the components that are parsing

D8639: Optimize SortFilterModel role names

broulik added inline comments. INLINE COMMENTS > mwolff wrote in datamodel.h:141 > why was that kf6 note there? Probably someone added it who thought it could not be changed because you can't for exported classes but this isn't. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D8638: Remove DataModel::roleNameToId

mwolff accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8638 To: broulik, #plasma, mwolff Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8639: Optimize SortFilterModel role names

mwolff accepted this revision. mwolff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > datamodel.h:141 > protected: > -int roleNameToId(const QString ); //FIXME TODO KF6: This should > have been const. > +int roleNameToId(const QString ) const;

D8639: Optimize SortFilterModel role names

broulik edited the summary of this revision. broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8639 To: broulik, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8639: Optimize SortFilterModel role names

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY - Reserve m_roleIds - Avoid double lookup contains+value but use default value

D8638: Remove DataModel::roleNameToId

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It is unused and returned `-1` whereas `SortFilterModel` would return

D8632: kded: remove dbus calls to ksplash.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D8632 To: dfaure, davidedmundson Cc: #plasma, #frameworks

D8619: Refactor and remove duplicate code in kfileplacesview

mlaurent edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D8619 To: mlaurent, #frameworks, ervin Cc: ngraham

D8619: Refactor and remove duplicate code in kfileplacesview

mlaurent updated this revision to Diff 21828. mlaurent added a comment. Don't disconnect a model without check if not null. Const'ify some variables CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8619?vs=21779=21828 REVISION DETAIL https://phabricator.kde.org/D8619 AFFECTED

D8633: KLauncher: remove dead code related to autostart.

This revision was automatically updated to reflect the committed changes. Closed by commit R303:0d4d861ba3b9: KLauncher: remove dead code related to autostart. (authored by dfaure). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8633?vs=21814=21827#toc REPOSITORY R303 KInit CHANGES

D8332: Added baloo urls into places model

mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent Cc: ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren added a reviewer: apol. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren, apol Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

Zren edited the test plan for this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D8636 To: Zren Cc: #frameworks