mlaurent accepted this revision.
mlaurent added a comment.
Seems ok for me now.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
That is indeed source incompatible (apart from the change to the _p.h
headers). You can either just add a "TODO KF6" comment, or provide a cmake
option for linking to QtWidgets,
smithjd updated this revision to Diff 22107.
smithjd added a comment.
- Merge local and tag file handling.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=21851=22107
BRANCH
master-nestedTags (branched from master)
REVISION DETAIL
anthonyfieroni added a comment.
In https://phabricator.kde.org/D8536#165865, @elvisangelaccio wrote:
> As I mentioned, using //only// a combobox doesn't work, because the main
functionality (= check integrity of downloaded files) is now harder to use.
In other hand moslty user
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/135/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Wed, 08 Nov 2017 18:29:39 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/136/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 08 Nov 2017 18:29:39 +
Build duration:
17 min and counting
JUnit Tests
Name:
anthonyfieroni added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:2657
> +class KChecksumAlgorithmListModel: public QAbstractListModel {
> +QVector algorithms;
> +
Make it static const and initialize it here.
> kpropertiesdialog.cpp:2681-2682
> +QVariant data(const
rkflx added a comment.
In https://phabricator.kde.org/D8056#165453, @simgunz wrote:
> Is it there a way to make my contact info in kde identity public? I
couldn't find an option for it.
There is no such option yet, as far as I know. Turns out as you used `arc` to
upload your
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:83595ebd5636: Change label Advanced options
Terminal options (authored by simgunz, committed by rkflx).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
kossebau added inline comments.
INLINE COMMENTS
> kde5.xml:3647
>
> +
> +Qt Resource Collection file
This one surely should be also added to shared-mime-info, once proposed name
and details have been checked.
Anyone up for that task, ideally someone who could run this also across Qt
kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
When browsing folders of sources with KDE software, e.g. in Dolphin or
KDevelop, there are currently quite some files shown to be only simple text
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/134/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Wed, 08 Nov 2017 17:19:44 +
Build duration:
18 min and counting
JUnit Tests
Name: (root)
elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.
As I mentioned, using //only// a combobox doesn't work, because the main
functionality (= check integrity of downloaded files) is now harder to use.
REPOSITORY
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/135/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 08 Nov 2017 17:19:44 +
Build duration:
6 min 57 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a2f1e9fa43d2: Dont autoremove empty temp file
(authored by elvisangelaccio).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8696?vs=22034=22093
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1d55f0448725: JavaScript: include standard mime types
(authored by ChALkeR).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8451?vs=21248=22085#toc
REPOSITORY
R216 Syntax Highlighting
ngraham added a comment.
@davidk, I think you have commit rights; do you want to do the honors?
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham,
mgallien added a comment.
Yes exactly.
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks
graesslin added subscribers: dfaure, graesslin.
graesslin added a comment.
From my side a -1. This is not source compatible. Thus I think we need to
wait for Frameworks 6 for it.
I want @dfaure to ack/nack this change.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/134/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 08 Nov 2017 13:56:03 +
Build duration:
23 min and counting
JUnit Tests
Name:
ngraham added a comment.
Do you want to land this?
REPOSITORY
R286 KFileMetaData
BRANCH
readOnly
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/133/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Wed, 08 Nov 2017 13:56:03 +
Build duration:
6 min 7 sec and counting
JUnit Tests
Name:
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8697#165670, @apol wrote:
> Here's an alternative: https://codereview.qt-project.org/210716
That would be much cleaner indeed, I'll hold this patch for now.
REPOSITORY
R241 KIO
BRANCH
fix-empty-exists
REVISION
dfaure added inline comments.
INLINE COMMENTS
> simgunz wrote in kopenwithdialog.cpp:463
> Segmentation fault happens if I use the member var. Accessing the member var
> is the cause of the fault, because even `qDebug() << d->m_proxyModel`
> generates the same error. It is not clear to me why.
apol added a comment.
Here's an alternative: https://codereview.qt-project.org/210716
REPOSITORY
R241 KIO
BRANCH
fix-empty-exists
REVISION DETAIL
https://phabricator.kde.org/D8697
To: elvisangelaccio, dfaure
Cc: apol, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/132/
Project:
Frameworks kio kf5-qt5 XenialQt5.7
Date of build:
Wed, 08 Nov 2017 10:44:37 +
Build duration:
8 min 2 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1a7d545c4040: Only prevent the name to update if
its empty (authored by apol).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8683?vs=21981=22067
REVISION DETAIL
simgunz added inline comments.
INLINE COMMENTS
> dfaure wrote in kopenwithdialog.cpp:463
> Use the member var instead of casting.
Segmentation fault happens if I use the member var. Accessing the member var is
the cause of the fault, because even `qDebug() << d->m_proxyModel` generates
the
28 matches
Mail list logo
