D8330: Open files in TagLib extractor readonly

davidk added a comment. In https://phabricator.kde.org/D8330#165813, @ngraham wrote: > @davidk, I think you have commit rights; do you want to do the honors? Yes I have commit rights. I'l land it at the weekend. Thanks for your feedback! REPOSITORY R286 KFileMetaData BRANCH

D8461: Remove unused config.h.cmake entries

davidk added a comment. Thanks for the git hint and the revew. Then we should remove this code too. REPOSITORY R293 Baloo BRANCH cleanup REVISION DETAIL https://phabricator.kde.org/D8461 To: davidk, dfaure Cc: dfaure, #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

davidedmundson created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY During plasma startup we have multiple processes using kactivities at once. The current code looks to see if the bus is active then

D8732: Fix race that starts kactivitymanagerd multiple times

davidedmundson added a comment. bootchart screenshot of the problem (courtesy of apol) F5483212: Spectacle.GxYIDa.png REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D8732 To: davidedmundson Cc: #frameworks

D8732: Fix race that starts kactivitymanagerd multiple times

davidedmundson added a dependency: D8733: DBus activate KActivityManagerd. REPOSITORY R6 KActivities REVISION DETAIL https://phabricator.kde.org/D8732 To: davidedmundson Cc: #frameworks

D8705: Remove Qt5::Widgets as a dependency

apol added a comment. Qt has this kind of changes all the time and I've never seen a complaint. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D8705 To: apol, #frameworks, dfaure Cc: graesslin, dfaure, anthonyfieroni

D8732: Fix race that starts kactivitymanagerd multiple times

apol added a comment. +1 I can see the same issue in my bootchart. INLINE COMMENTS > manager_p.cpp:82 > +if (!reply.isValid()) { > +//pre 5.12 the daemon did not support DBus > activation. Fall back to manually forking > +

D8705: Remove Qt5::Widgets as a dependency

dfaure added a comment. Qt doesn't have files like KF5WindowSystemConfig.cmake.in :) I guess you mean changing #includes in public headers, but this is also about changing the library dependencies, which I have never seen change in Qt. Now that you remind me that Qt sometimes change

D8705: Remove Qt5::Widgets as a dependency

graesslin added a comment. In https://phabricator.kde.org/D8705#166045, @dfaure wrote: > I guess that the same argument could be made about Qt5::Widgets... if you're using a widget you're supposed to link to that, rather than indirectly via KWindowSystem... > > This is making me chan

D8332: Added baloo urls into places model

ngraham added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks

Making Purpose part of KF5

Hi, I would like to include Purpose [1] into the frameworks umbrella. It's been around for a while now, used by few applications and reasonably stable. Any thoughts? Aleix [1] https://phabricator.kde.org/source/purpose/

Re: Making Purpose part of KF5

On Thu, Nov 9, 2017 at 5:10 PM, Aleix Pol wrote: > Hi, > I would like to include Purpose [1] into the frameworks umbrella. > It's been around for a while now, used by few applications and > reasonably stable. > > Any thoughts? > +1 I actually included it in kdesrc-build quite a while ago because

Re: Making Purpose part of KF5

On Thu, Nov 9, 2017 at 7:35 PM, David Edmundson wrote: > I think having src/plugins in the framework will cause problems. Can you please elaborate? I'm not excited about having all the plugins inside TBH, but then I don't see another way around that isn't having a purpose-plugins repository (or

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 144 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/144/ Project: Frameworks kirigami kf5-qt5 XenialQt5.7 Date of build: Fri, 10 Nov 2017 03:52:00 + Build duration: 6 min 5 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 138 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/138/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 10 Nov 2017 03:52:00 + Build duration: 10 min and counting JUnit Tests Na

D5111: Provide demo/preview for checkable menu items

anthonyfieroni removed a dependent revision: D8741: [kget] Fix a crash when opening the transfer history dialog. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin, anthonyfieroni Cc: ltoscano, kde-mac, #frameworks

D5111: Provide demo/preview for checkable menu items

anthonyfieroni added a dependent revision: D8741: [kget] Fix a crash when opening the transfer history dialog. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D5111 To: rjvbb, hpereiradacosta, jriddell, zhigalin, anthonyfieroni Cc: ltoscano, kde-mac, #frameworks

D8296: Use Ctrl+Shift+, as the standard shortcut for "Configure "

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg, broulik, rkflx Cc: ilic, abetts, elvisangelaccio, aacid, argonel, marten, gr