anthonyfieroni added inline comments.
INLINE COMMENTS
> kio_tags.cpp:363
> +
> +if (result.decodedUrl.contains(QStringLiteral("?//")) ||
> chopLastSection) {
> +result.tag = result.tag.section(QDir::separator(), 0, -2);
Better reverse conditions
if (chopLastSection ||...)
broulik added a comment.
I think you should store the mouse position and then check whether the
`manhattanLength()` between new and old is `>=
QApplication::startDragDisance()` to be consistent with regular click and drag
drop handling – not everyone is capable of holding a mouse perfectly s
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:e2795e947233: [MouseEventListener] Allow accepting mouse
event (authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8864?vs=22518&id=22803#toc
REPOSITORY
R296 KDeclarative
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Thu, 23 Nov 2017 11:29:22 +
Build duration:
8 min 9 sec and counting
JUnit Tests
Name
renatoo updated this revision to Diff 22809.
renatoo marked 7 inline comments as done.
renatoo added a comment.
Fixed typos
Fixed code style
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22783&id=22809
REVISION DETAIL
https://phabricator.kde.org/D
renatoo updated this revision to Diff 22810.
renatoo marked an inline comment as done.
renatoo added a comment.
Renamed test function
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8332?vs=22775&id=22810
REVISION DETAIL
https://phabricator.kde.org/D8332
AFF
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/115/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 23 Nov 2017 11:29:22 +
Build duration:
25 min and counting
JUnit Tests
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8963
To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-
aacid added a reviewer: Frameworks.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D8964
To: aacid, #frameworks
Cc: #frameworks
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8965
To: broulik, #plasma, fvogt
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Bug #1: If you call show() or setVisible() after animatedHide() nothing would
happen
This is because animatedHide() does
d->conte
aacid updated this revision to Diff 22827.
aacid added a comment.
Small tweak to the test
REPOSITORY
R236 KWidgetsAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8964?vs=22825&id=22827
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8964
AFFECTED FILES
au
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8963
To: broulik, #plasma, fvogt
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/149/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 23 Nov 2017 13:53:03 +
Build duration:
1 min 39 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Thu, 23 Nov 2017 13:53:03 +
Build duration:
1 min 16 sec and counting
JUnit Tests
Nam
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8965
To: broulik, #plasma, fvogt, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-
broulik edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8963
To: broulik, #plasma, fvogt
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This ensures the menu can have nice round corners with Breeze and Oxygen. The
sa
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/2/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Thu, 23 Nov 2017 13:26:03 +
Build duration:
6 min 11 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Thu, 23 Nov 2017 13:26:03 +
Build duration:
6 min 6 sec and counting
JUnit Te
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/148/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 23 Nov 2017 11:29:22 +
Build duration:
51 min and counting
JUnit Tests
Nam
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/148/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 23 Nov 2017 13:26:03 +
Build duration:
11 min and counting
JUnit
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This would create the surface after which this flag has no effect causing
menus
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Thu, 23 Nov 2017 15:04:34 +
Build duration:
6 min 40 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Thu, 23 Nov 2017 15:04:34 +
Build duration:
7 min 14 sec and counting
JUnit T
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/149/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 23 Nov 2017 15:04:34 +
Build duration:
22 min and counting
JUnit
renatoo added a comment.
@dvratil, @ervin any comments?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure, mwolff
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil
broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
TEST PLAN
Removed my `~/.local/share/libkunitconversion/currency.xml` file, restarted
krunner, entered `5EUR` and got the file properly created. I verified with
`curl` that
renatoo updated this revision to Diff 22815.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22780&id=22815
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 22816.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22781&id=22816
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 22818.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22809&id=22818
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 22813.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22778&id=22813
REVISION DETAIL
https://phabricator.kde.org/D8943
AFFECTED FILES
autotests/kfileplacesmodelte
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8948
To: renatoo, dfaure
Cc: #frameworks
renatoo updated this revision to Diff 22817.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22782&id=22817
REVISION DETAIL
https://phabricator.kde.org/D8947
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 22814.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22779&id=22814
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 22812.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=22777&id=22812
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
autotests/kfileplacesmodelte
renatoo updated this revision to Diff 22811.
renatoo added a comment.
Parent branch updated
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=22776&id=22811
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
autotests/kfileplacesmodelte
This revision was automatically updated to reflect the committed changes.
Closed by commit R6:b4bdd796079c: Fix race that starts kactivitymanagerd
multiple times (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8732?vs=22112&id=22819#toc
REPOSITORY
R6 KActiv
broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
The Qt Xml module is not actively maintained anymore and docs suggest to use
QXmlStreamReader. Also removes the dependency on Qt Xml
TEST PLAN
I can still
safaalfulaij added a comment.
I can commit but it is showing as not accepted.
So I'll just wait for the final confirmation.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D7660
To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann, mwolff, cullmann
Cc: mwolff
dfaure accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure, mwolff
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks
ngraham added a comment.
I'm going to land this on 11/25/17 unless I hear any more objections from
anyone.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8332
To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham,
ervin, mlaurent, dfaure, mwolf
anthonyfieroni added inline comments.
INLINE COMMENTS
> currency.cpp:713
> +const auto multiplier =
> attributes.value(QLatin1String("rate")).toDouble();
> +if (multiplier != 0) {
> +unit.setUnitMultiplier(1.
broulik added a comment.
`qFuzzyIsNull` rather. The original code didn't even check ..
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
To: broulik, #frameworks
Cc: anthonyfieroni
apol created this revision.
apol added reviewers: Frameworks, jgrulich.
Restricted Application added a project: Frameworks.
REPOSITORY
R282 NetworkManagerQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8976
AFFECTED FILES
src/manager.cpp
To: apol, #frameworks, jgrulich
apol added a comment.
+1
REPOSITORY
R292 KUnitConversion
REVISION DETAIL
https://phabricator.kde.org/D8971
To: broulik, #frameworks
Cc: apol, anthonyfieroni
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/63/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 23 Nov 2017 13:26:03 +
Build duration:
5 hr 48 min and counting
smithjd updated this revision to Diff 22857.
smithjd marked 3 inline comments as done.
smithjd added a comment.
- Review suggestions.
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8098?vs=22792&id=22857
BRANCH
master-nestedTags (branched from master)
REV
smithjd added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kio_tags.h:101
> metaData(QString{})
Doesn't work.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D8098
To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure
Cc: anthonyfieroni, dfaure, nicol
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/116/
Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 23 Nov 2017 13:53:03 +
Build duration:
6 hr 45 min and counting
JUnit Te
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Thu, 23 Nov 2017 20:49:37 +
Build duration:
10 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/7/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Thu, 23 Nov 2017 20:49:37 +
Build duration:
10 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/150/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Thu, 23 Nov 2017 20:49:37 +
Build duration:
12 min and counting
JUnit
kfunk accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R282 NetworkManagerQt
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8976
To: apol, #frameworks, jgrulich, kfunk
kfunk created this revision.
kfunk added a reviewer: dfaure.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
REVISION SUMMARY
We need to separate paths in environment variables
with a semincolon (;) on Windows
kfunk added a subscriber: Windows.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux
Cc: #windows, #frameworks, #build_system
kfunk added a reviewer: bcooksley.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux, bcooksley
Cc: #windows, #frameworks, #build_system
kfunk added a reviewer: cgiboudeaux.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux
Cc: #frameworks, #build_system
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah, oops, indeed.
REPOSITORY
R240 Extra CMake Modules
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8979
To: kfunk, dfaure, cgiboudeaux, bcooksley
Cc: #windows, #framew
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/64/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 23 Nov 2017 19:15:05 +
Build duration:
4 hr 23 min and counting
aleksejshilin updated this revision to Diff 22866.
aleksejshilin added a comment.
- Don't consider mouse moves which are smaller than drag distance
- Don't pass the ignored mouse release event to the base class
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Fri, 24 Nov 2017 01:58:10 +
Build duration:
3 min 24 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Fri, 24 Nov 2017 01:58:10 +
Build duration:
3 min 14 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/64/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Fri, 24 Nov 2017 01:58:10 +
Build duration:
4 min 56 sec and counting
JUnit Test
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/65/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 23 Nov 2017 23:39:06 +
Build duration:
3 hr 14 min and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/22/
Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Fri, 24 Nov 2017 01:58:10 +
Build duration:
2 hr 51 min and counting
JUn
66 matches
Mail list logo