D8983: Properly parse dates in cookies when running in non-English locale

anthonyfieroni added inline comments. INLINE COMMENTS > kcookiejar.cpp:78-84 > +static const char *const day_name[] = { > + "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun" > +}; > +for (int i = 0; i < 7; ++i) { > +// No need to check for long names sin

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/2/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Sun, 26 Nov 2017 03:52:56 + Build duration: 15 min and counting JUnit Tests Name: (root) Failed:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 142 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/142/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 26 Nov 2017 03:52:56 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 2 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/2/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 26 Nov 2017 03:52:56 + Build duration: 6 min 44 sec and counting JUnit Tests Name: (root)

D8366: Factoring out lists of url data within KFilePlacesModelTest

ngraham added a comment. Is this ready to go in, or do we need some more time for review? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8366 To: franckarrecot, renatoo, ervin, mlaurent Cc: ervin, ngraham, mlaurent, #frameworks

D8348: Add a section for removable devices

ngraham added a comment. @renatoo, now that https://phabricator.kde.org/D8332 is in, this no patch longer applies cleanly. Can you update so I can land it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8348 To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham, mwo

D8332: Added baloo urls into places model

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7eb6333bdb48: Added baloo urls into places model (authored by Renato Araujo Oliveira Filho , committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://p

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22940. smithjd added a comment. - Fix for slash-less tag urls. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22938&id=22940 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricato

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.9/31/ Project: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.9 Date of build: Sun, 26 Nov 2017 02:45:51 + Build duration: 11 min and counting JU

D8791: Avoid inconsistent passworddialog

This revision was automatically updated to reflect the committed changes. Closed by commit R236:0919a1b8ba52: Avoid inconsistent passworddialog (authored by cryptodude, committed by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8791?vs=22268&

D8999: KJob: add start(int delay) method

rjvbb abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8999 To: rjvbb, dfaure Cc: apol, anthonyfieroni, #frameworks

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added a comment. Currently known issues: Entering a tagged folder works, listing it from within the tags: protocol in the slave results in a folder cannot be entered error. Attempting to copy a tag tree with such a populated folder results in a file not found error for each file

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22938. smithjd added a comment. - Fix valid tag calculation. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22857&id=22938 BRANCH master-nestedTags (branched from master) REVISION DETAIL https://phabricator.

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 152 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/152/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 Date of build: Sat, 25 Nov 2017 22:20:05 + Build duration: 1 hr 1 min and counting J

what happens when calling KDirWatch::addDir() multiple times with the same path?

Hi, KDirWatch is mostly rather old code, does anyone really know why it does what it does? For instance, watching a directory multiple times with KDW::addDir() results in as many "Added already watched Entry" debug messages but I can't get my head around the underlying goal. It's also not clea

D8983: Properly parse dates in cookies when running in non-English locale

schwab added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8983 To: schwab, dfaure, #frameworks Cc: #frameworks

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/67/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 Date of build: Sat, 25 Nov 2017 22:20:05 + Build duration: 46 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 25 Nov 2017 22:20:05 + Build duration: 10 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Sat, 25 Nov 2017 22:20:05 + Build duration: 5 min 56 sec and counting JUnit T

D8992: Warn about errors when parsing json files

mpyne accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8992 To: apol, #frameworks, mpyne

D8999: KJob: add start(int delay) method

dfaure added a comment. -2 There *is* already API for this: `QTimer::singleShot(delay, job, &KJob::start)` REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8999 To: rjvbb, dfaure Cc: apol, anthonyfieroni, #frameworks

D9001: Better handle of subjobs

anthonyfieroni added a comment. It should be two different patches, one in KIO and one in KCoreAddons. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9001 To: jtamate, #frameworks, dfaure Cc: anthonyfieroni, ltoscano

D8999: KJob: add start(int delay) method

rjvbb added a comment. I'm not convinced that there's much that can be done in the example I gave to make it smarter and more capable to predict random events, but that's not the point here. It's just an explicit example I had at hand. I proposed this addition because it's a tiny convenience

D9001: Better handle of subjobs

dfaure added a comment. Phabricator usage: you can't upload one patch for two git repos into a single change request. This makes the "repo" field wrong, and it makes it impossible to get context. Use `arc diff` and create two review requests (unfortunately). Commit log: something like "f

D8999: KJob: add start(int delay) method

anthonyfieroni added inline comments. INLINE COMMENTS > rjvbb wrote in kjob.cpp:98 > In fact, are you sure that KJob::start won't be ambiguous? Trying to compile > this with clang++ I get > > src/lib/jobs/kjob.cpp:98:5: error: no matching function for call to > 'singleShot' > QTimer::s

D8999: KJob: add start(int delay) method

apol added a comment. I don't really see the value here. Can't the application developer also do the QTimer gimmick? Something I find myself doing often is the singleShot with 0, maybe simply adding a `startLater()` (à la `deleteLater()`) method would work and be slightly more elegant A

D8999: KJob: add start(int delay) method

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. I don't think it's KJob's job (haha) to be responsible for compressing change notifications, which is basically the use case you're mentioning. This can be done with a QTimer and

D8999: KJob: add start(int delay) method

rjvbb set the repository for this revision to R244 KCoreAddons. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8999 To: rjvbb, dfaure Cc: anthonyfieroni, #frameworks

D8999: KJob: add start(int delay) method

rjvbb updated this revision to Diff 22934. rjvbb added a comment. `int delay` can be negative; prevent warnings from QTimer by calling start() directly when `delay<=0`. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8999?vs=22932&id=22934 REVISION DETAIL https://phabricator.kde.o

D9002: add PKGUILD to bash syntax

jvanderwaa created this revision. jvanderwaa added a reviewer: Framework: Syntax Highlighting. jvanderwaa added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add pacman's PKGB

D8999: KJob: add start(int delay) method

rjvbb added inline comments. INLINE COMMENTS > rjvbb wrote in kjob.cpp:98 > So KJob::emitSpeed() doesn't use the "old" syntax for compatibility reasons? In fact, are you sure that KJob::start won't be ambiguous? Trying to compile this with clang++ I get src/lib/jobs/kjob.cpp:98:5: error: no

D8999: KJob: add start(int delay) method

rjvbb set the repository for this revision to R244 KCoreAddons. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D8999 To: rjvbb, dfaure Cc: anthonyfieroni, #frameworks

D8999: KJob: add start(int delay) method

rjvbb updated this revision to Diff 22932. rjvbb marked 2 inline comments as done. rjvbb edited the summary of this revision. rjvbb added a comment. Updated as requested. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8999?vs=22925&id=22932 REVISION DETAIL https://phabricator.kde.

D8999: KJob: add start(int delay) method

rjvbb marked 2 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kjob.cpp:98 > Use new syntax > > QTimer::singleShot(delay, this, &KJob::start); So KJob::emitSpeed() doesn't use the "old" syntax for compatibility reasons? > anthonyfieroni wrote i

D9001: Better handle of subjobs

jtamate retitled this revision from "Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs.." to "Better handle of subjobs". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R241 KIO REVIS

D9001: Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs..

ltoscano added a comment. Almost :) The line should have only BUG: 364039 and the title should be a bit shorter (think about the usual rules for git commit messages) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9001 To: jtamate, #frameworks, dfaure Cc: ltosc

D9001: Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs..

jtamate retitled this revision from "Possible solution to bug 364039" to "Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs..". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R241 KIO

D9001: Possible solution to bug 364039

ltoscano added a comment. I can't comment on the content of the review, but remember that what you write in the title, the summary and the test plan will become the git commit message. So please change the description to something more descriptive. You can refer to the bug with a single in

D9001: Possible solution to bug 364039

jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY This is my first phabricator revision, I hope I'm doing it right. First part of the patch in kcoreaddons. Don't remove a child if it is not in th

D8998: Add FindSeccomp to find-modules

davidk marked 3 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8998 To: davidk, graesslin Cc: #frameworks, #build_system

D8998: Add FindSeccomp to find-modules

davidk updated this revision to Diff 22931. davidk added a comment. Remove apparently unneeded version check REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8998?vs=22922&id=22931 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8

D8999: KJob: add start(int delay) method

anthonyfieroni added inline comments. INLINE COMMENTS > kjob.cpp:98 > +{ > +QTimer::singleShot(delay, this, SLOT(start())); > +} Use new syntax QTimer::singleShot(delay, this, &KJob::start); > kjob.h:182 > + */ > +Q_SCRIPTABLE virtual void start(int delay); > + You cannot add a

D8998: Add FindSeccomp to find-modules

davidk added inline comments. INLINE COMMENTS > graesslin wrote in FindSeccomp.cmake:50-55 > No idea, that's copy pasted from some other cmake modules. Well, based on the fact that no other find-module includes such a check, I will remove it. REPOSITORY R240 Extra CMake Modules REVISION DET

D8919: Add explicit AppMenu protocol

graesslin added inline comments. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. INLINE COMMENTS > appmenu.xml:37-38 > + > + > + > + Could you please add "The string must be encoded in latin-1". REPOSITORY R127 KWayland R

D8998: Add FindSeccomp to find-modules

graesslin added inline comments. INLINE COMMENTS > davidk wrote in FindSeccomp.cmake:50-55 > I'm not sure about this. @graesslin is this nessecarry? Most find-modules > don't check for the CMake version, and we don't do anything special here. No idea, that's copy pasted from some other cmake m

D8999: KJob: add start(int delay) method

rjvbb created this revision. rjvbb added a reviewer: dfaure. rjvbb added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I'd like to propose a KJob method that provides a simple API to start asynchronous jobs after a delay. The default implementati

D8998: Add FindSeccomp to find-modules

davidk added inline comments. INLINE COMMENTS > FindSeccomp.cmake:50-55 > +if(CMAKE_VERSION VERSION_LESS 2.8.12) > +message(FATAL_ERROR "CMake 2.8.12 is required by FindSeccomp.cmake") > +endif() > +if(CMAKE_MINIMUM_REQUIRED_VERSION VERSION_LESS 2.8.12) > +message(AUTHOR_WARNING "Your pro

D8998: Add FindSeccomp to find-modules

davidk added a reviewer: graesslin. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8998 To: davidk, graesslin Cc: #frameworks, #build_system

D8998: Add FindSeccomp to find-modules

davidk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY This is copied from KScreenlocker, but will be utilized in Baloo too. TEST PLAN - Autotests are working - KScre