ervin added inline comments.
INLINE COMMENTS
> franckarrecot wrote in kfileplacesview.cpp:863-866
> Oki I add that to my list :-)
Cool, I'll wait for that extra review to appear before accepting that one. So
that we don't forget it. :-)
REPOSITORY
R241 KIO
REVISION DETAIL
ervin added inline comments.
INLINE COMMENTS
> franckarrecot wrote in kfileplacesmodel.cpp:870
> Because it wouldn't compile without the whole KFIlePlacesModel:: prefix, so I
> end up going for variable renaming, seemed cleaner
Let's go for naming it "groupHidden" then. It's a weird shortening
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.9/24/
Project:
Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 02:10:27 +
Build duration:
15 min and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 02:10:27 +
Build duration:
13 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/7/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 02:10:27 +
Build duration:
8 min 20 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/66/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 02:10:27 +
Build duration:
6 min 23 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kfilemetadata kf5-qt5 SUSEQt5.10
Date of build:
Mon, 27 Nov 2017 01:51:37 +
Build duration:
3 min 39 sec and counting
JUnit
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/16/
Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 01:51:37 +
Build duration:
4 min 25 sec and counting
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.7/37/
Project:
Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 27 Nov 2017 01:51:37 +
Build duration:
1 min 25 sec and counting
JUnit
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kfilemetadata kf5-qt5 SUSEQt5.7
Date of build:
Mon, 27 Nov 2017 01:51:37 +
Build duration:
1 min 29 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.9/15/
Project:
Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.9
Date of build:
Mon, 27 Nov 2017 01:07:02 +
Build duration:
2 min 42 sec and counting
kossebau added a comment.
See also discussion at https://phabricator.kde.org/D7194#159565 ff.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D9012
To: kossebau, whiting, leinir, apol
Cc: #frameworks
kossebau created this revision.
kossebau added reviewers: whiting, leinir, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This reverts commits
mgallien added subscribers: vhanda, mgallien.
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Sorry for me being late to review your work. I had not noticed it.
Thanks for your work.
I am all for this change.
The code you are
anthonyfieroni added inline comments.
INLINE COMMENTS
> dfaure wrote in kcompositejob.cpp:102
> When a subclass calls this slotResult implementation, they expect the
> behaviour of "finish with an error if the subjob had an error".
>
> But NOT emitResult in the normal case (no error), since we
dfaure added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kcompositejob.cpp:102
> Yeah, you are right, but we ever emit on error? It's finish whole composite
> job (deleteLater will be called)
When a subclass calls this slotResult implementation, they expect the behaviour
of
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kcookiejar.cpp:117
>
> + // Only English month names are allowed, thus use the C locale.
> +const QLocale cLocale = QLocale::c();
indentation seems
anthonyfieroni added inline comments.
INLINE COMMENTS
> dfaure wrote in kcompositejob.cpp:102
> No no no this is all wrong, please don't change the logic here.
> After a subjob is done, we might want to start another one.
> Most KIO jobs work like that.
Yeah, you are right, but we ever emit on
schwab marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8983
To: schwab, dfaure, #frameworks
Cc: anthonyfieroni, #frameworks
schwab updated this revision to Diff 22971.
schwab added a comment.
Rename variable and constify.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8983?vs=22970=22971
REVISION DETAIL
https://phabricator.kde.org/D8983
AFFECTED FILES
dhaumann closed this revision.
dhaumann added a comment.
Committed:
https://cgit.kde.org/syntax-highlighting.git/commit/?id=105aca796ffbfebc4ffed4581f1cf69a531da996
Thanks for the patch!
INLINE COMMENTS
> bash.xml:11
> ]>
> -
dfaure added a comment.
Thanks for the fix, looks good, just two minor improvement suggestions.
INLINE COMMENTS
> kcookiejar.cpp:78
> const QString weekday = value.left(index);
> +QLocale l = QLocale::c();
> for (int i = 1; i < 8; ++i) {
"i" and "l" local variables
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Just do another arc diff, if your uploaded patch isn't the latest one.
INLINE COMMENTS
> anthonyfieroni wrote in kcompositejob.cpp:102
> Here after remove last job it should emit
schwab marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8983
To: schwab, dfaure, #frameworks
Cc: anthonyfieroni, #frameworks
schwab updated this revision to Diff 22970.
schwab added a comment.
Use the week names from the C locale
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8983?vs=22882=22970
REVISION DETAIL
https://phabricator.kde.org/D8983
AFFECTED FILES
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 26 Nov 2017 15:26:26 +
Build duration:
21 min and counting
JUnit Tests
Name: (root) Failed:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sun, 26 Nov 2017 15:26:26 +
Build duration:
12 min and counting
JUnit Tests
Name: (root)
This revision was automatically updated to reflect the committed changes.
Closed by commit R280:2e2664b0ab0a: Add Aztec code generator (authored by
vkrause).
REPOSITORY
R280 Prison
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8546?vs=22559=22969
REVISION DETAIL
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D9002
To: jvanderwaa, #framework_syntax_highlighting, vkrause
Cc: #frameworks, genethomas, cullmann, vkrause, dhaumann
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3e8eb3746b33: Created remote section
(authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com,
committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
renatoo updated this revision to Diff 22964.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22953=22964
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
renatoo updated this revision to Diff 22966.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22955=22966
REVISION DETAIL
https://phabricator.kde.org/D8947
AFFECTED FILES
renatoo updated this revision to Diff 22965.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22954=22965
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
renatoo updated this revision to Diff 22967.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22956=22967
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22963.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22952=22963
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
renatoo updated this revision to Diff 22962.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22951=22962
REVISION DETAIL
https://phabricator.kde.org/D8943
AFFECTED FILES
renatoo updated this revision to Diff 22961.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=22950=22961
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/3/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sun, 26 Nov 2017 14:44:56 +
Build duration:
17 min and counting
JUnit Tests
Name: (root)
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 26 Nov 2017 14:44:56 +
Build duration:
10 min and counting
JUnit Tests
Name: (root) Failed:
ngraham added a comment.
@renatoo Next! :-) Time to update this one, too.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8434
To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:3db04cfc5179: Add a section for removable devices
(authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com,
committed by ngraham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
petermajchrak added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kpropertiesdialog.cpp:2904-2906
> It's a private function, i can't image why it can be call with null pointers
> :)
I am looking up the UI components based on name and I was getting some nullptrs
until I found the
anthonyfieroni added a comment.
> ! In https://phabricator.kde.org/D8536#172105, @elvisangelaccio wrote:
>
> Unfortunately many websites only show you the SHA1 or, even worse, only the
MD5 of the file. As I said, it doesn't matter that your preferred algo is e.g.
SHA256, if the website
anthonyfieroni added inline comments.
INLINE COMMENTS
> kpropertiesdialog.cpp:2904-2906
> +if (calculateButton == nullptr || copyButton == nullptr) {
> +return;
> +}
It's a private function, i can't image why it can be call with null pointers :)
REPOSITORY
R241 KIO
REVISION
davidk marked 7 inline comments as done.
davidk added a comment.
Thank you, missed this when renaming the docs.
INLINE COMMENTS
> cgiboudeaux wrote in FindSeccomp.cmake:12
> so, what about naming your variables Seccomp_LIBRARIES and
> Seccomp_INCLUDE_DIRS in the file ?
WellI'm for it!
davidk updated this revision to Diff 22958.
davidk added a comment.
Fix variable names
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8998?vs=22931=22958
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8998
AFFECTED FILES
anthonyfieroni added a comment.
In https://phabricator.kde.org/D9004#172096, @jtamate wrote:
> - I can't reproduce now bug 364039 even without a patched kio
But to be correct as needed KIO' one should land too when David accept it.
INLINE COMMENTS
> kcompositejob.cpp:104
>
petermajchrak edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio,
#frameworks
petermajchrak marked 4 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio,
#frameworks
petermajchrak updated this revision to Diff 22957.
petermajchrak added a comment.
I reverted back to the group box layout and parallelized hash calculations
(removed the annoying recursive function).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
renatoo added a comment.
In https://phabricator.kde.org/D8348#172032, @ngraham wrote:
> @renatoo, now that https://phabricator.kde.org/D8332 is in, this no patch
longer applies cleanly. Can you update so I can land it?
I updated it. Could you try again.
REPOSITORY
R241 KIO
renatoo updated this revision to Diff 22956.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8948?vs=22818=22956
REVISION DETAIL
https://phabricator.kde.org/D8948
AFFECTED FILES
renatoo updated this revision to Diff 22955.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8947?vs=22817=22955
REVISION DETAIL
https://phabricator.kde.org/D8947
AFFECTED FILES
renatoo updated this revision to Diff 22954.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8946?vs=22816=22954
REVISION DETAIL
https://phabricator.kde.org/D8946
AFFECTED FILES
renatoo updated this revision to Diff 22952.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8944?vs=22814=22952
REVISION DETAIL
https://phabricator.kde.org/D8944
AFFECTED FILES
renatoo updated this revision to Diff 22953.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8945?vs=22815=22953
REVISION DETAIL
https://phabricator.kde.org/D8945
AFFECTED FILES
renatoo updated this revision to Diff 22951.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8943?vs=22813=22951
REVISION DETAIL
https://phabricator.kde.org/D8943
AFFECTED FILES
renatoo updated this revision to Diff 22949.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8348?vs=22811=22949
REVISION DETAIL
https://phabricator.kde.org/D8348
AFFECTED FILES
renatoo updated this revision to Diff 22950.
renatoo added a comment.
Updated parent branch
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8434?vs=22812=22950
REVISION DETAIL
https://phabricator.kde.org/D8434
AFFECTED FILES
elvisangelaccio added reviewers: VDG, colomar.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8536
To: petermajchrak, elvisangelaccio, #vdg, colomar
Cc: colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio,
#frameworks
elvisangelaccio added a subscriber: colomar.
elvisangelaccio added a comment.
In https://phabricator.kde.org/D8536#165899, @anthonyfieroni wrote:
> In https://phabricator.kde.org/D8536#165865, @elvisangelaccio wrote:
>
> > As I mentioned, using //only// a combobox doesn't work,
petermajchrak added a comment.
I am still not clear on what to do now. Should I revert it to be a lot of
separate buttons (hidden in a collapsible group box) (as @elvisangelaccio said)
or should I keep it in a dropdown (ok according to me and @anthonyfieroni)?...
I'm going to fix some other
jtamate marked 4 inline comments as done.
jtamate added a comment.
I've missed to do:
git add -u
git commit
before doing the last arc diff
If I do arc land (when the ship it! comes), will it do the right thing?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
jtamate updated this revision to Diff 22948.
jtamate added a comment.
- Improved input validation for SubJobs
- Added the changes suggested by anthony
- I can't reproduce now bug 364039 even without a patched kio
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
anthonyfieroni added a comment.
+1
Could you please check, while you are on KCoreAddons and KIO for other jobs
that emitting result in same way?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9005
To: jtamate, #frameworks, dfaure
Cc: anthonyfieroni,
anthonyfieroni requested changes to this revision.
anthonyfieroni added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcompositejob.cpp:67
> +if (d->subjobs.removeAll(job) > 0) {
> +job->setParent(nullptr);
> +return true;
We don't want to
jtamate updated this revision to Diff 22947.
jtamate added a comment.
- Improved input validation for SubJobs by dfaure
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9004?vs=22943=22947
BRANCH
master
REVISION DETAIL
emateli added a comment.
@dfaure I've managed to take another look at this, added a `directory`
property which controls the base dir. Works as it should, however there is one
case where I'm not sure which way we want it and is probably just a matter of
preference.
User types
cgiboudeaux added inline comments.
INLINE COMMENTS
> FindSeccomp.cmake:12
> +# The seccomp include directories
> +# ``Seccomp_LIBRARIES``
> +# The seccomp libraries for linking
so, what about naming your variables Seccomp_LIBRARIES and Seccomp_INCLUDE_DIRS
in the file ?
>
jtamate added a comment.
The backtrace without this patch:
Thread 1 (Thread 0x7f0a25cc5dc0 (LWP 18492)):
[KCrash Handler]
#6 0x7f0a1fe9b156 in KJob::isAutoDelete() const (this=0x1ae3410) at
/g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:333
#7 0x7f0a1fe9a826 in
jtamate edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9005
To: jtamate, #frameworks, dfaure
Cc: elvisangelaccio
dfaure added a comment.
Ah wait this could be made faster to avoid the double lookup.
if (d->subjobs.removeAll(job) > 0) {
job->setParent(nullptr);
return true;
}
return false;
(and then we don't even need the job==nullptr check, that's included in the
dfaure requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9004
To: jtamate, #frameworks, dfaure
elvisangelaccio added a comment.
If this doesn't fix bug #332948, please remove it from the BUG: keyword,
otherwise it will be automatically closed when pushing this commit.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9005
To: jtamate, #frameworks, dfaure
Cc:
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9004
To: jtamate, #frameworks, dfaure
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
As a temporary workaround for the problems with nested eventloops
and warning messages in the move/copy operation when it can't
change the
jtamate abandoned this revision.
jtamate added a comment.
Creating two review requests.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9001
To: jtamate, #frameworks, dfaure
Cc: ngraham, anthonyfieroni, ltoscano
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Don't remove a SubJob pointer if it is not in the list of SubJobs.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
78 matches
Mail list logo
