On Sunday, 3 December 2017 12:12:53 PST David Faure wrote:
> > This should already work, unless the O_CLOEXEC flag has been set on the
> > file descriptor for stderr. The kernel should duplicate open
> > descriptors on fork(2), and exec(2) should maintain its association to
> > any already-open
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/11/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.7
Date of build:
Mon, 04 Dec 2017 02:05:31 +
Build duration:
14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/73/
Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Mon, 04 Dec 2017 02:05:31 +
Build duration:
13 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/13/
Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
Date of build:
Mon, 04 Dec 2017 02:05:31 +
Build duration:
3 min 51 sec and counting
JUnit Tests
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
rtl
REVISION DETAIL
https://phabricator.kde.org/D9126
To: mvourlakos, #plasma, davidedmundson
Cc: plasma-devel, #frameworks, ZrenBot, progwolff,
dhaumann added a comment.
Please test the following:
1. load an existing file in kwrite: kwrite myFile
2. touch it on console, e.g. echo "asdf" >> myFile
3. Now a message widghet should appear on top of the view with a notification
text.
4. This is animated. Is the final size
dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Currently, the search procedure for Definitions is:
1.
jtamate abandoned this revision.
jtamate added a comment.
The new revision is https://phabricator.kde.org/D9156
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D9120
To: jtamate, #frameworks
Cc: mpyne, anthonyfieroni, aacid, apol
jtamate created this revision.
jtamate added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
domainSetups QHash was populated in Kuit::setupForDomain, but
the values of the QHash where not deleted in the default destructor.
All the credit goes to
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R297 KDED
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9155
To: davidedmundson, apol
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:182f76c25275: remove extractor based on QtMultimedia
(authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8886?vs=22575=23399
REVISION
mgallien added a comment.
In https://phabricator.kde.org/D8886#174348, @dfaure wrote:
> Your call. But since that would also fix CI, I'm in favour.
I did read the code of Qt in the gstreamer support and it seems that it is
not possible to get metadata outside a QMediaPlayer. I
aacid added a comment.
In https://phabricator.kde.org/D8964#173472, @dhaumann wrote:
> In general this patch should be OK.
> Could you try with Kate search warp behavior as well? KTextEditor relies
on correct behaviors here heavily.
What should i be looking at? that it appears
davidedmundson created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
X-KDE-Kded-phase is used by kded.cpp
It wasn't in the .desktop file defintion
Will be important if anyone does the json
dhaumann closed this revision.
dhaumann added a comment.
This was committed with:
https://cgit.kde.org/syntax-highlighting.git/commit/?id=e5f5db6719681edb1aa3c442e10ab62615ebb5b4
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D9154
To: dhaumann, vkrause
On Sunday December 03 2017 12:01:12 David Faure wrote:
> How many calls to addDir() are we talking about?
That's the main point: potentially lots. The function that loads directories
and also sets the watch will also be called when a KDirWatch::dirty signal is
received, plus when the user
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kcrash kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 20:15:33 +
Build duration:
1 min 11 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/29/
Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Dec 2017 20:15:33 +
Build duration:
32 sec and counting
JUnit Tests
Name:
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kcrash kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 20:15:33 +
Build duration:
1 min 6 sec and counting
JUnit Tests
Name:
On dimanche 3 décembre 2017 17:17:10 CET Michael Pyne wrote:
> On Sun, Dec 03, 2017 at 11:54:21AM +0100, David Faure wrote:
> > I'm trying to fix a bug (caught by CI) where KCrash, with the AutoRestart
> > flag, restarts the crashing process directly (fork+execve) rather than
> > via kdeinit.
> >
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kcrash kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 20:04:03 +
Build duration:
4 min 38 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.7/28/
Project:
Frameworks kcrash kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Dec 2017 20:04:03 +
Build duration:
51 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kcrash kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 20:04:03 +
Build duration:
1 min 25 sec and counting
JUnit Tests
Name:
mart updated this revision to Diff 23397.
mart added a comment.
only toString once
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9124?vs=23328=23397
BRANCH
phab/killurlinterceptor
REVISION DETAIL
https://phabricator.kde.org/D9124
mart added inline comments.
INLINE COMMENTS
> davidedmundson wrote in qmlobject.h:72
> The problem being solved is that QQmlObjectSharedEngine inherits QQmlObject
> that needs a constructor that doesn't do engine things
>
> It could be protected though.
what about a different ctor which does
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixUnusedItemDatas (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9154
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Just some minor cleanups.
TEST PLAN
make test
REPOSITORY
R216 Syntax Highlighting
BRANCH
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/17/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 18:05:26 +
Build duration:
11 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/163/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Dec 2017 18:08:27 +
Build duration:
6 min 19 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/21/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 18:05:54 +
Build duration:
4 min 56 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/162/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Dec 2017 17:59:38 +
Build duration:
8 min 24 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/20/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 17:59:38 +
Build duration:
6 min 15 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/16/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 17:59:38 +
Build duration:
5 min 47 sec and counting
hein reopened this revision.
hein added a comment.
Sorry, accidental push. I'll revert and reopen this.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9119
To: hein, #plasma, davidedmundson, broulik, mart
Cc: graesslin, plasma-devel, #frameworks,
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:15f470fafce3: Initialize scale factor to the last scale
factor set on any instance (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:a570254e1aad: Dont update when the underlying
FrameSvg is repaint-blocked (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9138
To: hein, #plasma, davidedmundson, mart
Cc: anthonyfieroni, plasma-devel, #frameworks,
hein added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in framesvgitem.cpp:463
> It doesn't have d-pointer
(I did a git reset and then rewrote the patch, that's how this happened ...)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9138
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in qmlobject.h:72
> this shouldn't be necessary?
>
> qmoobject will do things engine-wise, the qmlsharedengine subclass will
> always do things context-wise without new public constructors?
The problem being solved is that
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a44fdbcdb319: Highlighting Indexer: Warn about unused
itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> qmlobject.h:72
> + */
> +enum class SetupFlag {
> +Engine = 1<<0, ///< call setupEngine() on it
this shouldn't be necessary?
qmoobject will do
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
UnusedItemDatas (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9153
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Current list looks like follows:
Unused itemDatas:
- "syntax/4dos.xml": QSet("Path")
-
mpyne added a comment.
I think `~KuitStaticData()` *does* delete domainSetups. But deleting that
QHash doesn't delete the underlying values. That means the real leak is at
"Kuit::setupForDomain(QByteArray const&) (kuitmarkup.cpp:504)".
If that's the case, then adding a destructor to
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a640eee5a2a1: Fix referencing of non-existing keyword
lists (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9146?vs=23370=23372
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixKeywordLists (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9146
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
There are still some left (e.g. qml.xml) which need a fix later.
TEST PLAN
make test
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:a5ffeaa46d86: Fix simple cases of duplicate contexts
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9143?vs=23366=23369
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixDuplicateContexts (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9143
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Other issues still exist, but need more careful investigation.
TEST PLAN
make && make test
On Sun, Dec 03, 2017 at 11:54:21AM +0100, David Faure wrote:
> I'm trying to fix a bug (caught by CI) where KCrash, with the AutoRestart
> flag,
> restarts the crashing process directly (fork+execve) rather than via kdeinit.
>
> The first process then exits, and whenever the child writes to
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1f2f650f4fc8: Fix duplicate itemDatas (authored by
dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9142?vs=23363=23364
REVISION DETAIL
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixDuplicateItemDatas (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9142
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Remove duplicate itemData entries.
TEST PLAN
make && make test
REPOSITORY
R216 Syntax
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:7df4bda956d7: Fix DetectChar and Detect2Chars rules
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9140?vs=23361=23362
hein added subscribers: mart, hein.
hein added a comment.
Looks good to me, but @mart needs to have a look too.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9141
To: broulik, #plasma
Cc: hein, mart, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
mpyne added a comment.
In https://phabricator.kde.org/D9118#174892, @aacid wrote:
> Will this cause trouble with older cmake versions?
Good question, I haven't tried it. I've verified that `set_property` at least
is present in 2.8.12
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
`setupBindings` is called for every `QmlObject` created and installs various
bits on
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
FixChars (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9140
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
These rules are allowed to have only one char.
TEST PLAN
make && make test
REPOSITORY
R216 Syntax
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:cd7f2837aad1: Try detecting unused contexts (authored by
dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9139?vs=23352=23356
REVISION DETAIL
hein updated this revision to Diff 23354.
hein added a comment.
Fix code
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9138?vs=23351=23354
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9138
AFFECTED FILES
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
UnusedContextChecker (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9139
To: dhaumann, vkrause
Cc: #frameworks
anthonyfieroni added inline comments.
INLINE COMMENTS
> framesvgitem.cpp:463
> {
> +if (d->m_frameSvg->isRepaintBlocked()) {
> +return;
It doesn't have d-pointer
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9138
To: hein, #plasma,
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Try detecting unused contexts. This is only a heuristic,
since a context might be cross-included via
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
When the component completes `FrameSvg::setRepaintBlocked(false)`
is called, which
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:463dfc78b4be: Highlighting Indexer: Check keyword lists
(authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9137?vs=23348=23350#toc
REPOSITORY
R216 Syntax Highlighting
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
KeywordChecker (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9137
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This check includes:
- warn about duplicate keyword list
- warn about missing keyword list
-
hein added a comment.
So I worked out why this happens. We have API like this:
SvgItem {
svg: Svg { imagePath: "..." }
}
Without my patch, `Svg` is instanciated with a scale factor of 1.0 always.
Then `setImagePath` is called on it first. Then `SvgItem::setSvg` is called
graesslin created this revision.
graesslin added reviewers: Frameworks, Plasma, KWin.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The main difference compared to version 2 is additional drag and
apol added a comment.
Wow that's a lot of code gone!
INLINE COMMENTS
> packageurlinterceptor.cpp:95
>
> -if (d->forcePlasmaStyle &&
> path.path().contains(QLatin1String("Controls.2/org.kde.desktop/"))) {
> -return
>
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/19/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 14:20:18 +
Build duration:
10 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/19/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 14:19:19 +
Build duration:
8 min 32 sec and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/18/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 13:58:12 +
Build duration:
22 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/18/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 13:58:12 +
Build duration:
21 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/161/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Dec 2017 14:01:02 +
Build duration:
15 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/19/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Sun, 03 Dec 2017 14:01:02 +
Build duration:
12 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/15/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Sun, 03 Dec 2017 14:01:02 +
Build duration:
9 min 45 sec and counting
ossi added a comment.
you *really* should use a whitelist. it's ok if that breaks some 3rdparty
extractor; you'll get a bug report which you can properly evaluate.
you could go totally overboard and assign fine-grained syscall capabilities
to individual extractors, but i can't really think
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:621e282acbcb: Highlighting Indexer: Warn about duplicate
contexts (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Warn, if two contexts have the same name.
Currently, we have the following issues:
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ContextDataChecker (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9132
To: dhaumann, vkrause
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:befcbbd4e36b: Add undo support to BatchRenameJob
(authored by chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9107?vs=23290=23340
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6b7cd0c8735a: Highlighting Indexer: Check for duplicate
itemDatas (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
ossi added inline comments.
INLINE COMMENTS
> file_unix.cpp:241
> QFile dest_file(dest);
> -if (!dest_file.open(QIODevice::Truncate | QIODevice::WriteOnly)) {
> +int dest_fd = ::open(dest.toStdString().c_str(), O_CREAT | O_TRUNC |
> (is_removeable? O_SYNC : 0) | O_WRONLY);
> +
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:12bf704476c6: Add BatchRenameJob to KIO (authored by
chinmoyr).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9103?vs=23306=23337
REVISION DETAIL
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Check for duplicate itemData entries during indexing.
Currently, there are the following
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
ItemDataChecker (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9129
To: dhaumann, vkrause
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:9d30439abda8: Highlighting indexer: Check DetectChar and
Detect2Chars (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
anthonyfieroni created this revision.
anthonyfieroni added reviewers: leinir, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
If engine is a part of global allocated object d_func *potentially* can be
freed
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
DetectCharChecker (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9127
To: dhaumann, vkrause
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Raise a warning on the console in case of DetectChar or
Detect2Chars have more that one char
mvourlakos created this revision.
mvourlakos added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
--align selected text correctly for
PlasmaComponents2.ComboBox taking into
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:2b8b664e15c0: Validate that for all attributes an
itemData exists (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
AttributeChecker
REVISION DETAIL
https://phabricator.kde.org/D9125
To: dhaumann, vkrause
Cc: #frameworks
dhaumann abandoned this revision.
dhaumann added a comment.
Abandoned in favor of https://phabricator.kde.org/D9125.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D8662
To: dhaumann, vkrause, cullmann
Cc: #frameworks
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
This patch adds a check at compile time that verifies that for
all refereced attributes an itemData
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/160/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Sun, 03 Dec 2017 11:41:16 +
Build duration:
1 hr 3 min and counting
mart abandoned this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9113
To: mart, #plasma
Cc: davidedmundson, apol, plasma-devel, #frameworks, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
1 - 100 of 148 matches
Mail list logo
