BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/22/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 06 Dec 2017 07:18:03 +
Build duration:
14 min and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/26/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 06 Dec 2017 07:18:03 +
Build duration:
4 min 19 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/168/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 06 Dec 2017 07:18:03 +
Build duration:
1 min 21 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/114/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 06 Dec 2017 07:03:48 +
Build duration:
2 min 53 sec and counting
CONSOLE
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks kio kf5-qt5 SUSEQt5.10
Date of build:
Wed, 06 Dec 2017 06:40:33 +
Build duration:
20 min and counting
JUnit Tests
Name: (root)
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/20/
Project:
Frameworks kio kf5-qt5 SUSEQt5.7
Date of build:
Wed, 06 Dec 2017 06:40:33 +
Build duration:
8 min 10 sec and counting
JUnit Tests
Name: (root)
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.7/62/
Project:
Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 06 Dec 2017 06:44:53 +
Build duration:
1 min 11 sec and counting
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/160/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
Date of build:
Wed, 06 Dec 2017 06:40:33 +
Build duration:
2 min 5 sec and counting
CONSOLE OUTPUT
broulik added a comment.
https://bugs.kde.org/show_bug.cgi?id=372813
REVISION DETAIL
https://phabricator.kde.org/D9217
To: dfaure, emateli, elvisangelaccio
Cc: broulik, #frameworks
dfaure added a comment.
That's exactly what this fixes (not only ~/foo but also /foo/bar). Out of
curiosity, in which context (app) were you seeing that issue?
REVISION DETAIL
https://phabricator.kde.org/D9217
To: dfaure, emateli, elvisangelaccio
Cc: broulik, #frameworks
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/25/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 22:37:02 +
Build duration:
9 min 2 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/21/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 22:37:02 +
Build duration:
8 min 43 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/167/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 22:37:02 +
Build duration:
5 min 4 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:3ad4798ca683: [AppletQuickItem] Only set QtQuick Controls
1 style once per engine (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4362
To: broulik, #plasma, davidedmundson
Cc: mart, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff,
broulik added a comment.
Will this fix typing `~/foo` when foo does not exist return an invalid URL?
REVISION DETAIL
https://phabricator.kde.org/D9217
To: dfaure, emateli, elvisangelaccio
Cc: broulik, #frameworks
On mardi 5 décembre 2017 16:46:50 CET Thiago Macieira wrote:
> On Tuesday, 5 December 2017 04:12:30 PST David Faure wrote:
> > I see. But how should one implement a crash handler that autorestarts an
> > app, then, in a "standalone application" use case, i.e. no kdeinit or
> > other
> > daemon
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.7/4/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 22:00:47 +
Build duration:
6 min 30 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 22:00:47 +
Build duration:
4 min 38 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.7/39/
Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 22:00:47 +
Build duration:
3 min 3 sec and counting
JUnit Tests
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
I don't really mind/care if it's fixed or not, if it's deprecated and unused
:-)
Want to submit a patch to deprecate it?
REPOSITORY
R237 KConfig
BRANCH
fix-sort-order
REVISION
dfaure added a comment.
@anthonyfieroni commit
https://phabricator.kde.org/R446:0c4f04b074d9d214b86721ac7c881a6ea95b8c41 seems
to have added that KLineEdit just to be able to show the clear button. This
could just be ported to QLineEdit::setClearButtonEnabled these days.
REPOSITORY
R284
dfaure accepted this revision.
REPOSITORY
R284 KCompletion
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9189
To: mwolff, dfaure, anthonyfieroni
Cc: #frameworks
dfaure created this revision.
dfaure added reviewers: emateli, elvisangelaccio.
REVISION SUMMARY
This allows to use partially-typed paths for completion purposes.
TEST PLAN
Adjusted unittest passes.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9217
AFFECTED FILES
dfaure added inline comments.
INLINE COMMENTS
> kurlnavigator.cpp:1009
> +// Always expand starting ~/ to $HOME. We want all inputs starting with
> it to point home directory.
> +// The reason this expansion is performed here, is that kshorturifilter
> will not return the desired
dhaumann marked 4 inline comments as done.
dhaumann added a comment.
Mark some comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9175
To: dhaumann, cullmann, kfunk, mwolff
Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
dhaumann updated this revision to Diff 23538.
dhaumann marked 3 inline comments as done.
dhaumann added a comment.
- Minor updates to the patch.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9175?vs=23437=23538
BRANCH
QRegExpCleanup2 (branched from
dhaumann marked 5 inline comments as done.
dhaumann added a comment.
Update patch comes in a second.
INLINE COMMENTS
> mwolff wrote in katebookmarks.cpp:129
> static?
I don't think this is critical. Maybe it's even better to not have it static,
since otherwise it'll lurk around until
dfaure added reviewers: apol, davidedmundson.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9213
To: dfaure, apol, davidedmundson
Cc: #frameworks
dfaure updated this revision to Diff 23535.
dfaure added a comment.
Drop the use of KService; broke reading of "Keys" without the servicetype
available
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9213?vs=23529=23535
BRANCH
master
REVISION DETAIL
emateli updated this revision to Diff 23532.
emateli added a comment.
- ~/ at the start always resolves to $HOME
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8920?vs=22702=23532
BRANCH
relative-files-v2
REVISION DETAIL
https://phabricator.kde.org/D8920
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:273e2f26fb55: email.xml: add *.email to the extensions
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8782?vs=22251=23531
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Mostly just removed, some commented out where it seemed more appropriate.
TEST PLAN
make test
dhaumann closed this revision.
dhaumann added a comment.
Committed with
https://cgit.kde.org/syntax-highlighting.git/commit/?id=bb939b4ace0213b822383e23cd15719ad9b4242d
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D9186
To: dhaumann, vkrause
Cc:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.7/3/
Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 18:36:42 +
Build duration:
4 min 41 sec and counting
JUnit Tests
dfaure created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Instead, locate the desktop files and read them, into a memory cache.
This allows to run the KIO unittests without installing KIO.
TEST
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/4/
Project:
Frameworks kimageformats kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 18:36:42 +
Build duration:
1 min 9 sec and counting
JUnit
This revision was automatically updated to reflect the committed changes.
Closed by commit R287:7f2c44add4aa: Use brace-initializer instead of nullptr in
returning 0-QFlags (authored by mkoller).
REPOSITORY
R287 KImageFormats
CHANGES SINCE LAST UPDATE
dhaumann created this revision.
dhaumann added reviewers: jpoelen, jpoelen2, vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Comment out currently unused keyword lists to
avoid having dead code lying around.
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/113/
Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 17:37:46 +
Build duration:
14 min and counting
JUnit Tests
dhaumann created this revision.
dhaumann added a reviewer: mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I had to add a helper function to avoid messy
STL iterator code everywhere. Not an ideal
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:eb0bdd49417c: QStringList initializer list cleanup
(authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9205?vs=23518=23525
REVISION DETAIL
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/20/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 17:29:11 +
Build duration:
5 min 58 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/24/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 17:29:11 +
Build duration:
5 min 39 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/166/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 17:29:11 +
Build duration:
4 min 19 sec and counting
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:78f83f5c7744: Dont set a window icon in
Plasma::Dialog (authored by hein).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9209?vs=23520=23523
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9209
To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: broulik, plasma-devel, ZrenBot,
broulik added a comment.
Ping. (Stupid Phab doesn't move this thing to the top in search result
because it'd old)
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4362
To: broulik, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/19/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 17:14:06 +
Build duration:
7 min 55 sec and counting
broulik added a comment.
+1
I still get an icon for plasma popups in tabbox and present windows
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D9209
To: hein, #plasma, #frameworks, davidedmundson, graesslin
Cc: broulik, plasma-devel, ZrenBot,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/23/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 17:14:06 +
Build duration:
6 min 46 sec and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/165/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 17:14:06 +
Build duration:
4 min 56 sec and counting
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
yep this is better than before after all
INLINE COMMENTS
> kateview.cpp:1385
>
> -QStringList l;
> -
> -l << QStringLiteral("edit_replace")
> - <<
mwolff updated this revision to Diff 23522.
mwolff retitled this revision from "WIP: Forward QComboBox signals instead of
QComboBox lineedit signals" to "Forward QComboBox signals instead of QComboBox
lineedit signals".
mwolff edited the summary of this revision.
mwolff removed subscribers:
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:71f8f16fea15: [RTL] - align properly the selected text
for RTL (authored by mvourlakos).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
hein created this revision.
hein added reviewers: Plasma, Frameworks, davidedmundson, graesslin.
Restricted Application added projects: Plasma, Frameworks.
REVISION SUMMARY
Setting a window icon is costly enough to be worth avoiding when it's
not actually needed.
This is a resurrection
mwolff added inline comments.
INLINE COMMENTS
> dfaure wrote in kurlrequestertest.cpp:162
> Then use QTest::keyClick to send key events to the widget?
I still don't get it to work. This is my currently latest attempt:
void KUrlRequesterTest::testComboEditableRequester()
{
dhaumann added a comment.
@mwolff I have a separate patch where I use STL algos in katedocument. I
would like to keep this as separate patch, though. So is this change fine now?
make test still passes.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D9205
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 16:24:36 +
Build duration:
5 min 4 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 16:24:36 +
Build duration:
3 min 37 sec and counting
CONSOLE OUTPUT
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.7/42/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 16:24:36 +
Build duration:
30 sec and counting
CONSOLE OUTPUT
nicolasfella added a comment.
> Yes it does. You don't know it but
> m_reply = Daemon::instance()->networkAccessManager()->put(req,
m_origin.data());
> in filetransferjob.cpp is using kio.
I really didn't know that
> Are you sure you know how to run kdeconnect with the
dhaumann updated this revision to Diff 23518.
dhaumann added a comment.
Use initializer_lists directly
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9205?vs=23513=23518
BRANCH
QStringListCleanup (branched from master)
REVISION DETAIL
graesslin added a comment.
I'm against a risky change here. Especially as this becomes irrelevant with
Wayland.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D9207
To: hein, #plasma, davidedmundson, mart
Cc: graesslin, plasma-devel, #frameworks, ZrenBot,
On Tuesday, 5 December 2017 04:12:30 PST David Faure wrote:
> > forking inside a signal handler is a bad idea because it may deadlock. If
> > the crash happens while glibc holds some mutexes relating to
> > pthread_atfork, then you'll have a problem.
>
> I see. But how should one implement a
On Tuesday, 5 December 2017 04:12:30 PST David Faure wrote:
> I see. But how should one implement a crash handler that autorestarts an
> app, then, in a "standalone application" use case, i.e. no kdeinit or other
> daemon running in the background?
Wait, why are you forking in the first place?
hein created this revision.
hein added reviewers: Plasma, davidedmundson, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
I'm not as sure on this one as I was with https://phabricator.kde.org/D9194
and the
mlaurent added a comment.
It's the problem that if class doesn't exist nobody will think to use it (or
he will reimplement it).
After that it's not a problem for me to put this code only in LO :)
As you want :)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
aacid added a comment.
In https://phabricator.kde.org/D9190#176216, @nicolasfella wrote:
> I'm sorry, but this does not resolve
https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's
FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so
it could be a
mwolff added a comment.
Most of this is just forwarding code from KFileWidget, so we could just use
that directly? I mean if our LO integration is going to be the only user of
this class, then maybe we should start by adding this code there and only
upstream it if we think more people are
mwolff added a comment.
better than before, but some things could be improved some more
INLINE COMMENTS
> katedocument.cpp:4518
> +// view variable names
> +static const QStringList vvl {
> + QStringLiteral("dynamic-word-wrap")
even better would be to not name this list
anthonyfieroni accepted this revision.
anthonyfieroni added a comment.
This revision is now accepted and ready to land.
Let's David says but i think KOpenWithDialog should be fixed as well, why we
need new KLineEdit while KHistoryComboBox do it for us?
mlaurent edited the test plan for this revision.
mlaurent added reviewers: mwolff, dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REPOSITORY
R241 KIO
BRANCH
add_kfile_dialog
REVISION DETAIL
https://phabricator.kde.org/D9206
AFFECTED FILES
autotests/CMakeLists.txt
dhaumann created this revision.
dhaumann added a reviewer: mwolff.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Simple cleanup of QStringList{...}
TEST PLAN
make test
REPOSITORY
R39 KTextEditor
BRANCH
mwolff edited the summary of this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9189
To: mwolff, dfaure
Cc: #frameworks
mwolff updated this revision to Diff 23508.
mwolff retitled this revision from "Do not crash when completion object gets
destroyed underneath us" to "Do not crash when setting new line edit on an
editable combo box".
mwolff edited the summary of this revision.
mwolff removed subscribers:
mwolff updated this revision to Diff 23507.
mwolff added a comment.
write unit test and document what's going on in more detail
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9189?vs=23473=23507
BRANCH
master
REVISION DETAIL
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/13/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 13:43:20 +
Build duration:
15 min and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/14/
Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 13:43:20 +
Build duration:
15 min and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f9dbd24e80b7: Migrate some QRegExps to QRegularExpression
(authored by dhaumann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D9168?vs=23491=23506#toc
REPOSITORY
R39 KTextEditor
CHANGES
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1c0667ac6af8: Highlighting Indexer: Check for infinite
loops (authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9202?vs=23504=23505
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R216 Syntax Highlighting
BRANCH
CheckLookAhead (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9202
To: dhaumann, vkrause
Cc: #frameworks
mwolff added inline comments.
INLINE COMMENTS
> mwolff wrote in kcombobox.cpp:317
> can you be more specific, such that I can build a unit test out of this? And
> are you saying that `QComboBox::setLineEdit` is deleting the line edit?
ah I think I got it now, thanks for the hint!
REPOSITORY
dhaumann updated this revision to Diff 23504.
dhaumann added a comment.
missing return true statement
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9202?vs=23503=23504
BRANCH
CheckLookAhead (branched from master)
REVISION DETAIL
dhaumann updated this revision to Diff 23503.
dhaumann added a comment.
Fixed typo
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9202?vs=23502=23503
BRANCH
CheckLookAhead (branched from master)
REVISION DETAIL
dhaumann created this revision.
dhaumann added a reviewer: vkrause.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
The infinite loop check looks for a lookAhead="true" in combination
with context="#stay". This would
mwolff added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kcombobox.cpp:317
> KHistoryComboBox is constructed with line edit in, then setLineEdit removes
> it with completion object in.
can you be more specific, such that I can build a unit test out of this? And
are you saying
nicolasfella added a comment.
I'm sorry, but this does not resolve
https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's
FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so
it could be a (similar) bug there.
REPOSITORY
R241 KIO
REVISION DETAIL
mwolff accepted this revision.
mwolff added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> katedocument.cpp:4475
> // found vars, if any
> QString s;
>
future: this could be a ref, quite probably, and capturedRef could be used below
>
Thanks, fixed.
David
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/10/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Tue, 05 Dec 2017 13:12:10 +
Build duration:
2 min 48 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/157/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 05 Dec 2017 13:12:10 +
Build duration:
2 min 29 sec and counting
JUnit Tests
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/12/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
Date of build:
Tue, 05 Dec 2017 13:12:10 +
Build duration:
2 min 8 sec and counting
JUnit Tests
On lundi 4 décembre 2017 17:04:25 CET Thiago Macieira wrote:
> On Monday, 4 December 2017 00:26:55 PST David Faure wrote:
> > > Or do you fork a child at that point? fork from inside a signal handler
> > > is
> > > an incredibly bad idea, don't do it.
> >
> > Well, I guess that's why it's the
dhaumann marked an inline comment as done.
dhaumann added a comment.
Update patch.
INLINE COMMENTS
> mwolff wrote in katecmds.cpp:502
> static?
I do not think static is needed here: When you invoke the command line (F7),
and type 'char 0x123', then creating a QRegularExpression will not be
dhaumann updated this revision to Diff 23491.
dhaumann marked 4 inline comments as done.
dhaumann added a comment.
Remove one usage of QRegularExpression
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9168?vs=23488=23491
BRANCH
QRegExpCleanup
mart updated this revision to Diff 23490.
mart added a comment.
- use kpackage_install_bundled_package
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9124?vs=23463=23490
BRANCH
phab/packegeFileUrl
REVISION DETAIL
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
support for the contents/ directory of kpackage to be
compressed in an rcc file, new cmake
anthonyfieroni added a reviewer: dfaure.
anthonyfieroni added inline comments.
INLINE COMMENTS
> kcombobox.cpp:317
>
> QComboBox::setLineEdit(edit);
> d->klineEdit = qobject_cast(edit);
KHistoryComboBox is constructed with line edit in, then setLineEdit removes it
with completion
1 - 100 of 110 matches
Mail list logo
