dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Perfect!
(until the first bug report, that is) :-)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9290
To: anthonyfieroni, #frameworks, dfaure, hein, aacid
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Thu, 14 Dec 2017 07:31:47 +
Build duration:
13 min and counting
JUnit Tests
Name: (r
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 14 Dec 2017 07:31:47 +
Build duration:
6 min 25 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
Date of build:
Thu, 14 Dec 2017 07:31:47 +
Build duration:
5 min 22 sec and counting
JUnit Tests
Name
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4985ee7f4d2b: Fix ASAN warnings in XDGForeignV2Interface
(authored by davidedmundson).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9319?vs=23880&id=23884
REVIS
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/5/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
Date of build:
Thu, 14 Dec 2017 06:49:22 +
Build duration:
7 min 26 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/5/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Thu, 14 Dec 2017 06:49:22 +
Build duration:
7 min 13 sec and counting
JUnit Tests
Na
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 14 Dec 2017 06:49:22 +
Build duration:
6 min 29 sec and counting
JUnit Tests
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.7/11/
Project:
Frameworks kconfig kf5-qt5 SUSEQt5.7
Date of build:
Thu, 14 Dec 2017 06:14:57 +
Build duration:
7 min 26 sec and counting
JUnit Tests
Name:
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:962998ad27e9: Remove cmake warning about generating moc
file (authored by mlaurent).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9277?vs=23882&id=23883
REVISION
mlaurent updated this revision to Diff 23882.
mlaurent added a comment.
- Use set_source_files_properties
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9277?vs=23716&id=23882
BRANCH
remove_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D92
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9319
To: davidedmundson, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai, ali-m
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/4/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 14 Dec 2017 03:57:00 +
Build duration:
4 min 8 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/13/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.10
Date of build:
Thu, 14 Dec 2017 03:57:00 +
Build duration:
1 min 36 sec and counting
JUnit Tests
N
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/15/
Project:
Frameworks kirigami kf5-qt5 SUSEQt5.7
Date of build:
Thu, 14 Dec 2017 03:57:00 +
Build duration:
2 min 24 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/11/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Thu, 14 Dec 2017 03:13:00 +
Build duration:
3 min 1 sec and counting
JUnit Tests
Name: (r
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/10/
Project:
Frameworks baloo kf5-qt5 SUSEQt5.10
Date of build:
Thu, 14 Dec 2017 03:04:21 +
Build duration:
8 min 37 sec and counting
JUnit Tests
Name: (r
davidedmundson created this revision.
Restricted Application added subscribers: Frameworks, plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.
REVISION SUMMARY
The current code captures a char* from a wayland event in a lambda.
By creating the QString first whe
anthonyfieroni created this revision.
anthonyfieroni added reviewers: leinir, Frameworks.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Every entry contains images who are memory expensive, so we don't want to
store identical entries.
REPOSITORY
R304 KNewStuff
REVISIO
On Sat, Dec 2, 2017 at 5:18 PM, David Faure wrote:
> On dimanche 22 octobre 2017 22:00:36 CET Mark Gaiser wrote:
> > Yes, the build and install were both in the same build folder.
> > Changing the install to some other folder (a sub folder now of the build
> > one) does indeed work.
> > Oh well,
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
Yes. Makes sense to me.
INLINE COMMENTS
> KF5ConfigMacros.cmake:98
>
> + set_property(SOURCE ${_header_FILE} PROPERTY SKIP_AUTOMOC TRUE) #
> don't run automoc on this file
> +
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/6/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 20:15:30 +
Build duration:
14 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.7/6/
Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 20:15:30 +
Build duration:
12 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 20:15:30 +
Build duration:
9 min 26 sec and counting
JUnit
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/8/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 17:35:26 +
Build duration:
2 min 59 sec and counting
broulik edited the test plan for this revision.
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D9312
To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
We initially populate the `QQmlPropertyMap` with all keys in settings after
which the
mart updated this revision to Diff 23864.
mart added a comment.
- ad an autotest
REPOSITORY
R290 KPackage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9197?vs=23489&id=23864
BRANCH
arcpatch-D9197
REVISION DETAIL
https://phabricator.kde.org/D9197
AFFECTED FILES
CMakeList
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/8/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 12:52:57 +
Build duration:
6 min 1 sec and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/3/
Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 12:52:57 +
Build duration:
2 min 42 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/8/
Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 12:52:57 +
Build duration:
1 min 33 sec and counting
JUnit Tests
Na
apol updated this revision to Diff 23858.
apol added a comment.
Added missing file
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9299?vs=23856&id=23858
BRANCH
prefix
REVISION DETAIL
https://phabricator.kde.org/D9299
AFFECTED FILES
kde-
apol edited the test plan for this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9299
To: apol, #frameworks, sitter
Cc: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system
apol updated this revision to Diff 23856.
apol added a comment.
Address issues
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9299?vs=23817&id=23856
BRANCH
prefix
REVISION DETAIL
https://phabricator.kde.org/D9299
AFFECTED FILES
kde-modu
apol added a comment.
> I agree. KDEInstallDirs.cmake seems to be wrong location for this
functionality.
>
> What I'm envisioning is a ecm-env.sh-like script which gets installed into
`$PREFIX/bin` as soon as you install ECM.
>
> Pseudo-cmake code:
>
> configure_file(${CMAKE_
apol marked 5 inline comments as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9299
To: apol, #frameworks, sitter
Cc: kfunk, bcooksley, ngraham, sitter, cgiboudeaux, #build_system
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/90/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 13 Dec 2017 10:55:28 +
Build duration:
34 min and counting
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/34/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
Date of build:
Wed, 13 Dec 2017 10:55:25 +
Build duration:
13 min and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/31/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 10:54:35 +
Build duration:
8 min 25 sec and counting
JUn
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/30/
Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
Date of build:
Wed, 13 Dec 2017 10:44:05 +
Build duration:
10 min and counting
JUnit Tes
kfunk added a comment.
In https://phabricator.kde.org/D9299#179036, @cgiboudeaux wrote:
> In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote:
>
> > In https://phabricator.kde.org/D9299#179032, @kfunk wrote:
> >
> > > If we'd name this file somewhat less generic then it
cgiboudeaux added a comment.
In https://phabricator.kde.org/D9299#179035, @cgiboudeaux wrote:
> In https://phabricator.kde.org/D9299#179032, @kfunk wrote:
>
> > If we'd name this file somewhat less generic then it could be even
installed by default, no?
> >
> > I had the scheme of
cgiboudeaux added a comment.
In https://phabricator.kde.org/D9299#179032, @kfunk wrote:
> If we'd name this file somewhat less generic then it could be even
installed by default, no?
>
> I had the scheme of the QNX setup script in my mind:
https://github.com/acklinr/qnx660/blob/mast
kfunk added inline comments.
INLINE COMMENTS
> sitter wrote in KDEInstallDirs.cmake:699
> From a style perspective, I'd suggest having the prefix.sh live somewhere in
> the installed ECM tree and get copied, rather than maintained as a glorified
> heredoc in the cmake code. That's just a sugges
kfunk added a comment.
If we'd name this file somewhat less generic then it could be even installed
by default, no?
I had the scheme of the QNX setup script in my mind:
https://github.com/acklinr/qnx660/blob/master/qnx660-env.sh
Thus: Maybe rename prefix.sh to say 'ecm-env.sh' and
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/7/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 08:10:39 +
Build duration:
1 hr 20 min and counting
CO
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/89/
Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
Date of build:
Wed, 13 Dec 2017 07:09:58 +
Build duration:
1 hr 42 min and counting
anthonyfieroni updated this revision to Diff 23845.
anthonyfieroni marked an inline comment as done.
anthonyfieroni retitled this revision from "[filewidgets] Fix create path" to
"[kio] Fix create path".
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9290?vs=23843
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/6/
Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 13 Dec 2017 06:46:37 +
Build duration:
1 hr 22 min and counting
CO
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Thanks.
INLINE COMMENTS
> copyjob.cpp:113
>
> -static QUrl addPathToUrl(const QUrl &url, const QString &relPath)
> +static QUrl concatPathsToUrl(const QUrl &url, const QString &
50 matches
Mail list logo
