D9217: KUriFilter: don't return an error on non-existing files.

dhaumann added a comment. @dfaure Better push today than one day before release. ;) BRANCH master REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi, dhaumann Cc: dhaumann, broulik, #frameworks

D9257: MessageInterface: Add CenterInView as additional position

dhaumann added a comment. ping? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9257 To: dhaumann, cullmann, neundorf Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9257: MessageInterface: Add CenterInView as additional position

cullmann added a comment. I like the code better with the array ;=) I would use the enum values instead of 5 or 2, otherwise this is fine for me. For the actual functionality I guess Alex should say yes/no. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D925

D9384: Use runtime install prefix instead of compile time install prefix.

habacker abandoned this revision. habacker added a comment. duplicate of https://phabricator.kde.org/D7708 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D9384 To: habacker, ltoscano, bcooksley, dfaure Cc: #frameworks

D7708: Use runtime install prefix instead of compile time install prefix.

habacker abandoned this revision. habacker added a comment. duplicate of https://phabricator.kde.org/D7706 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7708 To: habacker, cfeck, ltoscano, bcooksley Cc: #frameworks

D9387: Add cross compile support for kconfig_compiler and kconf_update.

habacker added a comment. > -DKF5_HOST_TOOLING=/opt/nativetooling/lib/x86_64-linux-gnu/cmake/ Can you point me to a working example for related cmake files specifing host tools ? Is KF5_HOST_TOOLING support implemented for all required host tools, which are ( from https://build.op

D9383: Use correct service executable path for installing kwalletd dbus service on Win32

habacker updated this revision to Diff 24054. habacker added a comment. - use service file template also for Windows REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9383?vs=24040&id=24054 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9383

D9217: KUriFilter: don't return an error on non-existing files.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f3bb9edbf5b3: KUriFilter: don't return an error on non-existing files. (authored by dfaure). Restricted Application added a project: Frameworks. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

rjvbb added a comment. I'd hope so. I thought I was waiting for additional information but it seems I may have missed a notification that there was new feedback. Apologies if that's the case. I'll need to find some time to go over this again. REPOSITORY R245 Solid REVISION DETAIL h

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/15/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 09:47:42 + Build duration: 2 min 36 sec and counting CONSOLE OUTPUT [...t

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Dec 2017 09:47:42 + Build duration: 5 min 39 sec and counting JUnit Tests Name: (root

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/37/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 09:47:42 + Build duration: 16 min and counting JUnit Tests Name: (root) Failed

D7706: Use runtime install prefix instead of compile time install prefix.

habacker marked an inline comment as done. habacker added inline comments. INLINE COMMENTS > dfaure wrote in kinit_win.cpp:205 > That's the Qt install prefix. I guess it matches your KF5 install prefix for > this patch to work, but it doesn't seem like a universal solution. > > Maybe this can u

D9393: MessageInterface: Add CenterInView as additional position

dhaumann created this revision. dhaumann added a reviewer: cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the message interface to support CenterInView. This should be binary compatib

D9257: MessageInterface: Add CenterInView as additional position

dhaumann abandoned this revision. dhaumann added a comment. Abandoned in favor of followup request: https://phabricator.kde.org/D9393 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9257 To: dhaumann, cullmann, neundorf Cc: #frameworks, kevinapavew, ngraham, demsk

D9393: MessageInterface: Add CenterInView as additional position

dhaumann added a comment. @cullmann This patch now only adds the CenterInView, nothing else (i.e. no changes in search code). Now good to go? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, kevinapavew, ngraham, demski

D9393: MessageInterface: Add CenterInView as additional position

dhaumann updated this revision to Diff 24059. dhaumann added a comment. - Add @since 5.42 REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9393?vs=24058&id=24059 BRANCH MessageInterface (branched from master) REVISION DETAIL https://phabricator.kde.o

D9393: MessageInterface: Add CenterInView as additional position

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH MessageInterface (branched from master) REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, s

D9393: MessageInterface: Add CenterInView as additional position

cullmann added a comment. Jup, ok ;) The 5 as size is still bit strange, but as we have no end enum value, which we don't want to be BC, I guess that is no issue. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9393 To: dhaumann, cullmann Cc: #frameworks, ke

D9393: MessageInterface: Add CenterInView as additional position

This revision was automatically updated to reflect the committed changes. Closed by commit R39:fc7433321d36: MessageInterface: Add CenterInView as additional position (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9393?vs=24059&id=24061#toc REPOSITORY R39 KTextE

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 11:04:17 + Build duration: 12 min and counting CONSOLE OUTPUT

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 - Build # 65 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.9/65/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.9 Date of build: Mon, 18 Dec 2017 11:04:17 + Build duration: 16 min and counting CONSOLE

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann created this revision. dhaumann added reviewers: neundorf, cullmann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch uses the "CenterInView" message position instead of "TopInView" and "BottomI

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added a comment. Example for a wrapping search at bottom, continuing at top: F073: image.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf, cullmann Cc: #frameworks, kevinapavew, n

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann updated this revision to Diff 24063. dhaumann added a comment. - Avoid queuing messages if F3 is continuously pressed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9394?vs=24062&id=24063 BRANCH SearchMessages (branched from master) REVISION

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added reviewers: kfunk, mwolff. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf, cullmann, kfunk, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9394: Show "Search wrapped" message in center of view for better visibility

broulik added a comment. Isn't "Search wrapped" a bit technical? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf, cullmann, kfunk, mwolff Cc: broulik, #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D9124: make packageurlinterceptor as noop as possible

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D9124 REVISION DETAIL https://phabricator.kde.org/D9124 To: mart, #plasma, davidedmundson Cc: davidedmundson, ngraham, apol, plasma-devel, #fr

D9124: make packageurlinterceptor as noop as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R242:c318fde313fe: make packageurlinterceptor as noop as possible (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9124?vs=23906&id=24065#toc REPOSITORY R242 Plasma Framework (L

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/37/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 12:00:57 + Build duration: 3 min 44 sec and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/11/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 12:00:57 + Build duration: 4 min 57 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/34/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Dec 2017 12:00:57 + Build duration: 5 min 10 sec and counting JUn

D9394: Show "Search wrapped" message in center of view for better visibility

dhaumann added a comment. That could very well be the case. Another possibility would be to simply show an icon, like Qt Creator does it. Or change the text, but I tried to avoid long messages (which will be a possible issue in translations anyways)... Suggestions welcome :-) REPOSITORY

D9318: [knewstuff] Limit request cache size

anthonyfieroni added a comment. Any objections? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9318 To: anthonyfieroni, leinir, #frameworks Cc: dfaure, broulik

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/11/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Dec 2017 12:27:22 + Build duration: 5 min 31 sec and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 12:27:22 + Build duration: 10 min and counting JUnit Te

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 12:49:22 + Build duration: 1 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/15/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Dec 2017 12:49:22 + Build duration: 2 min 13 sec and counting JUnit Tests N

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/11/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 12:27:22 + Build duration: 27 min and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/17/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 12:49:22 + Build duration: 7 min 18 sec and counting JUnit Tests Nam

D9398: Fix TagLib detection and build on Windows

leinir added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9398 To: leinir, #frameworks

D8311: Require the same internal version as you're building

This revision was automatically updated to reflect the committed changes. Closed by commit R304:e33d06f9857a: Require the same internal version as you're building (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8311?vs=20791&id=24076 RE

D9398: Fix TagLib detection and build on Windows

vonreth added a comment. +1 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9398 To: leinir, #frameworks Cc: vonreth

D9399: Fix crash, presumably since Qt 5.10?

apol created this revision. apol added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY We are opening the stream as read only and skipRawData would complain that it's a write-only device, and skipping needs reading: QIODevice::skip (QBuffer

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.7 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.7/18/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 16:22:47 + Build duration: 56 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 16:22:47 + Build duration: 1 min 11 sec and counting JUnit Tests

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/16/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Dec 2017 16:22:47 + Build duration: 1 min 22 sec and counting JUnit Tests N

D9400: use kpackage_install_bundled_package

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY use the new package install macro to install them as as rcc files TEST PLAN plasmashell

D9400: use kpackage_install_bundled_package

apol added a comment. I'd prefer a patch that ports plasma-workspace/desktop to kpackage_install_bundled_package rather than abstracting through plasma_install_package. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9400 To: mart, #plasma Cc: ap

D8920: Fixes url navigation with relative links on KUrlNavigator

emateli abandoned this revision. emateli added a comment. Resolved in https://phabricator.kde.org/D9217 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8920 To: emateli, #frameworks, dfaure Cc: #frameworks

D9399: Fix crash, presumably since Qt 5.10?

anthonyfieroni added inline comments. INLINE COMMENTS > http.cpp:4910 > > -stream.skipRawData(BinaryCacheFileHeader::size); > // append the command code I still can't understand why this call present? Doesn't work if it removed? REPOSITORY R241 KIO REVISION DETAIL https://phabri

D9399: Fix crash, presumably since Qt 5.10?

apol added inline comments. INLINE COMMENTS > anthonyfieroni wrote in http.cpp:4910 > I still can't understand why this call present? Doesn't work if it removed? I understand that the serialised cache tag is part of the command and it's there at the beginning. Skip was so that we wouldn't write

D9399: Fix crash, presumably since Qt 5.10?

anthonyfieroni added inline comments. INLINE COMMENTS > apol wrote in http.cpp:4910 > I understand that the serialised cache tag is part of the command and it's > there at the beginning. Skip was so that we wouldn't write on top of it but > append after. Why not just seek ? REPOSITORY R241

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 18:54:58 + Build duration: 6 min 26 sec and counting JUnit Tests Name: (

D9399: Fix crash, presumably since Qt 5.10?

apol added inline comments. INLINE COMMENTS > anthonyfieroni wrote in http.cpp:4910 > Why not just seek ? Why seek if this is essentially the same? Actually, initialising the qbytearray and opening a stream over it then skipping its contents feels wrong. REPOSITORY R241 KIO REVISION DETAIL

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

mpyne added a comment. In fact this appears to force files containing `K_PLUGIN_FACTORY*` into being evaluated by CMake's AUTOMOC (other warning fixes removed files from consideration by CMake AUTOMOC). CMake itself appears to have had an interface change for AUTOMOC between 3.8 and 3.9

D9394: Show "Search wrapped" message in center of view for better visibility

neundorf accepted this revision. neundorf added a comment. This revision is now accepted and ready to land. Definitely an improvement :-) REPOSITORY R39 KTextEditor BRANCH SearchMessages (branched from master) REVISION DETAIL https://phabricator.kde.org/D9394 To: dhaumann, neundorf,

D8919: Add explicit AppMenu protocol

This revision was automatically updated to reflect the committed changes. Closed by commit R127:a0180f387eaf: Add explicit AppMenu protocol (authored by davidedmundson). Restricted Application edited projects, added Plasma; removed Plasma on Wayland. CHANGED PRIOR TO COMMIT https://phabricator.

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/5/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 18 Dec 2017 22:08:58 + Build duration: 2 min 50 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 7 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/7/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Mon, 18 Dec 2017 22:08:58 + Build duration: 6 min 56 sec and counting CONSOLE OUTPUT [.

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Mon, 18 Dec 2017 22:08:58 + Build duration: 11 min and counting JUnit Tests Name: (r

D9398: Fix TagLib detection and build on Windows

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9398 To: leinir, #frameworks, kfunk Cc: vonreth

D9402: Fix error in WaylandSurface::testDisconnect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This test deletes the client wayland connection. We then

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

kossebau added a comment. In https://phabricator.kde.org/D9334#180540, @ngraham wrote: > We have a report in the wild that this broke compiling KWin with CMake 3.10.x for someone on Gentoo: https://bugs.kde.org/show_bug.cgi?id=387983 Actually did it uncover some issue in kwi

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 01:06:39 + Build duration: 4 min 42 sec and counting JUn

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/38/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 01:06:39 + Build duration: 11 min and counting JUnit Tests

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/12/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 01:06:39 + Build duration: 15 min and counting JUnit

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fixes also similar error with msvc in case openssl development header has been installed into the same location as KDEWin. TEST PLAN

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

habacker added reviewers: dfaure, ltoscano, bcooksley. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9404 To: habacker, dfaure, ltoscano, bcooksley Cc: #frameworks

D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON

mpyne added a comment. In https://phabricator.kde.org/D9334#180881, @kossebau wrote: > In https://phabricator.kde.org/D9334#180830, @mpyne wrote: > > > In fact this appears to force files containing `K_PLUGIN_FACTORY*` into being evaluated by CMake's AUTOMOC (other warning fixes remov

D9402: Fix error in WaylandSurface::testDisconnect

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D9402 To: davidedmundson, #plasma, graessl

D9399: Fix crash, presumably since Qt 5.10?

anthonyfieroni added inline comments. INLINE COMMENTS > apol wrote in http.cpp:4910 > Why seek if this is essentially the same? > Actually, initialising the qbytearray and opening a stream over it then > skipping its contents feels wrong. Current implementation has a 4k buffer on the stack (fro

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/8/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 07:28:49 + Build duration: 6 min 10 sec and counting CONSOLE OUTPUT [.

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 8 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 07:28:49 + Build duration: 9 min 16 sec and counting JUnit Tests Na

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 07:28:49 + Build duration: 16 min and counting JUnit Tests Name

D9402: Fix error in WaylandSurface::testDisconnect

This revision was automatically updated to reflect the committed changes. Closed by commit R127:edefb5629f6d: Fix error in WaylandSurface::testDisconnect (authored by davidedmundson). Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland CHAN

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/9/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.7 Date of build: Tue, 19 Dec 2017 07:45:44 + Build duration: 4 min 58 sec and counting CONSOLE OUTPUT [.

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/7/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 19 Dec 2017 07:45:46 + Build duration: 8 min 17 sec and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 9 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/9/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 19 Dec 2017 07:45:45 + Build duration: 10 min and counting JUnit Tests Name: (r