KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.7 - Build # 10 - Fixed!

2018-01-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.7/10/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.7 Date of build: Mon, 08 Jan 2018 08:06:23 + Build duration: 3 min 34 sec and counting JUnit Tests

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!

2018-01-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Jan 2018 08:06:23 + Build duration: 3 min 34 sec and counting JUnit Test

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 6 - Fixed!

2018-01-08 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 08 Jan 2018 08:06:23 + Build duration: 5 min 48 sec and counting JUnit T

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

2018-01-08 Thread Ralf Habacker
habacker added a comment. In https://phabricator.kde.org/D9669#187313, @habacker wrote: > - 5.42.0 is out, update version to 5.43.0 The patch update demonstrates a surprising phabricator behavior not updating commit messages - where should I report it ? REPOSITORY R241 KIO REV

D9429: Remove unused and duplicated file

2018-01-08 Thread Ralf Habacker
habacker closed this revision. habacker added a comment. patch has been applied REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

2018-01-08 Thread David Faure
dfaure added a comment. As a KDE sysadmin ticket; the sysadmins want to centralize KDE's issues with Phabricator before reporting them upstream (to present a unified front and avoid duplicates). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure,

D8536: Add more hashing algorithms to KPropertiesDialog

2018-01-08 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > checksumswidget.ui:62 > > - MD5: > + Value > Perhaps "Result:"? > checksumswidget.ui:76 > + > + Algorithm > + Shouldn't that have a colon at the end? REPOSITORY R241 KIO REVISION DE

D9729: [KPropertiesDialog] Enable word wrap for checksum description

2018-01-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, elvisangelaccio. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Depending on locale this text can become rather long making the dialog overly wide. TEST PLAN N

D7272: [DropJob] Enable drag and drop in a read-only folder

2018-01-08 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7272 To: chinmoyr, #frameworks, dfaure Cc: mreeves, ngraham

D6832: Integrate new file ioslave in KIO job

2018-01-08 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr, dfaure, #frameworks Cc: mreeves, #frameworks

D6830: Make use of kauth helper in copy method of file ioslave

2018-01-08 Thread Chinmoy Ranjan Pradhan
chinmoyr added a comment. ping REPOSITORY R241 KIO BRANCH 6830 REVISION DETAIL https://phabricator.kde.org/D6830 To: chinmoyr, dfaure, #frameworks Cc: elvisangelaccio, #frameworks

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

2018-01-08 Thread Ralf Habacker
habacker added a comment. thanks for this pointer, see T7711 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

2018-01-08 Thread David Faure
dfaure added a comment. In https://phabricator.kde.org/D9669#187624, @habacker wrote: > thanks for this pointer, see T7711 FYI, I can't, it's a "private" issue by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcoo

D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file

2018-01-08 Thread Ralf Habacker
habacker added a comment. Add you as subscriber. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks

D9712: balooctl status: produce parseable output

2018-01-08 Thread Michael Heidelbach
michaelh updated this revision to Diff 24943. michaelh added a comment. - Localized messages - Sending error messages to stderr REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9712?vs=24888&id=24943 BRANCH ctl REVISION DETAIL https://phabricator.kde.or

D9712: balooctl status: produce parseable output

2018-01-08 Thread Michael Heidelbach
michaelh marked 2 inline comments as done. michaelh added inline comments. INLINE COMMENTS > lueck wrote in statuscommand.cpp:108 > > The only thing translated in this function is the filename. I am new to > > this, but I think that is the only item that does not need translation. > > It shoul

D9734: [KFileItemActions] Allow specifying the number of selected files required for an action

2018-01-08 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, dfaure, michaelh, mlaurent. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This was mostly prompted by https://phabricator.kde.org/D9698 since Kompare can only co

D9749: Simplify code: return early to reduce indentation depth

2018-01-08 Thread Milian Wolff
mwolff created this revision. mwolff added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9749

D9750: ExpandingWidgetModel: find the right-most column based on location

2018-01-08 Thread Milian Wolff
mwolff created this revision. mwolff added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This fixes the width calculation for the argument hint completio

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!

2018-01-08 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/16/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Jan 2018 23:49:41 + Build duration: 4 min 14 sec and counting JUnit Tests Name: (