D9987: Lessen log spam by not checking for existence of file with empty name

rkflx created this revision. rkflx added a reviewer: Frameworks. Restricted Application added a project: Frameworks. rkflx requested review of this revision. REVISION SUMMARY Calls to `QFile::exists()` while starting a Plasma session resulted in `Empty filename passed to function` being logged

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added inline comments. INLINE COMMENTS > ktooltipwidget.cpp:147 > } else { > -y = rect.top() - size.height() - margin; > +y = rect.top() - size.height() + margin; > } This one is giving me headaches. By all logic it should be -margin. The resul

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added inline comments. INLINE COMMENTS > cfeck wrote in ktooltipwidget.cpp:155 > I don't understand. Either + or - is right here, but not both. Are you saying > that you don't want to correct it at the second place, just because tests did > not reveal a bug? > Are you saying that you

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 93 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/93/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 20 Jan 2018 03:52:42 + Build duration: 36 min and counting JUnit Tests Name: (root) Faile

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/74/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 20 Jan 2018 03:52:42 + Build duration: 21 min and counting JUnit Tests Name: (root)

D9973: ktooltipwidget: Fix tooltip positioning

cfeck added inline comments. INLINE COMMENTS > michaelh wrote in ktooltipwidget.cpp:155 > As depicted here > > long comments also get truncated. As a consequence this par

Re: A new tier1 for icontheme.rcc handling

On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth wrote: > Hi everyone. Hi Hannah, > > Only some few of you will be aware of KIconThemes ability to load binary > icon themes automagically. > > https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48 > > The code looks for a icontheme.rcc

D9468: Refactor Solid::NetworkingPrivate to have a shared and platform specific implementation

habacker added a comment. see also https://phabricator.kde.org/D9831 REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D9468 To: habacker, dfaure Cc: #frameworks

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.7/22/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.7 Date of build: Fri, 19 Jan 2018 22:30:49 + Build duration: 25 min and counting JUnit Tests

D9404: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill' was not declared in this scope"

This revision was automatically updated to reflect the committed changes. Closed by commit R239:4b70fd9ae983: Fix mingw compile error "src/kdeui/kapplication_win.cpp:212:22: error: 'kill'… (authored by habacker). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 Date of build: Fri, 19 Jan 2018 22:30:49 + Build duration: 5 min 57 sec and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/16/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 22:30:49 + Build duration: 5 min 14 sec and counting J

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb resigned from this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9824 To: mwolff, dfaure, #kdevelop, markg, aaronpuchert Cc: aaronpuchert, bcooksley, zimmerman, markg, #frameworks

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

aaronpuchert accepted this revision. aaronpuchert added a comment. @rjvbb You certainly have a point when you say that there are more deficits to address, but nothing will ever get done unless someone does it. Nobody here is claiming that this solves all problems, but I don't see how it would

D9983: Don't stat(/etc/localtime) between read() and write() copying files

jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY CCBUG: 384561 Unfortunately, QDateTime::currentDateTime() checks /etc/localtime each time it is called. Ch

D9973: ktooltipwidget: Fix tooltip positioning

ngraham added a comment. If you upload individual .webm videos, they'll play inline. I like SimpleScreenRecorder for my screen recording needs. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham

D9973: ktooltipwidget: Fix tooltip positioning

michaelh added a comment. Shall I upload some example files here? Truncated videos of course. If so single files or a zipped pack? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham Cc: cfeck

D9973: ktooltipwidget: Fix tooltip positioning

ngraham added a comment. Everything seems to work in testing, though I'll admit I have a hard time reproducing the original bug, not being a heavy user of Dolphin's Tooltips. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio,

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

dfaure added a comment. > What is slow in my experience is feeding a KDW instance. That is part of the benchmark, see KDirWatch_UnitTest::benchCreateWatcher(). So the door is open for further improvements in that area. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

rjvbb added a comment. David Faure wrote on 20180119::08:33:32 re: "https://phabricator.kde.org/D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry" > Then why didn't you open XXX yourself to look for XXX like I did? It's not rocket science, and

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 150 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/150/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 19 Jan 2018 10:21:52 + Build duration: 7 min 7 sec and counting

KDE CI: Frameworks kirigami kf5-qt5 SUSEQt5.10 - Build # 36 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kirigami kf5-qt5 SUSEQt5.10 Date of build: Fri, 19 Jan 2018 10:21:52 + Build duration: 4 min 31 sec and counting JUnit Tests Na

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.9/29/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 19 Jan 2018 10:21:52 + Build duration: 57 sec and counting

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/1/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Fri, 19 Jan 2018 09:51:25 + Build duration: 25 min and counting CONSOLE OUTPUT [...trunca

D9973: ktooltipwidget: Fix tooltip positioning

michaelh marked an inline comment as done. michaelh added inline comments. INLINE COMMENTS > cfeck wrote in ktooltipwidget.cpp:155 > Does this also need to be adjusted to ' + margin'? Or was the change above > accidential? As depicted here

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/1/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 19 Jan 2018 09:51:24 + Build duration: 2 min 56 sec and counting CONSOLE OUT

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/1/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Fri, 19 Jan 2018 09:51:26 + Build duration: 3 min 12 sec and counting JUnit Tests Name

D8652: Add supported transformations to OutputDevice

sebas added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. Dingdong? REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma, sebas, davidedmunds

D9973: ktooltipwidget: Fix tooltip positioning

michaelh updated this revision to Diff 25626. michaelh added a comment. Removed obsolete include REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9973?vs=25613&id=25626 BRANCH tooltip (branched from master) REVISION DETAIL https://phabricator.kde

D9808: fix incorrect emission of signals by kLineEdit

dfaure closed this revision. dfaure added a comment. Pushed in https://commits.kde.org/kcompletion/31f226116f99bcf40ddc67fe6328594d5fb46222, thanks for the contribution! Keep 'em coming ;-) REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9808 To: dweatherill, #

D9973: ktooltipwidget: Fix tooltip positioning

michaelh retitled this revision from "[kwidgetsaddons] Fix tooltip positioning" to "ktooltipwidget: Fix tooltip positioning". michaelh edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9973 To: michaelh, elvisangelaccio, #framew

D9959: baloosearch: Send summary to stderr

michaelh retitled this revision from "[baloosearch] Send summary to stderr" to "baloosearch: Send summary to stderr". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9959 To: michaelh, #frameworks, vhanda, smithjd, broulik, lbeltrame

D9958: balooctl status: Produce parseable output

michaelh retitled this revision from "Parseable output for balooctl status" to "balooctl status: Produce parseable output". michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9958 To: michaelh, #frameworks, vhanda, smithjd, lbelt

D9966: [KIO] Fix issues with sharing of file descriptor

dfaure added a comment. Note: if someone wants to use XDG_RUNTIME_DIR with Qt, use QStandardPaths::RuntimeLocation (which includes the proper security checks for that directory, and fallbacks). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #framewo

D9824: Optimize inotify KDirWatch backend: map inotify wd to Entry

dfaure added a comment. In https://phabricator.kde.org/D9824#193179, @rjvbb wrote: > > That's not applicable. > > Did you read my actual, original request? If so you'd have seen that it's satisfied by this answer. Then why didn't you open kdirwatch.cpp yourself to look for m_