BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.9/10/
Project:
Frameworks purpose kf5-qt5 WindowsMSVCQt5.9
Date of build:
Thu, 25 Jan 2018 08:34:52 +
Build duration:
13 min and counting
JUnit Tests
rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.
LGTM.
The examples seem to have a circular runtime dependency on (at least)
plasma-desktop. Is that just an opportunistic dependency (= they'd work fine
you'd only just installed plasma-
chinmoyr updated this revision to Diff 25941.
chinmoyr added a comment.
1.Change errno value just before execWithPrivilege call
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9966?vs=25897&id=25941
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
chinmoyr added inline comments.
INLINE COMMENTS
> file_unix.cpp:117
> +errno = err;
> +
> if (auto err = execWithElevatedPrivilege(OPEN, path, flags, mode)) {
@fvogt I think the errno assignment should be fine here?
Except this one case, the function call whose errno value we are inter
dfaure accepted this revision.
REPOSITORY
R241 KIO
BRANCH
firstChildUrl (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D10071
To: jtamate, #frameworks, dfaure
Cc: ngraham
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:805b295541db: Change an assert to do as the function
documentation tells (authored by jtamate).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10071?vs=25907&id=25955
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/77/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 25 Jan 2018 18:48:40 +
Build duration:
9 min 8 sec and counting
JUnit Tests
Name: (r
PureTryOut added a comment.
@bcooksley well I'd love to add a reviewer, but I'm not sure who?
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10072
To: PureTryOut
Cc: bcooksley, #frameworks
fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> chinmoyr wrote in file_unix.cpp:117
> @fvogt I think the errno assignment should be fine here?
> Except this one case, the function call whose errno value we ar
bshah added subscribers: vkrause, bshah.
bshah added a reviewer: vkrause.
bshah added a comment.
Adding @vkrause as reviewer who is listed as maintainer in metainfo.yaml
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D10072
To: PureTryOut, vkrause
Cc: bsh
michaelh created this revision.
michaelh added reviewers: elvisangelaccio, ngraham, vhanda, smithjd, Dolphin,
Frameworks.
michaelh requested review of this revision.
REVISION SUMMARY
Prepare fixing bug 388583
Make signal emission more obvious
Make is easier to distinguish synchronous and as
ngraham edited the summary of this revision.
REPOSITORY
R824 Baloo Widgets
REVISION DETAIL
https://phabricator.kde.org/D10105
To: michaelh, elvisangelaccio, ngraham, vhanda, smithjd, #dolphin, #frameworks
michaelh edited the summary of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9973
To: michaelh, elvisangelaccio, #frameworks, #dolphin, ngraham
Cc: cfeck
smithjd created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
smithjd requested review of this revision.
REVISION SUMMARY
If the database exists in the old XDG Data location, migrate it to the XDG
cache location.
REPOS
ngraham added a subscriber: michaelh.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10106
To: smithjd
Cc: michaelh, ngraham, #frameworks
fredrik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10090
To: aacid, fredrik
Cc: #frameworks
ltoscano added a comment.
This is a follow up of https://git.reviewboard.kde.org/r/129605/ (and the
related discussion)
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10106
To: smithjd
Cc: ltoscano, michaelh, ngraham, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:a6c2b89ed3e8: Downgrade not finding smb.conf from warning
to debug (authored by aacid).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10090?vs=25919&id=25965
REVISION
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/78/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Thu, 25 Jan 2018 21:49:05 +
Build duration:
5 min 56 sec and counting
JUnit Tests
Name: (
michaelh added a comment.
If no one objects, I'm going to land this on Saturday.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9989
To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham
michaelh retitled this revision from "tools: Make all output messages
translatable " to "baloo-tools: Make all output messages translatable ".
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D9989
To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham
romangg added inline comments.
INLINE COMMENTS
> component.cpp:251
> {
> Q_ASSERT(shortcut.context()->component() == this);
> // In production mode do nothing
Also always false.
REPOSITORY
R268 KGlobalAccel
REVISION DETAIL
https://phabricator.kde.org/D10081
To:
ngraham added a comment.
Looks like this revision and the two that depend on it have all been accepted
and are ready to land!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: elvisangelaccio, mlaurent, aacid, ngraham, #frameworks
ngraham added a comment.
FWIW I'm in favor of this. XDG_CACHE_HOME seems appropriate since the data
is easily regenerate-able, and we try to move the existing DB to the new
location to prevent a re-index.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D10106
To: smi
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/79/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Fri, 26 Jan 2018 04:06:26 +
Build duration:
10 min and counting
JUnit Tests
Name: (root)
25 matches
Mail list logo