D10054: Fix: View jumps when Scroll past end of document is enabled

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Then lets reopen it. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10054 To: dhaumann, cullmann Cc: rikmills, #frameworks, michaelh, kevinapavew,

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.7 - Build # 21 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks purpose kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 04:16:46 + Build duration: 4 min 24 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.7/44/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.7 Date of build: Tue, 13 Feb 2018 02:20:01 + Build duration: 5 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/49/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Tue, 13 Feb 2018 02:20:01 + Build duration: 5 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 33 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/33/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 13 Feb 2018 02:20:01 + Build duration: 4 min 32 sec and counting JUnit

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works great, thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9912 To: broulik, dfaure, ngraham Cc: ngraham, #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

markg marked 2 inline comments as done. markg added a comment. I'm not afraid of the compiler generating wrong code. That is the least of my worries :) What i am afraid of (which is why i suggested the copy test) is a wrong optimization at some point (like adding a pointer member but

D10414: Add move semantics support to KIO::UDSEntry.

markg updated this revision to Diff 27028. markg added a comment. Fix a typo and replace QCOMPARE with QVERIFY for the file open check. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10414?vs=26868=27028 BRANCH udsentry_reductions REVISION DETAIL

D10444: Improve KLanguageButton::insertLanguage when no name is passed

aacid updated this revision to Diff 27027. aacid added a comment. fix suggestion by Aleix REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10444?vs=26924=27027 BRANCH arcpatch-D10444_1 REVISION DETAIL https://phabricator.kde.org/D10444 AFFECTED

D10444: Improve KLanguageButton::insertLanguage when no name is passed

aacid added inline comments. INLINE COMMENTS > apol wrote in klanguagebutton.cpp:148 > Why `QStringLiteral("locale") + QLatin1Char('/')`? Because i wrote that as result of copy, i'll fix it. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D10444 To: aacid Cc:

D10365: New icon for Elisa music player

mmustac added a comment. Old-school rules! Also just think of the floppy  disk icon which is mostly everywhere the save icon. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10365 To: paullesur, #breeze, #vdg, #elisa, andreaska, mgallien Cc:

D10054: Fix: View jumps when Scroll past end of document is enabled

rikmills added a comment. This change appears to cause ktexteditor to fail it's vimode_completion autotests. From KDE CI: https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/35/testReport/junit/(root)/TestSuite/vimode_completion/ Ubuntu autotests: F5707888:

D10450: Generate a custom target in kcoreaddons_desktop_to_json

rakuco requested changes to this revision. rakuco added a comment. This revision now requires changes to proceed. @kossebau's right: the problem lies in `lookandfeeltool` depending on `kcm.cpp`, while the `kcoreaddons_desktop_to_json()` call makes the `kcm_lookandfeel` target depend on the

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

ngraham added a comment. The Places panel items are always visible without a submenu, so there should never be a situation where the menu consists entirely of submenus. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc:

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

abetts added a comment. Will this hide "All" menu items or will it hide after a certain amount of them are in the menu? For example, it will turn into a sub menu after 3 items? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

michaelh added a comment. +1 Looking forward to it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: michaelh, ngraham

D10464: Initialize m_actualGroup to NormalColorGroup

apol created this revision. apol added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. apol requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10464 AFFECTED FILES

D9912: [KNewFileMenu] KDirNotify::emitFilesAdded after storedPut

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9912 To: broulik, dfaure Cc: #frameworks, michaelh

D10462: Android toolchain: add ANDROID_COMPILER_PREFIX variable.

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D10462 To: dfaure, apol, mart Cc: #build_system, #frameworks, michaelh

D10329: [KUrlNavigatorPlacesSelector] Put categories into submenus

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10329 To: broulik, #vdg, #frameworks, dfaure Cc: ngraham, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

kossebau added a subscriber: kfunk. kossebau added a comment. In D10450#204762 , @adridg wrote: > In D10450#204623 , @kossebau wrote: > > > "This (hopefully) fixes the build failure noticed in the

D10462: Android toolchain: add ANDROID_COMPILER_PREFIX variable.

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D10462 To: dfaure, apol, mart Cc: #build_system, #frameworks, michaelh

D10462: Android toolchain: add ANDROID_COMPILER_PREFIX variable.

dfaure created this revision. dfaure added reviewers: apol, mart. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. dfaure requested review of this revision. REVISION SUMMARY For ARM it's not necessary, but when building

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/60/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Feb 2018 13:37:48 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/63/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 Date of build: Mon, 12 Feb 2018 13:37:48 + Build duration: 9 min 32 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/36/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Feb 2018 13:37:48 + Build duration: 8 min 17 sec and counting

D10444: Improve KLanguageButton::insertLanguage when no name is passed

apol added inline comments. INLINE COMMENTS > klanguagebutton.cpp:148 > if (name.isEmpty()) { > -text = languageCode; > -QLocale locale(languageCode); > -if (locale != QLocale::c()) { > -text = locale.nativeLanguageName(); > -} else { > -

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3e4b26452aeb: Make sure the FrameSvg and Svg instances have the right devicePixelRatio (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D10420 To: apol, #plasma, hein Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai,

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

apol added a comment. In D10420#204235 , @hein wrote: > Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.) > > Otherwise makes sense (and finally fixes some Wayland

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

dfaure added a comment. Come on, this is fun! Well, unless you feel like I took the fun out of it by providing a solution... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. /o\ I don't like life anymore REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10405 To: hein, dfaure, davidedmundson, mart, ngraham Cc: #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

dfaure added a comment. The statics can be refactored, if they're internal ;) What's more troublesome is the KRun instance might have gone away by the time KProcessRunner ::slotProcessExited is called, though (which is why it's done in a different class). So maybe what's needed is

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

hein added a comment. @dfaure I don't see how the virtual thing is going to work - there's numerous static affected codepaths so there's no 'this' to pass down to call the non-static error handler on. I could add a new "silent" RunFlag and pass that around to quiet the message box

D10072: Add APKBUILD to be highlighted as a Bash file

bshah added a comment. In D10072#204816 , @ltoscano wrote: > I suggest to push a revert and push it again with the right metadata. done. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To:

D10072: Add APKBUILD to be highlighted as a Bash file

ltoscano added a comment. I suggest to push a revert and push it again with the right metadata. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: ltoscano, dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

bshah added a comment. Uhm sorry, arc screwed up author metadata :-( but submitted patch anyway. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10072 To: PureTryOut, vkrause Cc: dhaumann, bshah, vkrause, bcooksley, #frameworks, michaelh

D10072: Add APKBUILD to be highlighted as a Bash file

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7bafdc592040: Add APKBUILD to be highlighted as a Bash file (authored by bshah). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10072?vs=25985=26985

D8917: Reduce the amount of spurious property changes on ColorScope

dfaure added inline comments. INLINE COMMENTS > colorscope.h:131 > +QObject *const m_parent; > +Plasma::Theme::ColorGroup m_actualGroup; > valgrind says this member isn't initialized, please fix. http://www.davidfaure.fr/2018/colorscope_valgrind_log.txt REPOSITORY R242 Plasma

D10437: Limit the use of file.so for privilege operation to one application

dfaure added a comment. Indeed the sender could definitely fake the PID. One could generate and send a sha1 and store it in the slave (and send it as metadata with every command), but this can still be sniffed. I assume the KAuth security principle is that an intruder (who would have

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 130 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/130/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Mon, 12 Feb 2018 08:46:41 + Build duration: 17 min and counting JUnit Tests Name: (root)

D10450: Generate a custom target in kcoreaddons_desktop_to_json

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure Cc: adridg, kossebau, #frameworks,

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 112 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/112/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 12 Feb 2018 08:46:41 + Build duration: 9 min 6 sec and counting JUnit Tests Name:

D10450: Generate a custom target in kcoreaddons_desktop_to_json

adridg added a comment. In D10450#204623 , @kossebau wrote: > "This (hopefully) fixes the build failure noticed in the FreeBSD (and some linuxes)" - leaves the question: why should it exactly fix it? :) From reading the CMake

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/132/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 12 Feb 2018 08:46:41 + Build duration: 5 min 37 sec and counting JUnit Tests Name:

D10450: Generate a custom target in kcoreaddons_desktop_to_json

adridg added a comment. Associated bug https://bugs.kde.org/show_bug.cgi?id=389982 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10450 To: tcberner, #freebsd, mpyne, bshah, dfaure Cc: adridg, kossebau, #frameworks, michaelh

D10405: Don't proceed in runCommandInternal if the executable doesn't exit

dfaure added a comment. Yes. Well, you can't add new virtual methods, but these two already exist: virtual void handleInitError(int kioErrorCode, const QString ); virtual void handleError(KJob *job); I think you should be able to (ab)use the first one for this purpose.