D11204: Support NTFS hidden files

rominf created this revision. rominf added a reviewer: Dolphin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. rominf requested review of this revision. REVISION SUMMARY This patch implements function isHiddenNtfs which checks extended

D11204: Support NTFS hidden files

rominf edited the summary of this revision. rominf added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks Cc: #frameworks, #dolphin, michaelh

D11204: Support NTFS hidden files

rominf edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks Cc: #frameworks, #dolphin, michaelh

D11153: Use correct item URL for Create New context menu

dfaure added a comment. For the git author information, I need your email address. This doesn't seem to appear anywhere in phabricator. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11153 To: prukgaber, #frameworks, dfaure Cc: hein, #frameworks, michaelh

KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/43/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:39:03 + Build duration: 6 min 36 sec and counting JUnit Tests Name: (

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 62 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/62/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:39:42 + Build duration: 21 min and counting JUnit Tests N

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.10/5/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 10 Mar 2018 08:39:27 + Build duration: 21 min and counting JUnit Tes

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/45/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:39:42 + Build duration: 24 min and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:41:02 + Build duration: 29 min and counting JUnit Tests Name: (

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks krunner kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:41:18 + Build duration: 33 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks kservice kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:41:19 + Build duration: 35 min and counting JUnit Tests Name: (

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:39:57 + Build duration: 38 min and counting JUnit T

D11181: Resolve symlinks in QML import paths

This revision was automatically updated to reflect the committed changes. Closed by commit R240:919b6be0004d: Resolve symlinks in QML import paths (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11181?vs=29091&id=29139 REVISI

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/17/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:41:42 + Build duration: 41 min and counting JUnit Tests

D11204: Support NTFS hidden files

broulik added a comment. Shouldn't that rather go into the `file` KIO slave so it sets the `UDS_HIDDEN` attribute? INLINE COMMENTS > kfileitem.h:282 > + */ > +bool isHiddenNtfs() const; > +#endif If we were to go this route (adding it to `KFileItem` which I think we shouldn't), thi

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/29/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:42:02 + Build duration: 47 min and counting JUnit Tests Name: (ro

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 35 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:41:36 + Build duration: 49 min and counting JUnit Tests Name: (

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 165 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/165/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:40:37 + Build duration: 52 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/23/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:01 + Build duration: 56 min and counting JUnit Tests Nam

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:12 + Build duration: 59 min and counting JUnit Tests Name: (root

D11204: Support NTFS hidden files

rominf added a comment. In D11204#222421 , @broulik wrote: > Shouldn't that rather go into the `file` KIO slave so it sets the `UDS_HIDDEN` attribute? I think you are right, but I don't have an idea what "`file` KIO slave" means. Can you

KDE CI: Frameworks krunner kf5-qt5 FreeBSDQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20FreeBSDQt5.9/13/ Project: Frameworks krunner kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:18 + Build duration: 1 hr 1 min and counting JUnit Tests N

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.10/6/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 10 Mar 2018 08:40:17 + Build duration: 1 hr 3 min and counting J

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 145 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/145/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:40:37 + Build duration: 1 hr 2 min and counting JUnit Tests Name: (r

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/93/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 08:41:58 + Build duration: 1 hr 2 min and counting JUnit

D11204: Support NTFS hidden files

anthonyfieroni added inline comments. INLINE COMMENTS > kfileitem.cpp:1116-1136 > +constexpr size_t xattr_size = 1024; > +char strAttr[xattr_size]; > +length = getxattr(fileName, attrName, strAttr, xattr_size); > +if (length <= 0) { > +return false; > +} > + Indeed th

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.9 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.9/14/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:19 + Build duration: 1 hr 4 min and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:39:42 + Build duration: 1 hr 8 min and counting JUnit Tests

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.9/10/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:27 + Build duration: 1 hr 8 min and counting JUnit Tes

D11204: Support NTFS hidden files

rominf updated this revision to Diff 29141. rominf marked an inline comment as done. rominf added a comment. Use delete[] for array deletion REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11204?vs=29137&id=29141 BRANCH ntfs-hidden REVISION DETAIL https://

D11204: Support NTFS hidden files

rominf added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileitem.cpp:1116-1136 > Indeed this should be done in different way, about me > > std::uint64_t attr; > length = getxattr(fileName, attrName, &attr, sizeof attr); > if (length <= 0) { > return false; > } I w

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:41:02 + Build duration: 1 hr 19 min and counting JUnit Tests Name:

KDE CI: Frameworks krunner kf5-qt5 SUSEQt5.9 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20SUSEQt5.9/4/ Project: Frameworks krunner kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:41:18 + Build duration: 1 hr 19 min and counting JUnit Tests Name: (

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/31/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:36 + Build duration: 1 hr 22 min and counting JUnit Tests

D11204: Support NTFS hidden files

ltoscano added a comment. I can't comment on the internal implementation, but: instead of checking for #ifndef Q_OS_WIN shouldn't you check for the availability of xattr? Think about other platforms too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/68/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 08:41:58 + Build duration: 1 hr 30 min and counting

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 - Build # 4 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.9/4/ Project: Frameworks ktexteditor kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:41:24 + Build duration: 1 hr 38 min and counting JUnit Tests

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/6/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:41:36 + Build duration: 1 hr 40 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:40:37 + Build duration: 1 hr 42 min and counting JUnit Tests Name: (root) F

KDE CI: Frameworks threadweaver kf5-qt5 SUSEQt5.9 - Build # 5 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20SUSEQt5.9/5/ Project: Frameworks threadweaver kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 08:42:18 + Build duration: 1 hr 50 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 17 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/17/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 10 Mar 2018 08:40:37 + Build duration: 2 hr 36 min and counting JUnit Tests

D11153: Use correct item URL for Create New context menu

prukgaber added a comment. My email address is tyel...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11153 To: prukgaber, #frameworks, dfaure Cc: hein, #frameworks, michaelh

D11204: Support NTFS hidden files

elvisangelaccio added a comment. In D11204#222427 , @rominf wrote: > In D11204#222421 , @broulik wrote: > > > Shouldn't that rather go into the `file` KIO slave so it sets the `UDS_HIDDEN` attribute

D7909: Add syntax support for Crystal Programming Language

faguilar added inline comments. INLINE COMMENTS > crystal.xml:160 > + > + > + char1="%" context="Find closing macro brace" beginRegion="def block"/> @dhaumann Crystal language supports macros. This macro syntax is a bit different from ru

D11204: Support NTFS hidden files

broulik added a comment. > Can you point me out to appropriate files? Sure, I think you want to add your code to `kio/src/ioslaves/file/file_unix.cpp` (it already has a Unix-specific file) in the `listDir` method: if (ntfshidden) { entry.insert(KIO::UDSEntry::UDS_HIDDEN, t

D11153: Use correct item URL for Create New context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:032709c17f00: Use correct item URL for Create New context menu (authored by prukgaber, committed by hein). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11153?vs=29006

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

hein added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11107 To: hein, #frameworks, broulik, dfaure Cc: michaelh

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/18/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 10 Mar 2018 14:44:26 + Build duration: 59 sec and counting CONSOLE OUTPUT S

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 146 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/146/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 10 Mar 2018 14:44:26 + Build duration: 7 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 166 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/166/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sat, 10 Mar 2018 14:44:26 + Build duration: 9 min 5 sec and counting JUnit Tests Name: (root

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sat, 10 Mar 2018 14:44:26 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed

D11204: Support NTFS hidden files

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. -2 in my opinion. KFileItem should know nothing about NTFS. You already have isHidden in there which should handle it. If it doesn't then you might have found a bug. See

D10694: epubextractor: Handle multiple subjects better

michaelh added a comment. @mgallien: I think we have a beautiful misunderstanding here :-) In D10694#221719 , @michaelh wrote: > This is bad! ... I was referring to baloo inablility to handle string lists and not to this diff.

D11213: balooctl: Introduce list command

michaelh created this revision. michaelh added reviewers: Baloo, Frameworks, smithjd. michaelh added projects: Baloo, Frameworks. michaelh requested review of this revision. REVISION SUMMARY This command list all entries of the database. Information items are - device id - inode - url

D11213: balooctl: Introduce list command

michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11213 To: michaelh, #baloo, #frameworks, smithjd Cc: ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin

D11213: balooctl: Introduce list command

michaelh added inline comments. INLINE COMMENTS > purgelistcommand.cpp:62 > +: QString(); > +const QSharedPointer urlFilter(pattern.isEmpty() ? > nullptr : new QRegularExpression{pattern}); > +qDebug() << "main" I'm not sure, if this is correct/proper usage. > purgelistcommand

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio updated this revision to Diff 29182. elvisangelaccio added a comment. - Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=27940&id=29182 BRANCH undo-deleted-file (branched from master) REVISION DETAIL https://phabric

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks, michaelh

D10312: FileUndoManager: don't delete non-existing local files

elvisangelaccio updated this revision to Diff 29183. elvisangelaccio added a comment. - QLatin1String for concat REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10312?vs=29182&id=29183 BRANCH undo-deleted-file (branched from master) REVISION DETAIL https:/

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29184. smithjd added a comment. - Lessen chattiness. - balooctl: Clarify the prune option description. - Fix document purging. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28987&id=29184 BRANCH master-pu

D9973: ktooltipwidget: Fix tooltip positioning

elvisangelaccio added a comment. Almost there! Just minor comments. INLINE COMMENTS > ktooltipwidgettest.cpp:195 > +QLabel* contentWidget = new QLabel(content); > +const QSize shrinkSize{2 * m_offset, 2 * m_offset}; > +contentWidget->setMaximumSize(m_screenGeometry.size() - shrink

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11107 To: hein, #frameworks, broulik, dfaure Cc: michaelh

D10312: FileUndoManager: don't delete non-existing local files

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH undo-deleted-file (branched from master) REVISION DETAIL https://phabricator.kde.org/D10312 To: elvisangelaccio, dfaure Cc: ngraham, #frameworks, michaelh

Re: KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Still Failing!

Hi all, This is caused by kioslave.exe continuing to hang around post completion of tests, and also resisting being killed by the CI Tooling once testing is all finished. I've therefore disabled the execution of tests for KIO on Windows to prevent this from continuing to occur. Cheers, Ben

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/19/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Sat, 10 Mar 2018 19:41:51 + Build duration: 20 min and counting

D10621: Highlighting Indexer: list of suggestions

dhaumann added a comment. As quick comment: I like the idea of programmatically suggesting better usage of rules. I did not yet fine the time to look into this, so I do not know how much output this currently generates. In any case, for the highlighting files we ship with the syntax high

D7175: Redesign CMake syntax

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. So everyone seems to agree that in general it's a good idea. @turbov Please go ahead and commit. Don't forget to run make test, and possibly update the unit test rererence with aut

D7175: Redesign CMake syntax

dhaumann added a comment. Oh, and btw. sorry that this review took essentially 7 months. Sometimes we simply suck and things go badly wrong :-) REVISION DETAIL https://phabricator.kde.org/D7175 To: turbov, dhaumann, #kate, #framework_syntax_highlighting, vkrause Cc: cullmann, #frameworks,

D10621: Highlighting Indexer: list of suggestions

dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Btw, current generated list finds 1658 issues: https://paste.kde.org/p7iareuxc Not all of them are correct, for instance zsh.xml" line 919 RegExpr candidate for "De

D10621: Highlighting Indexer: list of suggestions

dhaumann added a comment. Just for info: https://kate-editor.org/2018/03/10/improving-syntax-highlighting-files/ tries to reach a broader audience for getting patches. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10621 To: jpoelen, dhaumann Cc: #fram

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 04:22:29 + Build duration: 28 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 167 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/167/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 04:22:29 + Build duration: 30 min and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.9/32/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 04:22:16 + Build duration: 49 min and counting JUnit T

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 147 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/147/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 04:22:29 + Build duration: 52 min and counting JUnit Tests Name: (root)

D11107: [KProtocolInfoFactory] Don't clear cache if it had just been built

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9625a3be6b1: [KProtocolInfoFactory] Don't clear cache if it had just been built (authored by hein). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11107?vs=28916&id=29

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 148 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/148/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Mar 2018 07:00:53 + Build duration: 7 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 168 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/168/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 11 Mar 2018 07:00:53 + Build duration: 10 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/19/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Mar 2018 07:00:53 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed