KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 171 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/171/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 03:21:07 + Build duration: 25 min and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 192 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/192/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 03:21:07 + Build duration: 25 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 42 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/42/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 03:21:07 + Build duration: 24 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 91 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/91/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 03:21:36 + Build duration: 14 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/116/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 03:21:36 + Build duration: 11 min and counting JUnit

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 39 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/39/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 03:21:17 + Build duration: 8 min 18 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.9/22/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 03:21:17 + Build duration: 6 min 8 sec and counting JUnit Tests

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 45 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/45/ Project: Frameworks kpackage kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 03:21:17 + Build duration: 3 min 1 sec and counting JUnit Tests

D11361: add a version containmentForScreen with activity

2018-03-29 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Either Corona tracks which containment are on which containment or ShellCorona does. Having QHash m_desktopContainments; in

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-29 Thread Christoph Feck
cfeck added a comment. Otherwise looks good. Maybe needs more feedback from testers. INLINE COMMENTS > kiconloader.cpp:1264 > { > +return loadIcon(_name, group, 1.0 /*scale*/, size, state, overlays, > path_store, canReturnNull); > +} indent > kicontheme.cpp:169 > +} else if (scale >

D11740: ktooltipwidget: Subtract margins from available size

2018-03-29 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > ktooltipwidget.cpp:183 > d->addWidget(content); > +const auto marginSize = QSize{ > +2 * content->style()->pixelMetric(QStyle::PM_DefaultTopLevelMargin), Call me old-school, but I prefer to see the type before the variable name,

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.10/36/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 30 Mar 2018 00:18:30 + Build duration: 12 min and counting JUnit Tests

KDE CI: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 - Build # 11 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20SUSEQt5.9/11/ Project: Frameworks kwidgetsaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 30 Mar 2018 00:18:30 + Build duration: 8 min 53 sec and counting JUnit

KDE CI: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20FreeBSDQt5.9/28/ Project: Frameworks kwidgetsaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 30 Mar 2018 00:18:30 + Build duration: 6 min 56 sec and counting

D11346: Only set iconText() if actually changed

2018-03-29 Thread Christoph Feck
This revision was automatically updated to reflect the committed changes. Closed by commit R236:7fe64f532d38: [KAcceleratorManager] Only set iconText() if actually changed (authored by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Nathaniel Graham
ngraham marked 2 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Huon Imberger
huoni added a comment. FWIW, I run Arch, and never use Desktop View and therefore the Desktop folder. I //do// have `~/Desktop`, but I do not have the places entries by default. I definitely +1 this change, but it has to be robust and deal with any combination of pre-existing distro

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 30891. ngraham added a comment. Only create user place bookmarks if their target directories already exist CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11768?vs=30799=30891 BRANCH add-desktop-and-downloads (branched from master) REVISION

Changes to networkmanager-qt - breakage in plasma-workspace

2018-03-29 Thread Ben Cooksley
Hi Jan, It seems that as part of your recent changes to networkmanager-qt to increase the dependency to 1.0.0 you've made some other changes which mean the appropriate include paths are no longer being provided to projects that depend on networkmanager-qt. This has the unfortunate effect that

D11740: ktooltipwidget: Subtract margins from available size

2018-03-29 Thread Michael Heidelbach
michaelh updated this revision to Diff 30888. michaelh edited the summary of this revision. michaelh added a comment. - Apply suggested changes REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11740?vs=30703=30888 BRANCH restrict_size REVISION

D11740: ktooltipwidget: Subtract margins from available size

2018-03-29 Thread Elvis Angelaccio
elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ktooltipwidgettest.cpp:33-37 > +void initStyle() { > +// Change manually to test available styles > +//

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 15 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 19:23:45 + Build duration: 4 min 24 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/71/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 19:24:36 + Build duration: 2 min 2 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 67 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/67/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 19:24:15 + Build duration: 2 min 8 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/70/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 19:18:58 + Build duration: 5 min 36 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 14 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/14/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 19:18:58 + Build duration: 4 min 44 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 66 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/66/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 19:18:58 + Build duration: 2 min 11 sec and counting JUnit

D11461: rename 64 px icons added for elisa

2018-03-29 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0f7c93f1b7e8: rename 64 px icons added for elisa (authored by astippich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11461?vs=29851=30869#toc REPOSITORY R266 Breeze Icons CHANGES SINCE

D10292: change 32px icons for playlist shuffle and repeat

2018-03-29 Thread Alexander Stippich
This revision was automatically updated to reflect the committed changes. Closed by commit R266:f0a96f5f85cb: change 32px icons for playlist shuffle and repeat (authored by astippich). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10292?vs=29110=30868

D10292: change 32px icons for playlist shuffle and repeat

2018-03-29 Thread Alexander Stippich
astippich added a comment. Thanks a lot! REPOSITORY R266 Breeze Icons BRANCH playlist_shuffle_repeat REVISION DETAIL https://phabricator.kde.org/D10292 To: astippich, #breeze, #vdg, andreaska, andreask, ngraham Cc: bcooksley, andreask, ngraham, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 191 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/191/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 17:07:27 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 41 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/41/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 17:07:28 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 170 - Still unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/170/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 17:07:27 + Build duration: 9 min 53 sec and counting JUnit Tests Name:

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Nathaniel Graham
ngraham added a comment. I sent an email to Renato asking if he can resolve the test failures. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg Cc: markg, fabiank, progwolff, broulik, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

2018-03-29 Thread Roman Inflianskas
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f1ab805c4ebc: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa (authored by rominf). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-29 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, davidedmundson, plasma-devel, #frameworks,

D11784: Fix duplicate lgpl-notice/gpl-notice/fdl-notice

2018-03-29 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R238:e932059b349b: Fix duplicate lgpl-notice/gpl-notice/fdl-notice (authored by lueck). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11784?vs=30852=30860 REVISION

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Mark Gaiser
markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. I don't know why, but i already have this by default in my Dolphin... (ArchLinux user here, i don't think they add it explicitly as they try to stay as true to upstream as

D10694: epubextractor: Handle multiple subjects better

2018-03-29 Thread Michael Heidelbach
michaelh added a comment. Finally I understood how those multiple `add()`s were meant and it makes more sense now. We're still not good to go because of this: $ balooctl index test.epub Indexing ~/frameworks/kfilemetadata/autotests/samplefiles/test.epub File(s) indexed

D10694: epubextractor: Handle multiple subjects better

2018-03-29 Thread Michael Heidelbach
michaelh updated this revision to Diff 30858. michaelh edited the summary of this revision. michaelh added a comment. - Add multiple properies to map REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10694?vs=27632=30858 BRANCH multi-subject

D11786: Fix returning of data in the helper example

2018-03-29 Thread Alexander Volkov
volkov added a reviewer: Frameworks. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D11786 To: volkov, #frameworks Cc: #frameworks, michaelh, ngraham

D11786: Fix returning of data in the helper example

2018-03-29 Thread Alexander Volkov
volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. volkov requested review of this revision. REVISION SUMMARY ActionReply::data() returns a value, not a reference, so its modifications will be lost. Use

D11783: RFC: [DataContainer] Batch repeated calls of checkForUpdate()

2018-03-29 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Will play around with `setNeedsUpdate(true)` in the mpris dataengine instead. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11783 To: broulik, #plasma, davidedmundson Cc: davidedmundson,

D11783: RFC: [DataContainer] Batch repeated calls of checkForUpdate()

2018-03-29 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. 1. I think it's something that needs to be opt-in, so under a different method name 2. plasma already has that :D checkForUpdate vs scheduleSourcesUpdated

D11784: Fix duplicate lgpl-notice/gpl-notice/fdl-notice

2018-03-29 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Uh /me facepalms REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D11784 To: lueck, #documentation, ltoscano Cc: ltoscano, #frameworks, kde-doc-english,

D11784: Fix duplicate lgpl-notice/gpl-notice/fdl-notice

2018-03-29 Thread Burkhard Lück
lueck created this revision. lueck added a reviewer: Documentation. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, Frameworks. lueck requested review of this revision. REVISION SUMMARY revert wrong commit R760462

D11783: RFC: [DataContainer] Batch repeated calls of checkForUpdate()

2018-03-29 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY A single call is processed immediately but any additional calls

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Nathaniel Graham
ngraham added a comment. In D11768#236365 , @fabiank wrote: > In D11768#236349 , @ngraham wrote: > > > In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Fabian Kosmale
fabiank added a comment. In D11768#236349 , @ngraham wrote: > In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other distros? I'm not sure what is currently done, but I'm pretty sure in Chakra we

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Julian Wolff
progwolff added a comment. In D11768#236348 , @broulik wrote: > > Still, that folder exists by default > > Are you sure? It might be created by some weird startup script or something else. Also, a user can choose to change the location of

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Nathaniel Graham
ngraham added a comment. In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other distros? I think a user who goes and figures out how to make Folder View point to a different folder than ~/Desktop is the kind of user who can figure out how to edit

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Kai Uwe Broulik
broulik added a comment. > Still, that folder exists by default Are you sure? It might be created by some weird startup script or something else. Also, a user can choose to change the location of the Desktop folder. Just wanting to make sure this change (which I'm totally in favor of,

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > broulik wrote in kfileplacesmodel.cpp:245 > Desktop KIO claims that this may return $HOME if the Desktop folder does not > exist, can you confirm/invalidate that? If I delete ~/Desktop, trying to access it via the Places entry gives me a red

D11657: Do not export databasesanitizer by default

2018-03-29 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH hide_sanitizer REVISION DETAIL https://phabricator.kde.org/D11657 To: michaelh, #baloo, davidedmundson Cc: smithjd, #frameworks, ashaposhnikov, michaelh, astippich,

D11657: Do not export databasesanitizer by default

2018-03-29 Thread Michael Heidelbach
michaelh retitled this revision from "Do not export sanitizer by default" to "Do not export databasesanitizer by default". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11657 To: michaelh, #baloo, davidedmundson Cc: smithjd, #frameworks, ashaposhnikov, michaelh,

D11365: also test for value types in taglibextractortest and fix errors

2018-03-29 Thread Michael Heidelbach
michaelh requested changes to this revision. michaelh added a comment. This patch should be split. 1. Test more properties 2. Change return types of ... Also 'fix errors' in the title is misleading because currently kfilemetadata works well. INLINE COMMENTS > astippich wrote in

D11740: ktooltipwidget: Subtract margins from available size

2018-03-29 Thread Michael Heidelbach
michaelh added a comment. Ping REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D11740 To: michaelh, #frameworks Cc: elvisangelaccio, cfeck, michaelh, ngraham

D11649: Fix crash in the file slave

2018-03-29 Thread David Faure
dfaure added a comment. canResume is an "internal" signal, I don't think any apps can do anything meaningful with it, so I don't mind you connecting to it, except that I think this is the wrong layer... BTW did you notice the section about resuming in docs/design.txt? It might help

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 37 - Fixed!

2018-03-29 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/37/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 07:19:14 + Build duration: 7 min 41 sec and counting JUnit

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 40 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/40/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 06:50:59 + Build duration: 27 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 - Build # 36 - Failure!

2018-03-29 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.9/36/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.9 Date of build: Tue, 27 Mar 2018 15:38:33 + Build duration: 1 day 15 hr and counting

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Kai Uwe Broulik
broulik added a comment. +1 INLINE COMMENTS > kfileplacesmodel.cpp:245 > + QStringLiteral("Desktop"), > I18N_NOOP2("KFile System Bookmarks", "Desktop"), > + >

D11643: Fix crash when device emits ready read after job is finished

2018-03-29 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11643 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D11716: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa

2018-03-29 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH fix-ntfs-hidden-files-on-freebsd REVISION DETAIL https://phabricator.kde.org/D11716 To: rominf, #dolphin, kossebau, dfaure Cc: ngraham, bcooksley, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 190 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/190/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 06:50:59 + Build duration: 7 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 169 - Still Failing!

2018-03-29 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/169/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 06:50:59 + Build duration: 3 min 12 sec and counting CONSOLE OUTPUT

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

2018-03-29 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Nice! Works fine in my setup too. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D11776 To: apol, #frameworks, #build_system,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/39/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 29 Mar 2018 06:20:04 + Build duration: 11 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 189 - Still Unstable!

2018-03-29 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/189/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 29 Mar 2018 06:20:04 + Build duration: 7 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 168 - Still Failing!

2018-03-29 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/168/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 29 Mar 2018 06:20:04 + Build duration: 3 min 31 sec and counting CONSOLE OUTPUT