D12242: KJob public signals

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY KIO::KCoreDirLister connects to those signals, they must be public so the new connect syntax compiles. TES

D12226: balooshow: Colorize only when attached to terminal

This revision was automatically updated to reflect the committed changes. Closed by commit R293:094d6e90d4c0: balooshow: Colorize only when attached to terminal (authored by michaelh). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32256&id=32257 REVIS

D12226: balooshow: Colorize only when attached to terminal

michaelh updated this revision to Diff 32256. michaelh added a comment. - Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12226?vs=32193&id=32256 BRANCH no-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D12226 AFFECTED F

D11945: Optimize AppArmor & SELinux highlighting and improve regex

dhaumann added a comment. Out of curiosity: why are you putting multiple items in the same line on the keyword lists? This bloats up the diff and makes a real review so much harder... :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11945 To: nibags,

D11753: baloodb: Add clean command

michaelh added inline comments. INLINE COMMENTS > bruns wrote in databasesanitizer.cpp:344 > do the calls to m_transaction using a wrapper, e.g. > `DatabaseSanitizer::removeDocument(info.id)` I'm assuming you meant `DatabaseSanitizerImpl::removeDocument(info.id)`. If you meant `DatabaseSanitiz

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32255. michaelh added a comment. - Wrap transaction operations REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32254&id=32255 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phabricator

D11753: baloodb: Add clean command

michaelh updated this revision to Diff 32254. michaelh added a comment. - Remove unrelated whitespace change REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11753?vs=32201&id=32254 BRANCH sanitize-clean (branched from master) REVISION DETAIL https://phab

D12218: Remove Reload button from the file dialogs' toolbar

broulik added a comment. Is it also accessible from the menu in the top right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: broulik, rkflx, #dolphin, michaelh, ngraham, bruns

D12228: kdirlister new connect syntax

dfaure added a comment. Signals having changed from protected to public in Qt5, the whole idea of preventing others to emit signals went down the drain anyway. Extending that to KJob we could make the signals non-private there, with strong documentation "don't emit this yourself". REPOSITOR

<    1   2