KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/74/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 20 Apr 2018 05:01:14 + Build duration: 4 min 21 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 AndroidQt5.10 - Build # 10 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20AndroidQt5.10/10/ Project: Frameworks kcoreaddons kf5-qt5 AndroidQt5.10 Date of build: Fri, 20 Apr 2018 05:01:14 + Build duration: 3 min 6 sec and counting CONSOLE

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/18/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 20 Apr 2018 05:01:14 + Build duration: 3 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/19/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Fri, 20 Apr 2018 05:01:14 + Build duration: 1 min 40 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 - Build # 57 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.9/57/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 20 Apr 2018 05:01:14 + Build duration: 1 min 0 sec and counting CONSOLE

Re: KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.10 - Build # 60 - Failure!

On Fri, Apr 20, 2018 at 2:17 AM, Marco Martin wrote: > should be fixed now, the job is blue > Thanks Marco, it's appreciated. Cheers, Ben > > On Thu, Apr 19, 2018 at 11:09 AM, Ben Cooksley wrote: > >> On Thu, Apr 19, 2018 at 12:12 AM, Aleix Pol

D11768: Add Desktop and Downloads to the default list of Places

abetts added a comment. I would say remove search for images audio files and video and move them to the places location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg,

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

abetts added a comment. I gave a +1 to the original idea because I feel that there isn't really much closeness that you can achieve with the open dialog. It is simple, straightforward. If we wanted to do a strict fitt's law follow, then each back and forth icon would be next to each of the

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: abetts, jtamate, broulik, anemeth, rkflx, michaelh, bruns

D12327: Show Detailed Tree View by default

ngraham retitled this revision from "[WIP/open dependencies] Show Detailed Tree View by default" to "Show Detailed Tree View by default". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. ngraham added reviewers: Frameworks, VDG, rkflx. ngraham added a

D12326: In Short View, display icons on top and increase icon size

ngraham added a dependent revision: D12327: Show Detailed Tree View by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: abetts, anemeth, #frameworks, michaelh, bruns

D12218: Remove Reload button from the file dialogs' toolbar

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: abetts, markg, broulik, rkflx, #dolphin, michaelh, bruns

D12327: [WIP/open dependencies] Show Detailed Tree View by default

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12327 To: ngraham Cc: abetts, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

abetts added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added a comment. Better "sort options" icon - https://bugs.kde.org/show_bug.cgi?id=393318 Bring back arrows in menu toolbuttons - https://bugs.kde.org/show_bug.cgi?id=344746 On the arrow issue, apparently this is actually a design decision and not a bug. If others also feel

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham planned changes to this revision. ngraham added a comment. You make a lot of good points, Henrik. One of these days I'll learn that whenever you and I disagree, you're probably right! :-) I'll agree to an icon-only button if we can get a better icon and make Breeze display

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

rkflx added a comment. Hm, now you are getting quite off-topic. I thought we wanted to make sorting easier? In D12337#250147 , @ngraham wrote: > Nevertheless, this needs to be a broader discussion, and we can't address it as a part of the

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added a comment. If I step back, I think one reason why I find myself objecting to icon-only toolbuttons is because of an in-my-opinion unfortunate confluence of factors that make them difficult to distinguish as interactive UI elements: - No border: doesn't actually look like a

D12306: Filepicker dialog proper grid icon layout

rkflx added a comment. Video for the flickering I'm talking about (recorded with no "hacks", adding `-1` will solve it): F5813789: KIO-flickering.webm REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth,

D12306: Filepicker dialog proper grid icon layout

rkflx added inline comments. INLINE COMMENTS > kdiroperator.cpp:2594-2595 > + > +// Subtract 1 px to prevent the last column from missing > +// Reduce 4 more (scaled) pixels to prevent flickering when resizing > the window > +const int viewPortWidth =

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/72/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 19 Apr 2018 22:01:18 + Build duration: 24 min and counting JUnit Tests Name: (root)

D12306: Filepicker dialog proper grid icon layout

rkflx added a comment. In D12306#250116 , @anemeth wrote: > @rkflx the 3px is causing flickering on Oxygen, 4px does not. I don't see this, but I'm also fine with 4px. > Also I can't reproduce the missing last column issue for

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham added a comment. In D12337#249988 , @markg wrote: > Well, the icon certainly is better and without text is much better as well, but i still don't like (nor see the value) of having this sort option that prominent "in your face". >

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 202 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/202/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 22:01:18 + Build duration: 9 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 223 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/223/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 19 Apr 2018 22:01:18 + Build duration: 5 min 44 sec and counting JUnit Tests Name:

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32614. anemeth added a comment. Move scrollbar width correction to viewPortWidth. @rkflx the 3px is causing flickering on Oxygen, 4px does not. Also I can't reproduce the missing last column issue for Oxygen. The itemsInRow == 1 part is for when

D11204: Support NTFS hidden files

ngraham added a comment. Mac build fixed with D12365: getxattr takes 6 parameters in macOS REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11204 To: rominf, #dolphin, #frameworks, dfaure Cc: ngraham, vonreth, kossebau, dfaure,

D12365: getxattr takes 6 parameters in macOS

This revision was automatically updated to reflect the committed changes. Closed by commit R241:87e9e3b68fdc: getxattr takes 6 parameters in macOS (authored by yurikoles, committed by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12365?vs=32612=32613

D12365: getxattr takes 6 parameters in macOS

ngraham added a comment. Thanks! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12365 To: yurikoles, ngraham Cc: #frameworks, michaelh, bruns

D12365: getxattr takes 6 parameters in macOS

yurikoles added a comment. I don't have commit access. My email is yuriko...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12365 To: yurikoles, ngraham Cc: #frameworks, michaelh, bruns

D12365: getxattr takes 6 parameters in macOS

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Feel free to land this diff if you've got commit rights. If not, I need an email address before I can do it for you. REPOSITORY R241 KIO REVISION DETAIL

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a subscriber: Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D11924: Add "SkipSwitcher" to API

sharvey added a subscriber: Plasma. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: #plasma, ngraham, graesslin, apol, #frameworks, michaelh, bruns

D12363: Fix autotest regression after adding SkipSwitcher to API

sharvey added a subscriber: Plasma. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D12363 To: joselema, graesslin, hein, sharvey Cc: #plasma, rikmills, #frameworks, michaelh, bruns

D12365: getxattr takes 6 parameters in macOS

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12365 To: yurikoles, ngraham Cc: #frameworks, michaelh, bruns

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. Polite "bump" for my reviewers. Please see D12363 - the Kubuntu team has had to manually disable some autotests stemming from D11924 . REPOSITORY R127 KWayland REVISION DETAIL

D12365: getxattr takes 6 parameters in macOS

yurikoles created this revision. yurikoles added a reviewer: ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. yurikoles requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12365

D12328: Enable preview by default in the filepicker dialog

ngraham added a comment. Hmm, I'm not sure the kconf update script is working. I just tried out the patch in its current state, and got this: Before: dev@dev-pc:~/repos/kio$ grep Preview ~/.config/kdeglobals Preview Width=269 Previews=true Show Preview=false

D12306: Filepicker dialog proper grid icon layout

rkflx requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/71/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 19 Apr 2018 21:13:53 + Build duration: 6 min 17 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 201 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/201/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 21:13:53 + Build duration: 4 min 59 sec and counting JUnit Tests Name:

D12218: Remove Reload button from the file dialogs' toolbar

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12218 To: ngraham, #frameworks Cc: markg, broulik, rkflx, #dolphin, michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 222 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/222/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 19 Apr 2018 21:13:53 + Build duration: 4 min 43 sec and counting JUnit Tests Name:

D12306: Filepicker dialog proper grid icon layout

rkflx added a comment. Sorry for the back and forth, it seems this is all a bit tricky to get right… Now I get a horizontal scrollbar for small window sizes and big icons (independent from the widget style in use) :( The `5 * devicePixelRatioF` sounds odd, and adding an additional

D12215: Add a "Reload" menu item to KDirOperator's context menu

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks, hein Cc: maximilianocuria, dhaumann, rkflx, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 32611. anemeth added a comment. - Add kconf_update files REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=32603=32611 REVISION DETAIL https://phabricator.kde.org/D12328 AFFECTED FILES CMakeLists.txt

D12215: Add a "Reload" menu item to KDirOperator's context menu

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12215 To: ngraham, #frameworks, hein Cc: maximilianocuria, dhaumann, rkflx, michaelh, bruns

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/44/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 20:57:08 + Build duration: 59 sec and counting JUnit Tests

D11675: use KDE_INSTALL_DATADIR instead of FULL_DATADIR

This revision was automatically updated to reflect the committed changes. Closed by commit R290:ee1ea06d964c: use KDE_INSTALL_DATADIR instead of FULL_DATADIR (authored by bshah, committed by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11675?vs=30487=32610#toc REPOSITORY

D12328: Enable preview by default in the filepicker dialog

rkflx added a comment. In D12328#250057 , @anemeth wrote: > In D12328#249648 , @rkflx wrote: > > > Could not run this yet, but IIRC deleting a key does not need a separate script, you should be able

D12328: Enable preview by default in the filepicker dialog

anemeth added a comment. In D12328#249648 , @rkflx wrote: > Could not run this yet, but IIRC deleting a key does not need a separate script, you should be able to do it inline in the `upd` with `RemoveKey`. how about this then:

D12233: Avoid manipulation of lists with quadratic complexity

jtamate added inline comments. INLINE COMMENTS > pendingfilequeue.cpp:68 > +const auto startRemoving = std::partition(m_cache.begin(), end, > isDescendant); > +for (auto it = startRemoving; it != end; it++) { > +m_pendingFiles.remove(it->path()); According to

D12363: Fix autotest regression after adding SkipSwitcher to API

sharvey added a comment. Also, related patches D11925 and D11926 are still open and uncommitted. I'm unclear if those missing pieces are affecting the autotests. REPOSITORY R278 KWindowSystem REVISION DETAIL

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#250031 , @ngraham wrote: > In fact, perhaps we should consider this new automatically-disable-previews-at-small-sizes behavior to be a replacement for Dolphin's clunky

D12363: Fix autotest regression after adding SkipSwitcher to API

sharvey added a comment. I'm afraid to admit I don't understand it all that well myself. This is my first submission to KWindowSystem. It was supposed to be a straightforward case of "implement `skipSwitcher` just like `skipTaskbar` is implemented". I believe I noted the problems with the

D12353: [API dox] New UI marker @item:valuesuffix

kossebau updated this revision to Diff 32605. kossebau added a comment. add also in kuit handling code REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12353?vs=32571=32605 BRANCH additemvaluesuffixuimaker REVISION DETAIL

D12355: [API dox] New UI marker @info:placeholder

kossebau updated this revision to Diff 32604. kossebau added a comment. add also in kuit handling code REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12355?vs=32572=32604 BRANCH addinfoplaceholderuimarker REVISION DETAIL

D12321: Hide file preview when icon is too small

ngraham added a comment. In D12321#24 , @xyquadrat wrote: > In D12321#249981 , @ngraham wrote: > > > Fabulous. I agree with @rkflx that before committing this, we should also prepare a similar

D12363: Fix autotest regression after adding SkipSwitcher to API

joselema edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D12363 To: joselema, graesslin, hein, sharvey Cc: rikmills, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 32603. anemeth added a comment. Rebase on D12321 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=32512=32603 REVISION DETAIL https://phabricator.kde.org/D12328 AFFECTED

D12363: Fix autotest regression after adding SkipSwitcher to API

joselema created this revision. joselema added reviewers: graesslin, hein, sharvey. joselema added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, I think since this change:

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32602. anemeth added a comment. Remove left in debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32601=32602 BRANCH conditional_preview (branched from master) REVISION DETAIL

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32601. anemeth added a comment. - Hide previews when icons are too small and disable the preview pushbutTO - Remember preview state after closing window REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32596=32601

D12353: [API dox] New UI marker @item:valuesuffix

kossebau added a comment. In D12353#249996 , @aacid wrote: > All the other elements of that list have an entry like > > ./src/kuitmarkup.cpp:281:SET_CUE(InrangeCue, QStringLiteral("inrange")); > > Do we need that too for valuesuffix?

D12321: Hide file preview when icon is too small

xyquadrat added a comment. In D12321#249981 , @ngraham wrote: > Fabulous. I agree with @rkflx that before committing this, we should also prepare a similar patch for Dolphin to unify the behaviors. That would be great, as this would

D12320: add ability to read embedded cover files

astippich added a comment. In D12320#249982 , @michaelh wrote: > -2 > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. It is also disqualified by the fact that it is not in frameworks. I think a nice solution

D12353: [API dox] New UI marker @item:valuesuffix

aacid added a comment. All the other elements of that list have an entry like ./src/kuitmarkup.cpp:281:SET_CUE(InrangeCue, QStringLiteral("inrange")); Do we need that too for valuesuffix? REPOSITORY R249 KI18n BRANCH additemvaluesuffixuimaker REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. In D12156#249977 , @michaelh wrote: > In D12156#249971 , @astippich wrote: > > > In D12156#249951 , @michaelh wrote: > > >

D10694: epubextractor: Handle multiple subjects better

bruns added inline comments. INLINE COMMENTS > michaelh wrote in epubextractor.cpp:85 > I think we should port away from libepub. Multiple titles result in one > ';'-joined string. > Also it seems to be unmaintained. The joined titles is the fault of this epubextractor AFAICS - see

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

markg added a comment. In D12337#249814 , @rkflx wrote: > In D12337#249528 , @rkflx wrote: > > > F5812548: KIO-toolbar-sort-button.png > > > @broulik

D12320: add ability to read embedded cover files

michaelh added a comment. Too bad `ffmpegthumbs` is for videos only. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12320: add ability to read embedded cover files

michaelh added a comment. https://cgit.kde.org/ffmpegthumbs.git/ should be useable. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12321: Hide file preview when icon is too small

ngraham added a comment. Fabulous. I agree with @rkflx that before committing this, we should also prepare a similar patch for Dolphin to unify the behaviors. One quality-of-life enhancement I could see would be to change the tooltip for the preview button to say "Previews are

D12156: implement reading of rating tag

michaelh added a comment. In D12156#249971 , @astippich wrote: > In D12156#249951 , @michaelh wrote: > > > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used

D12321: Hide file preview when icon is too small

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin Cc: sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32596. anemeth added a comment. Remove unintentional changes from D12328 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32546=32596 BRANCH master REVISION DETAIL

D12233: Avoid manipulation of lists with quadratic complexity

michaelh updated this revision to Diff 32595. michaelh added a comment. - Indent REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=32322=32595 BRANCH remove-if (branched from master) REVISION DETAIL https://phabricator.kde.org/D12233 AFFECTED

D12156: implement reading of rating tag

astippich added a comment. In D12156#249951 , @michaelh wrote: > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? It will be used as a fallback when there is no

D12097: Make room for footer and header.

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c6c41b4a97cc: Make room for footer and header. (authored by hein). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12097?vs=31836=32594 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 200 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/200/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 19 Apr 2018 18:35:22 + Build duration: 5 min 31 sec and counting JUnit Tests Name:

D12097: Make room for footer and header.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D12097 To: hein, #kirigami, mart Cc: plasma-devel, #frameworks, michaelh, bruns, apol, davidedmundson, mart, hein

D12234: Update unit tests after removing "this month" and "last month" items

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b526f154d0de: Update unit tests after removing this month and last month items (authored by joselema). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

rkflx added a comment. In D12333#249939 , @jtamate wrote: > Lately, the zoom widget is placed at the bottom in most programs, perhaps it can be moved at the left of the Save/Open Cancel buttons. Nice idea, but if I understood Nate

D12156: implement reading of rating tag

michaelh added a comment. It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks,

D12156: implement reading of rating tag

astippich added a comment. Those formulas didn't work with newly added tests with values from Winamp, Windows Media Player and MediaMonkey. I calculated a linear regression line and this one seems to work with some special case handling REPOSITORY R286 KFileMetaData REVISION DETAIL

D12156: implement reading of rating tag

astippich updated this revision to Diff 32591. astippich added a comment. - simplify REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=32587=32591 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

jtamate added a comment. Lately, the zoom widget is placed at the bottom in most programs, perhaps it can be moved at the left of the Save/Open Cancel buttons. If the mouse distance is a problem, the navigation buttons can be placed at the top right, just where the zoom widget is now.

D10694: epubextractor: Handle multiple subjects better

michaelh added inline comments. INLINE COMMENTS > bruns wrote in epubextractor.cpp:85 > I think we should add each title individually (there may be one per language). > > Dito for all other properties, see below. I think we should port away from libepub. Multiple titles result in one

D12306: Filepicker dialog proper grid icon layout

anemeth added a comment. I see what you are talking now. The reason Oxygen has this issue but Breeze (or others ) not is because `QListView::contentsRect()` is reporting the wrong size. At first I used `QListView::viewport()::width()` to get the size, but it was unreliable and sometimes

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32588. anemeth added a comment. Fix flickering for Oxygen and spacing for very narrow window. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12306?vs=32575=32588 BRANCH master REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. code didn't get prettier, but that's the de-facto standard REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:222-234 > The thing here is that the most common implementation don't allow half star > ratings. Only Mediamonkey does it and that diverges from the rest. Also, the > values are not distributed equidistantly,

D12156: implement reading of rating tag

astippich updated this revision to Diff 32587. astippich added a comment. - implement reading of half star ratings for mp3 and add tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=31987=32587 BRANCH rating REVISION DETAIL

D12326: In Short View, display icons on top and increase icon size

ngraham retitled this revision from "[WIP/open dependencies] In Short View, display icons on top and increase icon size" to "In Short View, display icons on top and increase icon size". ngraham edited the summary of this revision. ngraham added a subscriber: abetts. REPOSITORY R241 KIO

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham edited the summary of this revision. ngraham added a dependency: D12360: Use Tree view for the file browser instead of whatever the default view happens to be set to. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: anemeth, #frameworks,

D12342: Update CMakeLists.txt

michaelh added a reviewer: elvisangelaccio. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D12342 To: michaelh, #baloo, #dolphin, #frameworks, elvisangelaccio Cc: ashaposhnikov, astippich, spoorun

D12222: baloodb: Use complete access filtering for all outputs

michaelh marked an inline comment as done. michaelh added a comment. I'm sorry for making so much noise with all those stupid mistakes. It's probably best for me to let this rest for a few days, relax a little and gain some distance. REPOSITORY R293 Baloo REVISION DETAIL

D12326: [WIP/open dependencies] In Short View, display icons on top and increase icon size

ngraham edited the summary of this revision. ngraham added a dependency: D12358: Use Tree view for the file browser instead of whatever the default view happens to be set to. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12326 To: ngraham Cc: anemeth, #frameworks,

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32580. michaelh added a comment. - That was no typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32579=32580 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

D12222: baloodb: Use complete access filtering for all outputs

michaelh updated this revision to Diff 32579. michaelh added a comment. - Correct typo REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1?vs=32578=32579 BRANCH sanitize-dry (branched from master) REVISION DETAIL https://phabricator.kde.org/D1

  1   2   >