KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 141 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/141/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Mon, 23 Apr 2018 03:28:19 + Build duration: 10 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 116 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/116/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 03:28:20 + Build duration: 5 min 32 sec and counting

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9 - Build # 19 - Failure!

2018-04-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.9/19/ Project: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 03:27:14 + Build duration: 25 sec and counting

D12311: Align lock icon with bold message text; reduce overall size of dialog

2018-04-22 Thread Stefan Brüns
bruns added a comment. In D12311#250731 , @stikonas wrote: > In D12311#250688 , @bruns wrote: > > > Gnome-disks does, and so do other programs. > > > Gnome-disks uses UDisks to do everything

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32861. jpoelen added a comment. I am completely lost with `arc diff`. The command adds files that I did not normally modify in this branch and specifiying a reference commit does not seem to work. I ended up doing everything through a new branch,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32860. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" -

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32855. jpoelen added a comment. - diff with the proper branch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32853=32855 BRANCH new_sql_oracle REVISION DETAIL https://phabricator.kde.org/D11470 AFFECTED FILES

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32853. jpoelen added a comment. - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are restored REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32852=32853 BRANCH

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32852. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" REPOSITORY R216 Syntax

D11925: Add "SkipSwitcher" to API

2018-04-22 Thread Scott Harvey
sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add "SkipSwitcher" to API". REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: #plasma, graesslin, #frameworks, michaelh, bruns

D11925: Add "SkipSwitcher" to API

2018-04-22 Thread Scott Harvey
sharvey added a subscriber: davidedmundson. sharvey added a comment. Removed `[WIP]` from title at suggestion of @davidedmundson . REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: davidedmundson, #plasma, graesslin,

D12306: Filepicker dialog proper grid icon layout

2018-04-22 Thread Henrik Fehlauer
rkflx edited the summary of this revision. REPOSITORY R241 KIO BRANCH grid_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

2018-04-22 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, my patch from above has been applied, so LGTM now. Any additional objections or comments from #frameworks ? If not, I'll commit this

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 140 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/140/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 20:07:33 + Build duration: 2 min 46 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 115 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/115/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 20:07:33 + Build duration: 2 min 30 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 21 - Fixed!

2018-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Apr 2018 19:42:18 + Build duration: 8 min 13 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 73 - Fixed!

2018-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/73/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 19:42:18 + Build duration: 4 min 18 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 77 - Fixed!

2018-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/77/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 19:42:18 + Build duration: 1 min 27 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 - Build # 11 - Fixed!

2018-04-22 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.10/11/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 Date of build: Sun, 22 Apr 2018 19:42:17 + Build duration: 55 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 139 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/139/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 18:36:07 + Build duration: 7 min 37 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 114 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/114/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 18:36:07 + Build duration: 5 min 41 sec and counting

D12378: Properly search for NetworkManager

2018-04-22 Thread Jan Grulich
jgrulich updated this revision to Diff 32836. jgrulich edited the summary of this revision. jgrulich added a comment. Do not use prefix for NM header and remove unnecessary workarounds REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D11137: overflow-menu as view-more-symbolic, and horizontal

2018-04-22 Thread Nathaniel Graham
ngraham added a comment. This change broke the CI: https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/ [ 62%] Building CXX object autotests/CMakeFiles/scalable.dir/scalable_autogen/mocs_compilation.cpp.o

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 230 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/230/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 17:18:57 + Build duration: 23 min and counting JUnit Tests Name: (root)

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R284:fbb5609001ab: Fix KCompletionBox on wayland (authored by apol). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12448?vs=32805=32833 REVISION DETAIL

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Aleix Pol Gonzalez
apol added a comment. In D12448#251908 , @anthonyfieroni wrote: > Why not > > static const auto flags = qGuiApp->platformName() == QLatin1String("wayland") ? Qt::WindowFlags(Qt::ToolTip | Qt::FramelessWindowHint |

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 79 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/79/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Apr 2018 17:18:57 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 208 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/208/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 17:18:57 + Build duration: 12 min and counting JUnit Tests Name:

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. It's a bit cheeky, but it's the only soltuion that doesn't require an invasive patch inverting the way input is eventFiltered. REPOSITORY R284 KCompletion BRANCH

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 229 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/229/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 15:24:42 + Build duration: 6 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 207 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/207/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 15:24:42 + Build duration: 5 min 10 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 78 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/78/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Apr 2018 15:24:42 + Build duration: 4 min 45 sec and counting JUnit Tests Name: (root)

D11768: Add Desktop and Downloads to the default list of Places

2018-04-22 Thread Nathaniel Graham
ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

2018-04-22 Thread Elvis Angelaccio
elvisangelaccio added a comment. +1 One more reason to move this stuff from the Dolphin settings into a KCM... REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg, ngraham, #dolphin

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

2018-04-22 Thread Nathaniel Graham
ngraham removed a dependent revision: D11768: Add Desktop and Downloads to the default list of Places. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson Cc: rkflx, davidedmundson, michaelh, sharvey,

D11768: Add Desktop and Downloads to the default list of Places

2018-04-22 Thread Nathaniel Graham
ngraham removed a dependency: D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview,

D11768: Add Desktop and Downloads to the default list of Places

2018-04-22 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg, fabiank, progwolff,

D11768: Add Desktop and Downloads to the default list of Places

2018-04-22 Thread Nathaniel Graham
ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts,

D11768: Add Desktop and Downloads to the default list of Places

2018-04-22 Thread Nathaniel Graham
ngraham added a comment. Heh, thanks. Renato said he'd fix the tests soon, FWIW. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc:

D11768: Add Desktop and Downloads to the default list of Places

2018-04-22 Thread Mark Gaiser
markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Blocking it any longer seems rude to me :) REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham,

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

2018-04-22 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > jobuidelegate.cpp:229 > widget, > - i18np("Do you really want to delete this item?", > "Do you really want to delete these %1 items?", prettyList.count()), > +

D10980: updated hanle icon

2018-04-22 Thread Andres Betts
abetts added a comment. Just to provide perspective at what the rest of the industry is using, here is a search online: https://www.flaticon.com/search?word=drag REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart Cc: abetts, rkflx,

D10980: updated hanle icon

2018-04-22 Thread Marco Martin
mart added a comment. In D10980#251710 , @ngraham wrote: > In D10980#251709 , @mart wrote: > > > In D10980#251547 , @rkflx wrote: > > > > > Maybe less

D12448: Fix KCompletionBox on wayland

2018-04-22 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. apol requested review of this revision. REVISION SUMMARY On wayland it would immediately disappear, now it doesn't anymore. TEST PLAN Tried kcompletionuitest on

D10980: updated hanle icon

2018-04-22 Thread Nathaniel Graham
ngraham added a comment. In D10980#251709 , @mart wrote: > In D10980#251547 , @rkflx wrote: > > > Maybe less dots?: > > > > F5817550: Screenshot_20180422_111540_less-dots.png

D10980: updated hanle icon

2018-04-22 Thread Marco Martin
mart added a comment. In D10980#251547 , @rkflx wrote: > Maybe less dots?: > > F5817550: Screenshot_20180422_111540_less-dots.png > > (Not sure yet about the size of the triangle.) i like

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 113 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/113/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 12:14:36 + Build duration: 5 min 22 sec and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 138 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/138/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 12:14:36 + Build duration: 2 min 46 sec and counting

D10980: updated hanle icon

2018-04-22 Thread Henrik Fehlauer
rkflx added a comment. Maybe less dots?: F5817550: Screenshot_20180422_111540_less-dots.png (Not sure yet about the size of the triangle.) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10980 To: andreask, mart

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 228 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/228/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 10:47:16 + Build duration: 20 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 206 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/206/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 10:47:16 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 72 - Failure!

2018-04-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/72/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 10:54:51 + Build duration: 3 min 32 sec and counting CONSOLE

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 112 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/112/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 22 Apr 2018 10:52:21 + Build duration: 5 min 35 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 76 - Failure!

2018-04-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/76/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 10:54:51 + Build duration: 57 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 - Build # 10 - Failure!

2018-04-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20AndroidQt5.10/10/ Project: Frameworks breeze-icons kf5-qt5 AndroidQt5.10 Date of build: Sun, 22 Apr 2018 10:54:51 + Build duration: 50 sec and counting CONSOLE

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 20 - Failure!

2018-04-22 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Apr 2018 10:54:51 + Build duration: 58 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/77/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Sun, 22 Apr 2018 10:47:16 + Build duration: 8 min 8 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

2018-04-22 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/137/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Sun, 22 Apr 2018 10:52:21 + Build duration: 2 min 19 sec and counting

D11137: overflow-menu as view-more-symbolic, and horizontal

2018-04-22 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R266:b518d06b25c2: overflow-menu as view-more-symbolic, and horizontal (authored by mart). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11137?vs=28967=32786

D12379: [Containment Interface] Don't enter edit mode when immutable

2018-04-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:a0b7a71a94a7: [Containment Interface] Dont enter edit mode when immutable (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D12379: [Containment Interface] Don't enter edit mode when immutable

2018-04-22 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12379 To: broulik, #plasma, mart Cc: #frameworks, michaelh, bruns

D10863: [KRecentDocument] Use QGuiApplication::desktopFileName()

2018-04-22 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R241:73f3a9bee0d4: [KRecentDocument] Use QGuiApplication::desktopFileName() (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10863?vs=28111=32784

D12439: Add EventDataDecorator::hasEndDateTime()

2018-04-22 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY There can be events which have no duration. Those are

D12438: Fix PlasmaCalendar widget to not mark days with minor events

2018-04-22 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY CalendarEvents::EventData (in KDeclarative) has a property

Re: Required Compiler for KDE Frameworks

2018-04-22 Thread David Faure
On samedi 30 décembre 2017 23:41:01 CEST Dominik Haumann wrote: > Hi, > > on https://community.kde.org/Frameworks/Policies, it says: > > The following minimal compiler versions are supported > by KDE Frameworks: > > - GCC 4.6 > - Clang 3.1 > - VS2012 (MSVC11) > > Is this list really

D10980: updated hanle icon

2018-04-22 Thread Marco Martin
mart added a comment. i would use something on the line of the old icon we had, the grid of dots is very tipical for drag handles, this with every possible direction (maybe also a 4 directions handle one) F5817422: Screenshot_20180422_111540.png

D12423: Install pri file for qmake support & document it in metainfo.yaml

2018-04-22 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R293:5a6aff54fc8a: Install pri file for qmake support document it in metainfo.yaml (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12423?vs=32746=32764#toc REPOSITORY

D12371: fix always reproducible crash

2018-04-22 Thread David Faure
dfaure added a comment. It looks like the issue is that forgetDirs() doesn't find smb:// on the line of code that says `DirectoryDataHash::iterator dit = directoryData.find(urlStr);.` So it goes into early return and doesn't do dirData.listersCurrentlyHolding.removeAll(lister); which

D12424: Install pri file for qmake support & document it in metainfo.yaml

2018-04-22 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R286:5018509d5748: Install pri file for qmake support document it in metainfo.yaml (authored by kossebau). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE