D12545: Set focus on the filename line edit when a file is selected

rkflx added a comment. In D12545#256043 , @anemeth wrote: > I'm thinking about abandoning this revision in favor of proper tab ordering instead. As Nate already said, tabstop ordering would also be good to have. But given that the featur

D12320: add ability to read embedded cover files

astippich updated this revision to Diff 33375. astippich added a comment. - new reader for embedded image data REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12320?vs=32493&id=33375 BRANCH cover_read REVISION DETAIL https://phabricator.kde.org/D

D12320: {RFC] add ability to read embedded cover files

astippich retitled this revision from "add ability to read embedded cover files" to "{RFC] add ability to read embedded cover files". REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12320 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, mic

D12320: {RFC] add ability to read embedded cover files

astippich added a comment. So, this is a next attempt trying to create a solution that works for everyone. It is not yet perfect, but I'd like to get some feedback if such an approach is favorable. A new class is created that will handle the cover art. This way, there won't be any interfer

D12388: Output device color curves correction

romangg added inline comments. INLINE COMMENTS > zzag wrote in outputconfiguration.cpp:184 > Maybe `static_cast`? > > I haven't used wl_array but can't you allocate big enough contiguous chunk of > memory and call memcpy, e.g. > > wl_array wlRed; > > wl_array_init(&wlRed); > auto* red

D12388: Output device color curves correction

romangg updated this revision to Diff 33397. romangg added a comment. - autotests - improve doc - memcpy wl_array REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=32669&id=33397 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https:

D11732: Improve protocols documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R127:272112a07f07: Improve protocols documentation (authored by romangg). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11732?vs=30925&id=33400 REVISION DETAIL http

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/39/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 01 May 2018 14:41:26 + Build duration: 5 min 56 sec and counting JUnit Tests N

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/10/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 01 May 2018 14:41:26 + Build duration: 6 min 0 sec and counting JUnit Tests Name

D10078: Add separate lib KF5::DBusRunner

kossebau abandoned this revision. kossebau added a comment. Discarding for now as developers could not agree on API. Might be picked up later in one way or another. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns

D12016: [ktexteditor] much faster positionFromCursor

mwolff added a comment. lgtm, @cullmann ? regarding the accessibility interface, I agree that it's out of the scope of this patch. I'd say let's keep it like that for now... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12016 To: jtamate, #kate, cullmann,

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

ngraham added reviewers: Plasma, broulik, Frameworks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera, #plasma, broulik, #frameworks Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, se

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

bruns added a comment. -1 Coding style - you could use a lambda here Lacking comment, as its not obvious why the code is needed parent revision is missing ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera, #plasma, broulik, #fram

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

anthonyfieroni added inline comments. INLINE COMMENTS > deviceserviceaction.cpp:91 > +} else { > +connect(access, &Solid::StorageAccess::accessibilityChanged, > +this, &DelayedExecutor::_k_accessibilityChanged); Why not use it in all cases? REPOSITORY R

D12320: {RFC] add ability to read embedded cover files

bruns added inline comments. INLINE COMMENTS > embeddedimagedata.h:36 > +}; > +QByteArray imageData(const QString &fileUrl, const QMimeDatabase > &mimeDatabase, const ImageType imageType = FrontCover) const; > + return type QMap? And instead of an enum imageType a QFlags imagetype? Th

D12388: Output device color curves correction

davidedmundson added a comment. Looks pretty good. +1 INLINE COMMENTS > outputdevice.cpp:323 > +uint16_t *curvePtr = reinterpret_cast(curve->data); > +for (size_t i = 0; i < curve->size / sizeof(uint16_t); i++) { > +destination->append(curvePtr[i]); You can do thi

D12588: KFileWidget: Set minimum size for zoom slider

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4f4c66f96d8: KFileWidget: Set minimum size for zoom slider (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12588?vs=33271&id=33442 REVISION DETAIL

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

mlibera updated this revision to Diff 33433. mlibera edited the summary of this revision. mlibera added a comment. @anthonyfieroni I think it makes sense, I've tested it and it works. @bruns I've tried to mimic the code that was already there. With this revised version there is no ex

D12590: KFileWidget: Disable zoom buttons once reached minimum or maximum

This revision was automatically updated to reflect the committed changes. Closed by commit R241:00d8a78f5696: KFileWidget: Disable zoom buttons once reached minimum or maximum (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12590?vs=33367&id=33

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 241 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/241/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 01 May 2018 20:19:36 + Build duration: 5 min 8 sec and counting JUnit Tests Name: (root

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 90 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/90/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 01 May 2018 20:19:36 + Build duration: 5 min 56 sec and counting JUnit Tests Name: (root)

D12592: KFileWidget: Prevent places panel width from growing 1px iteratively

This revision was automatically updated to reflect the committed changes. Closed by commit R241:302c70b39723: KFileWidget: Prevent places panel width from growing 1px iteratively (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12592?vs=33274&id

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 242 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/242/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 01 May 2018 20:24:45 + Build duration: 4 min 51 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kxmlgui kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kxmlgui kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 33 min and counting JUnit Tests

D12593: KFileWidget: Save places panel width also after hiding panel

This revision was automatically updated to reflect the committed changes. Closed by commit R241:0bcc7eadf5ca: KFileWidget: Save places panel width also after hiding panel (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12593?vs=33275&id=33447

KDE CI: Frameworks kpty kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpty%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kpty kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 33 min and counting JUnit Tests Name:

D12594: KFileWidget: Perfectly align filename widget with icon view

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d5f67b07b5ce: KFileWidget: Perfectly align filename widget with icon view (authored by rkflx). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12594?vs=33276&id=33448 R

KDE CI: Frameworks kjobwidgets kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kjobwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 34 min and counting

KDE CI: Frameworks kitemviews kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kitemviews%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kitemviews kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 35 min and counting JUnit Tests

KDE CI: Frameworks kactivities-stats kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities-stats%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kactivities-stats kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 37 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 243 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/243/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 01 May 2018 20:29:46 + Build duration: 4 min 54 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks ki18n kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 38 min and counting JUnit Tests Name

KDE CI: Frameworks khtml kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks khtml kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 38 min and counting JUnit Tests Name

KDE CI: Frameworks karchive kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20karchive%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks karchive kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 39 min and counting JUnit Tests

KDE CI: Frameworks solid kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks solid kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 39 min and counting JUnit Tests Name

KDE CI: Frameworks kinit kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kinit kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 40 min and counting

KDE CI: Frameworks kcodecs kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcodecs kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 40 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 244 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/244/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 01 May 2018 20:34:42 + Build duration: 4 min 49 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 46 min and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 48 min and counting JUnit Tests Name: (

D12647: Move the inline preview button into the menu

ngraham created this revision. ngraham added reviewers: Frameworks, rkflx. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY Once previews are on by default and automatically disable themselves for small icon sizes, there's little re

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 91 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/91/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 01 May 2018 20:25:33 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed

KDE CI: Frameworks kdesu kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesu%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdesu kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 47 min and counting

D12328: Enable preview by default in the filepicker dialog

ngraham added a dependent revision: D12647: Move the inline preview button into the menu. BRANCH preview_default (branched from master) REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx, ngraham Cc: elvisangelaccio, abetts, rkflx, ngraham, #frameworks,

D12647: Move the inline preview button into the menu

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: anemeth, michaelh, bruns

D12647: Move the inline preview button into the menu

ngraham added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12647 To: ngraham, #frameworks, rkflx Cc: anemeth, michaelh, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 50 min and counting

KDE CI: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 51 min and counting

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 51 min and counting J

KDE CI: Frameworks kitemmodels kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kitemmodels%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kitemmodels kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 53 min and counting JUnit Test

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham updated this revision to Diff 33452. ngraham added a comment. - Merge master - Remove custom styling REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12333?vs=32522&id=33452 BRANCH move-sort-order-chooser-to-toolbar (branched from master) REVISION D

KDE CI: Frameworks purpose kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks purpose kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 54 min and counting JUnit Tests

KDE CI: Frameworks threadweaver kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks threadweaver kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 54 min and counting JUnit Te

KDE CI: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks knotifyconfig kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 55 min and counting

KDE CI: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kxmlrpcclient kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 55 min and counting JUnit

D12388: Output device color curves correction

romangg updated this revision to Diff 33453. romangg added a comment. - memcpy wl_array in colorcurvesCallback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12388?vs=33397&id=33453 BRANCH outputColorCorrectionCurvesOnly REVISION DETAIL https://phabr

D12333: Put the open/save dialog's toolbar above all other widgets, like Dolphin does

ngraham abandoned this revision. ngraham added a comment. Oops, updated the wrong revision. This wasn't gonna get done anyway. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12333 To: ngraham, #frameworks, #dolphin, #vdg Cc: abetts, jtamate, broulik, anemeth, rkflx, mic

D12388: Output device color curves correction

romangg marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12388 To: romangg, #frameworks Cc: davidedmundson, zzag, cfeck, michaelh, bruns

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 56 min and counting JUnit Te

KDE CI: Frameworks kwallet kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwallet%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kwallet kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 57 min and counting JUnit Tests

KDE CI: Frameworks kdbusaddons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdbusaddons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 6 hr 58 min and counting JUnit Test

KDE CI: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcompletion%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcompletion kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 58 min and counting JUnit Test

KDE CI: Frameworks kidletime kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kidletime%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kidletime kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 6 hr 59 min and counting

D12321: Hide file preview when icon is too small

rkflx added a comment. This breaks the string freeze. Please revert. See https://community.kde.org/Schedules/Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio Cc: elvisangelacc

KDE CI: Frameworks kcmutils kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcmutils%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcmutils kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 0 min and counting

KDE CI: Frameworks kjsembed kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kjsembed kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 3 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/92/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 01 May 2018 20:45:32 + Build duration: 14 min and counting JUnit Tests Name: (root) Failed

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#253903 , @rkflx wrote: > Cool, LGTM now. Due to the string change this will have to wait for 5.47 ...and I even added a warning :/ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D1232

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 2 min and counting

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 4 min and counting JUnit Tests

D12641: Workaround Device Notifier showing an error despite volume being mounted correctly

mlibera abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12641 To: mlibera, #plasma, broulik, #frameworks Cc: anthonyfieroni, bruns, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 5 min and counting JUnit Tests

KDE CI: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kglobalaccel kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 5 min and counting JUnit Tes

KDE CI: Frameworks kross kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kross kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 7 min and counting JUnit Tests Name:

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 7 min and counting

D12321: Hide file preview when icon is too small

ngraham added a comment. Darn, my bad. Could we revert just the tooltip string change and land that for 5.47, or would you prefer to hold the whole feature until 5.47? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx,

KDE CI: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks knewstuff kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 7 min and counting JUnit Tests

KDE CI: Frameworks kded kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kded kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 8 min and counting

KDE CI: Frameworks kauth kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kauth kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 8 min and counting JUnit Tests Name:

KDE CI: Frameworks kemoticons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kemoticons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 10 min and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 10 min and counting JUnit Te

KDE CI: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks oxygen-icons5 kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 11 min and counting JUnit

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kservice kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 12 min and counting JUnit Tests

D12321: Hide file preview when icon is too small

ngraham added a comment. Well, I'll revert and then we can discuss whether or not we can land a more limited version without the tooltip change. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelacc

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 13 min and counting

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 13 min and counting

KDE CI: Frameworks kdnssd kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdnssd kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 14 min and counting

KDE CI: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kdesignerplugin kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 14 min and counting JU

KDE CI: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks ktextwidgets kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 15 min and counting JUnit Te

KDE CI: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kiconthemes kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:16 + Build duration: 7 hr 16 min and counting JUnit Test

D12321: Hide file preview when icon is too small

ngraham reopened this revision. ngraham added a comment. This revision is now accepted and ready to land. Reverted. Alex, now that you have a fancy contributor account, you can land this yourself on 5/6/18, or else offer up a version of this without the tooltip change and petition to get that

KDE CI: Frameworks kholidays kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kholidays kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 16 min and counting JUnit Tests

D12337: Give the file dialogs a "Sort by" menu button on the toolbar

ngraham updated this revision to Diff 33459. ngraham added a comment. - Address review comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12337?vs=32533&id=33459 BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 AFFECTED FILE

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kirigami kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 17 min and counting

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#256786 , @ngraham wrote: > Darn, my bad. Could we revert just the tooltip string change and land that for 5.47, or would you prefer to hold the whole feature until 5.47? Well, the tooltip was added for a r

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 18 min and counting JUnit

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#256791 , @ngraham wrote: > Reverted. Alex, now that you have a fancy contributor account, you can land this yourself on 5/6/18, or else offer up a version of this without the tooltip change and petition to get

D12321: Hide file preview when icon is too small

ngraham added a comment. May 6th. REPOSITORY R241 KIO BRANCH conditional_preview (branched from master) REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, n

KDE CI: Frameworks kcrash kf5-qt5 FreeBSDQt5.10 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20FreeBSDQt5.10/1/ Project: Frameworks kcrash kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 01 May 2018 13:57:17 + Build duration: 7 hr 19 min and counting JUnit Tests Na

D12648: Update mount point after mount operations

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. davidedmundson requested review of this revision. REVISION SUMMARY The order of udisks evaluation has changed

  1   2   >