D3838: [Calendar] Optimize day delegate

broulik abandoned this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3838 To: broulik, #plasma, mart Cc: kde-frameworks-dev

D3837: [Calendar] Optimize Backend

broulik abandoned this revision. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3837 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, davidedmu

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol added a comment. In D13102#268015 , @cgiboudeaux wrote: > Please update the doc above. the documentation right now is: # ``LIBDIR`` # object code libraries (``EXECROOTDIR/lib``, ``EXECROOTDIR/lib64`` or # ``EXE

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.9 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.9/13/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.9 Date of build: Fri, 25 May 2018 11:37:57 + Build duration: 1 min 10 sec and counting JUnit Tests

KDE CI: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kimageformats kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 25 May 2018 11:37:57 + Build duration: 1 min 16 sec and counting JUni

KDE CI: Frameworks kimageformats kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20SUSEQt5.10/20/ Project: Frameworks kimageformats kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 May 2018 11:37:57 + Build duration: 1 min 11 sec and counting JUnit Tes

D13043: Properly sanitize input

apol updated this revision to Diff 34858. apol marked 2 inline comments as done. apol added a comment. address kai's remarks REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13043?vs=34659&id=34858 BRANCH master REVISION DETAIL https://phabricator.k

D13043: Properly sanitize input

apol marked 3 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in kconcatenaterowsproxymodel.cpp:112 > You can also use `{}` here, no? Also, I would prefer an early return rather > than unary operator No, the ternary operator doesn't allow using {} saying it

D13117: Don't set custom domain filter rules

aleksanderm created this revision. aleksanderm added reviewers: jgrulich, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. aleksanderm requested review of this revision. REVISION SUMMARY The library shouldn't set custom

D13117: Don't set custom domain filter rules

aleksanderm added a reviewer: Frameworks. REPOSITORY R281 ModemManagerQt REVISION DETAIL https://phabricator.kde.org/D13117 To: aleksanderm, jgrulich, broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 34871. mart added a comment. - Revert "virtual diland Virtual desktop protocol" - rename the xml file to be consistent with the rest - fix copyright - replace the concept of layout with neighbours - smaller fixes REPOSITORY R127 KWayland CHANGES SI

D12820: Add KWayland virtual desktop protocol

mart added a comment. different version for a new round of discussion: try to implement the neighbour concept for the desktop that stay near asnother one, so there may be as many grids unconnected with each other as possible so far there is not integrity check that an added it is actuall

D13120: fix i18n issues in framworks/purpose/plugins

lueck created this revision. lueck added reviewers: Frameworks, Localization, nicolasfella. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY add missing TRANSLATION_DOMAI

D13120: fix i18n issues in framworks/purpose/plugins

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13120 To: lueck, #frameworks, #localization, nicolasfella, apol Cc: apol, kde-frameworks-devel, michael

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham added a comment. Friendly ping! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12756: [KDateTable] Use a more visible red color

ngraham added a comment. Friendly ping! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, cfeck Cc: kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

cfeck resigned from this revision. cfeck added a comment. I will not block this change, but cannot approve it either. Reasons: - The pure red is looks too saturated, as if something dangerous is about to happen. Maybe add the VDG as a reviewer. - We should not use hardcoded colors

D12756: [KDateTable] Use a more visible red color

ngraham added a subscriber: cfeck. ngraham added a comment. In D12756#268311 , @cfeck wrote: > I will not block this change, but cannot approve it either. > > Reasons: > > - The pure red is looks too saturated, as if something dangerous is

D13026: Open Schema toolbar button with normal click rather than click-and-hold

hpereiradacosta added a comment. Hello, I would appreciate that you rephrase the description for this patch (and others where the same comment appear): the dissapearing arrow with breeze is not a *bug* in breeze, but a (conscious) design choice, that is discussed in D13064

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13026: Open Schema toolbar button with normal click rather than click-and-hold

ngraham added a comment. Fair enough! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13026 To: ngraham, #ktexteditor, #kate Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12756: [KDateTable] Use a more visible red color

ngraham updated this revision to Diff 34883. ngraham added a comment. Use a conditional lightness check but the same colors, pending a better color option (TBD) REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12756?vs=33824&id=34883 REVISION DETAIL

D12756: [KDateTable] Use a more visible red color

ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

aacid added a comment. Are you sure you need the backslashes in add_definitions? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13120 To: lueck, #frameworks, #localization, nicolasfella, apol Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D12756: [KDateTable] Use a more visible red color

ngraham updated this revision to Diff 34884. ngraham added a comment. Use conditional grays instead of reds (red was never an appropriate color anyway) REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12756?vs=34883&id=34884 BRANCH arcpatch-D12756

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham retitled this revision from "[KDateTable] Use a more visible red color" to "[KDateTable] Use more appropriate and readable text colors for weekends and holidays". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham added a reviewer: VDG. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D12728: KFileItemActions: fallback to default mimetype when selecting only files

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. It should be easy to use lxr to see which KDE applications uses KFileItemListProperties::mimeType(), but OK, your solution is safer in case of third-party applications. REPOSITORY R241 K

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/6/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Fri, 25 May 2018 23:01:09 + Build duration: 1 min 21 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/86/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Fri, 25 May 2018 23:01:08 + Build duration: 1 min 32 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Fri, 25 May 2018 23:01:08 + Build duration: 3 min 34 sec and counting JUnit Tests

D12945: kcoredirlister lstItems benchmark

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoredirlister_benchmark.cpp:244 > +uint hash=qHash(url); > +auto it = std::lower_bound(lstItems.cbegin(), lstItems.cend(), hash, > lessThanHa

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 34892. smithjd added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - Uniformly use storageDevices. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=31136&i

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

ngraham edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D12756 To: ngraham, #frameworks, #vdg Cc: cfeck, kde-frameworks-devel, mwolff, apol, michaelh, ngraham, bruns

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

sontolbonggol created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. sontolbonggol requested review of this revision. REVISION SUMMARY In some rare cases, the ungrab keyboard request is processed later than th

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

sontolbonggol edited the summary of this revision. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

ngraham added reviewers: Frameworks, Plasma. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12756: [KDateTable] Use more appropriate and readable text colors for weekends and holidays

rkflx added a comment. In D12756#268345 , @ngraham wrote: > Use conditional grays instead of reds (red was never an appropriate color anyway) Hm, now Sundays look like they belong to the previous/next month. (Do we even need to change co

D13130: Add new DDL partitioning keywords

damienclochard created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. damienclochard requested review of this revision. REVISION SUMMARY see https://www.postgresql.org/docs/current/static/ddl-partitioning.html

D13131: Add general purpose data types for PostgreSQL

damienclochard created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. damienclochard requested review of this revision. REVISION SUMMARY see https://www.postgresql.org/docs/current/static/datatype.html#DATATYPE