D13227: update mailto kioslave docbook

lueck created this revision. lueck added reviewers: Frameworks, Documentation. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY correct

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/30/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Thu, 31 May 2018 03:38:52 + Build duration: 9 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 54 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Thu, 31 May 2018 03:38:52 + Build duration: 2 min 13 sec and counting JUnit Tests

D13226: update trash docbook to 5.48

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good! Don't commit until after 5.47 is tagged, obviously. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13226 To: lueck, #frameworks, #documentation,

D13226: update trash docbook to 5.48

lueck updated this revision to Diff 35227. lueck added a comment. correct wrong frameworks version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13226?vs=35226=35227 REVISION DETAIL https://phabricator.kde.org/D13226 AFFECTED FILES

D13226: update trash docbook to 5.48

lueck retitled this revision from "update trash docbook to .47" to "update trash docbook to 5.48". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13226 To: lueck, #frameworks, #documentation Cc: ngraham, kde-frameworks-devel, kde-doc-english, michaelh, bruns, skadinna

D13226: update trash docbook to .47

ngraham added a comment. Looks good, though D12986 will land in Frameworks 5.48, not 5.47. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13226 To: lueck, #frameworks, #documentation Cc: ngraham, kde-frameworks-devel,

D13226: update trash docbook to .47

lueck created this revision. lueck added reviewers: Frameworks, Documentation. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel. lueck requested review of this revision. REVISION SUMMARY reflect gui

D13198: Android toolchain: allow to specify extra libs manually

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Interesting! This is probably a better way to solve the problem than the CMAKE_EXE_LINKER_FLAGS workaround we are doing currently.

D13083: Respect custom directory icons in iconNameForURL()

ngraham added a comment. So maybe we should go back to using `KFileItem` like I had clumsily tried to do in D13048 , and just ensure that we don't even try to go down this codepath for remote folders. Does that seem like a better approach? REVISION

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. Got it, need to remember about the string freeze... REPOSITORY R241 KIO BRANCH clean-up-trash-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin, #frameworks, #vdg, davidedmundson Cc: davidedmundson, abetts,

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

davidedmundson added a comment. Please wait till the 3rd. Otherwise you give practically no days for the i18n changes to happen. But then yes go for it. For future if I give an acceptance with a really minor comment feel free to push straight away after. REPOSITORY R241 KIO

D12986: [Trash KCM] Clean up and standardize UI to be in line with the KDE HIG

ngraham added a comment. Friendly ping! If nobody objects, I will commit this on June 3rd, or sooner if I get more explicit approvals. REPOSITORY R241 KIO BRANCH clean-up-trash-kcm (branched from master) REVISION DETAIL https://phabricator.kde.org/D12986 To: ngraham, #dolphin,

D13223: Set kcm context property on the correct context

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D13223 To: davidedmundson, #plasma, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D13223: Set kcm context property on the correct context

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY One code path of kdeclarative

D13222: Use QDateTime for interfacing with QML

fvogt created this revision. fvogt added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY QDate from/to JS Date has unexpected results, so

D13034: Add mechanism to notify other clients of config changes over DBus

davidedmundson updated this revision to Diff 35212. davidedmundson added a comment. Review comments REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13034?vs=34629=35212 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13034 AFFECTED FILES

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 53 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/53/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 30 May 2018 18:07:55 + Build duration: 10 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 29 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/29/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 30 May 2018 18:07:55 + Build duration: 2 min 28 sec and counting JUnit Tests

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 276 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/276/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 30 May 2018 17:38:30 + Build duration: 26 min and counting JUnit Tests Name: (root)

D12233: Avoid manipulation of lists with quadratic complexity

ngraham added a comment. In D12233#270663 , @dhaumann wrote: > I would give a ship-it - but maybe another review would be good? @ngraham maybe? I'm afraid I don't really consider myself qualified to review this kind of change. I'm more

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/126/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 30 May 2018 17:38:30 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 30 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/30/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 30 May 2018 17:38:30 + Build duration: 5 min 21 sec and counting JUnit Tests

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 35204. smithjd added a comment. - New DBus method updateIndex(). - Change for D13216 . REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=34892=35204 BRANCH

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13189: [kcoredirlister] Remove as many url.toString() as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae08cc2c983c: [kcoredirlister] Remove as many url.toString() as possible (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13189?vs=35114=35201

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35199. smithjd added a comment. - Minor simplification + fix: call checkUnindexedFiles when folder watches are installed instead of scheduleIndexing which can't check for changes in indexable files. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D13218: Draw FrameSVG corners only if both borders in both directions are enabled

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13218: Draw FrameSVG corners only if both borders in both directions are enabled

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13218 To: zzag, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13218: Draw FrameSVG corners only if both borders in both directions are enabled

zzag created this revision. zzag added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY FrameSVG documentation states > ... topleft and topright

D13215: Update sizes before generating frame svg background

zzag edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag added a comment. @broulik I tested panels with Oxygen(with compositing on and off) and didn't see any problems. > (Quickly browsing the bug numbers suggests it does \o/) Not sure about that. All of those bugs are "Breeze-related". REPOSITORY R242 Plasma Framework (Library)

D13215: Update sizes before generating frame svg background

zzag edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd retitled this revision from "Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now stops file indexing." to "Overhaul the file index scheduler.".

D13216: Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now sto

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY BUG: 353559 BUG: 378597 REPOSITORY R293 Baloo BRANCH

D12233: Avoid manipulation of lists with quadratic complexity

bruns added inline comments. INLINE COMMENTS > dhaumann wrote in pendingfilequeue.cpp:69 > Did you check? This is certainly correct for i++ if i is an int. But for > iterators, which are classes, this is often not the case, but I may be wrong > here. In any case, this is a minor nitpick you

D13198: Android toolchain: allow to specify extra libs manually

alexeymin added a comment. http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for `qmake` project: > ANDROID_EXTRA_LIBS: A list of external libraries that will be copied into your application's library folder and loaded on

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35192. jtamate added a comment. Taken into account invalid Items created from invalid QUrls. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35190=35192 REVISION DETAIL https://phabricator.kde.org/D13211

D13215: Update sizes before generating frame svg background

zzag added a comment. In D13215#270878 , @broulik wrote: > Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly browsing the bug numbers suggests

D13215: Update sizes before generating frame svg background

broulik added a comment. Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly browsing the bug numbers suggests it does \o/) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D13215: Update sizes before generating frame svg background

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35190. jtamate marked 4 inline comments as done. jtamate added a comment. Invalid items are not less than invalid items or invalid urls, they are not like -infinite. Added the tests comparing items with urls. Changed the descriptions. REPOSITORY

D13215: Update sizes before generating frame svg background

zzag created this revision. zzag added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY In some cases, when rendering frame svg background, measures &

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 35188. jtamate marked 3 inline comments as done. jtamate edited the test plan for this revision. jtamate added a comment. A KFileItem without url will be the lowest, even lower than itself. Created a new test. The comparison with the QUrl is for

D13211: Enable comparing KFileItems by url

bruns added inline comments. INLINE COMMENTS > dfaure wrote in kfileitem.cpp:1241 > This isn't symmetric. operator< must have the property that a aren't both true, and that they are both false only if the items are equal. > > If `this` is a valid item and `other` is null, then this code says

D13102: Don't include a 64 when building 64bit architectures on flatpak

cgiboudeaux added a comment. Thanks. +1 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13102 To: apol, #frameworks Cc: cgiboudeaux, eszlari, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13211: Enable comparing KFileItems by url

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. A good example of how a unittest helps catching a bug :-) (and a good example of how code that I suggest isn't necessarily bugfree, haha) Missing: unittests for the < QUrl

D13102: Don't include a 64 when building 64bit architectures on flatpak

apol updated this revision to Diff 35185. apol added a comment. Mention on the documentation that we don't change the lib/ value on flatpak REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13102?vs=34841=35185 BRANCH master REVISION DETAIL

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

sontolbonggol added a comment. @fvogt I don't have push access. Will appreciate if someone does it for me. Thanks! REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: davidedmundson, fvogt,

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

fvogt added a comment. @sontolbonggol Do you have access for pushing this or do you want someone else to do it? REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: davidedmundson, fvogt,

D13102: Don't include a 64 when building 64bit architectures on flatpak

eszlari added a comment. In D13102#268116 , @apol wrote: > I don't really see how to put it without reading convoluted. Also as is, the documentation isn't wrong, we are just changing the logic to use one or another. Maybe he just wants

Re: bic in kactivities

Marco, thanks for reverting this. @Laurent The proper change for the constructor should be to make the Private class take the shownStates by value (a sink constructor argument) and for the ActivitiesModel constructor to std::move it when passing to the Private constructor. @All - ` explicit`

D13211: Enable comparing KFileItems by url

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileitem.cpp:1241 > +{ > +if (!d || !other.d) { > +return false; This isn't symmetric. operator< must have the property that a kfileitem.h:493 >

D13128: Make sure ungrab keyboard request is processed before emitting shortcut

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D13128 To: sontolbonggol, #frameworks, #plasma, mck182, davidedmundson Cc: davidedmundson,

Re: bic in kactivities

On Wed, May 30, 2018 at 10:14 AM Harald Sitter wrote: https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > > You cannot...For existing functions of any type:change its signature. This includes:changing any of the types of the arguments in the parameter list, including

D13211: Enable comparing KFileItems by url

jtamate created this revision. jtamate added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Based on QUrl comparisons (available since Qt 5.4).

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

jtamate added a dependency: D13211: Enable comparing KFileItems by url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate, #frameworks, dfaure Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D12945: kcoredirlister lstItems benchmark

jtamate added a dependency: D13211: Enable comparing KFileItems by url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13211: Enable comparing KFileItems by url

jtamate added dependent revisions: D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache, D12945: kcoredirlister lstItems benchmark. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13211 To: jtamate, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: bic in kactivities

On 30.05.2018 10:13, Harald Sitter wrote: Salut! https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1 It appears to me that this is a binary incompatible change. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B You cannot...For

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac updated this revision to Diff 35173. mmustac added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Updated to the latest comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=26753=35173 REVISION DETAIL

D13189: [kcoredirlister] Remove as many url.toString() as possible

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yep, this makes sense these days (back when this was written, QUrl had no hashing function, and my first attempt at writing one was to call qHash(url.toString()) -- how horribly slow!!)

D12233: Avoid manipulation of lists with quadratic complexity

dhaumann added a comment. I would give a ship-it - but maybe another review would be good? @ngraham maybe? INLINE COMMENTS > bruns wrote in pendingfilequeue.cpp:69 > GCC generates identical code for both ... Did you check? This is certainly correct for i++ if i is an int. But for

bic in kactivities

Salut! https://cgit.kde.org/kactivities.git/commit/?id=47a4055e4d6fbf4eb826f255d040620ef23f11c1 It appears to me that this is a binary incompatible change. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B > You cannot...For existing functions of any type:change its

D12689: Lua: updated for Lua5.3

vkrause added a comment. That's probably due to me misunderstanding the intended/existing behavior when implementing this, not an intentional decision in KSyntaxHighlighting. Removing redundancy sounds like a good idea though. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 21 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/21/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Wed, 30 May 2018 07:10:53 + Build duration: 14 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 20 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/20/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 11:51:57 + Build duration: 19 hr and counting CONSOLE OUTPUT