KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 293 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/293/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Jun 2018 03:36:53 + Build duration: 22 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 142 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/142/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 13 Jun 2018 03:36:53 + Build duration: 15 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/49/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Wed, 13 Jun 2018 03:36:53 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 65 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/65/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Jun 2018 03:37:23 + Build duration: 4 min 34 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/41/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Wed, 13 Jun 2018 03:37:23 + Build duration: 4 min 5 sec and counting JUnit Tests Name:

D13442: Implemented displaying of total lines in kate

shubham added a comment. How can the self toggling be done based on the space available? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel,

D13442: Implemented displaying of total lines in kate

ngraham added a comment. Now the option is disabled by default, so nobody will ever find it, kind of defeating the point. If we absolutely have to make this a user-controllable option, I recommend having it on by default, because most of the time you're not space constrained. However I

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/55/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Jun 2018 20:27:11 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 27 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 12 Jun 2018 20:27:11 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/17/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 12 Jun 2018 20:27:11 + Build duration: 8 min 8 sec and counting JUnit Tests

D13501: Fix 'unused parameter' warnings

This revision was automatically updated to reflect the committed changes. Closed by commit R127:1028770d48e5: Fix unused parameter warnings (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13501?vs=36069=36075 REVISION DETAIL

D13394: C++: update for c++20 and fix some syntax errors

dhaumann added a subscriber: cullmann. dhaumann added a comment. To be honest, I cannot claim I can follow all changes, since this is a big update. But in general the usage of the rules look good. The autotest output (html highlighting) looks good to me, it contains nice improvements

D13502: Fix compiler warning about hidden virtual overloads

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY TextInput has 4 virtual operators

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:601f93780573: Rust: Add keywords bytes, fix identifiers, and other improvements/fixes (authored by nibags, committed by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Nice update, will integrate. And thanks for the unit test! REPOSITORY R216 Syntax Highlighting BRANCH improve-rust (branched from master) REVISION DETAIL

D13365: Fixed the cursor(caret) width in kate

mwolff added a comment. @shubham looks like you are a victim of https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/ right? :D REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor, brauch, cullmann Cc:

D13501: Fix 'unused parameter' warnings

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH fix-warnings REVISION DETAIL https://phabricator.kde.org/D13501 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13501: Fix 'unused parameter' warnings

zzag created this revision. zzag added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY The warnings:

D13500: Honor BUILD_TESTING

zzag created this revision. zzag added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY Don't build tests if BUILD_TESTING is OFF. TEST PLAN - Passed

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13498 To: nibags, dhaumann, cullmann Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, dhaumann

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

nibags edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13498 To: nibags, dhaumann, cullmann Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, dhaumann

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

nibags edited the summary of this revision. nibags added reviewers: dhaumann, cullmann. nibags added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13498 To: nibags, dhaumann, cullmann Cc: kde-frameworks-devel,

D13498: Rust: Add keywords & bytes, fix identifiers, and other improvements/fixes

nibags created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nibags requested review of this revision. REVISION SUMMARY **Changes:** - Add missing keywords. - Remove obsolete types `int` & `uint` (these

D13496: FrameSvg: Update mask frame if image path has been changed

zzag updated this revision to Diff 36057. zzag added a comment. Compare against frame->imagePath. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13496?vs=36053=36057 BRANCH dont-wreck-shared-mask-frames REVISION DETAIL

D13384: FrameSvg: Do not wreck shared mask frames

zzag updated this revision to Diff 36056. zzag added a comment. Use `frame`'s imagePath. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13384?vs=35806=36056 REVISION DETAIL https://phabricator.kde.org/D13384 AFFECTED FILES

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

fvogt added a comment. In D9070#277428 , @bkchr wrote: > Hi, > this patch is still no applied, would someone do it? :) > Because it already missed 5.13. I pushed it now. REPOSITORY R135 Integration for Qt applications in Plasma

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

This revision was automatically updated to reflect the committed changes. Closed by commit R135:2e971be576d2: KDE platform plugin: dont force default stylename on user-specified fonts (authored by rjvbb, committed by fvogt). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES

D9070: KDE platform plugin: don't force default stylename on user-specified fonts

bkchr added a comment. Hi, this patch is still no applied, would someone do it? :) Because it already missed 5.13. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9070 To: rjvbb, #frameworks, davidedmundson, graesslin, cfeck,

D13496: FrameSvg: Update mask frame if image path has been changed

zzag created this revision. zzag added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY A FrameSvg can have wrong mask frame if image path

D13384: FrameSvg: Do not wreck shared mask frames

zzag added a dependent revision: D13496: FrameSvg: Update mask frame if image path has been changed. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13384 To: zzag, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 36052. mart added a comment. - remove neighbours, only order - store data in a single structure - auto activate a new desktop REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=34871=36052 BRANCH

D13495: Fix XDGV6 popup test

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY We had a data funciton...then

D13494: Fix stupid copy paste bug in XDGShellV6 Client

davidedmundson updated this revision to Diff 36050. davidedmundson added a comment. fix REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13494?vs=36049=36050 BRANCH xdg_squash REVISION DETAIL https://phabricator.kde.org/D13494 AFFECTED FILES

D13494: Fix stupid copy paste bug in XDGShellV6 Client

davidedmundson created this revision. davidedmundson added a reviewer: KWin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Wasn't spotted because of the bug

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. @pstefan, any update? It would be a shame to let this amazing work languish! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham,

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/26/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.9 Date of build: Tue, 12 Jun 2018 11:43:19 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/54/ Project: Frameworks kwayland kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Jun 2018 11:43:19 + Build duration: 16 min and counting JUnit Tests Name:

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/16/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 12 Jun 2018 11:43:19 + Build duration: 7 min 44 sec and counting JUnit Tests

D13211: Enable comparing KFileItems by url

jtamate updated this revision to Diff 36037. jtamate marked an inline comment as done. jtamate edited the summary of this revision. jtamate added a comment. Change @since to 5.48 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35303=36037 REVISION

KDE CI: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10 - Build # 26 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20modemmanager-qt%20kf5-qt5%20SUSEQt5.10/26/ Project: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Jun 2018 08:18:58 + Build duration: 5 min 57 sec and counting

KDE CI: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9 - Build # 15 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20modemmanager-qt%20kf5-qt5%20SUSEQt5.9/15/ Project: Frameworks modemmanager-qt kf5-qt5 SUSEQt5.9 Date of build: Tue, 12 Jun 2018 08:18:58 + Build duration: 5 min 57 sec and counting CONSOLE

D13117: Don't set custom domain filter rules

This revision was automatically updated to reflect the committed changes. Closed by commit R281:54cc344aa659: Dont set custom domain filter rules (authored by aleksanderm, committed by jgrulich). REPOSITORY R281 ModemManagerQt CHANGES SINCE LAST UPDATE

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

jtamate abandoned this revision. jtamate added a comment. More numbers: The patch reserves 67 buckets in the QHash table vs. 37 by default. In my test, pasing the content of https://www.boe.es/legislacion/documentos/ConstitucionCASTELLANO.pdf from Okular, the number of items in the