nibags added a reviewer: dhaumann.
nibags added a project: Framework: Syntax Highlighting.
nibags edited subscribers, added: Framework: Syntax Highlighting; removed:
kde-frameworks-devel.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D13565
To: nibags, dhau
nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
nibags requested review of this revision.
REVISION SUMMARY
`cson` is a CoffeeScript-Object-Notation. It is a format for storing data,
like JSON, and
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b099af9eb569: Make menu-bearing toolbar buttons show their
menus with normal click rather… (authored by ngraham).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1
zzag added inline comments.
INLINE COMMENTS
> xdgshell_stable.cpp:305
> +Q_UNUSED(surface)
> +auto s = reinterpret_cast(data);
> +s->q->configureRequested(s->pendingSize, s->pendingState, serial);
Did you forget to change it to static_cast? Or there is a reason why it's still
reinte
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
REPOSITORY
R249 KI18n
REVISION DETAIL
https://phabricator.kde.org/D7033
To: carewolf, ilic
Cc: kde-frameworks-devel, huftis, ngraham, dhaumann, ltoscano, kfunk, michaelh,
bruns, #frameworks
romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in xdgshell_stable_interface.cpp:246
> What role do you think it should be?
>
> I'm using the error for when a wl_surface has another role in the case that
> you call get_xdg_surface twice on the same wl_surface, which seems
davidedmundson updated this revision to Diff 36206.
davidedmundson added a comment.
Roman's comments (except the one I commented on)
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13510?vs=36127&id=36206
BRANCH
master
REVISION DETAIL
https://phabrica
davidedmundson marked 4 inline comments as done.
davidedmundson added inline comments.
INLINE COMMENTS
> romangg wrote in xdgshell_stable_interface.cpp:246
> Wrong id `XDG_WM_BASE_ERROR_ROLE`.
What role do you think it should be?
I'm using the error for when a wl_surface has another role in the
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
Lgtm - thanks! Please only in master (as this review request shows).
REPOSITORY
R39 KTextEditor
BRANCH
schema-toolbar-button-opens-on-normal-click (branched from master)
REVISION D
ngraham added a comment.
Friendly ping!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13026
To: ngraham, #ktexteditor, #kate, dhaumann, cullmann
Cc: hpereiradacosta, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew,
ngraham, bruns, demsking, cullmann,
ngraham retitled this revision from "Improve some permissions-related strings"
to "[Properties dialog] Improve some permissions-related strings".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D13552
To: ngraham, #frameworks, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham
bshah created this revision.
bshah added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bshah requested review of this revision.
REVISION SUMMARY
- selfInitialization
- memleak
I could probably s
apol accepted this revision.
REPOSITORY
R245 Solid
BRANCH
gui-instead-of-widgets
REVISION DETAIL
https://phabricator.kde.org/D13541
To: graesslin, #frameworks, dhaumann, apol
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/57/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Fri, 15 Jun 2018 09:10:05 +
Build duration:
9 min 2 sec and counting
JUnit Tests
Na
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/19/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
Date of build:
Fri, 15 Jun 2018 09:10:05 +
Build duration:
6 min 34 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/29/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
Date of build:
Fri, 15 Jun 2018 09:10:05 +
Build duration:
5 min 37 sec and counting
JUnit Tests
Nam
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/56/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
Date of build:
Fri, 15 Jun 2018 08:48:40 +
Build duration:
9 min 34 sec and counting
JUnit Tests
N
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/28/
Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
Date of build:
Fri, 15 Jun 2018 08:48:40 +
Build duration:
9 min 3 sec and counting
JUnit Tests
Name
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/18/
Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
Date of build:
Fri, 15 Jun 2018 08:48:40 +
Build duration:
7 min 25 sec and counting
JUnit Tests
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:b046ca8e9d1f: Add the arclint file in kwayland (authored
by bshah).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13533?vs=36152&id=36192
REVISION DETAIL
https
20 matches
Mail list logo
