KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 78 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/78/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 12 Jul 2018 03:12:31 + Build duration: 9 min 20 sec and counting JUnit Tests

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D12164 To: kossebau, ilic Cc: kde-frameworks-devel, huftis, broulik, michaelh, ngraham, bruns, #frameworks

D13814: Speedup sort

jtamate edited the summary of this revision. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio, bruns Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros,

D14052: Add bluetooth plugin

nicolasfella added a dependent revision: D14056: Remove FileItemActionPlugin in favor of Purpose plugin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

nicolasfella updated this revision to Diff 37583. nicolasfella added a comment. - Revert unintended change REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14052?vs=37582=37583 BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052

D14052: Add bluetooth plugin

nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Replace Bluedevil's

D13814: Speedup sort

markg added a comment. In D13814#290512 , @bruns wrote: > The code looks fine now, but the summary is incorrect. > > The savings is not from using a lambda, but caused by initializing it once. If the old code had used

D14042: Support special URLs for finding files of a certain type

hein added a comment. Does it make sense to name the queries after XDG_USER_DIRS, so e.g. pictures instead of images? https://www.freedesktop.org/wiki/Software/xdg-user-dirs/ REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14042 To: broulik, #frameworks, bruns,

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

hein accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14043 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13814: Speedup sort

bruns added a comment. The code looks fine now, but the summary is incorrect. The savings is not from using a lambda, but caused by initializing it once. If the old code had used `m_collator(other.m_collator)` in the copy constructor, construction would have been just a ref count

D13819: dummy commit to test pre-review CI

jenkins-ci added a comment. Build is green https://build.kde.org/job/test/20/ for more details. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D13819 To: bshah Cc: jenkins-ci, kde-frameworks-devel, michaelh, ngraham, bruns

D13819: dummy commit to test pre-review CI

bshah updated this revision to Diff 37574. bshah added a comment. - jhdkjfhdskj REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13819?vs=37004=37574 BRANCH bshah REVISION DETAIL https://phabricator.kde.org/D13819 AFFECTED FILES CMakeLists.txt To:

D12520: [PasteJob] Emit KDirNotify on paste

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb updated this revision to Diff 37568. rjvbb added a comment. build on Mac too CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14000?vs=37439=37568 REVISION DETAIL https://phabricator.kde.org/D14000 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/kquickstyleitem_p.h To:

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb set the repository for this revision to R858 Qt Quick Controls 2: Desktop Style. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D14000 To: rjvbb, #frameworks Cc: mart, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Tested with a new and existing user. Entries in Kickoff, Dolphin, Gwenview, and the file dialogs all work perfectly, and the subtitles in Kickoff are pretty. Code looks sane. REPOSITORY

D14042: Support special URLs for finding files of a certain type

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Tested with a new and existing user. Entries in Kickoff, Dolphin, Gwenview, and the file dialogs all work perfectly, and the subtitles in Kickoff are pretty. Code looks sane. REPOSITORY

D13814: Speedup sort

jtamate updated this revision to Diff 37559. jtamate edited the summary of this revision. jtamate added a comment. Apply the workaround in loadSortingSettings. It is applied in the constructor and when the type of sorting is changed by the user. REPOSITORY R318 Dolphin CHANGES SINCE

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

sitter added a comment. lgtm. There's a legacy mention of this kiosk key in ContainmentInterface which should be nukable in favor of this change. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter Cc:

D13814: Speedup sort

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kfileitemmodel.cpp:60 > > loadSortingSettings(); > `loadSortingSettings()`, which sets `dirty`, is also called from `slotSortingChoiceChanged()`, so

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb marked 6 inline comments as done. rjvbb added a comment. Ping? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13899 To: rjvbb, #frameworks, #vdg Cc: aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna,

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

broulik created this revision. broulik added reviewers: Plasma, mart, sitter. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows disabling all containment

D14042: Support special URLs for finding files of a certain type

broulik added a dependent revision: D14043: [KFilePlacesModel] Support pretty baloosearch URLs. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14042 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, hein, ngraham Cc: kde-frameworks-devel, #baloo,

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

broulik edited the test plan for this revision. broulik added a dependency: D14042: Support special URLs for finding files of a certain type. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14043 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham,

D14042: Support special URLs for finding files of a certain type

broulik added reviewers: hein, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14042 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, hein, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

broulik created this revision. broulik added reviewers: Frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION

D14042: Support special URLs for finding files of a certain type

broulik created this revision. broulik added reviewers: Frameworks, bruns, dfaure, renatoo, franckarrecot. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY

D13814: Speedup sort

jtamate updated this revision to Diff 37543. jtamate added a comment. I've applied some of @bruns suggestions. Just use QString(), less filesize and memory. Move the comparison after loadSortingSettings(); Change the comment from Force the cleanup of to Force the clean state of.

D7448: generate and use a local cdda_interface headerfile copy

This revision was automatically updated to reflect the committed changes. Closed by commit R342:0c31ea5a5373: generate and use a local cdda_interface headerfile copy (authored by rjvbb). REPOSITORY R342 KIO AudioCD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7448?vs=18476=37541