KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 92 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/92/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Fri, 03 Aug 2018 03:38:32 + Build duration: 8 min 53 sec and counting JUnit Tests

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 69 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/69/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Fri, 03 Aug 2018 03:38:32 + Build duration: 2 min 29 sec and counting JUnit Tests

D14572: Check the build directory for po/ as well

apol created this revision. apol added reviewers: Frameworks, ltoscano. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of just checking if it's in the source

D14528: Android: Make sure we're looking for .mo files in the right path

apol updated this revision to Diff 38987. apol added a comment. Merged another patch, sorry REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14528?vs=38984=38987 BRANCH arcpatch-D14528 REVISION DETAIL https://phabricator.kde.org/D14528 AFFECTED FILES

D14528: Android: Make sure we're looking for .mo files in the right path

aacid added a comment. As I am arguing in the other review, let's install the files in a nicer place? We control were we install them, no? REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14528 To: apol, #frameworks, ilic, ckertesz Cc: aacid,

D14529: Android: Make sure Qm translations get loaded

aacid added a comment. Ok, second option, we are actually installing these files ourselves, right? Can we install them somewhere "nicer"? like maybe QStandardPaths::StandardLocation(DataLocation) + optionally "/share" ? REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D14528: Android: Make sure we're looking for .mo files in the right path

apol updated this revision to Diff 38984. apol added a comment. Check the build directory for po/ as well REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14528?vs=38882=38984 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14528 AFFECTED

D14569: Make it possible for ECM to detect po files at configure time

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY ECMPoQmTools will need to

D14528: Android: Make sure we're looking for .mo files in the right path

ckertesz accepted this revision. ckertesz added a comment. This revision is now accepted and ready to land. I think this is fine. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D14528 To: apol, #frameworks, ilic, ckertesz Cc: ltoscano,

D14565: Fix overflow in rounding code

cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. In D14565#302551 , @safaalfulaij wrote: > Maybe you should use `largeValue` instead of `largevalue`. Yes, that would be

D8007: popplerextractor: don't try to guess the title if there isn't one.

cfeck added a comment. In D8007#302464 , @szafar wrote: > I use this script to batch rename research papers I download and it works pretty well. Wait, you don't like your PDF's named "ilm1-2007000278.pdf" or "robinson_tr156.pdf"?

D14565: Fix overflow in rounding code

safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Worked great, thanks! Maybe you should use `largeValue` instead of `largevalue`. But please take an approval from a developer, it worked for me but I have no idea if it can

D14565: Fix overflow in rounding code

svuorela created this revision. svuorela added reviewers: cfeck, safaalfulaij. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. svuorela requested review of this revision. REVISION SUMMARY qRound works with int. BUG:

D14400: Fix Mixed to Upper mode latching in Aztec code generation

This revision was automatically updated to reflect the committed changes. Closed by commit R280:99de31859285: Fix Mixed to Upper mode latching in Aztec code generation (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14400?vs=38495=38975#toc REPOSITORY R280 Prison

D13570: Add workaround for labels with word-wrapping

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. Please commit until we find a better solution. REPOSITORY R236 KWidgetsAddons BRANCH workaround-wordwrap (branched from master) REVISION DETAIL https://phabricator.kde.org/D13570 To:

D14400: Fix Mixed to Upper mode latching in Aztec code generation

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D14400 To: vkrause, svuorela Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D8007: popplerextractor: don't try to guess the title if there isn't one.

szafar added a comment. Just wanted to chime in to say how my workflow depended on this bit of code. I compiled the `tests/dump.cpp` tool and used it as a CLI PDF metadata dumper. I then wrote this script

D6513: Add support for Attica tags support

cfeck added inline comments. INLINE COMMENTS > ngraham wrote in atticaprovider.cpp:280 > Also isn't Qt `foreach` deprecated anyway? > https://www.kdab.com/goodbye-q_foreach/ Ah, yes. `Q_FOREACH`, or C++11 `for (x : y)` if you see it does not cause unneeded detaches. REPOSITORY R304

D6513: Add support for Attica tags support

ngraham added inline comments. INLINE COMMENTS > cfeck wrote in atticaprovider.cpp:280 > Space after `foreach`. No space after `&`. Also isn't Qt `foreach` deprecated anyway? https://www.kdab.com/goodbye-q_foreach/ REPOSITORY R304 KNewStuff REVISION DETAIL

D14360: Remove custom icon selection for trash

shubham added a comment. In D14360#302343 , @cfeck wrote: > In D14360#302335 , @shubham wrote: > > > can I give your name as supporter for KDE developer account application? > > > Sure (even

D14360: Remove custom icon selection for trash

cfeck added a comment. In D14360#302335 , @shubham wrote: > can I give your name as supporter for KDE developer account application? Sure (even if I hate the mail I will receive from sysadmins ;) REPOSITORY R241 KIO REVISION DETAIL

D14360: Remove custom icon selection for trash

shubham added a comment. In D14360#302306 , @cfeck wrote: > I just noticed that this header says "const QString () const;" i.e. we return a reference to a string. Assuming this API is really not public, it probably needs to be changed to a

D14360: Remove custom icon selection for trash

shubham added a comment. In D14360#302141 , @cfeck wrote: > Well, I had to look up your 'previous contributions' page to find your full name and mail address, and I would say given your rate of submits it makes sense to apply for a developer

D6512: Add support for proposed tags addition in OCS 1.7

cfeck added inline comments. INLINE COMMENTS > content.cpp:338 > + > +void Attica::Content::setTags(const QStringList& tags) > +{ `& ` -> ` &` > downloaddescription.cpp:306 > + > +void Attica::DownloadDescription::setTags(const QStringList& tags) > +{ again REPOSITORY R235 Attica REVISION

D6513: Add support for Attica tags support

cfeck added inline comments. INLINE COMMENTS > atticaprovider.cpp:276 > Q_FOREACH (const Content , contents) { > -mCachedContent.insert(content.id(), content); > -entries.append(entryFromAtticaContent(content)); > +if(checker.filterAccepts(content.tags())) { > +

D14360: Remove custom icon selection for trash

cfeck added a comment. I just noticed that this header says "const QString () const;" i.e. we return a reference to a string. Assuming this API is really not public, it probably needs to be changed to a non-reference, correct? REPOSITORY R241 KIO REVISION DETAIL

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

ngraham edited the summary of this revision. REPOSITORY R237 KConfig BRANCH shortcut-actual-size (branched from master) REVISION DETAIL https://phabricator.kde.org/D14201 To: muhlenpfordt, dfaure, broulik, ngraham Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 186 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/186/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 02 Aug 2018 12:09:09 + Build duration: 26 min and counting JUnit Tests Name: (root)

D14435: Fix KTimeComboBox input mask for AM/PM times

cfeck added a comment. Thanks, committed. I hope I got the correct address from your bugzilla comment. Offtopic: When I started understanding BOOPSI objects, I was a bit disappointed that Window and Screen objects in intuition.library where not BOOPSI objects. I re-sourced the complete

D10040: Add serial number and EISA ID to OutputDevice interface

davidedmundson added a comment. Bug explained with a fix here D14505 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10040 To: davidedmundson, graesslin, sebas, #kwin, dvratil Cc: romangg, kde-frameworks-devel, davidedmundson,

D14435: Fix KTimeComboBox input mask for AM/PM times

This revision was automatically updated to reflect the committed changes. Closed by commit R236:628c5b1335a2: Fix KTimeComboBox input mask for AM/PM times (authored by glennw, committed by cfeck). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/96/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 02 Aug 2018 12:09:09 + Build duration: 7 min 1 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 339 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/339/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 02 Aug 2018 12:09:09 + Build duration: 5 min 44 sec and counting JUnit Tests Name:

D14360: Remove custom icon selection for trash

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:aa9b63b45105: Remove custom icon selection for trash (authored by shubham, committed by cfeck). CHANGED PRIOR TO

D13869: [solid] Notify when interface to mounted fs is lost

anthonyfieroni added a comment. For 5.49? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13869 To: anthonyfieroni, broulik, cfeck, dfaure Cc: bcooksley, bruns, kde-frameworks-devel, michaelh, ngraham

D14360: Remove custom icon selection for trash

cfeck accepted this revision. cfeck added a comment. Well, I had to look up your 'previous contributions' page to find your full name and mail address, and I would say given your rate of submits it makes sense to apply for a developer account so that you can commit yourself. This means less

D14544: Android: Don't hardcode a random version of the Android SDK

This revision was automatically updated to reflect the committed changes. Closed by commit R240:2f9bf6673179: Android: Dont hardcode a random version of the Android SDK (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D14544: Android: Don't hardcode a random version of the Android SDK

apol added a comment. In D14544#302017 , @alexeymin wrote: > From all of my installed build tools: `19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1` it selects _default_sdk as `19.1.0`, is it fine?  > I mean, which

D14435: Fix KTimeComboBox input mask for AM/PM times

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14544: Android: Don't hardcode a random version of the Android SDK

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D14544 To: apol, #frameworks, vkrause Cc: alexeymin, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D14360: Remove custom icon selection for trash

shubham added a comment. @dfaure I don't have commit access REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14529: Android: Make sure Qm translations get loaded

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Use a similar strategy as

D14360: Remove custom icon selection for trash

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

shubham updated this revision to Diff 38927. shubham added a comment. Fix typos return m_iconButton REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14360?vs=38913=38927 REVISION DETAIL https://phabricator.kde.org/D14360 AFFECTED FILES

D14360: Remove custom icon selection for trash

shubham added a comment. @dfaure is this patch okay REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik, #dolphin, #frameworks, pino Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

D14360: Remove custom icon selection for trash

dfaure added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kfileplaceeditdialog.cpp:220 > This will produce error on strict level it should be > > m_iconButton != nullptr Which strict level is that? AFAIK it's perfectly valid to "cast" a pointer into a boolean, we do this

D14544: Android: Don't hardcode a random version of the Android SDK

alexeymin added a comment. From all of my installed build tools: `19.1.0, 20.0.0, 21.1.2, 22.0.1, 23.0.1, 23.0.2, 23.0.3, 24.0.0, 26.0.1` it selects _default_sdk as `19.1.0`, is it fine?  REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14544 To: apol,