D14994: [Windows Device] Show device label only if there is one

vonreth accepted this revision. vonreth added a comment. This revision is now accepted and ready to land. Sounds sane REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D14994 To: broulik, #windows, vonreth Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15006: Allow to turn of the QStandardPaths lookups

cullmann added a comment. On the other side, with the define, no body can mess with the global settings of lookup without compiling a own version, which has it's benefits, too. (and all people bundling the stuff like QtCreator will anyways compile an own variant) REPOSITORY R216 Syntax Hi

D15006: Allow to turn of the QStandardPaths lookups

cullmann added a comment. I can live with a runtime setter, too. But it must be some stuff you can set before you instantiate the Repository, as you don't want to load potential hazard stuff from the normal locations. Would some static function in repository that toggles this off/on be ac

D15006: Allow to turn of the QStandardPaths lookups

vkrause added a comment. I generally agree with having that option, just wondering if this should be a compile-time or runtime setting? Runtime would allow to also use the system framework if you only want to load your custom theme or syntax files, while still enabling the bundling use-cases

D15013: balootctl: fix 396535

jausmus created this revision. jausmus added a project: Baloo. Herald added a project: Frameworks. Herald added subscribers: Baloo, kde-frameworks-devel. jausmus requested review of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15013 AFFECTED FILES src/t

D14984: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R169:b23e642e5ac4: Explicitly request Qt 5.7's QtQuick to make use of Connections.enabled (authored by mpyne). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14984?vs=4

D8536: Add more hashing algorithms to KPropertiesDialog

petermajchrak added a comment. @ngraham I have in the meantime switched away from KDE, so it would be difficult for me to continue the development... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: kde-framework

D14940: kformattest: Use plural suffix (s) consequently

aacid added a comment. In D14940#313136 , @habacker wrote: > According to the section'Handling of plurals' on http://doc.qt.io/qt-5/i18n-source-translation.html, for plurals an '(s)' is used instead of the 's' as suffx. You are refering to a dif

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D14971: Combine display OSD icon files and move to plasma icon theme

ngraham added a comment. Ah, that did it. So should we bump the version in this patch, then? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14971 To: pstefan, ngraham, #vdg, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcrash%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kcrash kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 15 hr and counting JUnit Tests

D8536: Add more hashing algorithms to KPropertiesDialog

ngraham added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @petermajchrak, are you going to finish this, or should someone else take over? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio,

D15006: Allow to turn of the QStandardPaths lookups

cullmann created this revision. cullmann added reviewers: vkrause, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY Rational: If you deploy this framework on your own, you

D14912: Bindings: Make generator forward compatible with Python 3

bruns updated this revision to Diff 40256. bruns edited the summary of this revision. bruns removed a subscriber: arojas. bruns added a comment. Use dict.items() for Python 2.7 and Python 3 REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14912?vs

D14912: Bindings: Make generator forward compatible with Python 3

bruns added a comment. Third option: just use `original.items()`. This is slightly more expensive in python 2 (it generates a temporary list instead of passing an iterator), but is functionally identical. I don't think the overhead is an issue here - it is only called when tracing. For pytho

D14908: Bindings: Add support for scoped enums

bruns updated this revision to Diff 40250. bruns edited the summary of this revision. bruns added a comment. Update minimum LLVM version in CMake check REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14908?vs=39943&id=40250 BRANCH scoped_enum

D15002: Allow to install syntax files instead of having them in a resource

This revision was automatically updated to reflect the committed changes. Closed by commit R216:59ddf56f98d9: Allow to install syntax files instead of having them in a resource (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D14978: Add unit test that checks Format data

dhaumann added a comment. True, agreed. And it was an ugly workaround in the first place. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14978 To: dhaumann, cullmann, vkrause Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D15002: Allow to install syntax files instead of having them in a resource

dhaumann accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars

D14237: Make Konqi look good in HiDPI

ngraham updated this revision to Diff 40246. ngraham added a comment. Use @bruns' latest SVG REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14237?vs=40104&id=40246 BRANCH hidpi-konqi (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D15000: Display mounted file system type in properties dialog

ngraham added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D14978: Add unit test that checks Format data

cullmann added a comment. I would be in favor of removing Alerts_indent. It has no use ATM. Even if the indentation setting would be important, we can't read that value, as no format of that definition is ever ending up in any textline. REPOSITORY R216 Syntax Highlighting REVISION DETAI

D15002: Allow to install syntax files instead of having them in a resource

cullmann requested review of this revision. cullmann added a comment. Updated patch to allow make test to work. REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullma

D15002: Allow to install syntax files instead of having them in a resource

cullmann updated this revision to Diff 40242. cullmann added a comment. Update that allows make test to succeed, even before one does make install. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15002?vs=40232&id=40242 REVISION DETAIL https://phabricator.kde.org/D15002

D15002: Allow to install syntax files instead of having them in a resource

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, k

KDE CI: Frameworks kconfigwidgets kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfigwidgets%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kconfigwidgets kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting JU

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

graesslin added a subscriber: plasma-devel. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D14910 To: graesslin, #kwin, #frameworks, davidedmundson Cc: plasma-devel, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting

KDE CI: Frameworks purpose kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks purpose kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting JUnit Tests

KDE CI: Frameworks frameworkintegration kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks frameworkintegration kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counti

KDE CI: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20sonnet%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks sonnet kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting JUnit Tests

KDE CI: Frameworks krunner kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20krunner%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks krunner kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting JUnit Tests

KDE CI: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjobwidgets%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kjobwidgets kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 10 hr and counting JUnit Tests Name:

D15002: Allow to install syntax files instead of having them in a resource

dhaumann added a comment. BTW, slightly related as idea: I think it would be nice to add a function Definition Downloader::setDownloadLocation() or similar that allows to have a custom download location. This would match nicely with Repository::addCustomSearchPath(). REPOSITORY R216 Synta

D15002: Allow to install syntax files instead of having them in a resource

dhaumann added a comment. I am fine with this change. I want a review from Volker, through . REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15002 To: cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bru

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40236. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40233&id=40236 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: broulik,

D15000: Display mounted file system type in properties dialog

shubham added a comment. 1. use KMountPoint::mountPoint() 2. Move everything into isLocal REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40233. shubham edited the summary of this revision. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40219&id=40233 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cp

D15000: Display mounted file system type in properties dialog

shubham edited the summary of this revision. shubham added a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks extra-cmake-modules kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks extra-cmake-modules kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 46 min and co

KDE CI: Frameworks kitemmodels kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kitemmodels%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kitemmodels kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 46 min and counting J

KDE CI: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kfilemetadata kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 43 min and counting

KDE CI: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdoctools kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 41 min and counting JUnit

KDE CI: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kpeople kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 39 min and counting JUnit Test

KDE CI: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20qqc2-desktop-style%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks qqc2-desktop-style kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 39 min and coun

KDE CI: Frameworks baloo kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks baloo kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 36 min and counting

D15002: Allow to install syntax files instead of having them in a resource

cullmann created this revision. cullmann added a reviewer: vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY Given the license of some files is dubious, this allows MIT lovi

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kauth kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 35 min and counting JUnit Tests

KDE CI: Frameworks kdesignerplugin kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdesignerplugin%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdesignerplugin kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 33 min and counting

KDE CI: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kiconthemes kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 29 min and counting J

KDE CI: Frameworks kdewebkit kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdewebkit kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 27 min and counting

KDE CI: Frameworks kcmutils kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcmutils%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kcmutils kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 26 min and counting

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 25 min and co

KDE CI: Frameworks kdnssd kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdnssd%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdnssd kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 22 min and counting

KDE CI: Frameworks oxygen-icons5 kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20oxygen-icons5%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks oxygen-icons5 kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 21 min and counting

KDE CI: Frameworks kdbusaddons kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdbusaddons%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdbusaddons kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 18 min and counting JU

KDE CI: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kplotting%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kplotting kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 16 min and counting JUnit

KDE CI: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjsembed%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kjsembed kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 15 min and counting

KDE CI: Frameworks kidletime kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kidletime%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kidletime kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 14 min and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kcoreaddons kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 13 min and counting J

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 8 min and counting

KDE CI: Frameworks kjs kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kjs%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kjs kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 6 min and counting JUnit Tests N

KDE CI: Frameworks ktextwidgets kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20ktextwidgets%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks ktextwidgets kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 4 min and counting J

KDE CI: Frameworks kxmlgui kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kxmlgui kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 8 hr 2 min and counting JUnit Test

KDE CI: Frameworks kguiaddons kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kguiaddons%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kguiaddons kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 59 min and counting JUni

KDE CI: Frameworks kconfig kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kconfig kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 57 min and counting JUnit Tes

KDE CI: Frameworks khtml kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20khtml%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks khtml kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 55 min and counting JUnit Tests

Re: os-release parser?

On Wednesday, 22 August 2018 14:14:12 CEST Harald Sitter wrote: > konnichiwa > > A while ago I wrote a class to parse /etc/os-release. Should we maybe > add this functionality to some framework? If so, which? > > https://cgit.kde.org/kinfocenter.git/tree/Modules/about-distro/src/OSRelease > .cpp

KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 48 min and countin

KDE CI: Frameworks kemoticons kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kemoticons kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 34 min and counting JUni

KDE CI: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks ktexteditor kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 32 min and counting J

D14948: Port scriptabletags to QJSEngine

carewolf added subscribers: kde-frameworks-devel, dhaumann, skelly. REVISION DETAIL https://phabricator.kde.org/D14948 To: carewolf, dhaumann, skelly Cc: skelly, dhaumann, kde-frameworks-devel

KDE CI: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20knotifyconfig%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks knotifyconfig kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 4 min and counting

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 7 hr 3 min and counting

KDE CI: Frameworks kholidays kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kholidays%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kholidays kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 58 min and counting JUnit

KDE CI: Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdelibs4support kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 56 min and counting

KDE CI: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kxmlrpcclient%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kxmlrpcclient kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 35 min and counting

KDE CI: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kpackage kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 32 min and counting JUnit T

KDE CI: Frameworks kross kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kross%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kross kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 29 min and counting JUnit Tests

KDE CI: Frameworks kactivities kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kactivities%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kactivities kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 25 min and counting

KDE CI: Frameworks kinit kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kinit kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 23 min and counting

KDE CI: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kbookmarks%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kbookmarks kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 22 min and counting JUn

KDE CI: Frameworks kded kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kded%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kded kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 21 min and counting

KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 20 min and counting JUnit Tests

KDE CI: Frameworks kparts kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kparts%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kparts kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 13 min and counting JUnit Tests

KDE CI: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20threadweaver%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks threadweaver kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 17 min and counting

KDE CI: Frameworks kcodecs kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kcodecs kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 9 min and counting JUnit Test

D15000: Display mounted file system type in properties dialog

broulik added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1161 > > +l = new QLabel(i18n("File system:"), d->m_frame); > +grid->addWidget(l, curRow, 0, Qt::AlignRight); Captailize: File System > kpropertiesdialog.cpp:1164 > + > +QStorageInfo *fileSystem = n

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 10 min and counting

KDE CI: Frameworks kitemviews kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kitemviews%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kitemviews kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 8 min and counting JUnit

KDE CI: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 6 min and counting J

KDE CI: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knewstuff%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks knewstuff kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 5 min and counting JUnit

D15000: Display mounted file system type in properties dialog

shubham removed a reviewer: broulik. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20knotifications%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks knotifications kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 3 min and counting

KDE CI: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kmediaplayer%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kmediaplayer kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 6 hr 1 min and counting J

D15000: Display mounted file system type in properties dialog

shubham updated this revision to Diff 40219. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15000?vs=40217&id=40219 REVISION DETAIL https://phabricator.kde.org/D15000 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: shubham, dfaure, broulik Cc: kde-frame

KDE CI: Frameworks kimageformats kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kimageformats%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks kimageformats kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 57 min and counting

KDE CI: Frameworks solid kf5-qt5 WindowsMSVCQt5.11 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20solid%20kf5-qt5%20WindowsMSVCQt5.11/1/ Project: Frameworks solid kf5-qt5 WindowsMSVCQt5.11 Date of build: Wed, 22 Aug 2018 06:21:07 + Build duration: 5 hr 54 min and counting JUnit Tests

os-release parser?

konnichiwa A while ago I wrote a class to parse /etc/os-release. Should we maybe add this functionality to some framework? If so, which? https://cgit.kde.org/kinfocenter.git/tree/Modules/about-distro/src/OSRelease.cpp

  1   2   >