D14236: Add some improvements to kate-syntax-highlighter for use in scripting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then lets land this, if Volker is ok already ;=) I will push it, I want to just hide the bestCandidate from the header afterwards. REPOSITORY R216 Syntax Highlighting REVISION

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:08b871457b79: Add some improvements to kate-syntax-highlighter for use in scripting (authored by xciml, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

cullmann added a comment. Thanks for the enhancements! I just did hide the bestCandidate function as static helper, no need to expose them at all in the header: Git commit 60affa47908782d2bda94af2e49fa3f1c4608f4e

D14922: Assert if trying to use a KCatalog without a QCoreApplication

ahartmetz added a comment. This change makes kwin_x11 crash on startup. Please fix kwin or degrade this to a warning. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham

D15161: [KFileItemListProperties] Use mostLocalUrl for capabilities

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This ensures that when e.g. `~/Desktop` is read-only that also files in `d

D15098: make push/pop part of ConfigModule API

davidedmundson added inline comments. INLINE COMMENTS > configmodule.cpp:170 > > d->_qmlObject->setSource(QUrl::fromLocalFile(package.filePath("mainscript"))); > - > d->_qmlObject->engine()->rootContext()->setContextProperty(QStringLiteral("kcm"), > this); > + > d->_qml

D15156: [KMountPoint] Remove traces of supermount

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15156 To: bruns, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14922: Assert if trying to use a KCatalog without a QCoreApplication

ahartmetz added a subscriber: kwin. ahartmetz added a comment. @kwin REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: kwin, ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, michaelh, ngraham, bruns

D15155: [KMountPoint] Fix typo in probablySlow()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:9f1ec50126f4: [KMountPoint] Fix typo in probablySlow() (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15155?vs=40672&id=40688 REVISION DETAIL

D14747: [Exe Thumbnailer] Don't generate QTemporaryFile

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:378df6f6eebe: [Exe Thumbnailer] Don't generate QTemporaryFile (authored by broulik). REPOSITORY R320 KIO Extras CHA

D15161: [KFileItemListProperties] Use mostLocalUrl for capabilities

broulik edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15161 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15155: [KMountPoint] Fix typo in probablySlow()

davidedmundson added a comment. I doubt it's a typo. "cifs" was the samba of the time e9828078e17c8b1bd06c0a23e81e8eb6d720139e introducing it also references subfs in the commit message. It's unlikely it's

D15155: [KMountPoint] Fix typo in probablySlow()

broulik added inline comments. INLINE COMMENTS > kmountpoint.cpp:550 > || d->mountType == QLatin1String("fuseblk"); > const bool isSmb = d->mountType == QLatin1String("cifs") || d->mountType > == QLatin1String("smbfs"); > Here it is explicit `smbfs`, though, and

D15155: [KMountPoint] Fix typo in probablySlow()

davidedmundson added a comment. Sure, it totally makes sense to add smbfs in the probablySlow. +1 on the core part of the patch. I don't think subfs was a typo, and shouldn't be removed on that basis. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15155 To: brouli

D12493: Require NetworkManager 1.4.0 and newer

sitter accepted this revision. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R282 NetworkManagerQt BRANCH master REVISION DETAIL https://phabricator.kde.org/D12493 To: jgrulich, #frameworks, sitter Cc: kde-frameworks-devel, #f

D15155: [KMountPoint] Fix typo in probablySlow()

broulik added a comment. Reverted https://cgit.kde.org/kio.git/commit/?id=105f532a0b97e8c5d4c656e6bcf302264ab9794d REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15155 To: broulik, dfaure, dhaumann, aacid, ngraham Cc: davidedmundson, kde-frameworks-devel, michaelh, ngr

D12493: Require NetworkManager 1.4.0 and newer

This revision was automatically updated to reflect the committed changes. Closed by commit R282:d5d45a61e324: Require NetworkManager 1.4.0 and newer (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12493?vs=32965&id=40692#toc REPOSITORY R282 NetworkManagerQt CHAN

D15164: Support button icons when present

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY support button icons. if there is no icon or is Qt 5.9, the iconItem will stay invisible TES

KDE CI: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.11 - Build # 3 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20WindowsMSVCQt5.11/3/ Project: Frameworks kdeclarative kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 30 Aug 2018 11:28:03 + Build duration: 3 min 52 sec and counting

D15098: make push/pop part of ConfigModule API

mart updated this revision to Diff 40701. mart marked an inline comment as done. mart added a comment. - hopefully clearer comment REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15098?vs=40499&id=40701 BRANCH arcpatch-D15098 REVISION DETAIL https

D14922: Assert if trying to use a KCatalog without a QCoreApplication

broulik added a comment. KWin is fixed in 5.12, 5.13 and master branch, thanks for bringing this to our attention REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14922 To: aacid, dfaure Cc: broulik, kwin, ahartmetz, dfaure, ltoscano, ilic, kde-frameworks-devel, micha

D15155: [KMountPoint] Fix typo in probablySlow()

bruns added a comment. In D15155#317602 , @davidedmundson wrote: > Sure, it totally makes sense to add smbfs in the probablySlow. +1 on the core part of the patch. > > I don't think subfs was a typo, and shouldn't be removed on that basis.

D15098: make push/pop part of ConfigModule API

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in configmodule.h:392 > I don't understand this sentence. It contains two "when"s hopefully simpler comment REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D15098 To: mart, #plasma Cc: davidedmunds

D15146: RFC: Don't consider KDiskFreeSpaceInfo valid if all relevant statvfs fields are zero

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Quite fantastic. Can reproduce the initial problem, the fact that this fixes it, and the new permissions issue, which I can also confirm is fixed with D15154

D15154: Also check smb-share for whether it's an SMB mount

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yup, this fixes that issue for me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15154 To: broulik, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, br

D15141: [KSambaShareData] Accept spaces in ACL host name

broulik updated this revision to Diff 40705. broulik added a comment. - Add unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15141?vs=40633&id=40705 REVISION DETAIL https://phabricator.kde.org/D15141 AFFECTED FILES autotests/CMakeLists.txt autot

D15153: RFC: Resolve gvfsd mounts

ngraham added a comment. Can't really comment on the code itself, but this plus D15154 do resolve the problem for me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15153 To: broulik, dfaure, ngraham Cc: kde-frameworks-devel, michae

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

xciml added a comment. Thank you! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14236 To: xciml, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, pino, kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, bmortimer, michae

Re: New framework: KF5Syndication

On 18.08.2018 15:38, Volker Krause wrote: The KIO dependency has been refactored away, so [KF5Syndication] is now a tier 2 functional framework. Any idea why https://api.kde.org/frameworks/syndication/html/syndication-dependencies.html says it needs KIO?

D15141: [KSambaShareData] Accept spaces in ACL host name

bruns added a comment. +1 Sidenote: can you explain "(somewhat)" in the Test Plan? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15141 To: broulik, dfaure, fvogt Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15154: Also check smb-share for whether it's an SMB mount

bruns added a comment. Can you add a comment mentioning where "smb-share" is comming from? Otherwise, +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15154 To: broulik, dfaure, ngraham Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D12493: Require NetworkManager 1.4.0 and newer

bruns added a comment. You have missed the checks added in https://phabricator.kde.org/D11353, e.g. in src/dnsconfiguration.h Also, the API documentation has a lot of `@note`s referencing NM < 1.2.0, 1.0.6, ... REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kd

D8256: Add _XOPEN_SOURCE to C definitions

awilcox added a comment. rindex was being used in kscreenlocker but that code was removed last year. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D8256 To: awilcox, alexmerry, dfaure Cc: kde-frameworks-devel, kde-buildsystem, mpyne, dfaure, michaelh, ng

Re: New framework: KF5Syndication

On Thursday, 30 August 2018 18:04:56 CEST Christoph Feck wrote: > On 18.08.2018 15:38, Volker Krause wrote: > > The KIO dependency has been refactored away, so [KF5Syndication] is now a > > tier 2 functional framework. > > Any idea why > https://api.kde.org/frameworks/syndication/html/syndication-

D15153: RFC: Resolve gvfsd mounts

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15153 To: broulik, dfaure, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15155: [KMountPoint] Fix typo in probablySlow()

dfaure added a comment. commit bd86d99dda Author: Adrian Schroeter Date: Wed Apr 7 07:36:37 2004 + do not use DNOTIFY on subfs mounted devices. this would lock the drive and make an eject impossible. svn path=/trunk/kdelibs/; revision=301908

D15161: [KFileItemListProperties] Use mostLocalUrl for capabilities

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15161 To: broulik, #frameworks, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15155: [KMountPoint] Fix typo in probablySlow()

bruns added a comment. Obviously no typo: https://phabricator.kde.org/source/kio/browse/master/tier3/kio/src/core/kmountpoint.cpp;1c03f632ea62f593ba88b65cad49e4e979d02ee3$542 but dead as a Dodo ... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15155 To: broulik

D15141: [KSambaShareData] Accept spaces in ACL host name

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ksambasharetest.cpp:26 > + > +#include > + This includes all of QtTest *and* all of QtCore. Please use instead. > ksambasharetest.h:21 > + > +#ifndef KSAMB

D15158: [KMountPoint] Remove Windows CE support

dhaumann accepted this revision. dhaumann added a comment. Makes sense REPOSITORY R241 KIO BRANCH remove_wince REVISION DETAIL https://phabricator.kde.org/D15158 To: bruns, #frameworks, #windows, vonreth, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15157: [KMountPoint] Remove AIX support

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this makes sense. One could add a #error in case of someone trying to build on aix, but it's probably overkill. REPOSITORY R241 KIO BRANCH remove_aix REVISION DETAIL htt

D15157: [KMountPoint] Remove AIX support

dhaumann added a comment. BTW: did you grep for other locations in kio for "_AIX"? Might make sense. REPOSITORY R241 KIO BRANCH remove_aix REVISION DETAIL https://phabricator.kde.org/D15157 To: bruns, #frameworks, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D15157: [KMountPoint] Remove AIX support

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2242013d2118: [KMountPoint] Remove AIX support (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15157?vs=40676&id=40718 REVISION DETAIL https://ph

D15158: [KMountPoint] Remove Windows CE support

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b1478006765a: [KMountPoint] Remove Windows CE support (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15158?vs=40678&id=40719#toc REPOSITORY R241 KIO CHANGES SINCE LAST

D15156: [KMountPoint] Remove traces of supermount

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c8207aafa14a: [KMountPoint] Remove traces of supermount (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15156?vs=40675&id=40720 REVISION DETAIL h

D15157: [KMountPoint] Remove AIX support

bruns added a comment. kio is AIX clean now. #windows : For WCE (see D15158 ), there are still several occurences. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15157 To: bruns, #fra

D13034: Add mechanism to notify other clients of config changes over DBus

davidedmundson marked an inline comment as done. davidedmundson added a subscriber: dfaure. davidedmundson added a comment. @dfaure are you ok with this? REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D13034 To: davidedmundson, broulik Cc: dfaure, br

D15141: [KSambaShareData] Accept spaces in ACL host name

ngraham added a comment. Does this patch help with https://bugs.kde.org/show_bug.cgi?id=398079? It just came in today. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15141 To: broulik, dfaure, fvogt Cc: ngraham, bruns, kde-frameworks-devel, michaelh

D15177: Emit signals when a package is installed/uninstalled

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This is needed for situations such as Plasma reloading the wallpa

D15177: Emit signals when a package is installed/uninstalled

Zren added a dependent revision: D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D15177 To: davidedmundson, #plasma Cc: Zren, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/50/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 05:13:10 + Build duration: 3 min 15 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/105/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 05:13:10 + Build duration: 7 min 37 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/106/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 05:27:35 + Build duration: 3 min 18 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/51/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 05:27:35 + Build duration: 8 min 12 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/52/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 Date of build: Fri, 31 Aug 2018 06:14:10 + Build duration: 4 min 17 sec and counting JUnit Tests

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/107/ Project: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 Date of build: Fri, 31 Aug 2018 06:14:10 + Build duration: 9 min 8 sec and counting JUnit Tests