D17090: Use append instead of operator+= when appending to an QVector

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D17090 To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippic

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. LGTM; just a minor change needed. INLINE COMMENTS > basicindexingjob.cpp:153 > +//{"application/vnd.ms-excel", Type::Document}, > +//{"application/vnd.ms-excel", Type:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 333 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/333/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Nov 2018 05:22:14 + Build duration: 5 min 29 sec and counting JUnit Tests Name: (root) Failed: 0 t

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 332 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/332/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Nov 2018 07:03:44 + Build duration: 22 hr and counting JUnit Tests Name: (root) Failed: 1 test(s)

D17084: Prolog & Lua: fix shebang

nibags updated this revision to Diff 45991. nibags added a comment. - Add tests REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17084?vs=45973&id=45991 BRANCH fix-shebang REVISION DETAIL https://phabricator.kde.org/D17084 AFFECTED FILES

D17086: Add icons for application-vnd.appimage

ngraham added a comment. That reasoning makes sense. Currently AppImages get the generic `application-x-executable` which isn't great: F6436057: Screenshot_20181121_193014.png The document motif isn't really accurate here, but it's also used by

D17079: Provide a qqc2/kirigami-based about page

ngraham added a comment. Cool! For this design, I'd like to get rid of the tabs and put everything in a scrollview. We generally have enough space that a tabbed view is overkill. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #p

D17091: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY wdf (word frequency) is neither saved to the database nor

D17090: Use append instead of operator+= when appending to an QVector

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY operator+= could easily be taken for an algebraic addition

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

bruns created this revision. bruns added reviewers: Baloo, Frameworks, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The mimetype is matched with "powerpoint" and "excel" alre

D17078: Make it possible to use KAboutData/License/Person from QML

apol updated this revision to Diff 45984. apol added a comment. Make new constructors explicit REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17078?vs=45964&id=45984 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17078 AFFECTED FILES

D17078: Make it possible to use KAboutData/License/Person from QML

mpyne added a comment. In D17078#363886 , @apol wrote: > In D17078#363772 , @anthonyfieroni wrote: > > > You can't change parameters in methods or constructors, it's a BIC. > > > https://commun

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#363906 , @ltoscano wrote: > That's a great idea! Would it be possible: > > - to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

kossebau created this revision. kossebau added reviewers: broulik, TheAssassin, azubieta. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The current CMake Config file of libappima

D16867: Don't generate appstream data for files that lack a description

rikmills added a comment. And we have a casualty from this ;) Marble 18.12 branch: > CMake Warning at /usr/lib/x86_64-linux-gnu/cmake/KF5Package/KF5PackageMacros.cmake:68 (message): >couldn't generate metainfo for org.kde.plasma.worldmap: Package type >"Plasma/Wallpaper

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Actually, I do need you to do something, but the icons themselves are fine. I need to to rebase this patch onto master. I can walk you through it here or in a chat room if you nee

D17079: Provide a qqc2/kirigami-based about page

ltoscano added a comment. That's a great idea! Would it be possible: - to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some groundwork is needed here) - to move this about page to some common kirigami-addo

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 80 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/80/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Nov 2018 00:05:50 + Build duration: 4 min 5 sec and counting JUnit Tests Name: (root) Fai

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 136 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/136/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Nov 2018 00:05:51 + Build duration: 4 min 0 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.11 - Build # 37 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.11/37/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Thu, 22 Nov 2018 00:05:51 + Build duration: 1 min 12 sec and counting

D16951: Resolve merge conflict

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2a85454d7a42: Resolve merge conflict (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45981&id=45982 REVISION DETAIL https://pha

D16951: Resolve merge conflict

nicolasfella accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, mic

D16951: Resolve merge conflict

ndavis retitled this revision from "Add mouse button icons" to "Resolve merge conflict". REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham,

D16951: Resolve merge conflict

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abe

D16951: Add mouse button icons

nicolasfella added a comment. In D16951#363898 , @ndavis wrote: > So now I have 2 commits and one of them is already on master, but they're both called "Add mouse button icons" and use the same description. Should I update this diff to describe

D16951: Add mouse button icons

ndavis added a comment. So now I have 2 commits and one of them is already on master, but they're both called "Add mouse button icons" and use the same description. Should I update this diff to describe only the latest commit or make it apply to both? REPOSITORY R266 Breeze Icons BRANCH

D16951: Add mouse button icons

ndavis updated this revision to Diff 45981. ndavis marked an inline comment as done. ndavis added a comment. Rebase onto master again REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45980&id=45981 BRANCH arcpatch-D16951 REVISION DETAIL ht

D16951: Add mouse button icons

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951_1 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, r

D16951: Add mouse button icons

ndavis added a comment. Ok, I see what the issue was. The conflicts are literally stored *in* the file that has the conflict as text, so `dialog-input-devices.svg` was turned into a diff of the old and new versions. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.or

D16951: Add mouse button icons

ndavis updated this revision to Diff 45980. ndavis added a comment. Fix conflicts REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45979&id=45980 BRANCH arcpatch-D16951_1 REVISION DETAIL https://phabricator.kde.org/D16951 AFFECTED FILES

D17078: Make it possible to use KAboutData/License/Person from QML

apol added a comment. In D17078#363772 , @anthonyfieroni wrote: > You can't change parameters in methods or constructors, it's a BIC. https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B REPOSITORY R244 KCoreAddo

D17071: Don't include any directory sizes in DirectorySizeJob

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16951: Add mouse button icons

nicolasfella added a comment. This assumes the files that you uploaded before the merge are all correct. - Save the correct icons somewhere. - Checkout the old diff: arc patch --diff 45755 - Begin rebase: git rebase master - Override the files with conflicts with the files you saved

D16951: Add mouse button icons

ndavis added a comment. In D16951#363879 , @nicolasfella wrote: > In D16951#363878 , @ndavis wrote: > > > Save what or how? Doesn't `arc diff --update D16951` save things? I know I added the right f

D16951: Add mouse button icons

nicolasfella added a comment. In D16951#363878 , @ndavis wrote: > Save what or how? Doesn't `arc diff --update D16951` save things? I know I added the right files and there were only 2 conflicts (`icons/actions/16/dialog-input-devices.svg` and

D16951: Add mouse button icons

ndavis added a comment. In D16951#363876 , @nicolasfella wrote: > In D16951#363875 , @ndavis wrote: > > > I thought I did this already. I rebased onto master, then added the version of the file I wa

D16951: Add mouse button icons

nicolasfella added a comment. I any case, try again and check the files for merge conflict markers REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello,

D16951: Add mouse button icons

nicolasfella added a comment. In D16951#363875 , @ndavis wrote: > I thought I did this already. I rebased onto master, then added the version of the file I wanted, then continued the rebase, then updated the diff. Is there something I missed?

D16951: Add mouse button icons

ndavis added a comment. I thought I did this already. I rebased onto master, then added the version of the file I wanted, then continued the rebase, then updated the diff. Is there something I missed? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: n

D16951: Add mouse button icons

nicolasfella reopened this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kd

D16951: Add mouse button icons

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolas

D16951: Add mouse button icons

cfeck added inline comments. INLINE COMMENTS > dialog-input-devices.svg:3 >

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 79 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/79/ Project: kf5-qt5 SUSEQt5.9 Date of build: Wed, 21 Nov 2018 22:35:20 + Build duration: 2 min 38 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 135 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/135/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 21 Nov 2018 22:35:20 + Build duration: 2 min 28 sec and counting CONSOLE OUTPUT [...trunca

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.11 - Build # 36 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.11/36/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Wed, 21 Nov 2018 22:35:20 + Build duration: 27 sec and counting CONSOLE OUTPUT [...truncat

D16951: Add mouse button icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6976172920e2: Add mouse button icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45978&id=45979 REVISION DETAIL https://pha

D16951: Add mouse button icons

ndavis added a comment. In D16951#363861 , @nicolasfella wrote: > Looks great! Ah thanks! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasf

D16951: Add mouse button icons

ndavis updated this revision to Diff 45978. ndavis added a comment. Rebase onto master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16951?vs=45755&id=45978 BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 AFFECTED FILE

D16951: Add mouse button icons

nicolasfella accepted this revision. nicolasfella added a comment. Looks great! REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: trickyricky26, abetts,

D17086: Add icons for application-vnd.appimage

kossebau added a comment. In D17086#363855 , @ngraham wrote: > Thanks for the icon! I'd recommend mimicking the style of the other package icons that have a symbol: > > In other words, add a zipper towards the right-side,, put the AppImage s

D16299: fallback to dnssd service discovery if smb listDir failed on root

ngraham added inline comments. INLINE COMMENTS > sitter wrote in kio_smb_browse.cpp:508 > https://en.wikipedia.org/wiki/If_and_only_if How about writing that out in English, then? :) "iff" just looks like a typo in this context. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricat

D16951: Add mouse button icons

ndavis added a comment. It's been 3 days and no response. It has already been approved by another reviewer, so I'm going to land this now. REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngr

D17086: Add icons for application-vnd.appimage

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks for the icon! I'd recommend mimicking the style of the other package icons that have a symbol: F6435828: Screenshot_20181121_151526.png

D16983: Move firewall-applet icons to status category

ndavis retitled this revision from "Add 48px firewall-applet* icons" to "Move firewall-applet icons to status category". ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons BRANCH firewall-applet-fix-tests (branched from master) REVISION DETAIL https://phabricator.kde

D16983: Add 48px firewall-applet* icons

ndavis added a comment. Anyone opposed to moving the firewall-applet icons into the status category? `status/22` is a scalable directory. If no-one speaks by tomorrow, I'm going to land the patch. REPOSITORY R266 Breeze Icons BRANCH firewall-applet-fix-tests (branched from master) REVI

D17086: Add icons for application-vnd.appimage

kossebau added a comment. Open questions: - how to support the dark icon set? - what would be better colors? Example of icon use with 64 & 16 pixel size, and bigger in preview: F6435751: Screenshot_20181121_220325.png The icon also fixe

D17086: Add icons for application-vnd.appimage

kossebau created this revision. kossebau added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Done based on the shape of the official AppImage logo, basing on SVG code of the ori

D17083: Fix hidden languages in the mode menu

nibags updated this revision to Diff 45975. nibags added a comment. - Update comment REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17083?vs=45972&id=45975 BRANCH fix-hidden-modes REVISION DETAIL https://phabricator.kde.org/D17083 AFFECTED FILES

D17085: Fix language load after including keywords from this language in another file

nibags retitled this revision from "Fix language load after including keywords from this language" to "Fix language load after including keywords from this language in another file". REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17085 To: nibags, #framewo

D17085: Fix language load after including keywords from this language

nibags edited the summary of this revision. nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann, vkrause, jpoelen. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17085 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vk

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

elvisangelaccio added inline comments. INLINE COMMENTS > global.h:249 > +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by > Slave::createSlave, @since 5.30 > +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since > 5.52 > }; Should be bumped to 5.53

D17085: Fix language load after including keywords from this language

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-keys-include REVISION DETAIL https://phabricator.kde.org/D17085 AFF

D17084: Prolog & Lua: fix shebang

nibags added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17084 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns,

D17084: Prolog & Lua: fix shebang

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Before, the shebang was highlighted if there were empty lines before. Now it will only be highlighted i

D17083: Fix hidden languages in the mode menu

dhaumann added inline comments. INLINE COMMENTS > katemodemanager.cpp:103 > for (int i = 0; i < modes.size(); ++i) { > // filter out None hl, we add that later as "normal" mode > +if (modes[i].isHidden() || modes[i].name() == QLatin1String("None")) > { Now the comment is w

D17083: Fix hidden languages in the mode menu

nibags added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17083 To: nibags, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17083: Fix hidden languages in the mode menu

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY In the status bar, the syntax highlighting menu (mode menu) shows hidden languages, for example:

D17078: Make it possible to use KAboutData/License/Person from QML

broulik added a comment. You can change default values just fine, it requires re-compilation to use them but no ABI implications. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: broulik, anthonyfieroni, kde-frameworks-deve

D17078: Make it possible to use KAboutData/License/Person from QML

anthonyfieroni added a reviewer: dfaure. anthonyfieroni added a comment. You can't change parameters in methods or constructors, it's a BIC. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: anthonyfieroni, kde-frameworks-dev

D17079: Provide a qqc2/kirigami-based about page

apol edited the summary of this revision. apol added a dependency: D17080: Make it possible to fallback to a different icon. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, l

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. WRT the gravatar bit, I'm not married to it, it's just a way to have this moving forward. I'll add some screenshots so you get an idea: F6435584: discover-about1.png F6435585: discover-about2.png

D17079: Provide a qqc2/kirigami-based about page

apol updated this revision to Diff 45968. apol added a comment. Don't show the gravatar logo when not there REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17079?vs=45965&id=45968 BRANCH master REVISION DETAIL https://phabricator.kde.or

D17079: Provide a qqc2/kirigami-based about page

apol edited the summary of this revision. apol added a dependency: D17078: Make it possible to use KAboutData/License/Person from QML. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: plasma-devel, ragreen, Pitel,

D17078: Make it possible to use KAboutData/License/Person from QML

apol added a dependent revision: D17079: Provide a qqc2/kirigami-based about page. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Instead of using the one in xmlgui, create one that integrates properly in Kirigami/Discover.

D17078: Make it possible to use KAboutData/License/Person from QML

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Exposes their properties through Q_GADGET. Makes it possible to export them as QVariant b

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham added a comment. @bruns @ngraham what's your view on this? Did you tested it out? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

dfaure accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D17048: Restore sendfile support

This revision was automatically updated to reflect the committed changes. Closed by commit R241:31980ecd1cac: Restore sendfile support (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17048?vs=45889&id=45955 REVISION DETAIL https://p

D17051: Use correct variable type for returned value from read/sendfile

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8f926e459622: Use correct variable type for returned value from read/sendfile (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17051?vs=4589

D16878: Resolve symlinks in exclude folders

poboiko added a comment. I believe can do something better here. I think if we stick to canonical paths everywhere, and resolve symlinks ASAP (but still follow them), that might solve all the problems. In D16878#359864 , @bruns wrote: > B

D16299: fallback to dnssd service discovery if smb listDir failed on root

acrouthamel added a comment. In D16299#363498 , @sitter wrote: > If someone has a thought to offer on this please do. > Personally I am somewhat leaning towards assuming that systems should be properly configured. The problem with setting the

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16249 To: shubham, ngraham, #frameworks, bruns, dfaure Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

shubham updated this revision to Diff 45951. shubham added a comment. - a REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16249?vs=45470&id=45951 BRANCH fat REVISION DETAIL https://phabricator.kde.org/D16249 AFFECTED FILES src/core/copyjob.cpp src/cor

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson updated this revision to Diff 45947. davidedmundson edited the summary of this revision. davidedmundson edited the test plan for this revision. davidedmundson added a comment. Squash REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17071?vs=45942&i

D17070: Don't double-count size of directories in DirectorySizeJob

davidedmundson abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17070 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17070: Don't double-count size of directories in DirectorySizeJob

davidedmundson added a dependent revision: D17071: Don't include any directory sizes in DirectorySizeJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17070 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson added a dependency: D17070: Don't double-count size of directories in DirectorySizeJob. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17070: Don't double-count size of directories in DirectorySizeJob

davidedmundson added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17070 To: davidedmundson, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Running stat on a directory gives a size of on ext3 gives a size of 4096. Running stat on a directory

D17070: Don't double-count size of directories in DirectorySizeJob

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Running "stat" on a directory gives a size of on ext3 gives a size of "4096". DirectorySizeJob has

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter added a comment. // TODO: it may be better to resolve the host to an ip address. dnssd // being able to find a service doesn't mean name resolution is // properly set up for its domain. So, we may not be able to resolve // this without help from avahi. OTOH KDNSSD doe

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, andre

D16299: fallback to dnssd service discovery if smb listDir failed on root

sitter retitled this revision from "RFC fallback to dnssd service discovery if smb listDir failed on root" to "fallback to dnssd service discovery if smb listDir failed on root". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter added inline comments. INLINE COMMENTS > ngraham wrote in kio_smb_browse.cpp:508 > iff -> if https://en.wikipedia.org/wiki/If_and_only_if REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin Cc: alexde, bcooksley, ngraham,

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

sitter updated this revision to Diff 45938. sitter marked 4 inline comments as done. sitter added a comment. - check kdnssd version; do not use dnssd discovery if it too old and suffers from signal racing (also see D16298 ) - fix typo in function name -

D17068: actually install the version header

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R272 KDNSSD BRANCH install-version REVISION DETAIL https://phabricator.kde.org/D17068 To: sitter, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17068: actually install the version header

This revision was automatically updated to reflect the committed changes. Closed by commit R272:43543acfee14: actually install the version header (authored by sitter). REPOSITORY R272 KDNSSD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17068?vs=45936&id=45937 REVISION DETAIL htt

D17068: actually install the version header

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY we've generated it but never installed it :| this enables lib consumers to check the kdnssd version without having to

  1   2   >