D15368: [Comic Thumbnailer] support more image formats

fleger added reviewers: broulik, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15368 To: fleger, broulik, #frameworks Cc: kde-frameworks-devel,

D15367: [Comic Thumbnailer] fix CBR thumbnail generation

fleger added reviewers: broulik, Frameworks. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15367 To: fleger, broulik, #frameworks Cc: kde-frameworks-devel,

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/14/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 22 Nov 2018 09:55:53 + Build duration: 20 hr and counting JUnit Tests Name:

D16919: Re-add DBus test

bcooksley added a comment. When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole,

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:6c2ebbb5b853: [thumbnailer appimage] Fix building with libappimage not in system path (authored by kossebau).

D17091: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

This revision was automatically updated to reflect the committed changes. Closed by commit R293:26a879838ace: Remove ununsed wdfInc parameter for addTerm and addPositionTerm (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

This revision was automatically updated to reflect the committed changes. bruns marked an inline comment as done. Closed by commit R293:149c8b2379df: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST

D17090: Use append instead of operator+= when appending to an QVector

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4b406b107792: Use append instead of operator+= when appending to an QVectorint (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D17114: [KUrlNavigator] Re-activate on mouse middle button click

thsurrel updated this revision to Diff 46049. thsurrel added a comment. Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17114?vs=46047=46049 BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED

D17114: [KUrlNavigator] Re-activate on mouse middle button click

thsurrel edited the summary of this revision. thsurrel edited the test plan for this revision. thsurrel added reviewers: Frameworks, elvisangelaccio. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17114 To: thsurrel, #frameworks, elvisangelaccio Cc: kde-frameworks-devel,

D17114: [KUrlNavigator] Re-activate on mouse middle button click

thsurrel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. thsurrel requested review of this revision. REPOSITORY R241 KIO BRANCH arc_kurlnavigator (branched from master) REVISION DETAIL https://phabricator.kde.org/D17114 AFFECTED

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

cfeck set the repository for this revision to R289 KNotifications. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D12674 To: ntninja, kde-frameworks-devel, apol Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

ntninja added a comment. Since these changes have been approved and marked read-to-land for quite some time, could this please be done soon? Thank you! REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: ntninja, dfaure Cc: dfaure, apol,

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/39/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Thu, 22 Nov 2018 20:29:06 + Build duration: 12 min and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 82 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/82/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Nov 2018 20:27:38 + Build duration: 1 min 54 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 138 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/138/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Nov 2018 20:27:38 + Build duration: 1 min 44 sec and counting JUnit Tests Name: (root)

D16983: Move firewall-applet icons to status category

This revision was automatically updated to reflect the committed changes. Closed by commit R266:7e27acf7e1a8: Move firewall-applet icons to status category (authored by ndavis). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16983?vs=45929=46038#toc REPOSITORY R266 Breeze Icons

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/137/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Nov 2018 20:11:23 + Build duration: 7 min 8 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/81/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 22 Nov 2018 20:11:23 + Build duration: 1 min 28 sec and counting JUnit Tests Name: (root)

D17062: Fix angle and margin of 32px dialog-ok-apply

This revision was automatically updated to reflect the committed changes. Closed by commit R266:e1375f0efcdf: Fix angle and margin of 32px dialog-ok-apply (authored by trickyricky26, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D17062: Fix angle and margin of 32px dialog-ok-apply

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. All correct! REPOSITORY R266 Breeze Icons BRANCH arcpatch-D17062 REVISION DETAIL https://phabricator.kde.org/D17062 To: trickyricky26, #vdg, #breeze, ndavis Cc: ndavis,

D17062: Fix angle and margin of 32px dialog-ok-apply

trickyricky26 retitled this revision from "Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks" to "Fix angle and margin of 32px dialog-ok-apply". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17062 To: trickyricky26, #vdg, #breeze, ndavis Cc:

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense to me, it's even already if'd! REVISION DETAIL https://phabricator.kde.org/D12674 To: ntninja, kde-frameworks-devel, apol Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux,

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

trickyricky26 updated this revision to Diff 46036. trickyricky26 added a comment. Rebase onto master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17062?vs=45914=46036 BRANCH arcpatch-D17062 REVISION DETAIL https://phabricator.kde.org/D17062

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ntninja updated this revision to Diff 46035. ntninja added a comment. Updated to latest KF5 version and probably fixed the issue mentioned in review – although I have no idea what it was. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12674?vs=33575=46035 REVISION DETAIL

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

ntninja added a reviewer: kde-frameworks-devel. REVISION DETAIL https://phabricator.kde.org/D12674 To: ntninja, kde-frameworks-devel Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > lbeltrame wrote in basicindexingjob.cpp:153 > Remove instead of committing commented out code? I prefer not to remove it, at least not completely. I think it is useful to have the mimetypes listed

D16919: Re-add DBus test

hindenburg added a comment. I manage to build the docker kdeorg/ci-suse-qt59 image - and of course the tests pass - so I'm not sure how to help now. I've already disabled this test again to avoid the sysadmins having more work to do. REPOSITORY R319 Konsole REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 268 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/268/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Nov 2018 18:11:23 + Build duration: 7 min 46 sec and counting JUnit Tests Name:

D17052: Simplify reference counting of FrameData

apol closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks, zzag Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks, zzag Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

apol updated this revision to Diff 46026. apol added a comment. Change destructor REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17052?vs=45893=46026 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17052 AFFECTED FILES

D17052: Simplify reference counting of FrameData

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > zzag wrote in framesvg.cpp:569 > Do we really need to pass a shared pointer? Wouldn't it better to just pass a > raw pointer? We won't do any ownership-related stuff anyway. It doesn't really make a difference

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#364263 , @apol wrote: > In D17079#364163 , @ltoscano wrote: > > > In D17079#364157 , @mart wrote: > > > > > I think

D17071: Don't include any directory sizes in DirectorySizeJob

adridg added a comment. With UFS, stat(1) tells me [adridg@beastie .../kio/build]$ stat . 2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 131072 17 0x800 . So that's a size

D17079: Provide a qqc2/kirigami-based about page

apol added a comment. In D17079#364163 , @ltoscano wrote: > In D17079#364157 , @mart wrote: > > > I think this ui should really go into KCoreAddons itself. Would it be accepted there? > > >

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

loh.tar added a comment. It would be nice someone could explain, or point me where to read, why there is no (more) direct use of Sonnet stuff in KTextEditor/Kate. 1. KTextEditor::SpellCheckBar looks (almost) the same as Sonnet::Dialog but has differently ingredients. I had expect, after

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

loh.tar created this revision. loh.tar added a reviewer: cullmann. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch alone is

D17070: Don't double-count size of directories in DirectorySizeJob

adridg added a comment. With UFS, stat(1) tells me [adridg@beastie .../kio/build]$ stat . 2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 131072 17 0x800 . So that's a size

D17079: Provide a qqc2/kirigami-based about page

ltoscano added a comment. In D17079#364157 , @mart wrote: > I think this ui should really go into KCoreAddons itself. Would it be accepted there? kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, kirigami-addons

D17079: Provide a qqc2/kirigami-based about page

mart added inline comments. INLINE COMMENTS > DiscoverWindow.qml:76 > } > +TopLevelPageData { > +id: aboutAction can you try how does it look for this page to be pushed as a layer instead of the main PageRow? would be like

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. I think this ui should really go into KCoreAddons itself. Would it be accepted there? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D17079 To: apol, #plasma, #frameworks Cc: mart, leinir, ngraham, ltoscano, plasma-devel,

D17052: Simplify reference counting of FrameData

mart added a comment. after adressing zzag's comments, is good to go for me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

mart added a comment. adding a default value should be bc, the opposite of course is not.. in its current state, looks good to me REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D17078 To: apol, #frameworks, dfaure Cc: mart, mpyne, broulik, anthonyfieroni,

D17079: Provide a qqc2/kirigami-based about page

mart added a comment. In D17079#363975 , @ngraham wrote: > Cool! > > For this design, I'd like to get rid of the tabs and put everything in a scrollview. We generally have enough space that a tabbed view is overkill. +1 REPOSITORY

D17079: Provide a qqc2/kirigami-based about page

leinir added a comment. Basically what Nate said, this is a great idea :) Thinking that having this is already an improvement, but also perhaps that having it as a scrollable page would indeed feel more natural here rather than tabs... Thinking this seems like a good place to use the fact

D17052: Simplify reference counting of FrameData

mart added a comment. things like https://bugs.kde.org/show_bug.cgi?id=398854 i guess REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D17052 To: apol, #plasma, #frameworks Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17085: Fix language load after including keywords from this language in another file

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Uh, good catch. REPOSITORY R216 Syntax Highlighting BRANCH fix-keys-include REVISION DETAIL https://phabricator.kde.org/D17085 To: nibags, #framework_syntax_highlighting,

D17091: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I'd change the wording. It's being exported, only that the headers aren't being installed so it's not really usable. ;) REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

TheAssassin added a comment. There will be packages for libappimage (hopefully) soon, which provide a `.pc` file. This provides an alternative to using these generated CMake config files, which can be used through CMake's pkg-config module (`find_package(PkgConfig)`). REPOSITORY R320 KIO

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

broulik added a comment. Don't know much cmake but still builds fine here with this change, so +1 from me REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D17088 To: kossebau, broulik, TheAssassin, azubieta Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss,

D17086: Add icons for application-vnd.appimage

TheAssassin added a comment. AppImages are, after all, only ELF executables. They're not archives. Using a zipper implies this, though. I really like the initial version that mimics the "normal executable" icon better. The dark blue is quite nice, but I thought perhaps a color from the

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 267 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/267/ Project: kf5-qt5 SUSEQt5.10 Date of build: Thu, 22 Nov 2018 10:00:51 + Build duration: 4 min 18 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Aborted!

BUILD ABORTED Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/13/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Mon, 19 Nov 2018 13:03:21 + Build duration: 2 days 20 hr and counting

D17093: Rust & Yacc/Bison: improve comments

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY Add `##Alerts` and

D17092: Add syntax highlighting for TypeScript & TypeScript React

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY TypeScript is a superset of

D17085: Fix language load after including keywords from this language in another file

nibags added a dependent revision: D17092: Add syntax highlighting for TypeScript & TypeScript React. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17085 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause, jpoelen Cc: kwrite-devel,

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. (sure it's convenient for the unittest, but less meaningful for the users) REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D17071 To: davidedmundson, dfaure, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

dfaure added a comment. Hmm hmm. The goal of this was to behave like "du" as much as possible. As you say, the real bug isn't that we count directories, but that we count files "as is" instead of blocks. But I'm not sure how easily we could get block information from here. REPOSITORY