D17128: DocumentPrivate: Remove comment mark when joining lines

dhaumann added a comment. As background: inserting the '*' automatically is done by the indenter in cstyle.js. Theorwtically, we could even add a joinLines function to the indenters as well and call it if it exists, and if not use the default implementation. Just an idea... Usually, the moti

D13627: [KSharedDataCache] Assume lock before flush changes

anthonyfieroni abandoned this revision. anthonyfieroni added a comment. Kernel regression for sure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein, mpyne Cc: mpyne, hein, kde-frameworks-devel, m

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14733: [KFormat] Add human readable list displaying function

yurchor added a comment. +1 REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D14733 To: safaalfulaij, #frameworks Cc: yurchor, bruns, kde-frameworks-devel, michaelh, ngraham

D17421: Add drive-* icons for YaST Partitioner

ndavis added a comment. In D17421#373045 , @ngraham wrote: > They generally look very good. > > I'm wondering if it might be worth it to get rid of those semicircular bumps on the inside for the 16px and maybe even 24px version too. They seem

D17421: Add drive-* icons for YaST Partitioner

ngraham added a comment. They generally look very good. I'm wondering if it might be worth it to get rid of those semicircular bumps on the inside for the 16px and maybe even 24px version too. They seem to interfere with any symbol inside the disk at really small sizes. For `drive-m

D16694: Improve visibility for Konsole icon when using Breeze Dark

ngraham added a comment. We had a big discussion in the VDG room and concluded that Konsole shouldn't even use this icon for its tabs by default (https://bugs.kde.org/show_bug.cgi?id=401864), which partially solves the problem. However I personally think it's still worthwhile to tweak t

D17419: Add private-mode icon

ndavis added a comment. I would like if it was more aligned with the grid: See how the top version is a bit more crisp? F6462554: Screenshot_20181207_221001.png F6462556: Screenshot_20181207_221121.png REP

D17421: Add drive-* icons for YaST Partitioner

ndavis retitled this revision from "Add new drive-* icons" to "Add drive-* icons for YaST Partitioner". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17421: Add new drive-* icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17421: Add new drive-* icons

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17421: Add new drive-* icons

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17421: Add new drive-* icons

ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17421 To: ndavis, #vdg Cc: kde-frameworks-devel, #vdg, michaelh, ngraham, bruns

D17421: Add new drive-* icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add `drive-harddisk-encrypted`, `drive-multidisk`, `drive-multipartition` and `drive-partit

D17419: Add private-mode icon

GB_2 added a comment. In D17419#372992 , @filipf wrote: > Very Chrome/-ium like :) > > F6462196: image.png > > Maybe expanding the bottom line just a tad more would make it more obvious it's a privat

D17310: Improve Kile icon with LaTeX font

ndavis added a comment. In D17310#372711 , @trickyricky26 wrote: > The proposed icons in my dock: > > F6461602: Root k screenshot.png > > F6461601: Root capital K screenshot.png

D17419: Add private-mode icon

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks great to me! Thanks for embedding the CSS stylesheet too. #falkon or other #VDG folks, any comments?

D17419: Add private-mode icon

ngraham added reviewers: VDG, Falkon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze, #vdg, #falkon Cc: filipf, ngraham, #vdg, kde-frameworks-devel, #breeze, alexde, IohannesPetros, trickyricky26, michaelh, crozbo, ndavis, firef, bruns, sk

D17419: Add private-mode icon

filipf added a comment. Very Chrome/-ium like :) F6462196: image.png Maybe expanding the bottom line just a tad more would make it more obvious it's a private eye's hat? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

loh.tar added a comment. #Frameworks Ping! (?) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17419: Add private-mode icon

GB_2 updated this revision to Diff 47081. GB_2 edited the summary of this revision. GB_2 added a comment. Improve icons. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17419?vs=47078&id=47081 REVISION DETAIL https://phabricator.kde.org/D17419 AFFEC

D17419: Add private-mode icon

ngraham added a comment. I like it! What do you think about making the bottom line of the hat a bit wider, so it's more clear that it's a hat? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17419 To: GB_2, #breeze Cc: ngraham, #vdg, kde-frameworks-devel, #bree

D17419: Add private-mode icon

GB_2 created this revision. GB_2 added a reviewer: Breeze. GB_2 added projects: Breeze, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 401646 F6462086: private-mode Breeze Icon.png

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think is an improvement - sorry for the delay :( will integrate tomorrow. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17382 To: loh.tar, #ktexteditor,

D17413: stay in context Linkage2/Pragma2 until closing paren

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I guess this is fine. Could you use your real name please? REPOSITORY R216 Syntax Highlighting BRANCH stay-in-context-until-closing-paren REVISION DETAIL https://phabricator.kde.

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.11 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.11/4/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 07 Dec 2018 21:21:08 + Build duration: 7 min 33 sec and counting BUILD ARTIFACTS compat_reports/K

D17413: stay in context Linkage2/Pragma2 until closing paren

aG0aep6G updated this revision to Diff 47069. aG0aep6G added a comment. - also fix contexts Version2 and Scope2 REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17413?vs=47062&id=47069 BRANCH stay-in-context-until-closing-paren REVISION DETAIL

D17406: add attributes `shared` and `__gshared`

aG0aep6G added a comment. In D17406#372806 , @cullmann wrote: > I can add the keywords myself then, no problem. Great, thanks. > Thought for larger contributions, I really would appreciate some real name, copyright wise I don't think

D17413: stay in context Linkage2/Pragma2 until closing paren

aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY Otherwise the closing paren isn't matched properly with the opening one. REPOSITORY R216 Syntax H

D17406: add attributes `shared` and `__gshared`

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I can add the keywords myself then, no problem. Thought for larger contributions, I really would appreciate some real name, copyright wise I don't think just some pseudonym is really t

D17406: add attributes `shared` and `__gshared`

aG0aep6G added a comment. In D17406#372788 , @cullmann wrote: > Google tells me this are valid attributes: https://dlang.org/spec/attribute.html > > Could you extend the unit test (or add one, if none there) I don't know how to do tha

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.9 - Build # 367 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.9/367/ Project: kf5-qt5 SUSEQt5.9 Date of build: Fri, 07 Dec 2018 18:24:10 + Build duration: 23 min and counting JUnit Tests Name: (root) Failed: 1 test(s

D17406: add attributes `shared` and `__gshared`

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Google tells me this are valid attributes: https://dlang.org/spec/attribute.html Could you extend the unit test (or add one, if none there) And do you have some clear

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.11 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.11/6/ Project: kf5-qt5 SUSEQt5.11 Date of build: Fri, 07 Dec 2018 18:24:10 + Build duration: 6 min 18 sec and counting JUnit Tests Name: (root) Failed: 1

D17406: add attributes `shared` and `__gshared`

shubham added a reviewer: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17406 To: aG0aep6G, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17310: Improve Kile icon with LaTeX font

trickyricky26 added a comment. The proposed icons in my dock: F6461602: Root k screenshot.png F6461601: Root capital K screenshot.png F6461600: Root a screenshot.png

D16694: Improve visibility for Konsole icon when using Breeze Dark

emateli added a comment. Agree with @ndavis with respect to the icon. I would be in favor of using something similar (if not identical) to `dialog-scripts`. It's monochrome and works with dark and light backgrounds. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.or

D16694: Improve visibility for Konsole icon when using Breeze Dark

ndavis added a comment. Why are we using a color icon at such a small size? Wouldn't it make more sense to make a monochrome icon at that size? This change would also affect how the Konsole icon looks in other places such as the task manager. At 100% size, I don't see this looking good o

D17395: add attributes `shared` and `__gshared`

aG0aep6G abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17395 To: aG0aep6G Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17406: add attributes `shared` and `__gshared`

aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH shared-__gshared REVISION DETAIL https://phabricator.kde.org/D17406

D17405: add attributes `shared` and `__gshared`

aG0aep6G abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17405 To: aG0aep6G Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17405: add attributes `shared` and `__gshared`

aG0aep6G created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. aG0aep6G requested review of this revision. REVISION SUMMARY stay in context Linkage2/Pragma2 until closing paren Otherwise the closing paren isn't matched

D16694: Improve visibility for Konsole icon when using Breeze Dark

ngraham added a comment. Great, the corners are now correct! For the outline let's try to use one of the Breeze colors, which you can see here: https://hig.kde.org/style/color/default.html What we typically do is choose one of the shades of gray, and make it partially transparent. T

D17381: macsec setting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:b5a906ba5730: macsec setting (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17381?vs=47027&id=47028#toc REPOSITORY R282 NetworkManagerQt CHA

D17381: macsec setting

jgrulich accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

thsurrel added a comment. Thanks for the tip, I will try to use gammaray. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D16913 To: thsurrel, #frameworks Cc: davidedmundson, cfeck, broulik, ngraham, kde-frameworks-devel, michaelh, bruns

D16913: Add the possibility to give focus to the KPluginSelector search field

davidedmundson added a comment. > Correct me if this is wrong. It shouldn't be needed, no. This is a workaround for something, potentially another widget pulling focus on startup. gammaray can be a fantastic tool in diagnosing this sort of thing. REPOSITORY R295 KCMUtils REV

D17381: macsec setting

pranavgade updated this revision to Diff 47027. pranavgade marked 7 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=47021&id=47027 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settin

D16299: fallback to dnssd service discovery if smb listDir failed on root

This revision was automatically updated to reflect the committed changes. Closed by commit R320:55eb68ff6364: fallback to dnssd service discovery if smb listDir failed on root (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16299?vs=459

D16299: fallback to dnssd service discovery if smb listDir failed on root

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-discovery REVISION DETAIL https://phabricator.kde.org/D16299 To: sitter, #frameworks, #dolphin, broulik Cc: acrouthamel, alexde, bcooksley, ngraham, kde-frameworks-devel,

D17381: macsec setting

jgrulich added inline comments. INLINE COMMENTS > macsecsetting.cpp:49 > +, sendSci(true) > +, validation(NetworkManager::MacsecSetting::Disable) > +{ } Isn't default validation 2, which means "strict" in your case. > macsecsetting.cpp:294 > + > +if (mode() > 0) { > +setting

D17381: macsec setting

jgrulich added a comment. Please update full diff. REVISION DETAIL https://phabricator.kde.org/D17381 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17398: [xscreensaverpoller] Flush after reset screensaver

This revision was automatically updated to reflect the committed changes. Closed by commit R274:de990fe48ff4: [xscreensaverpoller] Flush after reset screensaver (authored by anthonyfieroni). Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R274 KId

D17381: macsec setting

pranavgade updated this revision to Diff 47021. pranavgade marked 8 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46975&id=47021 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settin

D17381: macsec setting

jgrulich added inline comments. INLINE COMMENTS > pranavgade wrote in macsecsettingtest.cpp:29 > I tried to get the version from here: > F6459587: Screenshot from 2018-12-06 22-13-34.png > > > Is that incorrect? > If so, from where do I check the version?