D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

habacker added a comment. On opensuse there are the cross compile helper packages mingw32-cross-kde4-tools mingw32-cross-kf5-tools both containing docbookl10nhelper and nothing prevents them from been installed in parallel REPOSITORY R238 KDocTools REVISION DETAIL https://pha

T3689: Add abi compliance checker to CI

bcooksley added a comment. I've made an experimental change which should resolve this issue if it is what is suspected to be the issue here. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, kna

T3689: Add abi compliance checker to CI

bcooksley added a commit: R857:dbb3d8d9f37a: Make sure we wait and block until the publishing process is completed.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss, bcooksley Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blaz

D17623: Add YaST icons

ngraham added a comment. In D17623#380204 , @ndavis wrote: > In D17623#378670 , @ngraham wrote: > > > apps/32/yast-checkmedia.svg preferences/32/preferences-devices-drive-optical-ok.svg >

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

shubham added a comment. In D17632#380066 , @dfaure wrote: > Did you expect (or desire) anything else? I meant of adding test for copying multiple folders. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: d

D17623: Add YaST icons

ndavis added a comment. In D17623#378670 , @ngraham wrote: > apps/32/yast-checkmedia.svg preferences/32/preferences-devices-drive-optical-ok.svg Why `ok`? This is a preferences icon, so it doesn't make sense for there to be prefe

D17623: Add YaST icons

ndavis added a comment. In D17623#378989 , @ngraham wrote: > In D17623#378783 , @ndavis wrote: > > > 2. It's supposed to be a newspaper. I tried to make it look similar to `message-news`: F6486579: S

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.11 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.11/11/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 20 Dec 2018 22:48:00 + Build duration: 6 min 51 sec and counting JUnit Tests Name: (root) F

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

dfaure added a comment. Damn, I went too fast. This doesn't fix the issue. CMake says 5.0.300080 is > 5.0.1, obviously. The reason I enabled it for 5.0.1 is that on x86_64 linux, clang 5.0.1 does support it (but now I realize that 5.0.0 does too, most probably). I don't understand

D17178: Don't ask for confimation when reloading

This revision was automatically updated to reflect the committed changes. Closed by commit R39:82a1673746ea: Don't ask for confimation when reloading (authored by nicolasfella). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17178?vs=47740&id=47918 REVISIO

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

dfaure closed this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D17714 To: dfaure, aacid, cgiboudeaux, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D17714 To: dfaure, aacid, cgiboudeaux, apol Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, brun

D17459: SearchBar: Add Cancel button to stop long running tasks

anthonyfieroni added inline comments. INLINE COMMENTS > katesearchbar.cpp:89 > +ret = new KateSearchBarPrivate; > +d_func()->insert(foo, ret); > +} You can take another approach connect(foo, &Qobject::destroyed, d_func, [foo]() { delete d_func()->take(foo); }); > katesea

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47907. loh.tar added a comment. Fixed/Simplified as suggested - I noticed a reproducible crash when e.g. Kate will closed while a S&R is running. Happens also when a split view is closed (so far so good) and then Kate will closed . I will try to solv

D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0

dfaure created this revision. dfaure added reviewers: aacid, cgiboudeaux, apol. Herald added projects: Frameworks, Build System. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Build System, Frameworks. dfaure requested review of this revision. REVISION SUMMARY

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

dfaure added a comment. Same result: I copy 4 folders into "/", and I get one error saying: Access denied. Could not write to "/". Did you expect (or desire) anything else? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: dfaure, shubham, broulik, bruns Cc

D17632: Move/copy job: skip stat'ing sources if the destination dir isn't writable

shubham added a comment. Can you try copying multiple folders? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17632 To: dfaure, shubham, broulik, bruns Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D17331: Extend PositionCodec unit tests, better code coverage

This revision was automatically updated to reflect the committed changes. Closed by commit R293:b5fd732b171e: Extend PositionCodec unit tests, better code coverage (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17331?vs=46790&id=47899 REVIS

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/94/ Project: kf5-qt5 SUSEQt5.9 Date of build: Thu, 20 Dec 2018 16:17:29 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0 te

T3689: Add abi compliance checker to CI

knauss added a comment. In T3689#170601 , @bcooksley wrote: > I checked execution of KDav on all four build nodes, and the process ran fine when done manually. > Given there is no output from check-abi.py, this is quite hard to diagnose.

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.11 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.11/3/ Project: kf5-qt5 SUSEQt5.11 Date of build: Thu, 20 Dec 2018 16:17:29 + Build duration: 7 min 39 sec and counting JUnit Tests Name: (root) Faile

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

ngraham added a comment. In D17137#379789 , @gregormi wrote: > If there are no further comments, would proceed with: > > - Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants' > - Intr

D17558: Fix XDGForeign Client header installs

This revision was automatically updated to reflect the committed changes. Closed by commit R127:25eae63002a4: Fix XDGForeign Client header installs (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17558?vs=47506&id=47896 REVISION

T3689: Add abi compliance checker to CI

knauss added a revision: D17710: check-abi.py: Reload serverManiphest several times, if we don't find matching entries.. TASK DETAIL https://phabricator.kde.org/T3689 To: knauss Cc: dfaure, kde-frameworks-devel, bcooksley, sysadmin, scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

D17459: SearchBar: Add Cancel button to stop long running tasks

anthonyfieroni added inline comments. INLINE COMMENTS > katesearchbar.cpp:83 > +typedef QHash > KateSearchBarPrivateHash; > +static KateSearchBarPrivateHash KateSearchBarPrivateData; > +Q_GLOBAL_STATIC(KateSearchBarPrivateHash, d_func) It's not needed, right? > katesearchbar.cpp:97-99 > +K

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 47891. loh.tar added a comment. - Workaround to keep binary compatibility > It's exported class you cannot... Argh! How can I see this quickly the next time? KTEXTEDITOR_EXPORT ? - Seams still to work so far, but looks not so lovely - Fixed

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > the change from QChar to const QChar & does not improve the amount of copied data. Argh! OK. Was just an impulse to do it as usual and to follow isStartBracket(..) and isBracket(..) Will wait for further advice REPOSITORY R39 KTextEditor REVISION DETAIL

T3689: Add abi compliance checker to CI

bcooksley added a comment. I checked execution of KDav on all four build nodes, and the process ran fine when done manually. Given there is no output from check-abi.py, this is quite hard to diagnose. Can you propose some debug output which might point out why it's doing nothing? TASK

D16643: Correct the accept flag of the event object on DragMove

trmdi added a comment. !ping REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D16643 To: trmdi, mart, broulik, #plasma, hein, bruns Cc: anthonyfieroni, bruns, dkorth, ngraham, kde-frameworks-devel, michaelh

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

sars added inline comments. INLINE COMMENTS > katedocument.cpp:117 > > -static inline QChar matchingStartBracket(QChar c, bool withQuotes) > +static inline QChar matchingStartBracket(const QChar &c) > { I'm not familiar with the auto-bracket code, but the change from QChar to const QChar & d